Skip to content

[kotlin-sdk] Broadcast rejection flattens to ErrorUnknown(99) — add a dedicated pre-broadcast rejection code #4085

Closed

Description

@bfoss765

Priority: P1 — robustness of the no-double-pay classification every integrator must implement (the wallet currently message-matches; safe but brittle).

PlatformWalletError::TransactionBroadcast — the broadcaster's definitive "never reached any peer" rejection, with the reservation released — reaches Kotlin as Generic(nativeCode=99) with only a message prefix. Integrators must string-match to classify the failure as safely-not-broadcast (retryable without double-pay risk).

Ask: a dedicated error code/type for definitive pre-broadcast rejection, preserving the Core reject reason, so the classification is robust across SDK versions.

Context: dashpay/dash-wallet#1507; relates to the SdkWriteResult Broadcast/NotBroadcast/Ambiguous contract described in dashpay/dash-wallet PR #1507. cc @QuantumExplorer

Activity

  1. HashEngineering commented on Nov 9, 2026

    @HashEngineering
    Collaborator

    Fixed by #4308. A node rejection now maps to ErrorTransactionBroadcastRejected (26) → DashSdkError.PlatformWallet.TransactionBroadcastRejected, with the reject reason in the message, instead of ErrorUnknown(99). Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions