Skip to content

[kotlin-sdk] Core send should return the signed raw transaction, fee, and change address #4079

Closed

Description

@bfoss765

Priority: P1 — smallest change with the largest unlock for the dash-wallet send-path cutover (Phase 5c). App-side workaround exists (poll the SDK Room transactions row for the bytes) but is timing-fragile with no contract.

ManagedPlatformWallet.sendToAddresses returns only the txid hex. The signed consensus bytes, fee, and change address all exist Rust-side at broadcast time (the FFI box owns the tx bytes; they later land asynchronously in Room transactions.transactionData).

Ask:

data class BroadcastCoreTransaction(
    val txidHex: String,
    val rawTxBytes: ByteArray,   // consensus-encoded signed tx, exactly what was broadcast
    val feeDuffs: Long,
    val changeAddress: String?
)
suspend fun ManagedPlatformWallet.sendToAddressesEx(...): BroadcastCoreTransaction

One new FFI accessor (e.g. coreTransactionGetBytes) before coreTransactionFree; identical build/broadcast pipeline. With the raw bytes the wallet reconstructs a dashj Transaction and commits it locally, which makes confidence listeners, output locking, memo/exchange-rate persistence and result-screen states work unchanged across the cutover ("bridge" strategy, wallet plan Phase 5c).

Context: dashpay/dash-wallet#1507 Phase 5c GAP-1. cc @QuantumExplorer

Activity

  1. HashEngineering commented on Nov 9, 2026

    @HashEngineering
    Collaborator

    Fixed by #4308. buildSignedPayment returns a SignedCoreTransaction with txidHex, rawTxBytes and feeDuffs, and broadcastSigned broadcasts it. There is no separate change-address field; it can be read from rawTxBytes. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions