Repository navigation
base%build: pin base-sdk at a4ea791e for correct revocation reason names - #5
Merged
Merged
Conversation
base-sdk a4ea791e names ProUpRevTx reasons 1 to 3 as Dash Core does (termination of service, compromised keys, change of keys). Hyphen stores the reason's name in the payload JSON, so new revocations now carry the right name. It also refuses governance object signatures over 96 bytes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
dashpay is on CodeRabbit Free, which includes PR summaries. Ask your admin to upgrade for code reviews.
Walkthrough
|
|
Note This pull request has no conflicts! 🎊 🎉 🎊 Actions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hyphen shows the wrong reason on revocations (ProUpRevTx) for codes 1 to 3. The base-sdk it pins named code 1 "key compromise", code 2 "change of keys" and code 3 "violation of service", while Dash Core defines them as termination of service, compromised keys and change of keys (providertx.h). base-sdk fixed the names in dashpay/base-sdk#132.
This moves the pin from
90952f89to base-sdkdevelopata4ea791e, by commit. Only the pin andCargo.lockchange. The range also brings dashpay/base-sdk#126, which refuses governance object signatures over 96 bytes. Hyphen's governance hashing already tolerates a decode failure.Hyphen stores the reason's name in the payload JSON. New revocations get the right name. Rows ingested before this keep the old name, so an existing database needs those rows re-derived from the node, or a re-sync.
Tested:
cargo test -p hyphend(386 pass),cargo fmt --check,cargo clippy --workspace -- -D warningsandall_lint.py.🤖 Generated with Claude Code
Summary by CodeRabbit