Skip to content

base%build: pin base-sdk at a4ea791e for correct revocation reason names - #5

Merged
PastaPastaPasta merged 1 commit into
developfrom
chore/base-sdk-a4ea791e
Nov 14, 2026
Merged

PastaPastaPasta merged 1 commit into
developfrom
chore/base-sdk-a4ea791e

Conversation

@PastaPastaPasta

@PastaPastaPasta PastaPastaPasta commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Hyphen shows the wrong reason on revocations (ProUpRevTx) for codes 1 to 3. The base-sdk it pins named code 1 "key compromise", code 2 "change of keys" and code 3 "violation of service", while Dash Core defines them as termination of service, compromised keys and change of keys (providertx.h). base-sdk fixed the names in dashpay/base-sdk#132.

This moves the pin from 90952f89 to base-sdk develop at a4ea791e, by commit. Only the pin and Cargo.lock change. The range also brings dashpay/base-sdk#126, which refuses governance object signatures over 96 bytes. Hyphen's governance hashing already tolerates a decode failure.

Hyphen stores the reason's name in the payload JSON. New revocations get the right name. Rows ingested before this keep the old name, so an existing database needs those rows re-derived from the node, or a re-sync.

Tested: cargo test -p hyphend (386 pass), cargo fmt --check, cargo clippy --workspace -- -D warnings and all_lint.py.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • This update contains internal maintenance changes only. There are no visible changes to the application’s features, behavior, or interface. Existing user-facing functionality remains unchanged, with no new options, workflows, or settings included.

base-sdk a4ea791e names ProUpRevTx reasons 1 to 3 as Dash Core does
(termination of service, compromised keys, change of keys). Hyphen stores
the reason's name in the payload JSON, so new revocations now carry the
right name. It also refuses governance object signatures over 96 bytes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

dashpay is on CodeRabbit Free, which includes PR summaries. Ask your admin to upgrade for code reviews.

  • Ask an admin to upgrade

Open in CodeRabbit

Walkthrough

The daemon manifest updates the base-sdk revision used by four optional dependencies. Their optional status and other dependency settings remain unchanged.

Changes: Base SDK revision update

Layer / File(s) Summary
Update base-sdk dependency revisions
pkgs/daemon/Cargo.toml
Four optional dependencies now reference revision a4ea791e64e67d4053c6b328b43fe49df6f7f99d. Other dependency settings are unchanged.

Estimated code review effort: 2 (Simple) | ~5 minutes

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Free
  • Run ID: c5eb33d6-ce54-48d3-8dd2-fe5a68afbad7
Commits

Reviewing files that changed from the base of the PR and between d5ea27e and 21cac99.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1

  • pkgs/daemon/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Note

This pull request has no conflicts! 🎊 🎉 🎊

Actions

Workflow Status Link
Run linters 🟢 Pass Run #57
Rust ⌛ Waiting -
TypeScript ⌛ Waiting -
Test hyphen-daemon ⌛ Waiting -
Test hyphen-db ⌛ Waiting -
Test @repo/hyphen-webui ⌛ Waiting -

@PastaPastaPasta
PastaPastaPasta merged commit 3f9056c into develop Nov 14, 2026
7 of 9 checks passed
@PastaPastaPasta
PastaPastaPasta deleted the chore/base-sdk-a4ea791e branch November 14, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant