You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(dashpay): restore the connection sheet strings missing from Localizable.strings - #1415
#1399 (the connection sheet shows what an app can spend and do) was merged right after #1405 (drop unused keys and sort Localizable.strings), and its squash commit carries no Localizable.strings change. Twelve keys its code asks for are in no locale file on develop, so every locale shows the English key on the connection sheet and the Connections page, and Transifex never sees them.
What was done?
Added back to all 43 Localizable.strings files the twelve keys that ConnectionSheet.swift and ConnectionsViewModel.swift ask for and no file holds: %1$@ left of %2$@, %1$@: %2$@, App key, Connection expiry, DashPay profile key, Funding left, Identity funding limits, Maximum of %@, No limit, Not known, See what %@ will be able to do, What is left of the keys' budgets could not be read.
Script check over develop's sources: every NSLocalizedString key in the DashConnect connection sheet and view model is now in en.lproj/Localizable.strings.
All 43 files are still sorted by key, case-insensitively; git diff --check is clean; the diff has no removed lines.
No local build; CI builds the app.
Breaking Changes
None.
Checklist:
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
ADR (ADR-0001), keep the answer that applies: no significant decision
Nothing in this PR (files, commit messages, branch name, description, comments, attachments, linked issues) holds customer data, unfixed vulnerability detail, secrets, or step-by-step attack detail against keys, PIN or encryption; such content is left out and handled privately with the maintainers (ADR-0001, rule 2)
For repository code-owners and collaborators only
I have assigned this pull request to a milestone
If workflow-lint warned that a release-only step or .xcode-version changed, or a .platform-ref bump changed platform's Rust version, I ran the affected workflow by hand from this branch on the final commit (release-dashpay-testflight.yml with wallet_ref = that commit and release_channel: internal-only; appstore-schema-release.yml with dry_run: true) and linked the run here; a later push needs a new run
…ble.strings
The connection sheet and the Connections view model ask for twelve keys that
no Localizable.strings file holds, so every locale shows the English key.
Add them back to all 43 locale files with the values they had on the sheet's
branch, in the case-insensitive key order the files are sorted in.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The English localization catalog adds 12 DashConnect connection-sheet strings. Corresponding entries were added to the other locale catalogs. Many non-English catalog values use the English source text.
Changes: DashConnect localization
Layer / File(s)
Summary
Connection-sheet strings across locales DashWallet/*.lproj/Localizable.strings
The catalogs add strings for key budgets, app and profile key labels, expiry, funding and spending limits, app capabilities, and unreadable budget details. Formatted entries include amount and app-name placeholders.
This restores missing connection-sheet strings across all locales. It has no practical user-facing risk. Locale values stay in English until translations are pulled. The failing PR-title check is a scope-naming issue, not a code defect.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Title check
The title names the main change: restoring twelve DashConnect connection-sheet strings that were missing from the Localizable.strings files. The raw summary confirms that the change adds these entries…
Full details: Title check
Explanation
The title names the main change: restoring twelve DashConnect connection-sheet strings that were missing from the Localizable.strings files. The raw summary confirms that the change adds these entries across the locale files, and the PR objectives describe the same fix, so the title matches the changeset. The 'dashpay' scope is a reasonable label for the DashConnect/DashPay feature area, though the objectives use 'l10n' instead.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The reason will be displayed to describe this comment to others. Learn more.
Verdict: ready to merge once the PR title passes
No blockers or majors in the change. Reviewed at d6deb87. Other CI jobs were still pending.
Must fix before merge
Validate PR title fails with Unknown scope "l10n". The allowed scopes in .github/workflows/semantic-pull-request.yml are ui, dashsync, uphold, coinbase, explore-dash, crowdnode, syncing, testnet, dashpay, wallet, coinjoin, voting and dashdex. fix(dashpay): … fits, because the keys belong to the DashConnect connection sheet.
Checked
Coverage. Every NSLocalizedString key in ConnectionSheet.swift and ConnectionsViewModel.swift is now in en.lproj/Localizable.strings. None is missing.
Values. All 516 added entries (12 keys × 43 locales) have the value equal to the key. They are English, per the rule that new keys ship in English until the Transifex pull.
Shape. Each of the 43 files gets exactly 36 added lines and no removed lines. No key is duplicated.
Recommendation (non-blocking)
This was a merge-order accident: #1399 was squashed after #1405 re-sorted the files, and the strings were dropped silently. The check from the description, that every NSLocalizedString key in the sources exists in en.lproj, would catch the next one if it ran in CI.
romchornyi
changed the title
fix(l10n): restore the connection sheet strings missing from Localizable.strings
fix(dashpay): restore the connection sheet strings missing from Localizable.strings
Nov 13, 2026
The reason will be displayed to describe this comment to others. Learn more.
Additional comments: 1
DashWallet/fr.lproj/Localizable.strings-23-23: 1
23-23: Minor · Functional Correctness · Heavy lift
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Use the translation workflow for these entries.
The new budget, limit, expiry, and error text remains in English. The same applies to the additions in DashWallet/fi.lproj/Localizable.strings and DashWallet/fil.lproj/Localizable.strings, starting at Line 23. Users cannot review these connection details in their selected language. Remove the English placeholders and obtain translations through the localization workflow.
Based on learnings: “do not add English placeholder values directly to non-English Localizable.strings files”; use the Transifex workflow.
Source: Learnings
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 5c3137e7-5fa6-4792-9a9f-ee37a631f9b0
Commits
Reviewing files that changed from the base of the PR and between f2cb0d9 and d6deb87.
Files selected for processing: 43
DashWallet/ar.lproj/Localizable.strings
DashWallet/bg.lproj/Localizable.strings
DashWallet/ca.lproj/Localizable.strings
DashWallet/cs.lproj/Localizable.strings
DashWallet/da.lproj/Localizable.strings
DashWallet/de.lproj/Localizable.strings
DashWallet/el.lproj/Localizable.strings
DashWallet/en.lproj/Localizable.strings
DashWallet/eo.lproj/Localizable.strings
DashWallet/es.lproj/Localizable.strings
DashWallet/et.lproj/Localizable.strings
DashWallet/fa.lproj/Localizable.strings
DashWallet/fi.lproj/Localizable.strings
DashWallet/fil.lproj/Localizable.strings
DashWallet/fr.lproj/Localizable.strings
DashWallet/hr.lproj/Localizable.strings
DashWallet/hu.lproj/Localizable.strings
DashWallet/id.lproj/Localizable.strings
DashWallet/it.lproj/Localizable.strings
DashWallet/ja.lproj/Localizable.strings
DashWallet/ko.lproj/Localizable.strings
DashWallet/mk.lproj/Localizable.strings
DashWallet/ms.lproj/Localizable.strings
DashWallet/nb.lproj/Localizable.strings
DashWallet/nl.lproj/Localizable.strings
DashWallet/pl.lproj/Localizable.strings
DashWallet/pt.lproj/Localizable.strings
DashWallet/ro.lproj/Localizable.strings
DashWallet/ru.lproj/Localizable.strings
DashWallet/sk.lproj/Localizable.strings
DashWallet/sl.lproj/Localizable.strings
DashWallet/sl_SI.lproj/Localizable.strings
DashWallet/sq.lproj/Localizable.strings
DashWallet/sr.lproj/Localizable.strings
DashWallet/sv.lproj/Localizable.strings
DashWallet/th.lproj/Localizable.strings
DashWallet/tr.lproj/Localizable.strings
DashWallet/uk.lproj/Localizable.strings
DashWallet/vi.lproj/Localizable.strings
DashWallet/zh-Hans.lproj/Localizable.strings
DashWallet/zh-Hant-TW.lproj/Localizable.strings
DashWallet/zh.lproj/Localizable.strings
DashWallet/zh_TW.lproj/Localizable.strings
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Final validation — Phase 1 + Phase 2
The reviewed head contains only the intended 36-line additions to each of the 43 main-app localization catalogs. The restored keys match the connection sheet and view-model call sites, preserve catalog ordering and encoding, and introduce no blocking or in-scope issues; the simulator test check is still queued, while the failed checks are unrelated PR-title validation retries.
Triage: low by gpt-6.1-sol (effort low) — This is a contained localization-only change that restores twelve missing strings across locale files without changing application behavior or any critical surface.
These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.
Add CI coverage for localization key completeness — The missing connection-sheet keys were not caught when the feature merged, and the current CI checks do not compare NSLocalizedString literals with the English catalog. This is a valid regression-prevention improvement, but it is not introduced by this strings-only restoration change.
Follow-up: Open a follow-up PR adding a catalog-coverage check for NSLocalizedString keys and wiring it into CI, similar to scripts/ci/check_test_target_membership.py.
…-3ec86b
Localizable.strings: develop restored and added DashConnect keys (#1415,
#1289, #1293); the three new keys are re-inserted at their sorted positions
in develop's files.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
#1399 (the connection sheet shows what an app can spend and do) was merged right after #1405 (drop unused keys and sort Localizable.strings), and its squash commit carries no Localizable.strings change. Twelve keys its code asks for are in no locale file on
develop, so every locale shows the English key on the connection sheet and the Connections page, and Transifex never sees them.What was done?
Localizable.stringsfiles the twelve keys thatConnectionSheet.swiftandConnectionsViewModel.swiftask for and no file holds:%1$@ left of %2$@,%1$@: %2$@,App key,Connection expiry,DashPay profile key,Funding left,Identity funding limits,Maximum of %@,No limit,Not known,See what %@ will be able to do,What is left of the keys' budgets could not be read.developlacks are used nowhere indevelop's code, so chore(ui): drop unused keys and sort Localizable.strings as BartyCrouch writes them #1405 dropped them correctly; they stay out.How Has This Been Tested?
develop's sources: everyNSLocalizedStringkey in the DashConnect connection sheet and view model is now inen.lproj/Localizable.strings.git diff --checkis clean; the diff has no removed lines.Breaking Changes
None.
Checklist:
no significant decisionFor repository code-owners and collaborators only
.xcode-versionchanged, or a.platform-refbump changed platform's Rust version, I ran the affected workflow by hand from this branch on the final commit (release-dashpay-testflight.ymlwithwallet_ref= that commit andrelease_channel: internal-only;appstore-schema-release.ymlwithdry_run: true) and linked the run here; a later push needs a new run🤖 Generated with Claude Code
Summary by CodeRabbit