Repository navigation
feat(dashpay): the connection sheet shows what an app can spend and do #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
romchornyi
merged 278 commits into
develop
from
feat/dashconnect-connection-sheet-access
Nov 13, 2026
Merged
Changes from all commits
Commits
Show all changes
278 commits
Select commit
Hold shift + click to select a range
c89def3
fix(dashpay): a devnet pointed at other nodes is another scope for a …
jeanpierreroma 41187c9
fix(dashpay): record a one-QR session key before its registration is …
jeanpierreroma 5868ac1
fix(dashpay): confirm a recovered one-QR key only with its bound and …
jeanpierreroma b41bc1c
fix(dashpay): free a native result string through a typed C pointer
jeanpierreroma 4a05418
Merge branch 'develop' into feat/dashconnect-v2
jeanpierreroma 06e0d2c
fix(dashpay): activate an app's existing row when its one-QR key is c…
jeanpierreroma 5c2f19d
fix(dashpay): give a confirmed one-QR key its row back if the row was…
jeanpierreroma d126261
Merge remote-tracking branch 'origin/develop' into feat/dashconnect-v2
jeanpierreroma 3b75374
build: pin the platform SDK to v5.1-dev with platform#4844
jeanpierreroma b9e5089
fix(dashpay): settle a pending one-QR registration before a disconnec…
jeanpierreroma 96bee7c
fix(dashpay): choose the disconnect from a fresh view, and settle a o…
jeanpierreroma 13c1466
fix(dashpay): open an App Connect callback only for a request opened …
jeanpierreroma ce53cc7
fix(dashpay): report the user's last answer to an App Connect callback
jeanpierreroma 87a75f1
fix(dashpay): check an App Connect v2 request against the app's website
jeanpierreroma aaee088
fix(dashpay): send an App Connect v2 key again only as the binding's,…
jeanpierreroma bf4e32c
fix(dashpay): settle a registration that lands during a disconnect, a…
jeanpierreroma 0f3afaa
Merge branch 'feat/dashconnect-v2' into feat/app-connect-request-v2
jeanpierreroma 05cda52
Merge branch 'feat/app-connect-request-v2' into feat/app-connect-v2-l…
jeanpierreroma f796a86
fix(dashpay): close the second round of App Connect v2 review blockers
jeanpierreroma 2286399
fix(dashpay): take an App Connect v2 key that settled late only as it…
jeanpierreroma 74b7fed
fix(dashconnect): take the app's current encryption key from Platform
jeanpierreroma 074aa11
fix(dashconnect): send the current encryption key only when both read…
jeanpierreroma d636c66
fix(dashconnect): follow the contract's current-key rule for the app'…
jeanpierreroma 1bbd2e7
fix(dashconnect): wait for a second read before trusting an answer a …
jeanpierreroma f6d4446
fix(dashconnect): never take a lagging read of the current keys over …
jeanpierreroma 09d8d6c
fix(dashconnect): confirm every answer about the app's current key on…
jeanpierreroma 6ec3819
fix(dashconnect): wait on a second read beside any other live key of …
jeanpierreroma 29f08ca
fix(dashconnect): treat a disabled key of the app's as proof of a cur…
jeanpierreroma b62296c
fix(dashconnect): register the app's key behind a confirmed disabled …
jeanpierreroma 1ebc6d5
fix(dashconnect): count disabled keys of the app's beside a live curr…
jeanpierreroma 58ed8d7
fix(dashconnect): weigh a disabled key the store cannot place, and sh…
jeanpierreroma d2555f7
build: pin the platform SDK to v5.1-dev with platform#5491
jeanpierreroma 7851606
feat(dashpay): accept App Connect requests on dashpay://connect
PastaPastaPasta 790df15
fix(dashpay): bound the work dashpayHost does before the size limit
PastaPastaPasta 1571e2b
build: pin platform to 03945d3a for the encryption rotation level
PastaPastaPasta 41b4f17
feat(dashpay): select App Connect encryption keys by the DIP rotation…
PastaPastaPasta ecca052
feat(dashpay): leave unattributed DashPay profile keys on a disconnec…
romchornyi 2b13a81
fix(dashpay): pin the shared profile revoke to its identity and refus…
romchornyi 16c9bc5
fix(dashpay): keep an expired key from blocking the shared profile re…
romchornyi 0c5c2d6
fix(dashpay): revoke shared profile access only on the identity that …
romchornyi 9d9cb47
fix(dashpay): clearer shared profile copy, card styling and an honest…
romchornyi db0f58c
test(dashpay): cover the shared profile revoke's wallet pin and an un…
romchornyi 1ddb5d0
fix(wallet): pin testnet to Platform protocol 14 on this stack
romchornyi 6c95187
fix(wallet): pin testnet to Platform protocol 14 on this stack
romchornyi 2db6c0d
Merge remote-tracking branch 'origin/feat/app-connect-encryption-rota…
romchornyi c716e4d
docs(dashpay): say testnet gets the App Connect login now that it is …
PastaPastaPasta 5714af0
fix(dashconnect): refuse an App Connect v2 renewal that cannot turn o…
romchornyi fa9270f
Merge remote-tracking branch 'origin/feat/app-connect-encryption-rota…
romchornyi 5270831
feat(dashconnect): add a confirming connection status
romchornyi 4c2b940
fix(dashconnect): record an App Connect v2 grant before submitting it…
romchornyi 5362828
fix(dashconnect): settle a pending App Connect v2 update by a noted l…
romchornyi 95f097f
fix(dashconnect): fail closed on unknown shared profile counts and le…
romchornyi a2c04e3
fix(dashconnect): show the shared profile row in the connections card
romchornyi 6f9d659
fix(dashconnect): keep a confirmed App Connect v2 grant on a lagging …
romchornyi c4d71b8
fix(dashconnect): finish what an App Connect disconnect turned off, a…
romchornyi b2c828c
fix(dashconnect): publish recovered App Connect responses until they …
romchornyi 1eff885
fix(dashconnect): pin a shared profile revoke to what was shown and f…
romchornyi 36918b3
fix(dashconnect): confirm a late-landed App Connect v2 grant without …
romchornyi 352c3bd
Merge remote-tracking branch 'origin/fix/app-connect-shared-profile-a…
romchornyi 52802ec
fix(dashconnect): turn off only live keys of late-landed App Connect …
romchornyi 8587971
fix(dashconnect): judge a vanished shared profile access by the ident…
romchornyi 4cd0358
Merge remote-tracking branch 'origin/fix/app-connect-shared-profile-a…
romchornyi 56960f9
fix(dashconnect): restore a replaced two-QR row before judging by bou…
romchornyi e3c9078
fix(dashconnect): judge a dropped App Connect row by auth keys only, …
romchornyi eb52302
fix(dashconnect): compare App Connect key expiries as unsigned timest…
romchornyi b5be800
fix(dashconnect): note an App Connect update only when its own submis…
romchornyi bb9fb72
fix(dashconnect): a resubmitted App Connect update starts without the…
romchornyi f051611
test(dashconnect): an expired App Connect update whose keys are there…
romchornyi 61f4f46
Merge remote-tracking branch 'origin/fix/app-connect-shared-profile-a…
romchornyi d649367
fix(dashconnect): judge an App Connect row by the dropped record's id…
romchornyi 9308b14
fix(dashconnect): a disconnected app's two-QR row stays gone, and set…
romchornyi d2a626b
fix(dashconnect): retries stay within the approval, raised key limits…
romchornyi 5f6564e
fix(dashconnect): a waiting approval's reused keys reach its retry, a…
romchornyi 30c5b4d
fix(dashconnect): one-QR recovery hands out only the approved limits,…
romchornyi c0945f3
fix(dashconnect): keep a row while the app may still hold keys, settl…
romchornyi 8c50790
fix(dashconnect): a kept row stays as it was, a disconnect clears a r…
romchornyi 276d5aa
Merge remote-tracking branch 'origin/fix/app-connect-v2-grant-lifecyc…
romchornyi 0fef35b
fix(dashconnect): only an added key witnesses an update, a dropped re…
romchornyi 43a448c
fix(dashconnect): keep disables as an update's witness, a disconnect …
romchornyi e436350
feat(dashconnect): redesign the Connections page and add a connection…
romchornyi 140d69d
fix(dashconnect): a disconnect waits while the fetched view lacks a k…
romchornyi 9138fbd
Merge remote-tracking branch 'origin/fix/app-connect-v2-grant-lifecyc…
romchornyi 78ceedd
feat(dashconnect): a disconnect turns off unattributed DashPay profil…
romchornyi 7686069
fix(dashconnect): the app's revoke is never blocked by the profile ke…
romchornyi 024d99d
fix(dashconnect): connection sheet and tab states, history per app an…
romchornyi 29b2146
Merge #1263 (a disconnect turns off unattributed DashPay profile keys…
romchornyi 4aabd15
fix(dashconnect): profile keys go only with a disconnect that leaves …
romchornyi f09b5db
Merge #1272 (with #1263's automatic profile-key revoke) into feat/das…
romchornyi f3d2e9f
fix(dashconnect): the disconnect confirmation says what this row's di…
romchornyi 43b9c5c
fix(dashconnect): the connection sheet hands over to a request on dis…
romchornyi 001b864
fix(dashconnect): sheet details survive a status check, a closing she…
romchornyi 47ce526
fix(dashconnect): the whole Disconnect button takes the tap
romchornyi 3b44a3e
revert(ui): leave the shared SegmentedControl as it is
romchornyi 37b62e6
fix(dashconnect): a waiting record holding a live key is kept, a disa…
romchornyi b806585
Merge remote-tracking branch 'origin/fix/app-connect-v2-grant-lifecyc…
romchornyi 35e967b
fix(dashconnect): a row held by a waiting record shows its grant, a l…
romchornyi cf0a47e
fix(dashconnect): funding only for confirmed grants, history cleared …
romchornyi 17770c1
fix(dashconnect): a waiting record keeps the keys the store gives it,…
romchornyi 7332ea0
Merge remote-tracking branch 'origin/fix/app-connect-v2-grant-lifecyc…
romchornyi 8a851d5
fix(dashconnect): the funding limits info sheet is as tall as its text
romchornyi a69857c
fix(dashconnect): a later own update settles nothing; a waiting recor…
romchornyi 9fdfed9
Merge #1272 (a69857ce7) into feat/dashconnect-redesign-connections
romchornyi 0d27c19
fix(dashconnect): a row a waiting record brings back keeps the app's …
romchornyi 13903e9
feat(dashconnect): Disconnect and Reconnect on each Connections row
romchornyi 2eff9e6
fix(dashconnect): an incomplete expiry check says so, and the sheet f…
romchornyi c3df42a
fix(dashpay): expiry checks keep to their wallet and the chain's time…
romchornyi da098d6
refactor(dashpay): take the connection expiry check out of the Connec…
romchornyi 5032ebf
refactor(dashpay): take the disconnected-apps history out of the Conn…
romchornyi 62be203
fix(dashpay): a disconnect does what its question said; grant receipt…
romchornyi c4927f6
fix(dashpay): a two-QR row's disconnect question does not promise a r…
romchornyi bf7f7bc
fix(dashpay): one rule decides whether a disconnect is what its quest…
romchornyi 9471603
fix(dashpay): a retried grant keeps its first terms; the disconnect c…
romchornyi 5c3a4ed
fix(dashpay): the Connections page waits for its rows; one decision f…
romchornyi 7d4b89d
fix(dashpay): a disconnect of a gone row says so; a session key's rec…
romchornyi 43938ad
fix(dashpay): the Connections page follows every write to its rows
romchornyi be313b2
fix(dashconnect): settle a waiting App Connect v2 update by the revis…
romchornyi 6592d8e
Merge remote-tracking branch 'origin/fix/app-connect-v2-grant-lifecyc…
romchornyi 3415560
refactor(dashconnect): derive App Connect rows from the identity and …
romchornyi ded1f51
refactor(dashconnect): remove the two-QR login and close review findings
romchornyi 9e87349
fix(dashconnect): keep live keys of a conflicting intent actionable a…
romchornyi 8e8aa7e
fix(dashconnect): bind retries to their connection and recheck keys b…
romchornyi ab339f2
fix(dashconnect): publish a response only while its keys are current …
romchornyi 5c4f4db
fix(dashconnect): read the app's current encryption key one way
romchornyi 4f16611
refactor(dashconnect): answer a request at most once; show undelivere…
romchornyi e536c44
fix(dashconnect): check the read that showed the update before publis…
romchornyi dbffc36
fix(dashconnect): keep a scan button and access seen on other identities
romchornyi 3c9445e
fix(dashconnect): tell an answered request by its whole body
romchornyi 917a4a0
fix(dashconnect): refuse every repeat approval of a request
romchornyi 7422ef0
Merge branch 'develop' into feat/app-connect-v2-login
romchornyi d8ba460
fix(dashpay): derive an App Connect encryption key at DIP-13 rotation 0
romchornyi de4b125
fix(dashpay): refuse an App Connect request v2 for mainnet in the parser
romchornyi 5b3505f
docs: record ADR-0009 for answering App Connect request v2
romchornyi d6289ee
fix(dashconnect): key the sheet's permission rows by position
romchornyi 62dc24a
fix(dashconnect): bound the dash-key query before it is split or decoded
romchornyi 3ca6b58
fix(dashconnect): tell the app when its request is refused at Approve
romchornyi 05c9991
fix(dashconnect): leave the encryption slot out behind a disabled cur…
romchornyi d830206
fix(dashconnect): warn, not refuse, when a known app's request return…
romchornyi 0d46484
fix(dashconnect): refuse, not retry, a request that names an absent c…
romchornyi 5620cbc
fix(dashconnect): refuse a v2 request for an absent app contract or d…
romchornyi 29fef61
Merge origin/develop into feat/app-connect-v2-login
romchornyi ae77818
fix(dashconnect): refuse a v2 app owned like a system contract
romchornyi 99baad2
Merge the final head of #1210 into feat/app-connect-dashpay-carrier
romchornyi b6527df
Merge origin/develop into feat/app-connect-dashpay-carrier
romchornyi edcc414
Merge feat/app-connect-dashpay-carrier into feat/app-connect-encrypti…
romchornyi 6f230ff
Merge feat/app-connect-encryption-rotation into fix/app-connect-share…
romchornyi ad072fd
Merge fix/app-connect-shared-profile-access into refactor/app-connect…
romchornyi 654b76b
test(dashconnect): drop the session-key terms from the refusal-at-App…
romchornyi c2c5afe
feat(dashpay): redesign the Connections page and add a connection sheet
romchornyi 0315a24
Move the Connections redesign onto #1301
romchornyi cfefa97
feat(dashpay): DashConnect connection states from Platform and a disc…
romchornyi 58e6173
Merge #1334 (connection states, disconnect) into the Connections rede…
romchornyi a3452b5
refactor(dashpay): leave the approve sheet's terms to the redesigned …
romchornyi 69cd105
Merge stack/1334 (the approve sheet's terms left to #1278) into 1277
romchornyi ee80f00
ci: stub DashConnectStores in the Core drain recovery harness
romchornyi 92a1736
Merge 1334 (Core drain harness stub) into 1277
romchornyi 740f8ab
docs: record ADR-0015 to 0022 for DashConnect connection states and d…
romchornyi 9b067c4
Merge 1334 (ADR-0015 to 0022) into 1277
romchornyi 19e57aa
docs(dashconnect): give the wallet's own gate as the reason a mainnet…
romchornyi e9f88e6
Merge remote-tracking branch 'origin/develop' into feat/app-connect-e…
romchornyi e3a44f8
fix(dashpay): DashConnect unrecorded-only connections by Platform tim…
romchornyi 51baec2
Merge branch 'stack/1334' into stack/1277
romchornyi 04c5cca
fix(dashpay): DashConnect connection sheet ignores a stale dismissal …
romchornyi 2fca237
docs(adr): record #1301's App Connect decisions (0027–0030)
romchornyi 99d6166
Merge branch 'stack/1301' into stack/1334
romchornyi 3fb8f08
Merge branch 'stack/1334' into stack/1277
romchornyi 41ee478
fix(dashconnect): disable the app's keys after the profile keys, and …
romchornyi bd0145e
Merge remote-tracking branch 'origin/feat/app-connect-encryption-rota…
romchornyi 44abef3
Merge remote-tracking branch 'origin/develop' into feat/app-connect-e…
romchornyi 7180c6e
Merge remote-tracking branch 'origin/feat/app-connect-encryption-rota…
romchornyi 9447a46
docs(dashpay): describe the encryption key rules in ADR-0009 and the …
romchornyi 5dc260a
Merge remote-tracking branch 'origin/feat/app-connect-encryption-rota…
romchornyi 075afb3
Merge remote-tracking branch 'origin/develop' into fix/app-connect-sh…
romchornyi f7995b4
Merge remote-tracking branch 'origin/fix/app-connect-shared-profile-a…
romchornyi 20076bc
fix(dashconnect): disable the app's keys after the other keys on disc…
romchornyi 19ac4fb
Merge branch 'stack/1301' into stack/1334
romchornyi c454b4e
test(dashconnect): a disconnect plan lists the profile keys before th…
romchornyi fb609c2
Merge branch 'stack/1334' into stack/1277
romchornyi aa03cc0
Merge origin/develop into stack/1301 (#1263 squash-merged; its tree i…
romchornyi ebbdb92
Merge branch 'stack/1301' into stack/1334
romchornyi da18708
Merge branch 'stack/1334' into stack/1277
romchornyi 1e11360
fix(dashconnect): retry a failed response delete on the next signed o…
romchornyi f866489
Merge branch 'stack/1301' into stack/1334
romchornyi 916b1c9
Merge branch 'stack/1334' into stack/1277
romchornyi 0bb2013
fix(dashconnect): an update is not landed while a key's bound is unknown
romchornyi 0a29cf5
fix(dashconnect): retry left response deletes on every signed disconnect
romchornyi 8b1491a
Merge branch 'stack/1301' into stack/1334
romchornyi 62c58fb
Merge branch 'stack/1334' into stack/1277
romchornyi e002360
fix(dashconnect): keep the row while a disconnect leaves keys of unkn…
romchornyi 9fd7dcd
Merge branch 'stack/1301' into stack/1334
romchornyi f5388f7
Merge branch 'stack/1334' into stack/1277
romchornyi 4e8c23a
fix(dashconnect): keep every row while a key's bound is unknown
romchornyi 6b69db0
Merge refactor/app-connect-projection into feat/dashconnect-connectio…
romchornyi 57e51a8
Merge branch 'stack/1334' into stack/1277
romchornyi e134a7a
fix(dashconnect): a disconnect also turns off the app's keys on its o…
romchornyi 1d0cbcb
Merge fix/app-connect-owner-attribution (#1364) into feat/dashconnect…
romchornyi e14d9af
docs(adr): drop the private feature-record links from ADR-0032 and AD…
romchornyi 8a7c166
Merge stack/1334 with #1364 into feat/dashconnect-redesign-connections
romchornyi 3934123
Merge fix/app-connect-owner-attribution (#1364) into feat/dashconnect…
romchornyi f8f4bca
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi 1edad2b
docs(adr): ADR-0033 is superseded by ADR-0016 on this branch
romchornyi 77f2bd0
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi 40007ae
fix(dashpay): bind offered keys to their identity and report what sta…
romchornyi 4d7ff7c
Merge fix/app-connect-owner-attribution (#1364) into feat/dashconnect…
romchornyi d622ad0
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi 2652628
fix(dashconnect): a disconnect also turns off the app's keys on its o…
romchornyi 7230f62
docs(adr): drop the private feature-record links from ADR-0032 and AD…
romchornyi 8b6c87d
fix(dashpay): bind offered keys to their identity and report what sta…
romchornyi eacd952
Merge fix/app-connect-owner-attribution (#1364) into feat/dashconnect…
romchornyi 7a730c3
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi c69eb3f
fix(dashpay): date granted App Connect keys by Platform time and refu…
romchornyi 5d1eac8
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi 0ff9f55
fix(dashpay): settle a disconnect's rows and result on one owner read
romchornyi 1ffe25a
Merge fix/app-connect-owner-attribution (#1364) into feat/dashconnect…
romchornyi 0e75d09
fix(dashpay): keep an App Connect row while another identity still ha…
romchornyi 6a11823
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi e661639
fix(dashpay): report every key a confirmed disconnect leaves on, unde…
romchornyi 6fd0f88
Merge fix/app-connect-owner-attribution into feat/dashconnect-connect…
romchornyi 1fcf496
fix(dashpay): keep a key's raised limits across reads and DashConnect…
romchornyi 22344fd
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi af44713
fix(dashpay): send the user to the row whose disconnect offers every …
romchornyi 19224c4
Merge fix/app-connect-owner-attribution into feat/dashconnect-connect…
romchornyi e2cce0c
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi 3967684
fix(dashpay): remember contract owners per devnet name and endpoint
romchornyi 42f723e
fix(dashpay): admit an identity read atomically, keep the later block…
romchornyi e7e1d77
Merge fix/app-connect-owner-attribution into feat/dashconnect-connect…
romchornyi 13d11fe
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi 22822a4
Merge develop into feat/dashconnect-connection-states
romchornyi 16efa1b
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi d3e172f
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi 41a810e
fix(dashpay): keep a renewed app's row while a key's bound is unknown…
romchornyi a7c01dd
fix(dashpay): the connection sheet shows what the keys on Platform give
romchornyi 1e1ebb6
fix(dashpay): say what a disconnect turned off beyond the app's recor…
romchornyi a2ea8ff
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi 03e5af8
fix(dashpay): read key budgets off the main actor and count the app's…
romchornyi 48858ca
fix(dashpay): a sheet's disconnect runs only while its row still offe…
romchornyi 9d6f349
refactor(dashpay): the connection sheet no longer claims what an app …
romchornyi 1d55e52
feat(dashpay): the connection sheet shows what an app can spend and do
romchornyi 848c871
fix(dashpay): a connection sheet with no identity read claims no access
romchornyi 3688c70
Merge develop into feat/dashconnect-redesign-connections
romchornyi 42997e1
fix(dashpay): a sheet shows the identity of a row of unrecorded keys,…
romchornyi cf77343
Merge feat/dashconnect-redesign-connections into feat/dashconnect-con…
romchornyi f3096f7
fix(dashpay): the sheet's message access, funding lines and group war…
romchornyi 75a94f8
fix(dashpay): the sheet's Disconnect uses DashUIKit's tinted red, and…
romchornyi ea0fd6c
Merge feat/dashconnect-redesign-connections into feat/dashconnect-con…
romchornyi eec6650
fix(dashpay): a connection sheet claims message access only from encr…
romchornyi b695948
fix(dashpay): the sheet does not show what is left of a budget above …
romchornyi c77d018
fix(dashpay): the sheet claims no access through a key of unknown bou…
romchornyi eacae78
Merge develop into feat/dashconnect-connection-sheet-access
romchornyi ce6098b
fix(dashpay): a funding refresh with nothing to read clears the sheet…
romchornyi 7bd0ae6
fix(dashpay): tell the connection sheet's access and funding from one…
romchornyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Blocking: Do not report message access from an encryption key with an unknown bound
presence(of:in:)treats a matching key as.liveeven whenPlatformKey.boundKnownis false becauseisSameKeydeliberately permits an unknown bound.encryptionKeysGiveAccessthen accepts that.liveresult, and the re-sent-key branch checks only the key id and liveness. A key whose contract binding the wallet cannot read may belong to another contract, so the connection sheet can claim that the app receives encrypted messages without establishing that the identity's encryption key is bound to this app. The authentication projection already fails closed throughaccessKey; the message-access predicate needs the same known-bound requirement for both re-sent and added encryption keys.Raised on code unchanged since the last review, and confirmed by an independent pass: When an identity snapshot contains a matching encryption key with boundKnown == false, presence(of:in:) returns .live and encryptionKeysGiveAccess reports message access. The connection sheet can therefore claim the app receives encrypted messages even though the wallet cannot establish that the key is bound to this app and it may belong to another contract.
source:
gpt-6.1-sol(phase2-reviewer: general)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 7bd0ae6.
AppConnect.placedKey(withId:in:)is now the one proof for every claim the sheet makes from a key on Platform: access, messages and funding lines. A key whose bound the store does not hold gives no message access, whether the response added it or sent it again. Covered bytestMessageAccessNeedsItsEncryptionKeysPlaced.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved (re-reviewed at
7bd0ae65): Message access now requires every re-sent or added encryption key to be returned by placedKey, which requires a known bound. An encryption key with an unreadable bound therefore produces no message-access claim.