Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
278 commits
Select commit Hold shift + click to select a range
c89def3
fix(dashpay): a devnet pointed at other nodes is another scope for a …
jeanpierreroma Oct 13, 2026
41187c9
fix(dashpay): record a one-QR session key before its registration is …
jeanpierreroma Oct 14, 2026
5868ac1
fix(dashpay): confirm a recovered one-QR key only with its bound and …
jeanpierreroma Oct 14, 2026
b41bc1c
fix(dashpay): free a native result string through a typed C pointer
jeanpierreroma Oct 14, 2026
4a05418
Merge branch 'develop' into feat/dashconnect-v2
jeanpierreroma Oct 15, 2026
06e0d2c
fix(dashpay): activate an app's existing row when its one-QR key is c…
jeanpierreroma Oct 15, 2026
5c2f19d
fix(dashpay): give a confirmed one-QR key its row back if the row was…
jeanpierreroma Oct 15, 2026
d126261
Merge remote-tracking branch 'origin/develop' into feat/dashconnect-v2
jeanpierreroma Oct 16, 2026
3b75374
build: pin the platform SDK to v5.1-dev with platform#4844
jeanpierreroma Oct 16, 2026
b9e5089
fix(dashpay): settle a pending one-QR registration before a disconnec…
jeanpierreroma Oct 16, 2026
96bee7c
fix(dashpay): choose the disconnect from a fresh view, and settle a o…
jeanpierreroma Oct 16, 2026
13c1466
fix(dashpay): open an App Connect callback only for a request opened …
jeanpierreroma Oct 18, 2026
ce53cc7
fix(dashpay): report the user's last answer to an App Connect callback
jeanpierreroma Oct 18, 2026
87a75f1
fix(dashpay): check an App Connect v2 request against the app's website
jeanpierreroma Oct 18, 2026
aaee088
fix(dashpay): send an App Connect v2 key again only as the binding's,…
jeanpierreroma Oct 18, 2026
bf4e32c
fix(dashpay): settle a registration that lands during a disconnect, a…
jeanpierreroma Oct 18, 2026
0f3afaa
Merge branch 'feat/dashconnect-v2' into feat/app-connect-request-v2
jeanpierreroma Oct 18, 2026
05cda52
Merge branch 'feat/app-connect-request-v2' into feat/app-connect-v2-l…
jeanpierreroma Oct 18, 2026
f796a86
fix(dashpay): close the second round of App Connect v2 review blockers
jeanpierreroma Oct 18, 2026
2286399
fix(dashpay): take an App Connect v2 key that settled late only as it…
jeanpierreroma Oct 18, 2026
74b7fed
fix(dashconnect): take the app's current encryption key from Platform
jeanpierreroma Oct 19, 2026
074aa11
fix(dashconnect): send the current encryption key only when both read…
jeanpierreroma Oct 19, 2026
d636c66
fix(dashconnect): follow the contract's current-key rule for the app'…
jeanpierreroma Oct 19, 2026
1bbd2e7
fix(dashconnect): wait for a second read before trusting an answer a …
jeanpierreroma Oct 19, 2026
f6d4446
fix(dashconnect): never take a lagging read of the current keys over …
jeanpierreroma Oct 19, 2026
09d8d6c
fix(dashconnect): confirm every answer about the app's current key on…
jeanpierreroma Oct 19, 2026
6ec3819
fix(dashconnect): wait on a second read beside any other live key of …
jeanpierreroma Oct 19, 2026
29f08ca
fix(dashconnect): treat a disabled key of the app's as proof of a cur…
jeanpierreroma Oct 19, 2026
b62296c
fix(dashconnect): register the app's key behind a confirmed disabled …
jeanpierreroma Oct 19, 2026
1ebc6d5
fix(dashconnect): count disabled keys of the app's beside a live curr…
jeanpierreroma Oct 19, 2026
58ed8d7
fix(dashconnect): weigh a disabled key the store cannot place, and sh…
jeanpierreroma Oct 19, 2026
d2555f7
build: pin the platform SDK to v5.1-dev with platform#5491
jeanpierreroma Oct 24, 2026
7851606
feat(dashpay): accept App Connect requests on dashpay://connect
PastaPastaPasta Oct 28, 2026
790df15
fix(dashpay): bound the work dashpayHost does before the size limit
PastaPastaPasta Oct 28, 2026
1571e2b
build: pin platform to 03945d3a for the encryption rotation level
PastaPastaPasta Oct 29, 2026
41b4f17
feat(dashpay): select App Connect encryption keys by the DIP rotation…
PastaPastaPasta Oct 29, 2026
ecca052
feat(dashpay): leave unattributed DashPay profile keys on a disconnec…
romchornyi Oct 30, 2026
2b13a81
fix(dashpay): pin the shared profile revoke to its identity and refus…
romchornyi Oct 30, 2026
16c9bc5
fix(dashpay): keep an expired key from blocking the shared profile re…
romchornyi Oct 30, 2026
0c5c2d6
fix(dashpay): revoke shared profile access only on the identity that …
romchornyi Oct 30, 2026
9d9cb47
fix(dashpay): clearer shared profile copy, card styling and an honest…
romchornyi Oct 30, 2026
db0f58c
test(dashpay): cover the shared profile revoke's wallet pin and an un…
romchornyi Oct 30, 2026
1ddb5d0
fix(wallet): pin testnet to Platform protocol 14 on this stack
romchornyi Oct 30, 2026
6c95187
fix(wallet): pin testnet to Platform protocol 14 on this stack
romchornyi Oct 30, 2026
2db6c0d
Merge remote-tracking branch 'origin/feat/app-connect-encryption-rota…
romchornyi Oct 30, 2026
c716e4d
docs(dashpay): say testnet gets the App Connect login now that it is …
PastaPastaPasta Oct 30, 2026
5714af0
fix(dashconnect): refuse an App Connect v2 renewal that cannot turn o…
romchornyi Oct 30, 2026
fa9270f
Merge remote-tracking branch 'origin/feat/app-connect-encryption-rota…
romchornyi Oct 30, 2026
5270831
feat(dashconnect): add a confirming connection status
romchornyi Oct 30, 2026
4c2b940
fix(dashconnect): record an App Connect v2 grant before submitting it…
romchornyi Oct 30, 2026
5362828
fix(dashconnect): settle a pending App Connect v2 update by a noted l…
romchornyi Oct 30, 2026
95f097f
fix(dashconnect): fail closed on unknown shared profile counts and le…
romchornyi Oct 30, 2026
a2c04e3
fix(dashconnect): show the shared profile row in the connections card
romchornyi Oct 30, 2026
6f9d659
fix(dashconnect): keep a confirmed App Connect v2 grant on a lagging …
romchornyi Oct 30, 2026
c4d71b8
fix(dashconnect): finish what an App Connect disconnect turned off, a…
romchornyi Oct 30, 2026
b2c828c
fix(dashconnect): publish recovered App Connect responses until they …
romchornyi Oct 30, 2026
1eff885
fix(dashconnect): pin a shared profile revoke to what was shown and f…
romchornyi Oct 30, 2026
36918b3
fix(dashconnect): confirm a late-landed App Connect v2 grant without …
romchornyi Oct 30, 2026
352c3bd
Merge remote-tracking branch 'origin/fix/app-connect-shared-profile-a…
romchornyi Oct 30, 2026
52802ec
fix(dashconnect): turn off only live keys of late-landed App Connect …
romchornyi Oct 30, 2026
8587971
fix(dashconnect): judge a vanished shared profile access by the ident…
romchornyi Oct 30, 2026
4cd0358
Merge remote-tracking branch 'origin/fix/app-connect-shared-profile-a…
romchornyi Oct 30, 2026
56960f9
fix(dashconnect): restore a replaced two-QR row before judging by bou…
romchornyi Oct 30, 2026
e3c9078
fix(dashconnect): judge a dropped App Connect row by auth keys only, …
romchornyi Oct 30, 2026
eb52302
fix(dashconnect): compare App Connect key expiries as unsigned timest…
romchornyi Oct 30, 2026
b5be800
fix(dashconnect): note an App Connect update only when its own submis…
romchornyi Oct 30, 2026
bb9fb72
fix(dashconnect): a resubmitted App Connect update starts without the…
romchornyi Oct 30, 2026
f051611
test(dashconnect): an expired App Connect update whose keys are there…
romchornyi Oct 30, 2026
61f4f46
Merge remote-tracking branch 'origin/fix/app-connect-shared-profile-a…
romchornyi Oct 30, 2026
d649367
fix(dashconnect): judge an App Connect row by the dropped record's id…
romchornyi Oct 30, 2026
9308b14
fix(dashconnect): a disconnected app's two-QR row stays gone, and set…
romchornyi Oct 30, 2026
d2a626b
fix(dashconnect): retries stay within the approval, raised key limits…
romchornyi Oct 31, 2026
5f6564e
fix(dashconnect): a waiting approval's reused keys reach its retry, a…
romchornyi Oct 31, 2026
30c5b4d
fix(dashconnect): one-QR recovery hands out only the approved limits,…
romchornyi Oct 31, 2026
c0945f3
fix(dashconnect): keep a row while the app may still hold keys, settl…
romchornyi Oct 31, 2026
8c50790
fix(dashconnect): a kept row stays as it was, a disconnect clears a r…
romchornyi Oct 31, 2026
276d5aa
Merge remote-tracking branch 'origin/fix/app-connect-v2-grant-lifecyc…
romchornyi Oct 31, 2026
0fef35b
fix(dashconnect): only an added key witnesses an update, a dropped re…
romchornyi Oct 31, 2026
43a448c
fix(dashconnect): keep disables as an update's witness, a disconnect …
romchornyi Oct 31, 2026
e436350
feat(dashconnect): redesign the Connections page and add a connection…
romchornyi Oct 31, 2026
140d69d
fix(dashconnect): a disconnect waits while the fetched view lacks a k…
romchornyi Oct 31, 2026
9138fbd
Merge remote-tracking branch 'origin/fix/app-connect-v2-grant-lifecyc…
romchornyi Oct 31, 2026
78ceedd
feat(dashconnect): a disconnect turns off unattributed DashPay profil…
romchornyi Oct 31, 2026
7686069
fix(dashconnect): the app's revoke is never blocked by the profile ke…
romchornyi Oct 31, 2026
024d99d
fix(dashconnect): connection sheet and tab states, history per app an…
romchornyi Oct 31, 2026
29b2146
Merge #1263 (a disconnect turns off unattributed DashPay profile keys…
romchornyi Oct 31, 2026
4aabd15
fix(dashconnect): profile keys go only with a disconnect that leaves …
romchornyi Oct 31, 2026
f09b5db
Merge #1272 (with #1263's automatic profile-key revoke) into feat/das…
romchornyi Oct 31, 2026
f3d2e9f
fix(dashconnect): the disconnect confirmation says what this row's di…
romchornyi Oct 31, 2026
43b9c5c
fix(dashconnect): the connection sheet hands over to a request on dis…
romchornyi Oct 31, 2026
001b864
fix(dashconnect): sheet details survive a status check, a closing she…
romchornyi Oct 31, 2026
47ce526
fix(dashconnect): the whole Disconnect button takes the tap
romchornyi Oct 31, 2026
3b44a3e
revert(ui): leave the shared SegmentedControl as it is
romchornyi Oct 31, 2026
37b62e6
fix(dashconnect): a waiting record holding a live key is kept, a disa…
romchornyi Oct 31, 2026
b806585
Merge remote-tracking branch 'origin/fix/app-connect-v2-grant-lifecyc…
romchornyi Oct 31, 2026
35e967b
fix(dashconnect): a row held by a waiting record shows its grant, a l…
romchornyi Oct 31, 2026
cf0a47e
fix(dashconnect): funding only for confirmed grants, history cleared …
romchornyi Oct 31, 2026
17770c1
fix(dashconnect): a waiting record keeps the keys the store gives it,…
romchornyi Oct 31, 2026
7332ea0
Merge remote-tracking branch 'origin/fix/app-connect-v2-grant-lifecyc…
romchornyi Oct 31, 2026
8a851d5
fix(dashconnect): the funding limits info sheet is as tall as its text
romchornyi Oct 31, 2026
a69857c
fix(dashconnect): a later own update settles nothing; a waiting recor…
romchornyi Oct 31, 2026
9fdfed9
Merge #1272 (a69857ce7) into feat/dashconnect-redesign-connections
romchornyi Oct 31, 2026
0d27c19
fix(dashconnect): a row a waiting record brings back keeps the app's …
romchornyi Oct 31, 2026
13903e9
feat(dashconnect): Disconnect and Reconnect on each Connections row
romchornyi Nov 1, 2026
2eff9e6
fix(dashconnect): an incomplete expiry check says so, and the sheet f…
romchornyi Nov 1, 2026
c3df42a
fix(dashpay): expiry checks keep to their wallet and the chain's time…
romchornyi Nov 1, 2026
da098d6
refactor(dashpay): take the connection expiry check out of the Connec…
romchornyi Nov 1, 2026
5032ebf
refactor(dashpay): take the disconnected-apps history out of the Conn…
romchornyi Nov 1, 2026
62be203
fix(dashpay): a disconnect does what its question said; grant receipt…
romchornyi Nov 1, 2026
c4927f6
fix(dashpay): a two-QR row's disconnect question does not promise a r…
romchornyi Nov 1, 2026
bf7f7bc
fix(dashpay): one rule decides whether a disconnect is what its quest…
romchornyi Nov 1, 2026
9471603
fix(dashpay): a retried grant keeps its first terms; the disconnect c…
romchornyi Nov 1, 2026
5c3a4ed
fix(dashpay): the Connections page waits for its rows; one decision f…
romchornyi Nov 1, 2026
7d4b89d
fix(dashpay): a disconnect of a gone row says so; a session key's rec…
romchornyi Nov 2, 2026
43938ad
fix(dashpay): the Connections page follows every write to its rows
romchornyi Nov 2, 2026
be313b2
fix(dashconnect): settle a waiting App Connect v2 update by the revis…
romchornyi Nov 2, 2026
6592d8e
Merge remote-tracking branch 'origin/fix/app-connect-v2-grant-lifecyc…
romchornyi Nov 2, 2026
3415560
refactor(dashconnect): derive App Connect rows from the identity and …
romchornyi Nov 3, 2026
ded1f51
refactor(dashconnect): remove the two-QR login and close review findings
romchornyi Nov 3, 2026
9e87349
fix(dashconnect): keep live keys of a conflicting intent actionable a…
romchornyi Nov 3, 2026
8e8aa7e
fix(dashconnect): bind retries to their connection and recheck keys b…
romchornyi Nov 3, 2026
ab339f2
fix(dashconnect): publish a response only while its keys are current …
romchornyi Nov 3, 2026
5c4f4db
fix(dashconnect): read the app's current encryption key one way
romchornyi Nov 3, 2026
4f16611
refactor(dashconnect): answer a request at most once; show undelivere…
romchornyi Nov 3, 2026
e536c44
fix(dashconnect): check the read that showed the update before publis…
romchornyi Nov 3, 2026
dbffc36
fix(dashconnect): keep a scan button and access seen on other identities
romchornyi Nov 3, 2026
3c9445e
fix(dashconnect): tell an answered request by its whole body
romchornyi Nov 3, 2026
917a4a0
fix(dashconnect): refuse every repeat approval of a request
romchornyi Nov 3, 2026
7422ef0
Merge branch 'develop' into feat/app-connect-v2-login
romchornyi Nov 6, 2026
d8ba460
fix(dashpay): derive an App Connect encryption key at DIP-13 rotation 0
romchornyi Nov 6, 2026
de4b125
fix(dashpay): refuse an App Connect request v2 for mainnet in the parser
romchornyi Nov 6, 2026
5b3505f
docs: record ADR-0009 for answering App Connect request v2
romchornyi Nov 6, 2026
d6289ee
fix(dashconnect): key the sheet's permission rows by position
romchornyi Nov 6, 2026
62dc24a
fix(dashconnect): bound the dash-key query before it is split or decoded
romchornyi Nov 6, 2026
3ca6b58
fix(dashconnect): tell the app when its request is refused at Approve
romchornyi Nov 6, 2026
05c9991
fix(dashconnect): leave the encryption slot out behind a disabled cur…
romchornyi Nov 6, 2026
d830206
fix(dashconnect): warn, not refuse, when a known app's request return…
romchornyi Nov 6, 2026
0d46484
fix(dashconnect): refuse, not retry, a request that names an absent c…
romchornyi Nov 6, 2026
5620cbc
fix(dashconnect): refuse a v2 request for an absent app contract or d…
romchornyi Nov 6, 2026
29fef61
Merge origin/develop into feat/app-connect-v2-login
romchornyi Nov 9, 2026
ae77818
fix(dashconnect): refuse a v2 app owned like a system contract
romchornyi Nov 9, 2026
99baad2
Merge the final head of #1210 into feat/app-connect-dashpay-carrier
romchornyi Nov 9, 2026
b6527df
Merge origin/develop into feat/app-connect-dashpay-carrier
romchornyi Nov 9, 2026
edcc414
Merge feat/app-connect-dashpay-carrier into feat/app-connect-encrypti…
romchornyi Nov 9, 2026
6f230ff
Merge feat/app-connect-encryption-rotation into fix/app-connect-share…
romchornyi Nov 9, 2026
ad072fd
Merge fix/app-connect-shared-profile-access into refactor/app-connect…
romchornyi Nov 9, 2026
654b76b
test(dashconnect): drop the session-key terms from the refusal-at-App…
romchornyi Nov 9, 2026
c2c5afe
feat(dashpay): redesign the Connections page and add a connection sheet
romchornyi Nov 9, 2026
0315a24
Move the Connections redesign onto #1301
romchornyi Nov 9, 2026
cfefa97
feat(dashpay): DashConnect connection states from Platform and a disc…
romchornyi Nov 9, 2026
58e6173
Merge #1334 (connection states, disconnect) into the Connections rede…
romchornyi Nov 9, 2026
a3452b5
refactor(dashpay): leave the approve sheet's terms to the redesigned …
romchornyi Nov 9, 2026
69cd105
Merge stack/1334 (the approve sheet's terms left to #1278) into 1277
romchornyi Nov 9, 2026
ee80f00
ci: stub DashConnectStores in the Core drain recovery harness
romchornyi Nov 9, 2026
92a1736
Merge 1334 (Core drain harness stub) into 1277
romchornyi Nov 9, 2026
740f8ab
docs: record ADR-0015 to 0022 for DashConnect connection states and d…
romchornyi Nov 9, 2026
9b067c4
Merge 1334 (ADR-0015 to 0022) into 1277
romchornyi Nov 9, 2026
19e57aa
docs(dashconnect): give the wallet's own gate as the reason a mainnet…
romchornyi Nov 9, 2026
e9f88e6
Merge remote-tracking branch 'origin/develop' into feat/app-connect-e…
romchornyi Nov 9, 2026
e3a44f8
fix(dashpay): DashConnect unrecorded-only connections by Platform tim…
romchornyi Nov 9, 2026
51baec2
Merge branch 'stack/1334' into stack/1277
romchornyi Nov 9, 2026
04c5cca
fix(dashpay): DashConnect connection sheet ignores a stale dismissal …
romchornyi Nov 9, 2026
2fca237
docs(adr): record #1301's App Connect decisions (0027–0030)
romchornyi Nov 9, 2026
99d6166
Merge branch 'stack/1301' into stack/1334
romchornyi Nov 9, 2026
3fb8f08
Merge branch 'stack/1334' into stack/1277
romchornyi Nov 9, 2026
41ee478
fix(dashconnect): disable the app's keys after the profile keys, and …
romchornyi Nov 9, 2026
bd0145e
Merge remote-tracking branch 'origin/feat/app-connect-encryption-rota…
romchornyi Nov 9, 2026
44abef3
Merge remote-tracking branch 'origin/develop' into feat/app-connect-e…
romchornyi Nov 9, 2026
7180c6e
Merge remote-tracking branch 'origin/feat/app-connect-encryption-rota…
romchornyi Nov 9, 2026
9447a46
docs(dashpay): describe the encryption key rules in ADR-0009 and the …
romchornyi Nov 10, 2026
5dc260a
Merge remote-tracking branch 'origin/feat/app-connect-encryption-rota…
romchornyi Nov 10, 2026
075afb3
Merge remote-tracking branch 'origin/develop' into fix/app-connect-sh…
romchornyi Nov 10, 2026
f7995b4
Merge remote-tracking branch 'origin/fix/app-connect-shared-profile-a…
romchornyi Nov 10, 2026
20076bc
fix(dashconnect): disable the app's keys after the other keys on disc…
romchornyi Nov 10, 2026
19ac4fb
Merge branch 'stack/1301' into stack/1334
romchornyi Nov 10, 2026
c454b4e
test(dashconnect): a disconnect plan lists the profile keys before th…
romchornyi Nov 10, 2026
fb609c2
Merge branch 'stack/1334' into stack/1277
romchornyi Nov 10, 2026
aa03cc0
Merge origin/develop into stack/1301 (#1263 squash-merged; its tree i…
romchornyi Nov 10, 2026
ebbdb92
Merge branch 'stack/1301' into stack/1334
romchornyi Nov 10, 2026
da18708
Merge branch 'stack/1334' into stack/1277
romchornyi Nov 10, 2026
1e11360
fix(dashconnect): retry a failed response delete on the next signed o…
romchornyi Nov 10, 2026
f866489
Merge branch 'stack/1301' into stack/1334
romchornyi Nov 10, 2026
916b1c9
Merge branch 'stack/1334' into stack/1277
romchornyi Nov 10, 2026
0bb2013
fix(dashconnect): an update is not landed while a key's bound is unknown
romchornyi Nov 10, 2026
0a29cf5
fix(dashconnect): retry left response deletes on every signed disconnect
romchornyi Nov 10, 2026
8b1491a
Merge branch 'stack/1301' into stack/1334
romchornyi Nov 10, 2026
62c58fb
Merge branch 'stack/1334' into stack/1277
romchornyi Nov 10, 2026
e002360
fix(dashconnect): keep the row while a disconnect leaves keys of unkn…
romchornyi Nov 10, 2026
9fd7dcd
Merge branch 'stack/1301' into stack/1334
romchornyi Nov 10, 2026
f5388f7
Merge branch 'stack/1334' into stack/1277
romchornyi Nov 10, 2026
4e8c23a
fix(dashconnect): keep every row while a key's bound is unknown
romchornyi Nov 11, 2026
6b69db0
Merge refactor/app-connect-projection into feat/dashconnect-connectio…
romchornyi Nov 11, 2026
57e51a8
Merge branch 'stack/1334' into stack/1277
romchornyi Nov 11, 2026
e134a7a
fix(dashconnect): a disconnect also turns off the app's keys on its o…
romchornyi Nov 11, 2026
1d0cbcb
Merge fix/app-connect-owner-attribution (#1364) into feat/dashconnect…
romchornyi Nov 11, 2026
e14d9af
docs(adr): drop the private feature-record links from ADR-0032 and AD…
romchornyi Nov 11, 2026
8a7c166
Merge stack/1334 with #1364 into feat/dashconnect-redesign-connections
romchornyi Nov 11, 2026
3934123
Merge fix/app-connect-owner-attribution (#1364) into feat/dashconnect…
romchornyi Nov 11, 2026
f8f4bca
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 11, 2026
1edad2b
docs(adr): ADR-0033 is superseded by ADR-0016 on this branch
romchornyi Nov 11, 2026
77f2bd0
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 11, 2026
40007ae
fix(dashpay): bind offered keys to their identity and report what sta…
romchornyi Nov 11, 2026
4d7ff7c
Merge fix/app-connect-owner-attribution (#1364) into feat/dashconnect…
romchornyi Nov 11, 2026
d622ad0
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 11, 2026
2652628
fix(dashconnect): a disconnect also turns off the app's keys on its o…
romchornyi Nov 11, 2026
7230f62
docs(adr): drop the private feature-record links from ADR-0032 and AD…
romchornyi Nov 11, 2026
8b6c87d
fix(dashpay): bind offered keys to their identity and report what sta…
romchornyi Nov 11, 2026
eacd952
Merge fix/app-connect-owner-attribution (#1364) into feat/dashconnect…
romchornyi Nov 11, 2026
7a730c3
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 11, 2026
c69eb3f
fix(dashpay): date granted App Connect keys by Platform time and refu…
romchornyi Nov 11, 2026
5d1eac8
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 11, 2026
0ff9f55
fix(dashpay): settle a disconnect's rows and result on one owner read
romchornyi Nov 11, 2026
1ffe25a
Merge fix/app-connect-owner-attribution (#1364) into feat/dashconnect…
romchornyi Nov 11, 2026
0e75d09
fix(dashpay): keep an App Connect row while another identity still ha…
romchornyi Nov 11, 2026
6a11823
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 11, 2026
e661639
fix(dashpay): report every key a confirmed disconnect leaves on, unde…
romchornyi Nov 11, 2026
6fd0f88
Merge fix/app-connect-owner-attribution into feat/dashconnect-connect…
romchornyi Nov 11, 2026
1fcf496
fix(dashpay): keep a key's raised limits across reads and DashConnect…
romchornyi Nov 11, 2026
22344fd
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 11, 2026
af44713
fix(dashpay): send the user to the row whose disconnect offers every …
romchornyi Nov 11, 2026
19224c4
Merge fix/app-connect-owner-attribution into feat/dashconnect-connect…
romchornyi Nov 11, 2026
e2cce0c
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 11, 2026
3967684
fix(dashpay): remember contract owners per devnet name and endpoint
romchornyi Nov 11, 2026
42f723e
fix(dashpay): admit an identity read atomically, keep the later block…
romchornyi Nov 12, 2026
e7e1d77
Merge fix/app-connect-owner-attribution into feat/dashconnect-connect…
romchornyi Nov 12, 2026
13d11fe
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 12, 2026
22822a4
Merge develop into feat/dashconnect-connection-states
romchornyi Nov 12, 2026
16efa1b
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 12, 2026
d3e172f
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 12, 2026
41a810e
fix(dashpay): keep a renewed app's row while a key's bound is unknown…
romchornyi Nov 12, 2026
a7c01dd
fix(dashpay): the connection sheet shows what the keys on Platform give
romchornyi Nov 12, 2026
1e1ebb6
fix(dashpay): say what a disconnect turned off beyond the app's recor…
romchornyi Nov 12, 2026
a2ea8ff
Merge feat/dashconnect-connection-states into feat/dashconnect-redesi…
romchornyi Nov 12, 2026
03e5af8
fix(dashpay): read key budgets off the main actor and count the app's…
romchornyi Nov 12, 2026
48858ca
fix(dashpay): a sheet's disconnect runs only while its row still offe…
romchornyi Nov 12, 2026
9d6f349
refactor(dashpay): the connection sheet no longer claims what an app …
romchornyi Nov 12, 2026
1d55e52
feat(dashpay): the connection sheet shows what an app can spend and do
romchornyi Nov 12, 2026
848c871
fix(dashpay): a connection sheet with no identity read claims no access
romchornyi Nov 12, 2026
3688c70
Merge develop into feat/dashconnect-redesign-connections
romchornyi Nov 12, 2026
42997e1
fix(dashpay): a sheet shows the identity of a row of unrecorded keys,…
romchornyi Nov 12, 2026
cf77343
Merge feat/dashconnect-redesign-connections into feat/dashconnect-con…
romchornyi Nov 12, 2026
f3096f7
fix(dashpay): the sheet's message access, funding lines and group war…
romchornyi Nov 12, 2026
75a94f8
fix(dashpay): the sheet's Disconnect uses DashUIKit's tinted red, and…
romchornyi Nov 12, 2026
ea0fd6c
Merge feat/dashconnect-redesign-connections into feat/dashconnect-con…
romchornyi Nov 12, 2026
eec6650
fix(dashpay): a connection sheet claims message access only from encr…
romchornyi Nov 12, 2026
b695948
fix(dashpay): the sheet does not show what is left of a budget above …
romchornyi Nov 13, 2026
c77d018
fix(dashpay): the sheet claims no access through a key of unknown bou…
romchornyi Nov 13, 2026
eacae78
Merge develop into feat/dashconnect-connection-sheet-access
romchornyi Nov 13, 2026
ce6098b
fix(dashpay): a funding refresh with nothing to read clears the sheet…
romchornyi Nov 13, 2026
7bd0ae6
fix(dashpay): tell the connection sheet's access and funding from one…
romchornyi Nov 13, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions DashWallet/Sources/Models/DashConnect/AppConnectProjection.swift
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,41 @@ extension AppConnect {
} && outstandingDisables(of: intent, in: snapshot).isEmpty
}

/// The key under `id` on `snapshot` whose bound the store holds: the
/// only proof the connection sheet takes that a key is the app's. Every
/// claim it makes from a key on Platform (access, messages, funding)
/// rests on it. A key whose bound the store does not hold yet may be
/// bound to another contract, so it backs no claim until a read places it.
static func placedKey(withId id: UInt32, in snapshot: IdentitySnapshot) -> PlatformKey? {
snapshot.keys.first { $0.id == id && $0.boundKnown }
}

/// The key on `snapshot` an intended auth key gives access through: it
/// landed (live or expired) and is placed (`placedKey`), so its bound is
/// the intended one (`isSameKey`).
static func accessKey(of intended: IntendedKey, in snapshot: IdentitySnapshot) -> PlatformKey? {
guard [.live, .expired].contains(presence(of: intended, in: snapshot)) else { return nil }
return placedKey(withId: intended.id, in: snapshot)
}

/// Whether `intent`'s encryption keys give the app message access on
/// `snapshot`, as the connection sheet says it: every key it re-sends is
/// placed (`placedKey`) and live, and every key it adds is placed and
/// live, or not there yet while the intent may still land. One that is
/// off, expired, not placed, or whose id another key holds gives none.
static func encryptionKeysGiveAccess(_ intent: ConnectionIntent, in snapshot: IdentitySnapshot) -> Bool {
let mayLand = status(of: intent, in: snapshot) == .confirming
return intent.sentEncryptionKeyIds.allSatisfy { id in
placedKey(withId: id, in: snapshot).map { isLive($0, at: snapshot.platformTime) } == true
} && intent.keys.filter { !$0.isAuthentication }.allSatisfy { key in
switch presence(of: key, in: snapshot) {
case .live: return placedKey(withId: key.id, in: snapshot) != nil
case .missing: return mayLand
case .conflicting, .expired, .disabled: return false
}
Comment on lines +745 to +752

@thepastaclaw thepastaclaw Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Resolved at 7bd0ae65; see the replies below.

🔴 Blocking: Do not report message access from an encryption key with an unknown bound

presence(of:in:) treats a matching key as .live even when PlatformKey.boundKnown is false because isSameKey deliberately permits an unknown bound. encryptionKeysGiveAccess then accepts that .live result, and the re-sent-key branch checks only the key id and liveness. A key whose contract binding the wallet cannot read may belong to another contract, so the connection sheet can claim that the app receives encrypted messages without establishing that the identity's encryption key is bound to this app. The authentication projection already fails closed through accessKey; the message-access predicate needs the same known-bound requirement for both re-sent and added encryption keys.

Raised on code unchanged since the last review, and confirmed by an independent pass: When an identity snapshot contains a matching encryption key with boundKnown == false, presence(of:in:) returns .live and encryptionKeysGiveAccess reports message access. The connection sheet can therefore claim the app receives encrypted messages even though the wallet cannot establish that the key is bound to this app and it may belong to another contract.

Suggested change
return intent.sentEncryptionKeyIds.allSatisfy { id in
snapshot.keys.contains { $0.id == id && isLive($0, at: snapshot.platformTime) }
} && intent.keys.filter { !$0.isAuthentication }.allSatisfy { key in
switch presence(of: key, in: snapshot) {
case .live: return true
case .missing: return mayLand
case .conflicting, .expired, .disabled: return false
}
return intent.sentEncryptionKeyIds.allSatisfy { id in
snapshot.keys.contains {
$0.id == id && $0.boundKnown && isLive($0, at: snapshot.platformTime)
}
} && intent.keys.filter { !$0.isAuthentication }.allSatisfy { key in
switch presence(of: key, in: snapshot) {
case .live:
return snapshot.keys.first { $0.id == key.id }?.boundKnown == true
case .missing: return mayLand
case .conflicting, .expired, .disabled: return false
}
}

source: gpt-6.1-sol (phase2-reviewer: general)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 7bd0ae6. AppConnect.placedKey(withId:in:) is now the one proof for every claim the sheet makes from a key on Platform: access, messages and funding lines. A key whose bound the store does not hold gives no message access, whether the response added it or sent it again. Covered by testMessageAccessNeedsItsEncryptionKeysPlaced.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved (re-reviewed at 7bd0ae65): Message access now requires every re-sent or added encryption key to be returned by placedKey, which requires a known bound. An encryption key with an unreadable bound therefore produces no message-access claim.

}
}

/// Whether the encryption keys `intent`'s response carries can still be
/// used: those it re-sends are live, and those it adds are not off.
static func encryptionKeysUsable(_ intent: ConnectionIntent, in snapshot: IdentitySnapshot) -> Bool {
Expand Down
69 changes: 68 additions & 1 deletion DashWallet/Sources/Models/DashConnect/AppConnectV2Login.swift
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ extension AppConnect {
}
}

/// What an approval gives an app, as the approval sheet lists it.
/// What an approval gives an app, as the approval sheet and the
/// connection sheet list it.
struct GrantedAccess: Equatable {
struct Key: Equatable {
let bound: StoredBound
Expand Down Expand Up @@ -139,6 +140,72 @@ extension AppConnect {
},
receivesMessages: receivesMessages)
}

/// What `intents` gave, in their order: the auth keys each one adds,
/// with the terms it submitted them with, a key two intents name
/// once. An intent always names a bound and an expiry for an auth
/// key; one without is not listed.
init(intents: [ConnectionIntent]) {
self.init(intents: intents, snapshot: nil)
}

/// `init(intents:)` as the keys on Platform give it, when `snapshot`
/// read them: a key that landed gives the limits Platform holds now,
/// which an authorized limits update may have raised; a disabled key,
/// or one whose id another key holds, gives nothing; a key not there
/// yet gives its submitted terms while its intent may still land.
/// `unrecorded`: keys on `snapshot` the projection gives the app that
/// no intent names, with the limits Platform holds;
/// `administeredGroups`: the groups of those keys that may have
/// administrators. Message access, with `snapshot`, is what its
/// encryption keys still give.
init(
intents: [ConnectionIntent], snapshot: IdentitySnapshot?, unrecorded: [PlatformKey] = [],
administeredGroups: Set<Data> = []
) {
var listed = Set<UInt32>()
self.init(
keys: intents.flatMap { intent in
let mayLand = snapshot.map { AppConnect.status(of: intent, in: $0) == .confirming } ?? true
return intent.authKeys.compactMap { key -> Key? in
guard let bound = key.bound, let submittedExpiry = key.expiresAt else { return nil }
var expiresAt = submittedExpiry
var totalBudget = key.totalBudget
if let snapshot {
switch AppConnect.presence(of: key, in: snapshot) {
case .live, .expired:
// Its bound not read yet: not known to be access.
guard let actual = AppConnect.accessKey(of: key, in: snapshot) else { return nil }
totalBudget = actual.totalBudget
expiresAt = actual.expiresAt ?? submittedExpiry
case .missing:
guard mayLand else { return nil }
case .disabled, .conflicting:
return nil
}
}
guard listed.insert(key.id).inserted else { return nil }
return Key(
bound: bound, isCritical: key.securityLevel == .critical, totalBudget: totalBudget,
expiresAt: expiresAt, isAdministered: intent.isAdministered(bound))
}
} + unrecorded.compactMap { key -> Key? in
// The projection lists only keys with an expiry.
guard let bound = key.bound, let expiresAt = key.expiresAt, listed.insert(key.id).inserted else {
return nil
}
var isAdministered = false
if case .contractGroup(let id) = bound { isAdministered = administeredGroups.contains(id) }
return Key(
bound: bound, isCritical: key.securityLevel == .critical, totalBudget: key.totalBudget,
expiresAt: expiresAt, isAdministered: isAdministered)
},
receivesMessages: intents.contains { intent in
let hasMessageKey = !intent.sentEncryptionKeyIds.isEmpty || intent.keys.contains { !$0.isAuthentication }
guard hasMessageKey else { return false }
return snapshot.map { AppConnect.encryptionKeysGiveAccess(intent, in: $0) } ?? true
})
Comment thread
romchornyi marked this conversation as resolved.
Resolved
}
}

/// What approving a v2 request gives the app, as the approval sheet
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,17 @@ protocol DashConnectDataSource {
/// identity's intents for the app; `nil` when there is no active wallet
/// or `scope` is not its.
func connectionDetails(id: String, scope: String?) async -> ConnectionDetails?
/// What is left of the budgets of the keys `basis` gives the app, read
/// after the details told from it and apart from them, so the sheet
/// shows them first; `.notRead` when `basis` is not of the active
/// identity of the wallet `scope` names.
func connectionFunding(for basis: ConnectionBasis, scope: String?) async -> ConnectionFundingRead
}

extension DashConnectDataSource {
func refreshConnections() async {}
func connectionDetails(id: String, scope: String?) async -> ConnectionDetails? { nil }
func connectionFunding(for basis: ConnectionBasis, scope: String?) async -> ConnectionFundingRead { .notRead }
}

/// Why a token purchase failed, and — the part that decides what the UI may
Expand Down
207 changes: 205 additions & 2 deletions DashWallet/Sources/Models/DashConnect/DashConnectModels.swift
Original file line number Diff line number Diff line change
Expand Up @@ -250,15 +250,218 @@ struct DashConnectDisconnectResult: Equatable {
var keysOnAnotherIdentity = false
}

/// What a connection gives its app, from the intents of one identity that
/// hold it, as the connection sheet shows it.
struct ConnectionAccess: Equatable {
/// What each key can do.
let keys: [AppConnect.GrantedAccess.Key]
/// The most the keys can spend together, in credits: Platform counts
/// each key's budget apart, so it is their sum. `nil` when no key has a
/// budget (see `hasUnlimitedKey`).
let budgetLimit: UInt64?
/// A key with no spending limit.
let hasUnlimitedKey: Bool
/// When the last of the keys stops working.
let expiresAt: Date?
/// The connection can receive messages encrypted to this identity.
let receivesMessages: Bool

/// `nil` when no auth key of `intents` or `unrecorded` gives access on
/// `snapshot` (`GrantedAccess(intents:snapshot:unrecorded:)`). It needs a
/// read of the identity: without one, what the intents submitted is not
/// known to be the app's access.
init?(
intents: [AppConnect.ConnectionIntent], snapshot: AppConnect.IdentitySnapshot,
unrecorded: [AppConnect.PlatformKey] = [], administeredGroups: Set<Data> = []
) {
let access = AppConnect.GrantedAccess(
intents: intents, snapshot: snapshot, unrecorded: unrecorded, administeredGroups: administeredGroups)
guard !access.keys.isEmpty else { return nil }
self.init(access)
}

init(_ access: AppConnect.GrantedAccess) {
keys = access.keys
let budgets = access.keys.compactMap(\.totalBudget)
budgetLimit = budgets.isEmpty ? nil : budgets.reduce(0) { sum, budget in
let (total, overflow) = sum.addingReportingOverflow(budget)
return overflow ? .max : total
}
hasUnlimitedKey = access.keys.contains { $0.totalBudget == nil }
expiresAt = access.keys.map(\.expiresAt).max().map { Date(timeIntervalSince1970: TimeInterval($0) / 1000) }
receivesMessages = access.receivesMessages
}

var granted: AppConnect.GrantedAccess {
AppConnect.GrantedAccess(keys: keys, receivesMessages: receivesMessages)
}
}

/// What a connection sheet is told from: one read of the identity, the
/// intents that hold the app on it, and the keys that read gives the app
/// that no intent names. The sheet's access and what is left of its keys'
/// budgets both come from one basis, so they tell of the same read. A newer
/// read is another basis: funding read for an earlier one is never shown
/// beside it (`ConnectionDetails.attaching(_:for:)`).
struct ConnectionBasis: Equatable {
let snapshot: AppConnect.IdentitySnapshot
/// The open intents of the snapshot's identity that hold the app.
let intents: [AppConnect.ConnectionIntent]
/// Keys on `snapshot` the projection gives the app that no intent names.
let unrecorded: [AppConnect.PlatformKey]
/// The groups of `unrecorded` keys that may have administrators.
let administeredGroups: Set<Data>

/// What the app was given; `nil` when no auth key gives access.
var access: ConnectionAccess? {
ConnectionAccess(
intents: intents, snapshot: snapshot, unrecorded: unrecorded, administeredGroups: administeredGroups)
}

/// The keys whose remaining budgets the sheet reads, by id.
var fundedKeyIds: [UInt32] {
KeyFunding.keyIds(of: intents, snapshot: snapshot, unrecorded: unrecorded)
}

/// The funding lines of `fundedKeyIds` with what `remaining` (by key id)
/// says is left. What is left is read after `snapshot`: when it is above
/// a total of this read, a limits update came between them, and the read
/// fails rather than show it against totals it outgrew; the next read of
/// the identity brings them together.
func funding(remaining: [UInt32: UInt64?]) -> ConnectionFundingRead {
let lines = KeyFunding.of(intents: intents, snapshot: snapshot, unrecorded: unrecorded, remaining: remaining)
return KeyFunding.agree(lines) ? .read(lines) : .failed
}
}

/// A connection as its sheet shows it: the app, the identity it is
/// connected on, and when it was made.
/// connected on, and what it was given.
struct ConnectionDetails: Equatable {
let appId: String
let identityId: String?
let username: String?
/// What `access` and the funding lines are told from; `nil` without a
/// read of the identity, or when the connection is not the active
/// identity's.
let basis: ConnectionBasis?
/// What the app was given, from `basis`. Without one nothing is known to
/// be the app's access: the sheet shows none rather than what the
/// intents submitted, which may never have landed.
let access: ConnectionAccess?
/// When the connection was made: the latest of its approvals, so a
/// renewal from a new code counts as the connection it made.
var connectedAt: Date? = nil
let connectedAt: Date?
/// What is left of each key's budget, read from Platform for `basis`;
/// `nil` when it was not read or could not be (`fundingReadFailed`).
private(set) var keyFunding: [KeyFunding]?
private(set) var fundingReadFailed = false

init(
appId: String, identityId: String?, username: String?, basis: ConnectionBasis? = nil, connectedAt: Date? = nil
) {
self.appId = appId
self.identityId = identityId
self.username = username
self.basis = basis
access = basis?.access
self.connectedAt = connectedAt
}

/// These details with `read`, the funding read for `basis`; `nil` when
/// these details are not told from `basis`: what is left of the keys of
/// another read is not shown beside the access of this one.
func attaching(_ read: ConnectionFundingRead, for basis: ConnectionBasis) -> ConnectionDetails? {
guard basis == self.basis else { return nil }
var details = self
switch read {
case .notRead:
details.keyFunding = nil
details.fundingReadFailed = false
case .read(let lines):
details.keyFunding = lines
details.fundingReadFailed = false
case .failed:
details.keyFunding = nil
details.fundingReadFailed = true
}
return details
}

/// These details with the funding `previous` shows, when both are told
/// from the same basis; otherwise as they are, with none.
func keepingFunding(of previous: ConnectionDetails) -> ConnectionDetails {
guard previous.basis == basis else { return self }
var details = self
details.keyFunding = previous.keyFunding
details.fundingReadFailed = previous.fundingReadFailed
return details
}
}

/// What is left of a connection's keys' budgets, read apart from its details
/// so the sheet does not wait on it.
enum ConnectionFundingRead: Equatable {
/// Nothing to read: no landed key, or not the active identity's basis.
case notRead
case read([KeyFunding])
/// The read failed, or what it said is above the totals the identity
/// read gave (a limits update between the two).
case failed
}

/// One of a connection's keys, with what is left of its budget.
struct KeyFunding: Equatable {
/// The key is bound to the DashPay profile, not to the app's data.
let isProfileKey: Bool
/// What the key may spend over its life; `nil` with no limit.
let totalBudget: UInt64?
/// What is left of it; `nil` with no limit, or when Platform did not say.
let remaining: UInt64?

/// The auth keys of `intents` that are on `snapshot` and not disabled,
/// then the `unrecorded` keys the projection gives the app, in their
/// order, each with its budget as Platform holds it now and what
/// `remaining` (by key id) says is left. A key is listed once.
static func of(
intents: [AppConnect.ConnectionIntent], snapshot: AppConnect.IdentitySnapshot,
unrecorded: [AppConnect.PlatformKey] = [], remaining: [UInt32: UInt64?]
) -> [KeyFunding] {
landedKeys(of: intents, snapshot: snapshot, unrecorded: unrecorded).map { key in
KeyFunding(
isProfileKey: key.bound.map(AppConnect.isProfileBound) ?? false,
totalBudget: key.totalBudget,
remaining: remaining[key.id] ?? nil)
}
}

/// Whether `lines` hold together: nothing left above its key's total.
/// The totals come from an identity read and what is left from a later
/// one, so a limits update between them makes them disagree.
static func agree(_ lines: [KeyFunding]) -> Bool {
lines.allSatisfy { line in
guard let total = line.totalBudget, let remaining = line.remaining else { return true }
return remaining <= total
}
}

/// The ids `of(intents:snapshot:unrecorded:remaining:)` lists, whose
/// remaining budgets are read from Platform.
static func keyIds(
of intents: [AppConnect.ConnectionIntent], snapshot: AppConnect.IdentitySnapshot,
unrecorded: [AppConnect.PlatformKey] = []
) -> [UInt32] {
landedKeys(of: intents, snapshot: snapshot, unrecorded: unrecorded).map(\.id).sorted()
}

private static func landedKeys(
of intents: [AppConnect.ConnectionIntent], snapshot: AppConnect.IdentitySnapshot,
unrecorded: [AppConnect.PlatformKey]
) -> [AppConnect.PlatformKey] {
var listed = Set<UInt32>()
let recorded = intents.flatMap(\.authKeys).compactMap { AppConnect.accessKey(of: $0, in: snapshot) }
let placed = unrecorded.compactMap { AppConnect.placedKey(withId: $0.id, in: snapshot) }
return (recorded + placed).filter { listed.insert($0.id).inserted }
}
}

/// A pending request derived from a scanned login QR code.
Expand Down
Loading
Loading