Repository navigation
fix(wallet): show the address and an unverified label for unsigned payment requests #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
llbartekll
wants to merge
6
commits into
develop
Choose a base branch
from
claude/bip70-unsigned-recipient-0cc71f
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1e408b8
fix(payments): show the address and an unverified label for unsigned …
llbartekll 132820b
Merge remote-tracking branch 'origin/develop' into claude/bip70-unsig…
llbartekll 7095418
fix(payments): require https on every hop of an interactive payment-r…
llbartekll 8c9a328
fix(payments): cover the Payment POST with the https rule and label a…
llbartekll c9e1e13
style(payments): apply clang-format to the BIP70 spend authentication…
llbartekll 1baf174
fix(payments): refuse an unparseable payment_url, keep the unverified…
llbartekll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep a sent Payment from becoming retryable after a refused redirect.
If an HTTPS merchant receives the Payment POST and responds with an HTTP redirect, the redirect guard refuses that redirect and Line 93 throws.
BIP70PaymentService.confirmAndSendthen resetsconfirmation.sendGuardin its POST-error catch. A retry can build another signed transaction even though the merchant holds the first one and can broadcast it. Preserve the transaction identity and prevent a fresh send when this redirect is refused after the POST. Refusing a URLSession redirect returns the redirect response rather than following it. (developer.apple.com)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not changed in this PR. A Payment POST that fails after the merchant has the bytes is an existing, documented caveat of confirmAndSend (any non-2xx answer or a dropped connection behaves the same way), and the failure already carries the transaction hash out. A refused redirect is one more case of it, not a new class; changing the retry rule belongs in its own change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llbartekll Understood. The refused redirect is another case of the existing ambiguous POST failure. I’ll leave the retry rule for a separate change.
Would you like me to open a GitHub issue to track it?
You are interacting with an AI system.