Repository navigation
feat(voting): request dates, the links filter and Quick voting - #1366
Open
romchornyi wants to merge 17 commits into
Open
romchornyi wants to merge 17 commits into
romchornyi wants to merge 17 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Stacked on the stage 4 PR (#1347, vote from the pills), the last stage of the username voting redesign. A masternode owner now sees each request's date and link, can keep only the requests with links, and can approve every shown username at once with Quick voting. This PR also carries the review fixes to stage 4 made since it was published. Feature summary:
docs/features/username-voting/README.md.What was done?
develop); a request whose document cannot be read comes back without a date and the read still succeeds.QuickVotingSheet, sized to its content: how many of the shown usernames will be approved and how many are skipped, and "One vote left" once for the whole run.QuickVotePlanplans every name with the same gates as a single vote, in the same order (ADR-0035, Deviation): a name is skipped when it has closed or ended, its voting end or the order of its requests cannot be told (no date, or a tie to the millisecond), any masternode of this wallet blocked it, or no ticked masternode has a vote left; an existing block or approve is never replaced.castRun, ADR-0037): one PIN prompt, then name by name and masternode by masternode, recording each landed vote before the next; progress toast and VoiceOver announcement once the PIN is passed. A run with failures opens a result sheet listing the usernames not voted for, with "Try again" for those only; every vote failing is an error toast. Leaving the screen or sending the app to the background stops the run; a stopped run or Try again asks for no PIN and sends nothing.Security Lead: please review the Quick voting run (spec §6.1 — one confirmation for many votes):
QuickVotePlan,MasternodeVoteCaster.castRun,VotingStorerun / Try again.How Has This Been Tested?
DashWalletTests(schemedashwallet-dashpay, Debug, iPhone 17 simulator, iOS 26.5) on the tip (2026-11-11, after the live-run fixes): 2058 tests, 0 failures, 1 skipped. New tests:QuickVotePlanTests(every skip, mutation-checked),QuickVotingViewModelTests, the store's run / Try again / link-queue cases,VotingFilterTestsfor links, the caster's run inMasternodeVoteCasterTests, and the request-date cases inVotingStoreTests(AC-22; the decoder itself is covered by platform#5718).scripts/a11y_audit.py --check: no new findings; test-target membership check: ok.cb5ab12eeand the latest review fixes (2026-11-13):DashWalletTestson every stage branch — feat(voting): restyle the username voting list #1326 2231 (1 failure inCoinbaseTransferAmountTests, from develop, passes alone), feat(voting): filter and sort the username voting list #1327 2239, feat(voting): expand duplicates in place, open Request details from a row, keep contests until voting ends #1328 2379, feat(voting): vote from the pills, with the vote-limit and block confirmations and Add your voting keys #1347 2519, this PR 2632 tests, 1 skipped each, no other failures (iPhone 17 simulator, iOS 26.5); Release build (simulator) of every stage succeeded.username_voting_pill_before_setup,voting_key_validation,username_voting_manage_voting_keys) still expect "Add your voting keys" and the old field label, and the request date/time row, the "Quick voting" menu entry and the toasts over the list have no flows yet. They follow in a separate change.Screenshots
To add with the live run: a request with its date and "Link included", Request details with the voting period, "Only requests with links" (loading and can't-filter), the Quick voting sheet, the progress toast, and the result sheet.
Breaking Changes
None.
Checklist:
ADR-0037 addedFor repository code-owners and collaborators only
🤖 Generated with Claude Code