Repository navigation
feat(dashpay): receive to the identity on Receive, with a Receipt when its credits rise #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
79f5d91
feat(dashpay): receive to the identity on Receive, with a Receipt whe…
romchornyi a4f646d
fix(dashpay): scroll the Receive card when it is taller than the page
romchornyi 5cfb6b6
fix(dashpay): address review on identity receive
romchornyi 715a719
fix(dashpay): hold the Identity Receipt while an own top-up runs
romchornyi de83d0c
fix(dashpay): reconcile an own identity top-up with the balance it re…
romchornyi 6e63af1
fix(dashpay): merge develop, AC-08 gap wording, Ukrainian Identity label
romchornyi 81980f6
fix(dashpay): keep the recovery announcement in DashPay, cover the to…
romchornyi 562cbb9
fix(dashpay): keep IdentityTopUpsInFlight in the dashwallet target, d…
romchornyi b9b4d26
Merge develop into feat/identity-receive
romchornyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Blocking: Keep the recovery announcement inside the DashPay compilation boundary
AssetLockRecoveryService.swiftis included in bothdashwalletanddashpay, butIdentityTopUpDidComplete.swiftandDWIdentityRegistrationCoordinator.swift(which declaresPlatformPaymentIdentityFundingPolicy) are included only indashpay. These unguarded references make the non-DashPay target unable to compile. Keep the announcement path under#if DASHPAYand retain the originaltry await resume()path in the#elsebranch.source:
gpt-6.1-sol(phase2-reviewer: general)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 81980f6: the announcement is under
#if DASHPAY, anddashwalletresumes with the plaintry await resume().IdentityTopUpsInFlight.swiftalso leaves thedashwallettarget, which no longer uses it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Withdrawn (re-reviewed at
81980f6b): Your guard is present, but dashwallet defines DASHPAY in every configuration, so it does not route that target through the plain-resume branch as originally suggested. I withdraw the finding because my target-separation premise was wrong, the supported dashpay target includes the declarations, and repairing the documented legacy-target gaps is outside this PR's scope.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. The no-op guard is removed again in 562cbb9, and
IdentityTopUpsInFlight.swiftis back in thedashwallettarget.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Withdrawn (re-reviewed at
562cbb9c): Your correction is verified: dashwallet defines DASHPAY, so removing the guard does not reverse a meaningful compilation boundary. The registry is also restored to that target; my original guard recommendation remains withdrawn.