Repository navigation
feat(voting): expand duplicates in place, open Request details from a row, keep contests until voting ends #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
romchornyi
merged 4 commits into
feat/voting-filters
from
feat/voting-duplicates-and-details
Nov 16, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
127f7b1
feat(voting): expand duplicates in place, open Request details from a…
romchornyi 48ee23f
fix(voting): filters by my vote wait for the wallet's sync
romchornyi ae1b03e
chore(voting): take in develop through the stage below
romchornyi 9d219ea
chore(voting): take in develop through the stage below
romchornyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion (non-blocking). This went from
privateto internal so the tests can reach it. That makes a method that signs and broadcasts with the voting keys, with no PIN or biometric prompt, callable from anywhere in the app. The name can also be read as "cast with authentication".The caster already takes
sendandvotingKeyby injection. The steps before the loop could come in the same way: the SDK check, the open-contest pre-flight and theAuthenticationGatecall, each defaulting to what runs today. Then the tests could go throughcast(...)and this could beprivateagain. If that's more than this stage needs, a name likecastAfterAuthenticationwould at least make a wrong caller stand out. It is still internal at #1347 and #1366.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed at the stack tip in 59f8743 (#1366): it is now
castAfterAuthentication. Its doc says it asks no PIN, that it is internal only for the tests, and that app callers go throughcast(choice:onNormalizedLabel:with:). I kept the rename and did not inject the pre-flight steps, to keep the change small in the caster.