Repository navigation
chore(wallet): pin platform a7669077c5 (v5.2-dev) - #1307
romchornyi wants to merge 3 commits into
Conversation
Moves the platform pin to v5.1-dev at dashpay/platform#5715, which adds a read-only fetch of an identity's public keys with Platform's proved block time. The range also brings rust-dashcore's header difficulty checks and SPV store version 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
At 41391a1, the complete diff changes only .platform-ref; static verification found no concrete app compatibility or security regression. The disclosed fresh-store and upgraded-store live SPV checks remain unevidenced, and the current DashWalletTests simulator job is pending while target membership and PR-title checks pass. No builds or tests were run in this static-review lane.
🟡 1 suggestion(s)
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — The diff only updates .platform-ref, a small, contained dependency-pin change rather than a direct change to consensus, cryptography, or storage migration code. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 93% left, weekly 77% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer,gpt-6.1-sol— security-auditor (completed, effort medium); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `.platform-ref`:
- [SUGGESTION] .platform-ref:1: Complete the disclosed live SPV validation before merging
This pin changes live header acceptance through Dark Gravity Wave difficulty checks, replaces the X11 backend and checkpoints, and migrates SPV storage to version 3 by removing the persisted masternode data. These changes are present in the pinned rust-dashcore source, but static inspection and the supplied unit-test evidence do not establish that fresh and upgraded wallets sync successfully against the live network. The PR explicitly lists that validation as outstanding. Record exact-head testnet results for both a fresh store and an already-synced store: headers reach the tip, and InstantSend and Platform operations work after masternode resynchronization. Also confirm the current-head simulator CI result when it completes; its job is still pending.
| @@ -1 +1 @@ | |||
| e72022ab45fc0f30a286104714ae6241bc540901 | |||
| 9002c52ba4d90cd1b0cfdb7bb63301d4b3f768ca | |||
There was a problem hiding this comment.
🟡 Suggestion: Complete the disclosed live SPV validation before merging
This pin changes live header acceptance through Dark Gravity Wave difficulty checks, replaces the X11 backend and checkpoints, and migrates SPV storage to version 3 by removing the persisted masternode data. These changes are present in the pinned rust-dashcore source, but static inspection and the supplied unit-test evidence do not establish that fresh and upgraded wallets sync successfully against the live network. The PR explicitly lists that validation as outstanding. Record exact-head testnet results for both a fresh store and an already-synced store: headers reach the tip, and InstantSend and Platform operations work after masternode resynchronization. Also confirm the current-head simulator CI result when it completes; its job is still pending.
source: glm-5.3-flash (phase1-reviewer: general)
Merges develop and moves the platform pin to the head of v5.2-dev, which contains everything develop's pin had plus 52 commits, among them dashpay/platform#5904. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Final validation — Phase 1 + Phase 2
The reviewed range remains a single .platform-ref update from dabbec09c9 to a7669077c5, with no app-side source or project configuration changes. No concrete correctness or security defect is visible in the diff; however, the available simulator test check is still in progress and the runtime behavior selected by the new SDK pin remains insufficiently validated.
🟡 1 suggestion(s)
Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.
Still open from earlier rounds (1)
- 🟡 Suggestion: Complete the disclosed live SPV validation before merging —
.platform-ref:1(thread)
Review provenance
Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: ffi-engineer); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — Although the diff only changes .platform-ref, it upgrades the Rust/Swift SDK dependency and therefore changes runtime behavior across proof verification, asset-lock handling, reconciliation, and wallet persistence without changing app source code. - Phase 1 reviewers:
muse-spark-1.3-contributor— general (completed, effort xhigh); agentphase1-reviewer - Phase 1 model:
muse-spark-1.3-contributor— not quota-gated; passed overgemini-3.8-flash-high(antigravity quota lookup failed),glm-5.3-flash(not used above high effort; tier asks max) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— ffi-engineer (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— security-auditor (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.
In `.platform-ref`:
- [SUGGESTION] .platform-ref:1: Complete the disclosed live SPV validation before merging
(carried; thread: https://github.com/dashpay/dashwallet-ios/pull/1307#discussion_r4460337003)
Issue being fixed or feature implemented
Platform now has two development lines:
v5.1-devbecame the 5.1 release line (5.1.0-dev.1, dashpay/platform#5912) andv5.2-dev, cut from it on 2026-11-13, is where the wallet and SDK work lands. The app followsv5.2-devfrom now on and releases from it.The previous version of this PR pinned
9002c52ba4; develop has since moved past it (dabbec09c9, set by #1254), so the PR now moves develop's pin forward instead.What was done?
Merged develop (including #1413, without which the app aborts at launch on iOS 18) and moved
.platform-reffromdabbec09c9toa7669077c5, the head ofv5.2-dev(52 commits). The rust-dashcore pin is unchanged (c9aeac0d).What the bump brings for the app:
DashWalletTestsbuild as they are. New Swift API: DashPay private contact requests (feat(swift-sdk): send, receive and accept DashPay private contact requests platform#5812), document erase and history lifecycle (feat(sdk): expose the document erase and history lifecycle on mobile and FFI platform#4660), state transition outcome proofs (feat(sdk): prove a state transition's outcome, and add getRecentStateTransitionStatus platform#5823), fresh shielded addresses (feat(platform-wallet): fresh shielded addresses and an own-address check platform#5888). NewPlatformWalletResulterror codes 68–74 belong to private contact requests, which the app does not call yet.identityGetanddpnsGetUsernamenow run off the main actor (fix(swift-sdk): run identityGet and dpnsGetUsername off the main actor platform#5862); the app's call sites compile unchanged.SDK(network:)in Auto mode now builds the adaptive context provider: once the wallet manager's SPV client has synced, Platform proofs are verified with SPV's quorum keys, and with the trusted quorum service's keys for anything SPV cannot serve. Before that sync, and for an SDK no manager serves, behaviour is as before.How Has This Been Tested?
SwiftDashSDKbuilt for the simulator ata7669077c5(build_ios.sh --target sim --profile release).dashwallet-dashpaybuilt for testing on an iOS 27.2 simulator with no code change.DashWalletTests, full suite, on the iOS simulator: 2 265 tests, 1 skipped, 1 failure. The failure isString_DashWallet.testAssumptionThatCurrencySymbolIsEitherAtTheBeginningOrAtTheEnd, which depends on the simulator's locale data and fails the same way on the old pin.dabbec09c9:published-v4-to-v5, the store opens.store_open_failed,NSCocoaErrorDomain134504 "Cannot use staged migration with an unknown model version", and the app shows "Couldn't open your wallet data". The database is left untouched.Breaking Changes
None in the app's code. The SDK adds two models (
PersistentPrivateContactRequestsPosition,PersistentPrivateShieldedAddress) to SwiftData schema V5 without a new version. Platform's policy keeps the live schema open until an App Store release (dashpay/platform#4818), so App Store users are not affected. A store written by an internal or TestFlight build on the old pin (every 9.1.5 build so far) no longer matches V5 and fails to open, confirmed on a device (see Testing). Those testers have to use "Reset wallet data and rescan" on the error screen; the keys stay on the device.Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code