Skip to content

chore(wallet): pin platform a7669077c5 (v5.2-dev) - #1307

Open
romchornyi wants to merge 3 commits into
developfrom
chore/pin-platform-9002c52ba4
Open

romchornyi wants to merge 3 commits into
developfrom
chore/pin-platform-9002c52ba4

Conversation

@romchornyi

@romchornyi romchornyi commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Platform now has two development lines: v5.1-dev became the 5.1 release line (5.1.0-dev.1, dashpay/platform#5912) and v5.2-dev, cut from it on 2026-11-13, is where the wallet and SDK work lands. The app follows v5.2-dev from now on and releases from it.

The previous version of this PR pinned 9002c52ba4; develop has since moved past it (dabbec09c9, set by #1254), so the PR now moves develop's pin forward instead.

What was done?

Merged develop (including #1413, without which the app aborts at launch on iOS 18) and moved .platform-ref from dabbec09c9 to a7669077c5, the head of v5.2-dev (52 commits). The rust-dashcore pin is unchanged (c9aeac0d).

What the bump brings for the app:

How Has This Been Tested?

  • SwiftDashSDK built for the simulator at a7669077c5 (build_ios.sh --target sim --profile release).
  • dashwallet-dashpay built for testing on an iOS 27.2 simulator with no code change.
  • DashWalletTests, full suite, on the iOS simulator: 2 265 tests, 1 skipped, 1 failure. The failure is String_DashWallet.testAssumptionThatCurrencySymbolIsEitherAtTheBeginningOrAtTheEnd, which depends on the simulator's locale data and fails the same way on the old pin.
  • On an iPhone 13 Pro (iOS 18.7.8), mainnet wallet:
    • App Store 9.1.4 (schema V4) → a build on the old pin dabbec09c9: published-v4-to-v5, the store opens.
    • That store (old V5) → this branch: the store does not open. store_open_failed, NSCocoaErrorDomain 134504 "Cannot use staged migration with an unknown model version", and the app shows "Couldn't open your wallet data". The database is left untouched.
  • Not done: App Store 9.1.4 (V4) → this branch directly, and a live testnet session.

Breaking Changes

None in the app's code. The SDK adds two models (PersistentPrivateContactRequestsPosition, PersistentPrivateShieldedAddress) to SwiftData schema V5 without a new version. Platform's policy keeps the live schema open until an App Store release (dashpay/platform#4818), so App Store users are not affected. A store written by an internal or TestFlight build on the old pin (every 9.1.5 build so far) no longer matches V5 and fails to open, confirmed on a device (see Testing). Those testers have to use "Reset wallet data and rescan" on the error screen; the keys stay on the device.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

Moves the platform pin to v5.1-dev at dashpay/platform#5715, which adds a
read-only fetch of an identity's public keys with Platform's proved block
time. The range also brings rust-dashcore's header difficulty checks and
SPV store version 3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The .platform-ref value changes from e72022ab45fc0f30a286104714ae6241bc540901 to 9002c52ba4d90cd1b0cfdb7bb63301d4b3f768ca.

Changes: Platform SDK Reference

Layer / File(s) Summary
Update SDK reference
.platform-ref
The reference changes to a new revision. The provided context associates this revision with SDK updates related to finality guidance and identity-key expiry data.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related issues

Suggested reviewers: llbartekll

Merge Risk: Minimal · up to 41391

No merge-blocking issue was identified in this reference-only update.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Title check Warning The title states the change: the .platform-ref pin moves to platform commit a7669077c5, labelled v5.2-dev. The PR objectives describe a pin move from e72022ab45 to 9002c52ba4 (v5.1-dev), and the tit… Update the title so it matches the change. Use the target commit 9002c52ba4 and the v5.1-dev label, for example: chore(wallet): pin platform 9002c52ba4 (v5.1-dev). Alternatively, confirm that a7669077c5 (v5.2-dev) is the intended pin and up…
Passed Passed checks: 3 passed

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title states the change: the .platform-ref pin moves to platform commit a7669077c5, labelled v5.2-dev. The PR objectives describe a pin move from e72022ab45 to 9002c52ba4 (v5.1-dev), and the title names a different commit hash and version label. The title therefore refers to the right kind of change (a platform pin update for the wallet) but its commit and version details do not match the described changeset.

Resolution

Update the title so it matches the change. Use the target commit 9002c52ba4 and the v5.1-dev label, for example: chore(wallet): pin platform 9002c52ba4 (v5.1-dev). Alternatively, confirm that a7669077c5 (v5.2-dev) is the intended pin and update the PR description and objectives to match.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b5efbf97-e479-4d41-9703-8dd20d05b086
Commits

Reviewing files that changed from the base of the PR and between 55f0ad9 and 41391a1.

Files selected for processing: 1

  • .platform-ref

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@thepastaclaw

thepastaclaw commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

♻️ No change to this PR's diff since commit c437081 (an empty commit, a merge of the base or a rebase onto it): that review stands — approved; @thepastaclaw review asks for a review of this commit (commit c809a0e)

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

At 41391a1, the complete diff changes only .platform-ref; static verification found no concrete app compatibility or security regression. The disclosed fresh-store and upgraded-store live SPV checks remain unevidenced, and the current DashWalletTests simulator job is pending while target membership and PR-title checks pass. No builds or tests were run in this static-review lane.

🟡 1 suggestion(s)

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — The diff only updates .platform-ref, a small, contained dependency-pin change rather than a direct change to consensus, cryptography, or storage migration code.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 93% left, weekly 77% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort medium); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `.platform-ref`:
- [SUGGESTION] .platform-ref:1: Complete the disclosed live SPV validation before merging
  This pin changes live header acceptance through Dark Gravity Wave difficulty checks, replaces the X11 backend and checkpoints, and migrates SPV storage to version 3 by removing the persisted masternode data. These changes are present in the pinned rust-dashcore source, but static inspection and the supplied unit-test evidence do not establish that fresh and upgraded wallets sync successfully against the live network. The PR explicitly lists that validation as outstanding. Record exact-head testnet results for both a fresh store and an already-synced store: headers reach the tip, and InstantSend and Platform operations work after masternode resynchronization. Also confirm the current-head simulator CI result when it completes; its job is still pending.

Comment thread .platform-ref Outdated
@@ -1 +1 @@
e72022ab45fc0f30a286104714ae6241bc540901
9002c52ba4d90cd1b0cfdb7bb63301d4b3f768ca

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: Complete the disclosed live SPV validation before merging

This pin changes live header acceptance through Dark Gravity Wave difficulty checks, replaces the X11 backend and checkpoints, and migrates SPV storage to version 3 by removing the persisted masternode data. These changes are present in the pinned rust-dashcore source, but static inspection and the supplied unit-test evidence do not establish that fresh and upgraded wallets sync successfully against the live network. The PR explicitly lists that validation as outstanding. Record exact-head testnet results for both a fresh store and an already-synced store: headers reach the tip, and InstantSend and Platform operations work after masternode resynchronization. Also confirm the current-head simulator CI result when it completes; its job is still pending.

source: glm-5.3-flash (phase1-reviewer: general)

Merges develop and moves the platform pin to the head of v5.2-dev, which
contains everything develop's pin had plus 52 commits, among them
dashpay/platform#5904.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@romchornyi romchornyi changed the title chore(wallet): pin platform 9002c52ba4 chore(wallet): pin platform a7669077c5 (v5.2-dev) Nov 13, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

The reviewed range remains a single .platform-ref update from dabbec09c9 to a7669077c5, with no app-side source or project configuration changes. No concrete correctness or security defect is visible in the diff; however, the available simulator test check is still in progress and the runtime behavior selected by the new SDK pin remains insufficiently validated.

🟡 1 suggestion(s)

Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.

Still open from earlier rounds (1)

  • 🟡 Suggestion: Complete the disclosed live SPV validation before merging — .platform-ref:1 (thread)
Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: ffi-engineer); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — Although the diff only changes .platform-ref, it upgrades the Rust/Swift SDK dependency and therefore changes runtime behavior across proof verification, asset-lock handling, reconciliation, and wallet persistence without changing app source code.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — ffi-engineer (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `.platform-ref`:
- [SUGGESTION] .platform-ref:1: Complete the disclosed live SPV validation before merging
  (carried; thread: https://github.com/dashpay/dashwallet-ios/pull/1307#discussion_r4460337003)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants