Repository navigation
feat(dashpay): DashConnect expiry check and Expired tab - #1293
Conversation
…le' into feat/dashconnect-redesign-connections
…anded update clears its history entry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…once the row is back Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and a disconnect checks its follow-up view - A waiting record is dropped only when it holds no key by the store or the view (AppConnect.heldKeyIds): its re-sent keys and its added keys the store places count even when a lagging view omits them, unless the view shows them off or under another key or the store has them disabled; an added key live as added with no readable store record counts as unknown. Used by the settle and the failed-submit path. - A disconnect lets the row go with records still waiting only when its follow-up view shows every auth key the store gives them (AppConnect.showsWaitingKeys) and none of them is held. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…le' into feat/dashconnect-redesign-connections
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d that holds a key gets a row back - `pendingV2Outcome` no longer takes a later update of this wallet as proof that a waiting one cannot land: the SDK's copy of the identity can be reloaded while an update is on its way. A waiting record settles only on its own keys, an id held by other data, or its encryption key under another id. `outlivedBy` is only decoded; nothing notes it. - A waiting record that holds a key a disconnect can turn off gets a confirming row when the app has none offering a disconnect; a two-QR row waiting for its second scan is remembered for the drop. - Another identity's waiting record holds the row only while the store shows it holding an auth key, so one whose update never left the device does not block that app's disconnects elsewhere for good; nor does it keep a disconnect from turning off the unattributed profile keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…name and its disconnected entry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Following the updated design, each row carries its action: Disconnect on Active and Confirming rows, Reconnect on Disconnected and Expired ones. A row's Disconnect opens the connection's sheet, which asks there, so there is one disconnect question. The Expired sheet offers Reconnect, with Disconnect under it: an expired connection's keys stay on Platform until a disconnect, or a renewal of the same connection, turns them off. What a disconnect does is read from the data source when the question is asked (disconnectRevokesKeys), and again when it is confirmed: if it no longer holds, nothing runs and the sheet says why. A scan is refused, with a message, while something signs or an approval is on screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ollows its wallet - An expiry read that could not tell a listed app's expiry is not shown as complete: the Expired tab keeps what an earlier read told and shows "could not be checked" with Retry. An app whose recorded keys are all off (`ConnectionExpiry.keysOff`) reads the same every time and does not ask for a retry. - When the rows republish with another wallet's row of the app a connection sheet shows, the sheet closes, and its question with it. - A connection's end date is not shown when one of its records has no expiry noted. - A disconnect's history entry is dated when the revocation ends. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…; disconnect history and keys-off are said - The expiry read returns the wallet it was read for. A read of another wallet than the rows shown is not applied, the rows switching wallet drop the expiries, and an earlier Expired is carried over an incomplete read only for a row unchanged since (no renewal). A listed active app with no answer makes the check incomplete. - An app counts as expired only once both the phone's clock and the time of the last Core block SPV has synced are past its keys' expiry; until then, or without a chain time, it is not told. - An app whose recorded keys are all off shows "Keys turned off". - A disconnect whose app could not be saved among the disconnected apps says so, on the page once a closing sheet has gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tions page The Expired tab, the expiry read from Platform and its chain time, and the keys-off status move to a pull request of their own. The connection sheet shows the date the keys expire under a neutral label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ections page The Disconnected tab, the history store, its writers and its clearing on a wallet wipe, and Reconnect move to a pull request of their own. The page is one list of the connected apps; a disconnect closes its sheet once it has ended. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s note only the keys sent - A disconnect's question has three answers: its keys are turned off, only its local status changes, or either as Platform shows (a two-QR row with a grant). The data source holds the disconnect to the answer the user confirmed: before the revocation in turn, and again once the identity is read, before anything is turned off. - A v2 grant record notes message access only when its response carries an encryption key; a retry sealed again notes it again. - Only the latest read of the connection sheet's details is shown: one started before the sheet closed, opened again or read again is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…evocation The question is told from the wallet's records alone, which do not say which records are the active identity's: only a one-QR row is sure to turn its keys off. A two-QR row with a grant depends on what the identity shows, and its early two-QR return is held to the answer too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ion said A disconnect is held to its question by one rule, `accepts`, applied to the effect the records give before the PIN prompt and to the one the identity gives after its read. The data-source tests send the answer the screen would have asked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…heck is one rule in one place - A grant record keeps the keys and terms its first attempt noted: a retry registers those keys. Its message access follows the slots sent. - `DashConnectDisconnectEffect.accepts` is the rule the sheet's confirm and the disconnect's turn both apply; the turn checks it before the PIN prompt, and refuses when the row is gone. - A refused disconnect says the question changed, without "Could not disconnect". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…or a disconnect's effect - Until the rows are delivered the page shows progress, not the empty state. - `disconnectEffect` alone tells what a disconnect does from the records; the refusal of one whose row is gone says the connection changed. - Leftovers of the removed disconnected-app sheet are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ord stays one A row gone before the disconnect's turn throws its own error, so the sheet says the connection changed without guessing from the published rows. A refused disconnect leaves the sheet up and its Disconnect asks again. GrantedAccess.noted keeps isSessionKeyLogin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The connection store announces each save, and a data source republishes its wallet's rows on it, so a row another data source over the same rows removed (a page opened again while an earlier one's operation runs) leaves the page, and its sheet closes with the reason on the page. The mock refuses a row it does not list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings back the Disconnected tab, the history store and its writers, the sheet of a disconnected app and Reconnect, taken out of the page's first pull request, on top of its fixes: the disconnect question's three answers, the details read numbering and the store's save notice. This reverts commit 5032ebf. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed as disconnected The local-only disconnect left the row approved, which reads as waiting for the second code, with no Disconnect, no disconnect date and no Reconnect. It now records the app among the disconnected ones and drops its row, as a one-QR disconnect does; approving the same dash-key QR again makes a new row, active while its keys are still registered. The data source tests keep their history in the test suite's defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…in one value, under their wallet The data source publishes a DashConnectListing: the active wallet's rows, its disconnected apps and the scope they are of. Every sheet item carries that scope, so the one check that closes the sheet of another wallet's row covers a disconnected app too, including a switch between two wallets with no rows. The view model reads no history of its own, and the screen no longer refreshes on appear. A disconnect publishes the row gone and the app disconnected in one value; an approval publishes the row back and the entry forgotten. A disconnected app's sheet reads its entry again when it is recorded again. A two-QR disconnect that cannot be recorded among the disconnected apps says so, as a one-QR one does. An app's entry is forgotten only while it has a row, and a row that comes back takes the entry's name and website. The history store's unused save is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
While the Connections page is on screen, the data source's expiry check reads the active identity's keys and judges whether each active row's app can still sign. A key is the app's when a confirmed record names it or the store shows it bound to the app's contract; only keys that can sign are judged. An app is expired once the phone's clock and the Core tip, by Core's future-block margin, are past every live key's expiry; past by the phone alone it stays active and its sheet says so. An app with live keys that cannot sign, beside a live authentication key that cannot be matched to an app, is undecided, which the sheet says plainly. When to read, judge again and wait is one reducer (ConnectionExpiryMachine) run by ConnectionExpiryChecker; the data source tells it the rows, the identity, the page, the SDK manager and the Core tip, the view model tells it the app came back to the foreground, and the data source maps its read errors. The verdicts are published with the rows, each for a row of the generation the read was made for: a wallet or an identity change drops them, and a changed row has none until it is read again. With no active row nothing is read. A page that appears, or an app that comes back, moments after a read judges that read again; later it reads anew. A clock reaching a time that can change a verdict judges the keys already read, the latest Core tip seen counts while the SDK has none, and waits count the time the device sleeps. Leaving the page cancels a read, which is made when it is back. A runtime or an identity that is not ready yet is tried again after short waits, then shown as a failed check with Retry; a network with no identity to read says the check could not be made, without Retry. The page gets an Expired tab with Reconnect and Disconnect, which says "none" only when every active row was told. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Final review complete — no blockers (commit fa81bdd) · triage: normal |
The approve sheet now sits on the split stack: #1277 (page and sheet), #1289 (disconnected apps) and #1293 (expiry check). It reads the rows and the disconnected apps from the one published listing, waits for that listing before telling a first connection, and shows planned message access from the plan. The approve sheet keeps its "Connection will expire" string, which the stack's connection sheet no longer uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n-expiry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ly what the intents record - A read of one identity keeps a Disconnected row whose disconnect closed another identity's intents; it no longer removes the app from the wallet's Disconnected tab. - While the store holds intents of the identity it cannot read, a refresh keeps the Disconnected rows: one of them may be their disconnect. - A disconnected app with no marked intent to read has no disconnect time, access or connection time, instead of the row's own time. - A disconnected app is connected at its latest approval, as the sheet of the live connection shows it. - Tests for the listing the data source publishes: tabs and scope, a disconnect saved by another data source, a switch to a wallet with only a disconnected app, and a disconnected app's sheet on a wallet switch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…'s funding lines A refresh keeps the funding lines shown while its funding read runs, but a read that ended with nothing to read (no key gives the app access any more, or no identity read) left those lines and any earlier failure in place. It now clears both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…redesign-history The funding regressions pick their row from the Active tab, as this PR lists rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n-expiry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… identity read The sheet built its access from one read of the identity and its funding lines from another, taken later, so they could disagree: a funding line for a key the access list did not show, or a newer total beside an older maximum. Both now come from one ConnectionBasis (the read, the intents that hold the app on it, and the keys no intent names). Funding is read for that basis: only what is left of the budgets comes from the network, and the sheet sets it only beside details told from the same basis. A refresh from another read drops the earlier funding lines. Every claim the sheet makes from a key on Platform (access, messages, funding) now rests on AppConnect.placedKey: the store holds the key's bound. An encryption key whose bound is unknown, added or sent again, no longer gives message access. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t-access' into merge/history-1289
# Conflicts: # DashWallet/Sources/Models/DashConnect/DashConnectModels.swift # DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift # DashWallet/Sources/UI/DashConnect/ConnectionsScreen.swift # DashWallet/ar.lproj/Localizable.strings # DashWallet/bg.lproj/Localizable.strings # DashWallet/ca.lproj/Localizable.strings # DashWallet/cs.lproj/Localizable.strings # DashWallet/da.lproj/Localizable.strings # DashWallet/de.lproj/Localizable.strings # DashWallet/el.lproj/Localizable.strings # DashWallet/en.lproj/Localizable.strings # DashWallet/eo.lproj/Localizable.strings # DashWallet/es.lproj/Localizable.strings # DashWallet/et.lproj/Localizable.strings # DashWallet/fa.lproj/Localizable.strings # DashWallet/fi.lproj/Localizable.strings # DashWallet/fil.lproj/Localizable.strings # DashWallet/fr.lproj/Localizable.strings # DashWallet/hr.lproj/Localizable.strings # DashWallet/hu.lproj/Localizable.strings # DashWallet/id.lproj/Localizable.strings # DashWallet/it.lproj/Localizable.strings # DashWallet/ja.lproj/Localizable.strings # DashWallet/ko.lproj/Localizable.strings # DashWallet/mk.lproj/Localizable.strings # DashWallet/ms.lproj/Localizable.strings # DashWallet/nb.lproj/Localizable.strings # DashWallet/nl.lproj/Localizable.strings # DashWallet/pl.lproj/Localizable.strings # DashWallet/pt.lproj/Localizable.strings # DashWallet/ro.lproj/Localizable.strings # DashWallet/ru.lproj/Localizable.strings # DashWallet/sk.lproj/Localizable.strings # DashWallet/sl.lproj/Localizable.strings # DashWallet/sl_SI.lproj/Localizable.strings # DashWallet/sq.lproj/Localizable.strings # DashWallet/sr.lproj/Localizable.strings # DashWallet/sv.lproj/Localizable.strings # DashWallet/th.lproj/Localizable.strings # DashWallet/tr.lproj/Localizable.strings # DashWallet/uk.lproj/Localizable.strings # DashWallet/vi.lproj/Localizable.strings # DashWallet/zh-Hans.lproj/Localizable.strings # DashWallet/zh-Hant-TW.lproj/Localizable.strings # DashWallet/zh.lproj/Localizable.strings # DashWallet/zh_TW.lproj/Localizable.strings # DashWalletTests/DashConnect/PlatformDashConnectDataSourceTests.swift
…y' into fix/1293-bot-round # Conflicts: # DashWallet/ar.lproj/Localizable.strings # DashWallet/bg.lproj/Localizable.strings # DashWallet/ca.lproj/Localizable.strings # DashWallet/cs.lproj/Localizable.strings # DashWallet/da.lproj/Localizable.strings # DashWallet/de.lproj/Localizable.strings # DashWallet/el.lproj/Localizable.strings # DashWallet/en.lproj/Localizable.strings # DashWallet/eo.lproj/Localizable.strings # DashWallet/es.lproj/Localizable.strings # DashWallet/et.lproj/Localizable.strings # DashWallet/fa.lproj/Localizable.strings # DashWallet/fi.lproj/Localizable.strings # DashWallet/fil.lproj/Localizable.strings # DashWallet/fr.lproj/Localizable.strings # DashWallet/hr.lproj/Localizable.strings # DashWallet/hu.lproj/Localizable.strings # DashWallet/id.lproj/Localizable.strings # DashWallet/it.lproj/Localizable.strings # DashWallet/ja.lproj/Localizable.strings # DashWallet/ko.lproj/Localizable.strings # DashWallet/mk.lproj/Localizable.strings # DashWallet/ms.lproj/Localizable.strings # DashWallet/nb.lproj/Localizable.strings # DashWallet/nl.lproj/Localizable.strings # DashWallet/pl.lproj/Localizable.strings # DashWallet/pt.lproj/Localizable.strings # DashWallet/ro.lproj/Localizable.strings # DashWallet/ru.lproj/Localizable.strings # DashWallet/sk.lproj/Localizable.strings # DashWallet/sl.lproj/Localizable.strings # DashWallet/sl_SI.lproj/Localizable.strings # DashWallet/sq.lproj/Localizable.strings # DashWallet/sr.lproj/Localizable.strings # DashWallet/sv.lproj/Localizable.strings # DashWallet/th.lproj/Localizable.strings # DashWallet/tr.lproj/Localizable.strings # DashWallet/uk.lproj/Localizable.strings # DashWallet/vi.lproj/Localizable.strings # DashWallet/zh-Hans.lproj/Localizable.strings # DashWallet/zh-Hant-TW.lproj/Localizable.strings # DashWallet/zh.lproj/Localizable.strings # DashWallet/zh_TW.lproj/Localizable.strings
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Preliminary review — Phase 1 blocker gate
The head still contains two blocking expiry-state issues and two documentation inconsistencies identified in the prior review. The DashWalletTests, target-membership, and accessibility checks passed; the review check remains in progress, and the branch conflicts with the current base tip in localized string files.
Validated blockers were found by the Phase-1 review and confirmed by a fresh verifier. Phase 2 is deferred until a fresh same-head revalidation clears the blocker gate.
🔴 2 blocking | 💬 2 nitpick(s)
1 finding(s) not shown inline (the lines are not part of this PR's diff)
🔴 Blocking: A retained seenOn row is forced Active even when the other identity's keys already expired
DashWallet/Sources/Models/DashConnect/PlatformDashConnectDataSource.swift:1231-1245
When the current identity is removed from seenOn, any remaining identity causes this path to return .active without checking expiry evidence for that identity. seenOn is only a last-read marker, so it can preserve an Active row after the other identity's keys have expired; the current read does not re-evaluate those keys. Gate the retained status on evidence that the other identity still has live access, or represent stale seenOn as unresolved rather than forcing Active.
source: muse-spark-1.3-contributor (phase1-reviewer: general)
Still open from earlier rounds (3)
- 💬 Nitpick: Stale ADR 0010 reference on the new tab helper —
DashWallet/Sources/UI/DashConnect/ConnectionsViewModel.swift:250-252(thread) - 💬 Nitpick: Stale Core-tip comment on the expired date line —
DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift:454-458(thread) - 🔴 Blocking: Use the followed connection's expiry for the expired date —
DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift:454-458(thread)
Review provenance
Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This is a cross-cutting but contained DashConnect behavior and UI change that adds expiry classification, tab presentation, reconnect/disconnect actions, localization, and tests without changing funds movement, cryptography, key handling, consensus, networking deserialization, or storage migrations. - Phase 1 reviewers:
muse-spark-1.3-contributor— general (completed, effort xhigh); agentphase1-reviewer - Phase 1 model:
muse-spark-1.3-contributor— not quota-gated; passed overgemini-3.8-flash-high(antigravity quota lookup failed),glm-5.3-flash(not used above high effort; tier asks max) - Fresh verifier:
gpt-6.1-sol— verifier; agentsol-gate-verifier - Phase 2 reviewers: not run (deferred by blocker gate)
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.
In `DashWallet/Sources/Models/DashConnect/PlatformDashConnectDataSource.swift`:
- [BLOCKING] DashWallet/Sources/Models/DashConnect/PlatformDashConnectDataSource.swift:1231-1245: A retained seenOn row is forced Active even when the other identity's keys already expired
When the current identity is removed from `seenOn`, any remaining identity causes this path to return `.active` without checking expiry evidence for that identity. `seenOn` is only a last-read marker, so it can preserve an Active row after the other identity's keys have expired; the current read does not re-evaluate those keys. Gate the retained status on evidence that the other identity still has live access, or represent stale `seenOn` as unresolved rather than forcing Active.
In `DashWallet/Sources/UI/DashConnect/ConnectionsViewModel.swift`:
- [NITPICK] DashWallet/Sources/UI/DashConnect/ConnectionsViewModel.swift:250-252: Stale ADR 0010 reference on the new tab helper
(carried; thread: https://github.com/dashpay/dashwallet-ios/pull/1293#discussion_r4554420055)
In `DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift`:
- [NITPICK] DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift:454-458: Stale Core-tip comment on the expired date line
(carried; thread: https://github.com/dashpay/dashwallet-ios/pull/1293#discussion_r4542819890)
- [BLOCKING] DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift:454-458: Use the followed connection's expiry for the expired date
(carried; thread: https://github.com/dashpay/dashwallet-ios/pull/1293#discussion_r4516563374)
…xpired keys elsewhere hold no row - The sheet of an Expired row shows the expiry, limit and permissions of the connection the row follows (`ConnectionBasis.followedAccess`), not those of an older install still held. - `seenOn` records an identity only while one of its unrecorded keys is live at Platform's time; keys past their expiry on another identity no longer keep or bring back an Active row. - The expired-date comment tells Platform's proved block time; the tab helper cites ADR-0019. - Builds on the base after #1399: ended connections keep their recorded access (`ConnectionDetails(recorded:)`), the sheet previews and a funding test use the base's API. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re: A retained seenOn row is forced Active even when the other identity's keys already expired ( Fixed in a279d8b by recording |
…view details The preview's standalone access value is gone; the disconnected entry and its granted lines now take the access the preview details carry, as the Loaded preview does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…efresh test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # DashWallet/ar.lproj/Localizable.strings # DashWallet/bg.lproj/Localizable.strings # DashWallet/ca.lproj/Localizable.strings # DashWallet/cs.lproj/Localizable.strings # DashWallet/da.lproj/Localizable.strings # DashWallet/de.lproj/Localizable.strings # DashWallet/el.lproj/Localizable.strings # DashWallet/en.lproj/Localizable.strings # DashWallet/eo.lproj/Localizable.strings # DashWallet/es.lproj/Localizable.strings # DashWallet/et.lproj/Localizable.strings # DashWallet/fa.lproj/Localizable.strings # DashWallet/fi.lproj/Localizable.strings # DashWallet/fil.lproj/Localizable.strings # DashWallet/fr.lproj/Localizable.strings # DashWallet/hr.lproj/Localizable.strings # DashWallet/hu.lproj/Localizable.strings # DashWallet/id.lproj/Localizable.strings # DashWallet/it.lproj/Localizable.strings # DashWallet/ja.lproj/Localizable.strings # DashWallet/ko.lproj/Localizable.strings # DashWallet/mk.lproj/Localizable.strings # DashWallet/ms.lproj/Localizable.strings # DashWallet/nb.lproj/Localizable.strings # DashWallet/nl.lproj/Localizable.strings # DashWallet/pl.lproj/Localizable.strings # DashWallet/pt.lproj/Localizable.strings # DashWallet/ro.lproj/Localizable.strings # DashWallet/ru.lproj/Localizable.strings # DashWallet/sk.lproj/Localizable.strings # DashWallet/sl.lproj/Localizable.strings # DashWallet/sl_SI.lproj/Localizable.strings # DashWallet/sq.lproj/Localizable.strings # DashWallet/sr.lproj/Localizable.strings # DashWallet/sv.lproj/Localizable.strings # DashWallet/th.lproj/Localizable.strings # DashWallet/tr.lproj/Localizable.strings # DashWallet/uk.lproj/Localizable.strings # DashWallet/vi.lproj/Localizable.strings # DashWallet/zh-Hans.lproj/Localizable.strings # DashWallet/zh-Hant-TW.lproj/Localizable.strings # DashWallet/zh.lproj/Localizable.strings # DashWallet/zh_TW.lproj/Localizable.strings
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Final validation — Phase 1 + Phase 2
The rebuilt expiry projection and followed-connection access presentation are correct on this head. One blocking inconsistency remains: Expired sheets narrow permissions, expiry, and limits to the followed installation but still fetch and display funding balances for every held installation. The simulator test check is still in progress; completed accessibility, workflow-lint, target-membership, title, and CodeRabbit checks succeeded.
🔴 1 blocking
1 finding(s) not shown inline (the lines are not part of this PR's diff)
🔴 Blocking: Expired sheets still show funding for every held installation
DashWallet/Sources/Models/DashConnect/DashConnectModels.swift:344-356
ConnectionBasis.followedAccess restricts an Expired row's permissions, expiry, and funding limit to the intents followed by that row. However, fundedKeyIds and funding(remaining:) still use every intent in basis.intents, and heldConnection supplies all active, expired, and confirming installations for the active identity. When an older installation remains live while the newer followed installation is expired, the sheet therefore displays the expired installation's access limits alongside funding lines for the older live installation. Select the same followed intents and unrecorded keys for the funding read and displayed lines when the sheet is showing an Expired row, while preserving the current all-held behavior for other statuses.
source: muse-spark-1.3-contributor (phase1-reviewer: general); gpt-6.1-sol (phase2-reviewer: general)
Review provenance
Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This is a substantial cross-cutting behavior and UI change spanning DashConnect projections, platform data sourcing, expiry/status logic, localized strings, and tests, but it does not modify a critical surface such as funds movement, cryptography, key handling, consensus, or storage migrations. - Phase 1 reviewers:
muse-spark-1.3-contributor— general (completed, effort xhigh); agentphase1-reviewer - Phase 1 model:
muse-spark-1.3-contributor— not quota-gated; passed overgemini-3.8-flash-high(antigravity quota lookup failed),glm-5.3-flash(not used above high effort; tier asks max) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.
In `DashWallet/Sources/Models/DashConnect/DashConnectModels.swift`:
- [BLOCKING] DashWallet/Sources/Models/DashConnect/DashConnectModels.swift:344-356: Expired sheets still show funding for every held installation
`ConnectionBasis.followedAccess` restricts an Expired row's permissions, expiry, and funding limit to the intents followed by that row. However, `fundedKeyIds` and `funding(remaining:)` still use every intent in `basis.intents`, and `heldConnection` supplies all active, expired, and confirming installations for the active identity. When an older installation remains live while the newer followed installation is expired, the sheet therefore displays the expired installation's access limits alongside funding lines for the older live installation. Select the same followed intents and unrecorded keys for the funding read and displayed lines when the sheet is showing an Expired row, while preserving the current all-held behavior for other statuses.
…y' into fix/1293-bot-round # Conflicts: # DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift # DashWallet/ar.lproj/Localizable.strings # DashWallet/bg.lproj/Localizable.strings # DashWallet/ca.lproj/Localizable.strings # DashWallet/cs.lproj/Localizable.strings # DashWallet/da.lproj/Localizable.strings # DashWallet/de.lproj/Localizable.strings # DashWallet/el.lproj/Localizable.strings # DashWallet/en.lproj/Localizable.strings # DashWallet/eo.lproj/Localizable.strings # DashWallet/es.lproj/Localizable.strings # DashWallet/et.lproj/Localizable.strings # DashWallet/fa.lproj/Localizable.strings # DashWallet/fi.lproj/Localizable.strings # DashWallet/fil.lproj/Localizable.strings # DashWallet/fr.lproj/Localizable.strings # DashWallet/hr.lproj/Localizable.strings # DashWallet/hu.lproj/Localizable.strings # DashWallet/id.lproj/Localizable.strings # DashWallet/it.lproj/Localizable.strings # DashWallet/ja.lproj/Localizable.strings # DashWallet/ko.lproj/Localizable.strings # DashWallet/mk.lproj/Localizable.strings # DashWallet/ms.lproj/Localizable.strings # DashWallet/nb.lproj/Localizable.strings # DashWallet/nl.lproj/Localizable.strings # DashWallet/pl.lproj/Localizable.strings # DashWallet/pt.lproj/Localizable.strings # DashWallet/ro.lproj/Localizable.strings # DashWallet/ru.lproj/Localizable.strings # DashWallet/sk.lproj/Localizable.strings # DashWallet/sl.lproj/Localizable.strings # DashWallet/sl_SI.lproj/Localizable.strings # DashWallet/sq.lproj/Localizable.strings # DashWallet/sr.lproj/Localizable.strings # DashWallet/sv.lproj/Localizable.strings # DashWallet/th.lproj/Localizable.strings # DashWallet/tr.lproj/Localizable.strings # DashWallet/uk.lproj/Localizable.strings # DashWallet/vi.lproj/Localizable.strings # DashWallet/zh-Hans.lproj/Localizable.strings # DashWallet/zh-Hant-TW.lproj/Localizable.strings # DashWallet/zh.lproj/Localizable.strings # DashWallet/zh_TW.lproj/Localizable.strings
… follows The sheet of an Expired row is told from `ConnectionBasis.shown(as:)`: the intents the row follows, or its unrecorded keys when none is held. Its access, expiry and funding lines come from that basis, so the funding read no longer lists the keys of an older install still held. Other rows read the whole basis as before; funding is still attached to the details of the read it was made for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re: Expired sheets still show funding for every held installation ( Fixed in 1cb6777. The merge conflict with the base is resolved in 61d5264. |
…recorded ConnectionDetails is told from a basis since the sheet's access and funding come from one identity read; a connection that ended has none. It gets its own initializer that carries the recorded access with no basis and no funding, and the view model builds a disconnected app's details with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A disconnect also marks an intent whose update was still in flight, so the access recorded for a disconnected app may never have landed. Its sheet now says "See what you allowed %@ to do" instead of "was able to do", which holds whether the keys landed or not. The new key ships in English in every locale until the Transifex pull. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y' into fix/1293-bot-round # Conflicts: # DashWallet/Sources/Models/DashConnect/DashConnectModels.swift
# Conflicts: # DashWallet/Sources/Models/DashConnect/DashConnectModels.swift # DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift # DashWallet/Sources/UI/DashConnect/ConnectionsScreen.swift # DashWallet/Sources/UI/DashConnect/ConnectionsViewModel.swift # DashWallet/ar.lproj/Localizable.strings # DashWallet/bg.lproj/Localizable.strings # DashWallet/ca.lproj/Localizable.strings # DashWallet/cs.lproj/Localizable.strings # DashWallet/da.lproj/Localizable.strings # DashWallet/de.lproj/Localizable.strings # DashWallet/el.lproj/Localizable.strings # DashWallet/en.lproj/Localizable.strings # DashWallet/eo.lproj/Localizable.strings # DashWallet/es.lproj/Localizable.strings # DashWallet/et.lproj/Localizable.strings # DashWallet/fa.lproj/Localizable.strings # DashWallet/fi.lproj/Localizable.strings # DashWallet/fil.lproj/Localizable.strings # DashWallet/fr.lproj/Localizable.strings # DashWallet/hr.lproj/Localizable.strings # DashWallet/hu.lproj/Localizable.strings # DashWallet/id.lproj/Localizable.strings # DashWallet/it.lproj/Localizable.strings # DashWallet/ja.lproj/Localizable.strings # DashWallet/ko.lproj/Localizable.strings # DashWallet/mk.lproj/Localizable.strings # DashWallet/ms.lproj/Localizable.strings # DashWallet/nb.lproj/Localizable.strings # DashWallet/nl.lproj/Localizable.strings # DashWallet/pl.lproj/Localizable.strings # DashWallet/pt.lproj/Localizable.strings # DashWallet/ro.lproj/Localizable.strings # DashWallet/ru.lproj/Localizable.strings # DashWallet/sk.lproj/Localizable.strings # DashWallet/sl.lproj/Localizable.strings # DashWallet/sl_SI.lproj/Localizable.strings # DashWallet/sq.lproj/Localizable.strings # DashWallet/sr.lproj/Localizable.strings # DashWallet/sv.lproj/Localizable.strings # DashWallet/th.lproj/Localizable.strings # DashWallet/tr.lproj/Localizable.strings # DashWallet/uk.lproj/Localizable.strings # DashWallet/vi.lproj/Localizable.strings # DashWallet/zh-Hans.lproj/Localizable.strings # DashWallet/zh-Hant-TW.lproj/Localizable.strings # DashWallet/zh.lproj/Localizable.strings # DashWallet/zh_TW.lproj/Localizable.strings # DashWalletTests/DashConnect/PlatformDashConnectDataSourceTests.swift
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Final validation — Phase 1 + Phase 2
The exact head carries Platform-proved time through the expiry projection, routes expired rows to the Expired tab, and scopes expired-sheet access and funding to the followed connection; the former Core-time and scheduled-checker paths are absent. The available simulator tests, workflow lint, target-membership, accessibility, title, and CodeRabbit checks all succeeded; the remaining queued review check is not a code validation failure.
🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)
Review provenance
Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This is a cross-cutting behavioral change to DashConnect expiry classification, projections, view models, UI tabs, localization, and tests, but it does not modify funds movement, cryptography, key handling, consensus, peer-facing deserialization, or storage migrations. - Phase 1 reviewers:
muse-spark-1.3-contributor— general (completed, effort xhigh); agentphase1-reviewer - Phase 1 model:
muse-spark-1.3-contributor— not quota-gated; passed overgemini-3.8-flash-high(antigravity quota lookup failed),glm-5.3-flash(not used above high effort; tier asks max) - Fresh final gate: an independent Phase-2 review ran after iterative findings were reconciled
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.
No unresolved findings remain from the prior review on this head.
Issue being fixed or feature implemented
Stacked on #1289. Fourth part of the DashConnect redesign (Figma: DashPay / Android, Connections section 40042:59884): the expiry check and the Expired tab. It answers the review threads on #1277 about expiry: Platform time (#1277 (comment)), live legacy keys (#1277 (comment)) and the cache's scope (#1277 (comment)).
The redesign is split into four pull requests: #1277 (page, rows, connection sheet) ← #1289 (disconnected apps) ← this one ← #1278 (approve sheet).
What was done?
What counts as expired
expires_at; the app does not read Platform's time yet (feat: fetch an identity's public keys without reloading the managed identity platform#5715 will carry it; App Connect v2: known limits of settling an approval whose identity update's outcome is unknown #1273, item 21), so a narrow window at the boundary remains.When it is checked
ConnectionExpiryMachine) decides when to read, when to judge again and when to wait.ConnectionExpiryCheckerruns it.What the verdicts belong to
DashConnectListing.Page
Known limits
TODO(dashconnect-expiry)).How Has This Been Tested?
dashwallet-dashpayscheme, Debug, iOS 27 simulator, against the stack's platform pin. Every DashConnect suite passed (456), including:ConnectionExpiryMachineTests: the reducer, synchronous, one test per transition;ConnectionExpiryCheckerTests: the driver's reads, waits, cancellation and publishing;scripts/a11y_audit.py --check: no new findings.Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code
Summary by CodeRabbit