Skip to content

feat(dashpay): DashConnect expiry check and Expired tab - #1293

Merged
romchornyi merged 372 commits into
developfrom
feat/dashconnect-redesign-expiry
Nov 13, 2026
Merged

romchornyi merged 372 commits into
developfrom
feat/dashconnect-redesign-expiry

Conversation

@romchornyi

@romchornyi romchornyi commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Rebuilt on #1334 (2026-11-09). Merged onto this branch without rewriting its history. What differs from the text below:

Issue being fixed or feature implemented

Moved onto #1301 (2026-11-09), together with #1277 and #1289, on the product owner's choice to go through #1301's projection. The Expired tab is rebuilt in one commit, merged onto this branch without rewriting its history. What differs from the text below:

  • ConnectionExpiryMachine and ConnectionExpiryChecker are not taken. refactor(dashpay): derive App Connect rows from the identity and a recorded intent #1301's projection already has an expired status, judged against Platform's time, which the app does not read yet (feat: fetch an identity's public keys without reloading the managed identity platform#5715).
  • Until it does, the identity snapshot takes a time Platform is known to be past: the Core tip SPV synced, less the same 2 h 70 min margin (AppConnect.platformTimeLowerBound). A connection whose live keys are all past their expiry by it is ConnectionStatus.expired and is listed under Expired.
  • Its sheet says Expired and offers Reconnect and Disconnect, as described below.
  • The status is judged on each read of the identity, which the page makes when it appears. The scheduled re-checks, the "past by the phone's clock" and "undecided" notes, the progress and Retry of a check, and the .keysOff note are not part of this version.
  • Tests: the DashConnect suites, view model tests included, pass (288 tests). New tests cover the time bound, the expired status in the projection and in the rows, and the Expired tab.

Stacked on #1289. Fourth part of the DashConnect redesign (Figma: DashPay / Android, Connections section 40042:59884): the expiry check and the Expired tab. It answers the review threads on #1277 about expiry: Platform time (#1277 (comment)), live legacy keys (#1277 (comment)) and the cache's scope (#1277 (comment)).

The redesign is split into four pull requests: #1277 (page, rows, connection sheet) ← #1289 (disconnected apps) ← this one ← #1278 (approve sheet).

What was done?

What counts as expired

  • A key is the app's when a confirmed record names it, or when the store shows it bound to the app's contract. Only keys that can sign are judged.
  • An app is expired once the Core tip that SPV synced is past every live key's expiry by Core's future-block margin (2 h + 70 min), whatever the phone's clock says: a header can be at most that far ahead of real time, so the tip shows real time is past the expiry. Platform rejects a key once its block time reaches expires_at; the app does not read Platform's time yet (feat: fetch an identity's public keys without reloading the managed identity platform#5715 will carry it; App Connect v2: known limits of settling an approval whose identity update's outcome is unknown #1273, item 21), so a narrow window at the boundary remains.
  • An app whose expiry has passed by the phone's clock but not yet by the tip stays under Active, and its sheet says the network has not shown it yet. A phone clock set back takes no expiry back.
  • An app with a live key that can still sign is current, a legacy key with no expiry included.
  • An app with no live key of its own is keys off.
  • A live authentication key that cannot be matched to an app (for example a legacy two-QR key with no bound) makes an app past expiry undecided, and the sheet says so. A key the read lacks makes it unknown.

When it is checked

  • One reducer (ConnectionExpiryMachine) decides when to read, when to judge again and when to wait. ConnectionExpiryChecker runs it.
    • The data source tells it the rows, the identity, whether the page is on screen, the SDK manager and the Core tip.
    • The view model tells it the app came back to the foreground.
    • The data source maps its own read errors.
  • It reads only while the page is on screen and a row is active. Leaving the page cancels a read; the read is made again on return.
  • A page or app that comes back within 30 s of a read judges that read again; later it reads anew.
  • A clock reaching a time that can change a verdict judges the keys already read, without reading again. The latest Core tip seen still counts while a restarted SDK has none, and waits count the time the device sleeps.
  • A runtime or identity that is not ready yet is retried after 2, 5 and 15 s, then shown as a failed check with Retry. A runtime on a network with nothing to read says the check could not be made, without Retry.

What the verdicts belong to

  • Verdicts are published with the rows, in the same DashConnectListing.
  • Each verdict is for the row as it was when its read was made (id, wallet, status, login kind, last update).
  • A wallet or identity change drops the verdicts, and a renewed row has none until it is read again. Expiry only moves one way.

Page

  • An Expired tab. Its sheet shows "Expired", the past-tense access lists, Reconnect, and Disconnect (an expired connection's keys stay on Platform until a disconnect turns them off).
  • While a check runs, the tab shows progress. A failed check shows "Which connections have expired could not be checked." with Retry. "No expired connections" appears only when every active row was told.

Known limits

  • The read reloads the identity under the DashConnect operation lock, so an approval or disconnect started during a read waits for it. feat: fetch an identity's public keys without reloading the managed identity platform#5715 adds a read-only key fetch; the read moves to it once the app's platform pin includes it (TODO(dashconnect-expiry)).
  • A contract-group key no record names makes an app undecided; its owner is not looked up.
  • An expired row offers Reconnect, as in Figma; Disconnect is on its sheet.

How Has This Been Tested?

  • Unit tests: dashwallet-dashpay scheme, Debug, iOS 27 simulator, against the stack's platform pin. Every DashConnect suite passed (456), including:
    • ConnectionExpiryMachineTests: the reducer, synchronous, one test per transition;
    • ConnectionExpiryCheckerTests: the driver's reads, waits, cancellation and publishing;
    • the classifier: the Core-tip rule with the margin (a phone clock set back included), far-future expiries, legacy keys, unmatched keys, keys missing from the read or the store, encryption keys, the end-of-time overflow;
    • the data source wiring: a wallet switch during a read, a name change that keeps a verdict, the read-error mapping;
    • the view model: the Expired tab, the undecided note, a failed or unavailable check, Retry, foreground.
  • scripts/a11y_audit.py --check: no new findings.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an Expired connections tab with a matching empty state.
    • Expired connections display an expiration label and show available actions, such as reconnecting or disconnecting.
  • Bug Fixes
    • Connection actions now prioritize reconnect when it is available.
    • Expired connections appear in the expired list rather than the active list. Added expiration labels and empty-state text to localization resources.

romchornyi and others added 25 commits October 31, 2026 23:41
…le' into feat/dashconnect-redesign-connections
…anded update clears its history entry

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…once the row is back

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and a disconnect checks its follow-up view

- A waiting record is dropped only when it holds no key by the store or
  the view (AppConnect.heldKeyIds): its re-sent keys and its added keys
  the store places count even when a lagging view omits them, unless
  the view shows them off or under another key or the store has them
  disabled; an added key live as added with no readable store record
  counts as unknown. Used by the settle and the failed-submit path.
- A disconnect lets the row go with records still waiting only when its
  follow-up view shows every auth key the store gives them
  (AppConnect.showsWaitingKeys) and none of them is held.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…le' into feat/dashconnect-redesign-connections
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d that holds a key gets a row back

- `pendingV2Outcome` no longer takes a later update of this wallet as
  proof that a waiting one cannot land: the SDK's copy of the identity
  can be reloaded while an update is on its way. A waiting record settles
  only on its own keys, an id held by other data, or its encryption key
  under another id. `outlivedBy` is only decoded; nothing notes it.
- A waiting record that holds a key a disconnect can turn off gets a
  confirming row when the app has none offering a disconnect; a two-QR
  row waiting for its second scan is remembered for the drop.
- Another identity's waiting record holds the row only while the store
  shows it holding an auth key, so one whose update never left the device
  does not block that app's disconnects elsewhere for good; nor does it
  keep a disconnect from turning off the unattributed profile keys.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…name and its disconnected entry

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Following the updated design, each row carries its action: Disconnect on
Active and Confirming rows, Reconnect on Disconnected and Expired ones.
A row's Disconnect opens the connection's sheet, which asks there, so
there is one disconnect question. The Expired sheet offers Reconnect,
with Disconnect under it: an expired connection's keys stay on Platform
until a disconnect, or a renewal of the same connection, turns them off.

What a disconnect does is read from the data source when the question is
asked (disconnectRevokesKeys), and again when it is confirmed: if it no
longer holds, nothing runs and the sheet says why. A scan is refused, with
a message, while something signs or an approval is on screen.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ollows its wallet

- An expiry read that could not tell a listed app's expiry is not shown
  as complete: the Expired tab keeps what an earlier read told and shows
  "could not be checked" with Retry. An app whose recorded keys are all
  off (`ConnectionExpiry.keysOff`) reads the same every time and does
  not ask for a retry.
- When the rows republish with another wallet's row of the app a
  connection sheet shows, the sheet closes, and its question with it.
- A connection's end date is not shown when one of its records has no
  expiry noted.
- A disconnect's history entry is dated when the revocation ends.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…; disconnect history and keys-off are said

- The expiry read returns the wallet it was read for. A read of another
  wallet than the rows shown is not applied, the rows switching wallet
  drop the expiries, and an earlier Expired is carried over an
  incomplete read only for a row unchanged since (no renewal). A listed
  active app with no answer makes the check incomplete.
- An app counts as expired only once both the phone's clock and the
  time of the last Core block SPV has synced are past its keys' expiry;
  until then, or without a chain time, it is not told.
- An app whose recorded keys are all off shows "Keys turned off".
- A disconnect whose app could not be saved among the disconnected apps
  says so, on the page once a closing sheet has gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tions page

The Expired tab, the expiry read from Platform and its chain time, and the
keys-off status move to a pull request of their own. The connection sheet
shows the date the keys expire under a neutral label.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ections page

The Disconnected tab, the history store, its writers and its clearing on a
wallet wipe, and Reconnect move to a pull request of their own. The page is
one list of the connected apps; a disconnect closes its sheet once it has
ended.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s note only the keys sent

- A disconnect's question has three answers: its keys are turned off,
  only its local status changes, or either as Platform shows (a two-QR row
  with a grant). The data source holds the disconnect to the answer the
  user confirmed: before the revocation in turn, and again once the
  identity is read, before anything is turned off.
- A v2 grant record notes message access only when its response carries
  an encryption key; a retry sealed again notes it again.
- Only the latest read of the connection sheet's details is shown: one
  started before the sheet closed, opened again or read again is dropped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…evocation

The question is told from the wallet's records alone, which do not say
which records are the active identity's: only a one-QR row is sure to turn
its keys off. A two-QR row with a grant depends on what the identity shows,
and its early two-QR return is held to the answer too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ion said

A disconnect is held to its question by one rule, `accepts`, applied to
the effect the records give before the PIN prompt and to the one the
identity gives after its read. The data-source tests send the answer the
screen would have asked.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…heck is one rule in one place

- A grant record keeps the keys and terms its first attempt noted: a retry
  registers those keys. Its message access follows the slots sent.
- `DashConnectDisconnectEffect.accepts` is the rule the sheet's confirm and
  the disconnect's turn both apply; the turn checks it before the PIN
  prompt, and refuses when the row is gone.
- A refused disconnect says the question changed, without "Could not
  disconnect".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…or a disconnect's effect

- Until the rows are delivered the page shows progress, not the empty
  state.
- `disconnectEffect` alone tells what a disconnect does from the records;
  the refusal of one whose row is gone says the connection changed.
- Leftovers of the removed disconnected-app sheet are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ord stays one

A row gone before the disconnect's turn throws its own error, so the sheet
says the connection changed without guessing from the published rows. A
refused disconnect leaves the sheet up and its Disconnect asks again.
GrantedAccess.noted keeps isSessionKeyLogin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The connection store announces each save, and a data source republishes
its wallet's rows on it, so a row another data source over the same rows
removed (a page opened again while an earlier one's operation runs)
leaves the page, and its sheet closes with the reason on the page. The
mock refuses a row it does not list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings back the Disconnected tab, the history store and its writers, the
sheet of a disconnected app and Reconnect, taken out of the page's first
pull request, on top of its fixes: the disconnect question's three
answers, the details read numbering and the store's save notice.

This reverts commit 5032ebf.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed as disconnected

The local-only disconnect left the row approved, which reads as waiting for
the second code, with no Disconnect, no disconnect date and no Reconnect.
It now records the app among the disconnected ones and drops its row, as a
one-QR disconnect does; approving the same dash-key QR again makes a new
row, active while its keys are still registered. The data source tests
keep their history in the test suite's defaults.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…in one value, under their wallet

The data source publishes a DashConnectListing: the active wallet's rows,
its disconnected apps and the scope they are of. Every sheet item carries
that scope, so the one check that closes the sheet of another wallet's row
covers a disconnected app too, including a switch between two wallets
with no rows. The view model reads no history of its own, and the screen
no longer refreshes on appear. A disconnect publishes the row gone and the
app disconnected in one value; an approval publishes the row back and the
entry forgotten. A disconnected app's sheet reads its entry again when it
is recorded again.

A two-QR disconnect that cannot be recorded among the disconnected apps
says so, as a one-QR one does. An app's entry is forgotten only while it
has a row, and a row that comes back takes the entry's name and website.
The history store's unused save is gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
While the Connections page is on screen, the data source's expiry check
reads the active identity's keys and judges whether each active row's app
can still sign. A key is the app's when a confirmed record names it or the
store shows it bound to the app's contract; only keys that can sign are
judged. An app is expired once the phone's clock and the Core tip, by
Core's future-block margin, are past every live key's expiry; past by the
phone alone it stays active and its sheet says so. An app with live keys
that cannot sign, beside a live authentication key that cannot be matched
to an app, is undecided, which the sheet says plainly.

When to read, judge again and wait is one reducer
(ConnectionExpiryMachine) run by ConnectionExpiryChecker; the data source
tells it the rows, the identity, the page, the SDK manager and the Core
tip, the view model tells it the app came back to the foreground, and the
data source maps its read errors. The verdicts are published with the
rows, each for a row of the generation the read was made for: a wallet or
an identity change drops them, and a changed row has none until it is
read again. With no active row nothing is read. A page that appears, or an
app that comes back, moments after a read judges that read again; later it
reads anew. A clock reaching a time that can change a verdict judges the
keys already read, the latest Core tip seen counts while the SDK has none,
and waits count the time the device sleeps. Leaving the page cancels a
read, which is made when it is back. A runtime or an identity that is not
ready yet is tried again after short waits, then shown as a failed check
with Retry; a network with no identity to read says the check could not be
made, without Retry. The page gets an Expired tab with Reconnect and
Disconnect, which says "none" only when every active row was told.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Explain Change →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

DashConnect now separates expired connections from active connections. Expired connection sheets display available actions and use an expiry-specific label. The screen adds expired-tab labels and previews, and localization catalogs add the new strings.

Changes: DashConnect Expired Connection Interface

Layer / File(s) Summary
Expired tab filtering
DashWallet/Sources/UI/DashConnect/ConnectionsViewModel.swift, DashWalletTests/DashConnect/*
ConnectionsTab adds an expired case. The view model filters connections by their status-table tab. Tests cover expired status projection and separation from active rows.
Expired connection presentation
DashWallet/Sources/UI/DashConnect/Components/ConnectionRow.swift, DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift, DashWallet/Sources/UI/DashConnect/ConnectionsScreen.swift, DashWallet/*.lproj/Localizable.strings
The row prioritizes Reconnect. The sheet displays every available action and labels expired dates. The screen adds expired-tab labels and previews. Localization catalogs add the corresponding strings.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Possibly related PRs

Suggested reviewers: thepastaclaw, llbartekll, jeanpierreroma

Merge Risk: Moderate · previous review f8428

The Expired tab and its actions look correct. Earlier concerns remain open in the underlying expiry projection: some apps with live keys may be marked Expired, and some expired apps may stay undecided. Resolve or explicitly accept these before merging.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two main changes: an expiry check for DashConnect connections and a new Expired tab. The changeset adds an expired tab, expired status handling in the view model and connection she…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two main changes: an expiry check for DashConnect connections and a new Expired tab. The changeset adds an expired tab, expired status handling in the view model and connection sheet, and expired localization strings, so the title matches the main change. It is specific and uses the repository's conventional commit style.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6456d2ff-f108-49db-a16b-50c63ddfa8b0
Commits

Reviewing files that changed from the base of the PR and between bc30e43 and f8428c7.

Files selected for processing: 47

  • DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift
  • DashWallet/Sources/UI/DashConnect/ConnectionsViewModel.swift
  • DashWallet/ar.lproj/Localizable.strings
  • DashWallet/bg.lproj/Localizable.strings
  • DashWallet/ca.lproj/Localizable.strings
  • DashWallet/cs.lproj/Localizable.strings
  • DashWallet/da.lproj/Localizable.strings
  • DashWallet/de.lproj/Localizable.strings
  • DashWallet/el.lproj/Localizable.strings
  • DashWallet/en.lproj/Localizable.strings
  • DashWallet/eo.lproj/Localizable.strings
  • DashWallet/es.lproj/Localizable.strings
  • DashWallet/et.lproj/Localizable.strings
  • DashWallet/fa.lproj/Localizable.strings
  • DashWallet/fi.lproj/Localizable.strings
  • DashWallet/fil.lproj/Localizable.strings
  • DashWallet/fr.lproj/Localizable.strings
  • DashWallet/hr.lproj/Localizable.strings
  • DashWallet/hu.lproj/Localizable.strings
  • DashWallet/id.lproj/Localizable.strings
  • DashWallet/it.lproj/Localizable.strings
  • DashWallet/ja.lproj/Localizable.strings
  • DashWallet/ko.lproj/Localizable.strings
  • DashWallet/mk.lproj/Localizable.strings
  • DashWallet/ms.lproj/Localizable.strings
  • DashWallet/nb.lproj/Localizable.strings
  • DashWallet/nl.lproj/Localizable.strings
  • DashWallet/pl.lproj/Localizable.strings
  • DashWallet/pt.lproj/Localizable.strings
  • DashWallet/ro.lproj/Localizable.strings
  • DashWallet/ru.lproj/Localizable.strings
  • DashWallet/sk.lproj/Localizable.strings
  • DashWallet/sl.lproj/Localizable.strings
  • DashWallet/sl_SI.lproj/Localizable.strings
  • DashWallet/sq.lproj/Localizable.strings
  • DashWallet/sr.lproj/Localizable.strings
  • DashWallet/sv.lproj/Localizable.strings
  • DashWallet/th.lproj/Localizable.strings
  • DashWallet/tr.lproj/Localizable.strings
  • DashWallet/uk.lproj/Localizable.strings
  • DashWallet/vi.lproj/Localizable.strings
  • DashWallet/zh-Hans.lproj/Localizable.strings
  • DashWallet/zh-Hant-TW.lproj/Localizable.strings
  • DashWallet/zh.lproj/Localizable.strings
  • DashWallet/zh_TW.lproj/Localizable.strings
  • DashWalletTests/DashConnect/AppConnectProjectionTests.swift
  • DashWalletTests/DashConnect/PlatformDashConnectDataSourceTests.swift
Files skipped from review as they are similar to previous changes: 43

  • DashWallet/ar.lproj/Localizable.strings
  • DashWallet/bg.lproj/Localizable.strings
  • DashWallet/ca.lproj/Localizable.strings
  • DashWallet/cs.lproj/Localizable.strings
  • DashWallet/da.lproj/Localizable.strings
  • DashWallet/de.lproj/Localizable.strings
  • DashWallet/el.lproj/Localizable.strings
  • DashWallet/en.lproj/Localizable.strings
  • DashWallet/eo.lproj/Localizable.strings
  • DashWallet/es.lproj/Localizable.strings
  • DashWallet/et.lproj/Localizable.strings
  • DashWallet/fa.lproj/Localizable.strings
  • DashWallet/fi.lproj/Localizable.strings
  • DashWallet/fil.lproj/Localizable.strings
  • DashWallet/fr.lproj/Localizable.strings
  • DashWallet/hr.lproj/Localizable.strings
  • DashWallet/hu.lproj/Localizable.strings
  • DashWallet/id.lproj/Localizable.strings
  • DashWallet/it.lproj/Localizable.strings
  • DashWallet/ja.lproj/Localizable.strings
  • DashWallet/ko.lproj/Localizable.strings
  • DashWallet/mk.lproj/Localizable.strings
  • DashWallet/ms.lproj/Localizable.strings
  • DashWallet/nb.lproj/Localizable.strings
  • DashWallet/nl.lproj/Localizable.strings
  • DashWallet/pl.lproj/Localizable.strings
  • DashWallet/pt.lproj/Localizable.strings
  • DashWallet/ro.lproj/Localizable.strings
  • DashWallet/ru.lproj/Localizable.strings
  • DashWallet/sk.lproj/Localizable.strings
  • DashWallet/sl.lproj/Localizable.strings
  • DashWallet/sl_SI.lproj/Localizable.strings
  • DashWallet/sq.lproj/Localizable.strings
  • DashWallet/sr.lproj/Localizable.strings
  • DashWallet/sv.lproj/Localizable.strings
  • DashWallet/th.lproj/Localizable.strings
  • DashWallet/tr.lproj/Localizable.strings
  • DashWallet/uk.lproj/Localizable.strings
  • DashWallet/vi.lproj/Localizable.strings
  • DashWallet/zh-Hans.lproj/Localizable.strings
  • DashWallet/zh-Hant-TW.lproj/Localizable.strings
  • DashWallet/zh.lproj/Localizable.strings
  • DashWallet/zh_TW.lproj/Localizable.strings

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@thepastaclaw

thepastaclaw commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

✅ Final review complete — no blockers (commit fa81bdd) · triage: normal

romchornyi added a commit that referenced this pull request Nov 2, 2026
The approve sheet now sits on the split stack: #1277 (page and sheet),
#1289 (disconnected apps) and #1293 (expiry check). It reads the rows and
the disconnected apps from the one published listing, waits for that
listing before telling a first connection, and shows planned message
access from the plan. The approve sheet keeps its "Connection will
expire" string, which the stack's connection sheet no longer uses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n-expiry

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@romchornyi
romchornyi marked this pull request as draft November 13, 2026 07:20
romchornyi and others added 5 commits November 13, 2026 09:28
…ly what the intents record

- A read of one identity keeps a Disconnected row whose disconnect closed
  another identity's intents; it no longer removes the app from the wallet's
  Disconnected tab.
- While the store holds intents of the identity it cannot read, a refresh
  keeps the Disconnected rows: one of them may be their disconnect.
- A disconnected app with no marked intent to read has no disconnect time,
  access or connection time, instead of the row's own time.
- A disconnected app is connected at its latest approval, as the sheet of the
  live connection shows it.
- Tests for the listing the data source publishes: tabs and scope, a
  disconnect saved by another data source, a switch to a wallet with only a
  disconnected app, and a disconnected app's sheet on a wallet switch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…'s funding lines

A refresh keeps the funding lines shown while its funding read runs, but a
read that ended with nothing to read (no key gives the app access any
more, or no identity read) left those lines and any earlier failure in
place. It now clears both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…redesign-history

The funding regressions pick their row from the Active tab, as this PR
lists rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n-expiry

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… identity read

The sheet built its access from one read of the identity and its funding
lines from another, taken later, so they could disagree: a funding line for
a key the access list did not show, or a newer total beside an older
maximum. Both now come from one ConnectionBasis (the read, the intents that
hold the app on it, and the keys no intent names). Funding is read for that
basis: only what is left of the budgets comes from the network, and the
sheet sets it only beside details told from the same basis. A refresh from
another read drops the earlier funding lines.

Every claim the sheet makes from a key on Platform (access, messages,
funding) now rests on AppConnect.placedKey: the store holds the key's bound.
An encryption key whose bound is unknown, added or sent again, no longer
gives message access.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@romchornyi
romchornyi marked this pull request as ready for review November 13, 2026 14:12
# Conflicts:
#	DashWallet/Sources/Models/DashConnect/DashConnectModels.swift
#	DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift
#	DashWallet/Sources/UI/DashConnect/ConnectionsScreen.swift
#	DashWallet/ar.lproj/Localizable.strings
#	DashWallet/bg.lproj/Localizable.strings
#	DashWallet/ca.lproj/Localizable.strings
#	DashWallet/cs.lproj/Localizable.strings
#	DashWallet/da.lproj/Localizable.strings
#	DashWallet/de.lproj/Localizable.strings
#	DashWallet/el.lproj/Localizable.strings
#	DashWallet/en.lproj/Localizable.strings
#	DashWallet/eo.lproj/Localizable.strings
#	DashWallet/es.lproj/Localizable.strings
#	DashWallet/et.lproj/Localizable.strings
#	DashWallet/fa.lproj/Localizable.strings
#	DashWallet/fi.lproj/Localizable.strings
#	DashWallet/fil.lproj/Localizable.strings
#	DashWallet/fr.lproj/Localizable.strings
#	DashWallet/hr.lproj/Localizable.strings
#	DashWallet/hu.lproj/Localizable.strings
#	DashWallet/id.lproj/Localizable.strings
#	DashWallet/it.lproj/Localizable.strings
#	DashWallet/ja.lproj/Localizable.strings
#	DashWallet/ko.lproj/Localizable.strings
#	DashWallet/mk.lproj/Localizable.strings
#	DashWallet/ms.lproj/Localizable.strings
#	DashWallet/nb.lproj/Localizable.strings
#	DashWallet/nl.lproj/Localizable.strings
#	DashWallet/pl.lproj/Localizable.strings
#	DashWallet/pt.lproj/Localizable.strings
#	DashWallet/ro.lproj/Localizable.strings
#	DashWallet/ru.lproj/Localizable.strings
#	DashWallet/sk.lproj/Localizable.strings
#	DashWallet/sl.lproj/Localizable.strings
#	DashWallet/sl_SI.lproj/Localizable.strings
#	DashWallet/sq.lproj/Localizable.strings
#	DashWallet/sr.lproj/Localizable.strings
#	DashWallet/sv.lproj/Localizable.strings
#	DashWallet/th.lproj/Localizable.strings
#	DashWallet/tr.lproj/Localizable.strings
#	DashWallet/uk.lproj/Localizable.strings
#	DashWallet/vi.lproj/Localizable.strings
#	DashWallet/zh-Hans.lproj/Localizable.strings
#	DashWallet/zh-Hant-TW.lproj/Localizable.strings
#	DashWallet/zh.lproj/Localizable.strings
#	DashWallet/zh_TW.lproj/Localizable.strings
#	DashWalletTests/DashConnect/PlatformDashConnectDataSourceTests.swift
…y' into fix/1293-bot-round

# Conflicts:
#	DashWallet/ar.lproj/Localizable.strings
#	DashWallet/bg.lproj/Localizable.strings
#	DashWallet/ca.lproj/Localizable.strings
#	DashWallet/cs.lproj/Localizable.strings
#	DashWallet/da.lproj/Localizable.strings
#	DashWallet/de.lproj/Localizable.strings
#	DashWallet/el.lproj/Localizable.strings
#	DashWallet/en.lproj/Localizable.strings
#	DashWallet/eo.lproj/Localizable.strings
#	DashWallet/es.lproj/Localizable.strings
#	DashWallet/et.lproj/Localizable.strings
#	DashWallet/fa.lproj/Localizable.strings
#	DashWallet/fi.lproj/Localizable.strings
#	DashWallet/fil.lproj/Localizable.strings
#	DashWallet/fr.lproj/Localizable.strings
#	DashWallet/hr.lproj/Localizable.strings
#	DashWallet/hu.lproj/Localizable.strings
#	DashWallet/id.lproj/Localizable.strings
#	DashWallet/it.lproj/Localizable.strings
#	DashWallet/ja.lproj/Localizable.strings
#	DashWallet/ko.lproj/Localizable.strings
#	DashWallet/mk.lproj/Localizable.strings
#	DashWallet/ms.lproj/Localizable.strings
#	DashWallet/nb.lproj/Localizable.strings
#	DashWallet/nl.lproj/Localizable.strings
#	DashWallet/pl.lproj/Localizable.strings
#	DashWallet/pt.lproj/Localizable.strings
#	DashWallet/ro.lproj/Localizable.strings
#	DashWallet/ru.lproj/Localizable.strings
#	DashWallet/sk.lproj/Localizable.strings
#	DashWallet/sl.lproj/Localizable.strings
#	DashWallet/sl_SI.lproj/Localizable.strings
#	DashWallet/sq.lproj/Localizable.strings
#	DashWallet/sr.lproj/Localizable.strings
#	DashWallet/sv.lproj/Localizable.strings
#	DashWallet/th.lproj/Localizable.strings
#	DashWallet/tr.lproj/Localizable.strings
#	DashWallet/uk.lproj/Localizable.strings
#	DashWallet/vi.lproj/Localizable.strings
#	DashWallet/zh-Hans.lproj/Localizable.strings
#	DashWallet/zh-Hant-TW.lproj/Localizable.strings
#	DashWallet/zh.lproj/Localizable.strings
#	DashWallet/zh_TW.lproj/Localizable.strings

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Preliminary review — Phase 1 blocker gate

The head still contains two blocking expiry-state issues and two documentation inconsistencies identified in the prior review. The DashWalletTests, target-membership, and accessibility checks passed; the review check remains in progress, and the branch conflicts with the current base tip in localized string files.

Validated blockers were found by the Phase-1 review and confirmed by a fresh verifier. Phase 2 is deferred until a fresh same-head revalidation clears the blocker gate.

🔴 2 blocking | 💬 2 nitpick(s)

1 finding(s) not shown inline (the lines are not part of this PR's diff)

🔴 Blocking: A retained seenOn row is forced Active even when the other identity's keys already expired
DashWallet/Sources/Models/DashConnect/PlatformDashConnectDataSource.swift:1231-1245

When the current identity is removed from seenOn, any remaining identity causes this path to return .active without checking expiry evidence for that identity. seenOn is only a last-read marker, so it can preserve an Active row after the other identity's keys have expired; the current read does not re-evaluate those keys. Gate the retained status on evidence that the other identity still has live access, or represent stale seenOn as unresolved rather than forcing Active.

source: muse-spark-1.3-contributor (phase1-reviewer: general)

Still open from earlier rounds (3)

  • 💬 Nitpick: Stale ADR 0010 reference on the new tab helper — DashWallet/Sources/UI/DashConnect/ConnectionsViewModel.swift:250-252 (thread)
  • 💬 Nitpick: Stale Core-tip comment on the expired date line — DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift:454-458 (thread)
  • 🔴 Blocking: Use the followed connection's expiry for the expired date — DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift:454-458 (thread)
Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This is a cross-cutting but contained DashConnect behavior and UI change that adds expiry classification, tab presentation, reconnect/disconnect actions, localization, and tests without changing funds movement, cryptography, key handling, consensus, networking deserialization, or storage migrations.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Fresh verifier: gpt-6.1-sol — verifier; agent sol-gate-verifier
  • Phase 2 reviewers: not run (deferred by blocker gate)
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `DashWallet/Sources/Models/DashConnect/PlatformDashConnectDataSource.swift`:
- [BLOCKING] DashWallet/Sources/Models/DashConnect/PlatformDashConnectDataSource.swift:1231-1245: A retained seenOn row is forced Active even when the other identity's keys already expired
  When the current identity is removed from `seenOn`, any remaining identity causes this path to return `.active` without checking expiry evidence for that identity. `seenOn` is only a last-read marker, so it can preserve an Active row after the other identity's keys have expired; the current read does not re-evaluate those keys. Gate the retained status on evidence that the other identity still has live access, or represent stale `seenOn` as unresolved rather than forcing Active.

In `DashWallet/Sources/UI/DashConnect/ConnectionsViewModel.swift`:
- [NITPICK] DashWallet/Sources/UI/DashConnect/ConnectionsViewModel.swift:250-252: Stale ADR 0010 reference on the new tab helper
  (carried; thread: https://github.com/dashpay/dashwallet-ios/pull/1293#discussion_r4554420055)

In `DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift`:
- [NITPICK] DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift:454-458: Stale Core-tip comment on the expired date line
  (carried; thread: https://github.com/dashpay/dashwallet-ios/pull/1293#discussion_r4542819890)
- [BLOCKING] DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift:454-458: Use the followed connection's expiry for the expired date
  (carried; thread: https://github.com/dashpay/dashwallet-ios/pull/1293#discussion_r4516563374)

…xpired keys elsewhere hold no row

- The sheet of an Expired row shows the expiry, limit and permissions of the
  connection the row follows (`ConnectionBasis.followedAccess`), not those of
  an older install still held.
- `seenOn` records an identity only while one of its unrecorded keys is live
  at Platform's time; keys past their expiry on another identity no longer
  keep or bring back an Active row.
- The expired-date comment tells Platform's proved block time; the tab helper
  cites ADR-0019.
- Builds on the base after #1399: ended connections keep their recorded
  access (`ConnectionDetails(recorded:)`), the sheet previews and a funding
  test use the base's API.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@romchornyi

Copy link
Copy Markdown
Contributor Author

Re: A retained seenOn row is forced Active even when the other identity's keys already expired (PlatformDashConnectDataSource.swift, the retain path in rows(_:after:of:intents:at:keeping:); no inline thread, the lines are outside the diff).

Fixed in a279d8b by recording seenOn only for live keys, as the field's documentation already said. The projection now reports liveUnrecordedIdentities, the identities where an unrecorded key is live at Platform's time of their read, and rows adds the read identity to seenOn only when it is among them. An identity whose unrecorded keys are all past their expiry therefore no longer keeps a retained row, or brings it back as Active on another identity's read. Covered by testKeysPastTheirExpiryOnAnotherIdentityDoNotHoldTheRowActive.

romchornyi and others added 3 commits November 13, 2026 17:55
…view details

The preview's standalone access value is gone; the disconnected entry and its
granted lines now take the access the preview details carry, as the Loaded
preview does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…efresh test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	DashWallet/ar.lproj/Localizable.strings
#	DashWallet/bg.lproj/Localizable.strings
#	DashWallet/ca.lproj/Localizable.strings
#	DashWallet/cs.lproj/Localizable.strings
#	DashWallet/da.lproj/Localizable.strings
#	DashWallet/de.lproj/Localizable.strings
#	DashWallet/el.lproj/Localizable.strings
#	DashWallet/en.lproj/Localizable.strings
#	DashWallet/eo.lproj/Localizable.strings
#	DashWallet/es.lproj/Localizable.strings
#	DashWallet/et.lproj/Localizable.strings
#	DashWallet/fa.lproj/Localizable.strings
#	DashWallet/fi.lproj/Localizable.strings
#	DashWallet/fil.lproj/Localizable.strings
#	DashWallet/fr.lproj/Localizable.strings
#	DashWallet/hr.lproj/Localizable.strings
#	DashWallet/hu.lproj/Localizable.strings
#	DashWallet/id.lproj/Localizable.strings
#	DashWallet/it.lproj/Localizable.strings
#	DashWallet/ja.lproj/Localizable.strings
#	DashWallet/ko.lproj/Localizable.strings
#	DashWallet/mk.lproj/Localizable.strings
#	DashWallet/ms.lproj/Localizable.strings
#	DashWallet/nb.lproj/Localizable.strings
#	DashWallet/nl.lproj/Localizable.strings
#	DashWallet/pl.lproj/Localizable.strings
#	DashWallet/pt.lproj/Localizable.strings
#	DashWallet/ro.lproj/Localizable.strings
#	DashWallet/ru.lproj/Localizable.strings
#	DashWallet/sk.lproj/Localizable.strings
#	DashWallet/sl.lproj/Localizable.strings
#	DashWallet/sl_SI.lproj/Localizable.strings
#	DashWallet/sq.lproj/Localizable.strings
#	DashWallet/sr.lproj/Localizable.strings
#	DashWallet/sv.lproj/Localizable.strings
#	DashWallet/th.lproj/Localizable.strings
#	DashWallet/tr.lproj/Localizable.strings
#	DashWallet/uk.lproj/Localizable.strings
#	DashWallet/vi.lproj/Localizable.strings
#	DashWallet/zh-Hans.lproj/Localizable.strings
#	DashWallet/zh-Hant-TW.lproj/Localizable.strings
#	DashWallet/zh.lproj/Localizable.strings
#	DashWallet/zh_TW.lproj/Localizable.strings

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

The rebuilt expiry projection and followed-connection access presentation are correct on this head. One blocking inconsistency remains: Expired sheets narrow permissions, expiry, and limits to the followed installation but still fetch and display funding balances for every held installation. The simulator test check is still in progress; completed accessibility, workflow-lint, target-membership, title, and CodeRabbit checks succeeded.

🔴 1 blocking

1 finding(s) not shown inline (the lines are not part of this PR's diff)

🔴 Blocking: Expired sheets still show funding for every held installation
DashWallet/Sources/Models/DashConnect/DashConnectModels.swift:344-356

ConnectionBasis.followedAccess restricts an Expired row's permissions, expiry, and funding limit to the intents followed by that row. However, fundedKeyIds and funding(remaining:) still use every intent in basis.intents, and heldConnection supplies all active, expired, and confirming installations for the active identity. When an older installation remains live while the newer followed installation is expired, the sheet therefore displays the expired installation's access limits alongside funding lines for the older live installation. Select the same followed intents and unrecorded keys for the funding read and displayed lines when the sheet is showing an Expired row, while preserving the current all-held behavior for other statuses.

source: muse-spark-1.3-contributor (phase1-reviewer: general); gpt-6.1-sol (phase2-reviewer: general)

Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This is a substantial cross-cutting behavior and UI change spanning DashConnect projections, platform data sourcing, expiry/status logic, localized strings, and tests, but it does not modify a critical surface such as funds movement, cryptography, key handling, consensus, or storage migrations.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `DashWallet/Sources/Models/DashConnect/DashConnectModels.swift`:
- [BLOCKING] DashWallet/Sources/Models/DashConnect/DashConnectModels.swift:344-356: Expired sheets still show funding for every held installation
  `ConnectionBasis.followedAccess` restricts an Expired row's permissions, expiry, and funding limit to the intents followed by that row. However, `fundedKeyIds` and `funding(remaining:)` still use every intent in `basis.intents`, and `heldConnection` supplies all active, expired, and confirming installations for the active identity. When an older installation remains live while the newer followed installation is expired, the sheet therefore displays the expired installation's access limits alongside funding lines for the older live installation. Select the same followed intents and unrecorded keys for the funding read and displayed lines when the sheet is showing an Expired row, while preserving the current all-held behavior for other statuses.

romchornyi and others added 2 commits November 13, 2026 18:26
…y' into fix/1293-bot-round

# Conflicts:
#	DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift
#	DashWallet/ar.lproj/Localizable.strings
#	DashWallet/bg.lproj/Localizable.strings
#	DashWallet/ca.lproj/Localizable.strings
#	DashWallet/cs.lproj/Localizable.strings
#	DashWallet/da.lproj/Localizable.strings
#	DashWallet/de.lproj/Localizable.strings
#	DashWallet/el.lproj/Localizable.strings
#	DashWallet/en.lproj/Localizable.strings
#	DashWallet/eo.lproj/Localizable.strings
#	DashWallet/es.lproj/Localizable.strings
#	DashWallet/et.lproj/Localizable.strings
#	DashWallet/fa.lproj/Localizable.strings
#	DashWallet/fi.lproj/Localizable.strings
#	DashWallet/fil.lproj/Localizable.strings
#	DashWallet/fr.lproj/Localizable.strings
#	DashWallet/hr.lproj/Localizable.strings
#	DashWallet/hu.lproj/Localizable.strings
#	DashWallet/id.lproj/Localizable.strings
#	DashWallet/it.lproj/Localizable.strings
#	DashWallet/ja.lproj/Localizable.strings
#	DashWallet/ko.lproj/Localizable.strings
#	DashWallet/mk.lproj/Localizable.strings
#	DashWallet/ms.lproj/Localizable.strings
#	DashWallet/nb.lproj/Localizable.strings
#	DashWallet/nl.lproj/Localizable.strings
#	DashWallet/pl.lproj/Localizable.strings
#	DashWallet/pt.lproj/Localizable.strings
#	DashWallet/ro.lproj/Localizable.strings
#	DashWallet/ru.lproj/Localizable.strings
#	DashWallet/sk.lproj/Localizable.strings
#	DashWallet/sl.lproj/Localizable.strings
#	DashWallet/sl_SI.lproj/Localizable.strings
#	DashWallet/sq.lproj/Localizable.strings
#	DashWallet/sr.lproj/Localizable.strings
#	DashWallet/sv.lproj/Localizable.strings
#	DashWallet/th.lproj/Localizable.strings
#	DashWallet/tr.lproj/Localizable.strings
#	DashWallet/uk.lproj/Localizable.strings
#	DashWallet/vi.lproj/Localizable.strings
#	DashWallet/zh-Hans.lproj/Localizable.strings
#	DashWallet/zh-Hant-TW.lproj/Localizable.strings
#	DashWallet/zh.lproj/Localizable.strings
#	DashWallet/zh_TW.lproj/Localizable.strings
… follows

The sheet of an Expired row is told from `ConnectionBasis.shown(as:)`: the
intents the row follows, or its unrecorded keys when none is held. Its
access, expiry and funding lines come from that basis, so the funding read
no longer lists the keys of an older install still held. Other rows read
the whole basis as before; funding is still attached to the details of the
read it was made for.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@romchornyi

Copy link
Copy Markdown
Contributor Author

Re: Expired sheets still show funding for every held installation (DashConnectModels.swift, ConnectionBasis; no inline thread).

Fixed in 1cb6777. ConnectionBasis.followedAccess is replaced by shown(as:): for an Expired row it is a basis of the followed intents (or the unrecorded keys when none is held), and the view model reads funding for that basis, so fundedKeyIds and funding(remaining:) cover the same keys as the access, expiry and limit; other statuses keep the whole basis. Funding still attaches only to the details of the read it was made for. Covered by testAnExpiredSheetReadsTheFundingOfTheConnectionItFollows and the funding assertions added to testAnExpiredRowsSheetTellsTheExpiryOfTheConnectionItFollows.

The merge conflict with the base is resolved in 61d5264.

romchornyi and others added 2 commits November 13, 2026 18:43
…recorded

ConnectionDetails is told from a basis since the sheet's access and funding
come from one identity read; a connection that ended has none. It gets its
own initializer that carries the recorded access with no basis and no
funding, and the view model builds a disconnected app's details with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A disconnect also marks an intent whose update was still in flight, so the
access recorded for a disconnected app may never have landed. Its sheet now
says "See what you allowed %@ to do" instead of "was able to do", which holds
whether the keys landed or not. The new key ships in English in every locale
until the Transifex pull.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base automatically changed from feat/dashconnect-redesign-history to develop November 13, 2026 18:03
…y' into fix/1293-bot-round

# Conflicts:
#	DashWallet/Sources/Models/DashConnect/DashConnectModels.swift
# Conflicts:
#	DashWallet/Sources/Models/DashConnect/DashConnectModels.swift
#	DashWallet/Sources/UI/DashConnect/Components/ConnectionSheet.swift
#	DashWallet/Sources/UI/DashConnect/ConnectionsScreen.swift
#	DashWallet/Sources/UI/DashConnect/ConnectionsViewModel.swift
#	DashWallet/ar.lproj/Localizable.strings
#	DashWallet/bg.lproj/Localizable.strings
#	DashWallet/ca.lproj/Localizable.strings
#	DashWallet/cs.lproj/Localizable.strings
#	DashWallet/da.lproj/Localizable.strings
#	DashWallet/de.lproj/Localizable.strings
#	DashWallet/el.lproj/Localizable.strings
#	DashWallet/en.lproj/Localizable.strings
#	DashWallet/eo.lproj/Localizable.strings
#	DashWallet/es.lproj/Localizable.strings
#	DashWallet/et.lproj/Localizable.strings
#	DashWallet/fa.lproj/Localizable.strings
#	DashWallet/fi.lproj/Localizable.strings
#	DashWallet/fil.lproj/Localizable.strings
#	DashWallet/fr.lproj/Localizable.strings
#	DashWallet/hr.lproj/Localizable.strings
#	DashWallet/hu.lproj/Localizable.strings
#	DashWallet/id.lproj/Localizable.strings
#	DashWallet/it.lproj/Localizable.strings
#	DashWallet/ja.lproj/Localizable.strings
#	DashWallet/ko.lproj/Localizable.strings
#	DashWallet/mk.lproj/Localizable.strings
#	DashWallet/ms.lproj/Localizable.strings
#	DashWallet/nb.lproj/Localizable.strings
#	DashWallet/nl.lproj/Localizable.strings
#	DashWallet/pl.lproj/Localizable.strings
#	DashWallet/pt.lproj/Localizable.strings
#	DashWallet/ro.lproj/Localizable.strings
#	DashWallet/ru.lproj/Localizable.strings
#	DashWallet/sk.lproj/Localizable.strings
#	DashWallet/sl.lproj/Localizable.strings
#	DashWallet/sl_SI.lproj/Localizable.strings
#	DashWallet/sq.lproj/Localizable.strings
#	DashWallet/sr.lproj/Localizable.strings
#	DashWallet/sv.lproj/Localizable.strings
#	DashWallet/th.lproj/Localizable.strings
#	DashWallet/tr.lproj/Localizable.strings
#	DashWallet/uk.lproj/Localizable.strings
#	DashWallet/vi.lproj/Localizable.strings
#	DashWallet/zh-Hans.lproj/Localizable.strings
#	DashWallet/zh-Hant-TW.lproj/Localizable.strings
#	DashWallet/zh.lproj/Localizable.strings
#	DashWallet/zh_TW.lproj/Localizable.strings
#	DashWalletTests/DashConnect/PlatformDashConnectDataSourceTests.swift

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final validation — Phase 1 + Phase 2

The exact head carries Platform-proved time through the expiry projection, routes expired rows to the Expired tab, and scopes expired-sheet access and funding to the followed connection; the former Core-time and scheduled-checker paths are absent. The available simulator tests, workflow lint, target-membership, accessibility, title, and CodeRabbit checks all succeeded; the remaining queued review check is not a code validation failure.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This is a cross-cutting behavioral change to DashConnect expiry classification, projections, view models, UI tabs, localization, and tests, but it does not modify funds movement, cryptography, key handling, consensus, peer-facing deserialization, or storage migrations.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Fresh final gate: an independent Phase-2 review ran after iterative findings were reconciled
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.

@romchornyi
romchornyi merged commit 385a52a into develop Nov 13, 2026
7 checks passed
llbartekll added a commit that referenced this pull request Nov 14, 2026
…-3ec86b

Localizable.strings: develop restored and added DashConnect keys (#1415,
#1289, #1293); the three new keys are re-inserted at their sorted positions
in develop's files.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants