Repository navigation
feat(dashpay): decode App Connect request v2 and seal its response - #1204
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
⏹️ Not reviewed — PR is closed (merged) (commit 85a1e1b) |
|
#1210 wires this decoder into the login flow. It's a PR into this branch covering the grant plan and clamping, owner checks, per-binding keys and the encryption key, one identity update with CONNECTION_ID supersession, the sealed response, the callback, and a draft approval sheet (presets, toggles and layout are your team's call). It's tested live on sakura with yap.pr/devnet and the Yappr iOS app. If you don't want it, just close it. 🤖 Posted autonomously by Claude on behalf of pasta. |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
Verified the supplied reviewer assessments against the complete base-to-head diff at 0f3afaa, the pinned Yappr codec and vectors, and the pinned Platform cryptographic interfaces; no actionable in-scope defects were confirmed. The v2 decoder and response sealer remain isolated from production v1 login callers, and the added source and tests have target membership. Validation was static only: current CI passes target-membership and accessibility checks, while DashWalletTests on simulator remains pending.
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); reviewer 3: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 4: gpt-6-astra (agent: phase2-reviewer, role: security-auditor); reviewer 5: gemini-3.8-flash-high (agent: phase1-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
criticalbygpt-6.1-sol(effort low) — The substantial protocol implementation includes intricate cryptographic changes in KeyExchangeCrypto.swift covering v2 HKDF derivation, AES-GCM associated data, and multi-key response sealing. - Phase 1 reviewers:
gemini-3.8-flash-high— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
gemini-3.8-flash-high— antigravity quota: weekly 71% left, 5h 100% left - Single stage: Phase 1 and Phase 2 reviewed this head side by side, with no blocker gate between them (triage tier)
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort xhigh); agentphase2-reviewer,gpt-6.1-sol— security-auditor (completed, effort xhigh); agentphase2-reviewer,gpt-6-astra— general (completed, effort xhigh); agentphase2-reviewer,gpt-6-astra— security-auditor (completed, effort xhigh); agentphase2-reviewer - Model comparison: every Phase-2 reviewer also ran on
gpt-6-astra; the verifier weighed both sets without knowing which model wrote which
llbartekll
left a comment
There was a problem hiding this comment.
Approving. The decoder and the response sealing are correct, and nothing in the app calls them yet, so this can't change login behaviour.
What I checked:
AppConnectRequest.decodeandparseAppConnectRequestagainst Yappr'srequest.tsonstaging, rule by rule, including where each refusal lands asunsupportedorinvalid. Apart from what Known gaps lists, the only difference is the mainnet rule below.KeyExchangeCryptoagainstcrypto.ts: salt, info, AAD and the 17-slot limit all match. The vectors in the tests are the ones invectors.json, which hasn't changed sinceddfb001.BindingKindtags againstContractBoundsin rs-dpp.- The callback check, outside the app: I ran about 154k generated URLs through
parseCallbackand compared the 827 it accepted with Node'sURL. The host was the same every time, no credentials got through, and nothing crashed. That ran on macOS Foundation, not iOS 18. - CI at
0f3afaadd: 1217 tests pass, the new ones included.
I didn't build this locally or run it on a device.
The format moved after this was written: dashpay/dips#181 and the profile (2026-10-28) make dashpay://connect the protocol carrier. None of this blocks the PR, but it's worth picking up with #1210 or right after:
n=mondash-key:should be refused (inline).- Requests the DIP allows but this wallet doesn't grant should become
unsupported(inline). dashpay://connectisn't parsed yet. Yappr already emits it on mainnet and offers both carriers on its testnet and devnet builds.- In Known gaps, "The profile sets no maximum" is out of date. The DIP now sets 1,024 bytes on every carrier, the same as
maxAppConnectPayloadLength.
Merge order: this targets the #1202 branch, so merging it first would add 1,174 lines to a PR that's already approved. Land #1202 first, then retarget this to develop. CI here is from 18 Oct, so it needs a fresh run after that. The protocol files haven't changed on the base since, and a test merge is clean.
| let version = parameters["v"].map { (1 ... 3).contains($0.utf8.count) && $0.utf8.allSatisfy { (0x30 ... 0x39).contains($0) } ? $0 : "(unreadable)" } | ||
| throw AppConnectRequestError.unsupported("URI version \(version ?? "(none)")") | ||
| } | ||
| guard let network = parameters["n"].flatMap(DashConnectNetwork.init(rawValue:)) else { |
There was a problem hiding this comment.
Not blocking: the DIP and Yappr's codec changed after this was written. dash-key: v2 is testnet and devnet only now, and a wallet must not accept it on mainnet; Yappr's parser refuses n=m at this point.
Mainnet can't reach this today because DashConnect is off there, but the check belongs in the parser so it doesn't depend on that gate. It's a guard network != .mainnet throwing .invalid, plus one test.
There was a problem hiding this comment.
Deferred to #1210: the parser there refuses n=m on dash-key: with a test, independent of the mainnet gate.
| } | ||
| // CRITICAL only on a contract group; HIGH on every kind. | ||
| let securityLevel = SecurityLevel(rawValue: bytes[1]) | ||
| if securityLevel == nil || (securityLevel == .critical && kind != .contractGroup) { |
There was a problem hiding this comment.
Not blocking, this matches Yappr's codec today. The DIP now allows CRITICAL on any binding kind and up to 8 ENC_BINDINGs, so a request over these limits is no longer malformed, just more than this wallet grants. The DIP asks for unsupported there, and the profile says wallets are expected to move to it.
This line and the count check at line 231 would change together once dashpay/dips#181 settles.
There was a problem hiding this comment.
Deferred to #1210: requests the DIP allows but this wallet does not grant will be refused as unsupported, together with the binding-count check, once dashpay/dips#181 settles.
The request v2 proposed in Yappr's App Connect profile names several keys (a contract group, a document type, a single contract, an encryption key) with a budget and an expiry each. This adds the parts that are fully specified and have published vectors; nothing reads them in the login flow yet, so a v2 QR is still refused. - AppConnectRequest: the body decoder (header, TLVs, bindings) and the request age check. `unsupported` and `invalid` follow the reference codec. - DashConnectUri.parseAppConnectRequest: the `dash-key:` v=2 URI and its `cb` return URL. - KeyExchangeCrypto: the v2 response key (HKDF info "app-connect:v2"), its associated data and the multi-key payload. Checked against vendor/platform-auth/src/app-connect/vectors.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e host A bracketed host passed the check and read back without its brackets, and IP addresses passed in every spelling. The host is now a plain DNS name in lowercase. Query values are form-decoded one sequence at a time, and the version in the unsupported error is echoed only when it is a short number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0f3afaa to
85a1e1b
Compare
develop now holds #1202 and #1204 (squash-merged). Conflicts: - .platform-ref: develop's 1721ca7a8b, which contains 063589bf0a. - SwiftDashSDKSPVCoordinator: develop's SPV start through SPVChainStoreRebuild. - PlatformDashConnectDataSource: document searches use the SDK's own off-main documentList as on develop; the app-side copies keep only the epoch read and the identity contract-keys read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The DIP defines `dash-key:` v2 for testnet and devnets only. The parser now refuses `n=m` itself, so the refusal does not rest on DashConnect being off on mainnet. Raised in review of #1204. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): a row held by a waiting record shows its grant, a landed update clears its history entry
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): funding only for confirmed grants, history cleared once the row is back
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): a waiting record keeps the keys the store gives it, and a disconnect checks its follow-up view
- A waiting record is dropped only when it holds no key by the store or
the view (AppConnect.heldKeyIds): its re-sent keys and its added keys
the store places count even when a lagging view omits them, unless
the view shows them off or under another key or the store has them
disabled; an added key live as added with no readable store record
counts as unknown. Used by the settle and the failed-submit path.
- A disconnect lets the row go with records still waiting only when its
follow-up view shows every auth key the store gives them
(AppConnect.showsWaitingKeys) and none of them is held.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): the funding limits info sheet is as tall as its text
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): a later own update settles nothing; a waiting record that holds a key gets a row back
- `pendingV2Outcome` no longer takes a later update of this wallet as
proof that a waiting one cannot land: the SDK's copy of the identity
can be reloaded while an update is on its way. A waiting record settles
only on its own keys, an id held by other data, or its encryption key
under another id. `outlivedBy` is only decoded; nothing notes it.
- A waiting record that holds a key a disconnect can turn off gets a
confirming row when the app has none offering a disconnect; a two-QR
row waiting for its second scan is remembered for the drop.
- Another identity's waiting record holds the row only while the store
shows it holding an auth key, so one whose update never left the device
does not block that app's disconnects elsewhere for good; nor does it
keep a disconnect from turning off the unattributed profile keys.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): a row a waiting record brings back keeps the app's name and its disconnected entry
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(dashconnect): Disconnect and Reconnect on each Connections row
Following the updated design, each row carries its action: Disconnect on
Active and Confirming rows, Reconnect on Disconnected and Expired ones.
A row's Disconnect opens the connection's sheet, which asks there, so
there is one disconnect question. The Expired sheet offers Reconnect,
with Disconnect under it: an expired connection's keys stay on Platform
until a disconnect, or a renewal of the same connection, turns them off.
What a disconnect does is read from the data source when the question is
asked (disconnectRevokesKeys), and again when it is confirmed: if it no
longer holds, nothing runs and the sheet says why. A scan is refused, with
a message, while something signs or an approval is on screen.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): an incomplete expiry check says so, and the sheet follows its wallet
- An expiry read that could not tell a listed app's expiry is not shown
as complete: the Expired tab keeps what an earlier read told and shows
"could not be checked" with Retry. An app whose recorded keys are all
off (`ConnectionExpiry.keysOff`) reads the same every time and does
not ask for a retry.
- When the rows republish with another wallet's row of the app a
connection sheet shows, the sheet closes, and its question with it.
- A connection's end date is not shown when one of its records has no
expiry noted.
- A disconnect's history entry is dated when the revocation ends.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): expiry checks keep to their wallet and the chain's time; disconnect history and keys-off are said
- The expiry read returns the wallet it was read for. A read of another
wallet than the rows shown is not applied, the rows switching wallet
drop the expiries, and an earlier Expired is carried over an
incomplete read only for a row unchanged since (no renewal). A listed
active app with no answer makes the check incomplete.
- An app counts as expired only once both the phone's clock and the
time of the last Core block SPV has synced are past its keys' expiry;
until then, or without a chain time, it is not told.
- An app whose recorded keys are all off shows "Keys turned off".
- A disconnect whose app could not be saved among the disconnected apps
says so, on the page once a closing sheet has gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(dashpay): take the connection expiry check out of the Connections page
The Expired tab, the expiry read from Platform and its chain time, and the
keys-off status move to a pull request of their own. The connection sheet
shows the date the keys expire under a neutral label.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(dashpay): take the disconnected-apps history out of the Connections page
The Disconnected tab, the history store, its writers and its clearing on a
wallet wipe, and Reconnect move to a pull request of their own. The page is
one list of the connected apps; a disconnect closes its sheet once it has
ended.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): a disconnect does what its question said; grant receipts note only the keys sent
- A disconnect's question has three answers: its keys are turned off,
only its local status changes, or either as Platform shows (a two-QR row
with a grant). The data source holds the disconnect to the answer the
user confirmed: before the revocation in turn, and again once the
identity is read, before anything is turned off.
- A v2 grant record notes message access only when its response carries
an encryption key; a retry sealed again notes it again.
- Only the latest read of the connection sheet's details is shown: one
started before the sheet closed, opened again or read again is dropped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): a two-QR row's disconnect question does not promise a revocation
The question is told from the wallet's records alone, which do not say
which records are the active identity's: only a one-QR row is sure to turn
its keys off. A two-QR row with a grant depends on what the identity shows,
and its early two-QR return is held to the answer too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): one rule decides whether a disconnect is what its question said
A disconnect is held to its question by one rule, `accepts`, applied to
the effect the records give before the PIN prompt and to the one the
identity gives after its read. The data-source tests send the answer the
screen would have asked.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): a retried grant keeps its first terms; the disconnect check is one rule in one place
- A grant record keeps the keys and terms its first attempt noted: a retry
registers those keys. Its message access follows the slots sent.
- `DashConnectDisconnectEffect.accepts` is the rule the sheet's confirm and
the disconnect's turn both apply; the turn checks it before the PIN
prompt, and refuses when the row is gone.
- A refused disconnect says the question changed, without "Could not
disconnect".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): the Connections page waits for its rows; one decision for a disconnect's effect
- Until the rows are delivered the page shows progress, not the empty
state.
- `disconnectEffect` alone tells what a disconnect does from the records;
the refusal of one whose row is gone says the connection changed.
- Leftovers of the removed disconnected-app sheet are gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): a disconnect of a gone row says so; a session key's record stays one
A row gone before the disconnect's turn throws its own error, so the sheet
says the connection changed without guessing from the published rows. A
refused disconnect leaves the sheet up and its Disconnect asks again.
GrantedAccess.noted keeps isSessionKeyLogin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): the Connections page follows every write to its rows
The connection store announces each save, and a data source republishes
its wallet's rows on it, so a row another data source over the same rows
removed (a page opened again while an earlier one's operation runs)
leaves the page, and its sheet closes with the reason on the page. The
mock refuses a row it does not list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(dashpay): the disconnected-apps history on the Connections page
Brings back the Disconnected tab, the history store and its writers, the
sheet of a disconnected app and Reconnect, taken out of the page's first
pull request, on top of its fixes: the disconnect question's three
answers, the details read numbering and the store's save notice.
This reverts commit 5032ebfaa98dfa101f14d77f20269c6bf91fe4ec.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): a two-QR connection disconnected on this device is listed as disconnected
The local-only disconnect left the row approved, which reads as waiting for
the second code, with no Disconnect, no disconnect date and no Reconnect.
It now records the app among the disconnected ones and drops its row, as a
one-QR disconnect does; approving the same dash-key QR again makes a new
row, active while its keys are still registered. The data source tests
keep their history in the test suite's defaults.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): the Connections page's rows and disconnected apps come in one value, under their wallet
The data source publishes a DashConnectListing: the active wallet's rows,
its disconnected apps and the scope they are of. Every sheet item carries
that scope, so the one check that closes the sheet of another wallet's row
covers a disconnected app too, including a switch between two wallets
with no rows. The view model reads no history of its own, and the screen
no longer refreshes on appear. A disconnect publishes the row gone and the
app disconnected in one value; an approval publishes the row back and the
entry forgotten. A disconnected app's sheet reads its entry again when it
is recorded again.
A two-QR disconnect that cannot be recorded among the disconnected apps
says so, as a one-QR one does. An app's entry is forgotten only while it
has a row, and a row that comes back takes the entry's name and website.
The history store's unused save is gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(dashpay): the Connections page's expiry check and Expired tab
While the Connections page is on screen, the data source's expiry check
reads the active identity's keys and judges whether each active row's app
can still sign. A key is the app's when a confirmed record names it or the
store shows it bound to the app's contract; only keys that can sign are
judged. An app is expired once the phone's clock and the Core tip, by
Core's future-block margin, are past every live key's expiry; past by the
phone alone it stays active and its sheet says so. An app with live keys
that cannot sign, beside a live authentication key that cannot be matched
to an app, is undecided, which the sheet says plainly.
When to read, judge again and wait is one reducer
(ConnectionExpiryMachine) run by ConnectionExpiryChecker; the data source
tells it the rows, the identity, the page, the SDK manager and the Core
tip, the view model tells it the app came back to the foreground, and the
data source maps its read errors. The verdicts are published with the
rows, each for a row of the generation the read was made for: a wallet or
an identity change drops them, and a changed row has none until it is
read again. With no active row nothing is read. A page that appears, or an
app that comes back, moments after a read judges that read again; later it
reads anew. A clock reaching a time that can change a verdict judges the
keys already read, the latest Core tip seen counts while the SDK has none,
and waits count the time the device sleeps. Leaving the page cancels a
read, which is made when it is back. A runtime or an identity that is not
ready yet is tried again after short waits, then shown as a failed check
with Retry; a network with no identity to read says the check could not be
made, without Retry. The page gets an Expired tab with Reconnect and
Disconnect, which says "none" only when every active row was told.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): expiry is decided by the Core tip alone; a cancelled expiry read reads nothing
A key is expired once the Core tip is past its expiry by Core's
future-block margin, whatever the phone's clock says: the tip already
shows real time has passed, so a clock set back takes back no expiry. An
expiry past Int64.max is far in the future and never expired. The phone's
clock only tells an app past expiry while the tip does not show it yet,
and when to judge again. A stray key holds an app back unless the tip
shows it expired. A read from the phone's future is not fresh. A
cancelled expiry read stops before the operation gate and again once its
turn comes, without loading the identity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): an unrecorded live profile key leaves an app past expiry undecided
A key bound to DashPay `profile` names no app: every app can be given one.
With no record naming it, the expiry check now counts it as a key whose app
cannot be told, as the disconnect already does, instead of as attributed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): settle a waiting App Connect v2 update by the revision it was submitted at
An identity update notes the revision it is submitted at (read before the
submit, raised after a failed one; a retry never lowers it), for v1 session
key registrations and v2 updates alike. A waiting v2 update whose key is
absent from an identity at that revision or past it can no longer land, and
its record is settled instead of lingering.
Platform applies an identity update only at one above the identity's
revision, so an earlier waiting update cannot land after a later update of
this wallet did: the renewal and the disconnect no longer turn keys off
after their own update. A waiting update the read after the update shows
landed keeps the disconnect's row, and is logged after a renewal.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(dashconnect): derive App Connect rows from the identity and a recorded intent
Replace the App Connect grant lifecycle with a projection: one identity
snapshot plus the intents this wallet recorded before each update give every
row, status and unrecorded key. An intent is written before the identity
update is submitted and is closed, not deleted, when it is done.
- v2 only: a v1 dash-key login is refused at protocol version 14.
- Disconnect adds a wallet-owned fence key at each id an unlanded intent
would take, so a late update can no longer land, then disables it.
- A read behind the newest revision seen throws instead of overwriting state.
- Keys this wallet did not record are turned off only on an explicit confirm.
- Two-QR login keys are never offered for turning off.
- New "Confirming" status for an approval whose update may still land.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(dashconnect): remove the two-QR login and close review findings
The two-QR (App Connect v1) login never reached a store release, only
internal TestFlight builds. It is removed entirely: a v1 dash-key QR is
refused when scanned, a dash-st payload is taken only as a token purchase,
and the approved status, the scan-to-complete banner, the v1 key derivation
and sealing, the key-registration parser and the devnet login contract
setting go with it.
Review fixes:
- An intent counts as landed only once the keys it turns off are off too;
the outstanding disables are submitted on their own when the keys show.
- A retry is refused when an encryption key the response carries is off,
and when the encryption slots approved now differ from the recorded ones.
- DashPay profile keys no intent names are offered, on confirm, with the
disconnect of an app given profile access or with no record on that
identity, so they stay reachable after a restore.
- An unrecorded key on a contract several apps bind shows under each of
them, and the disconnect of any of them turns it off on confirm.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): keep live keys of a conflicting intent actionable and gate raised limits
- An intent keeps an actionable status while any of its auth keys is
enabled, even when another of its ids is held by a different key: a live
key makes it active, an expired one that is still enabled makes it
expired. Such an intent is never resumed and gets no fence; it counts as
never landed only once none of its auth keys is enabled.
- Before the sealed response is published, the auth keys that were already
on the identity (an earlier try, another device) must hold no more than
the plan approved now: no larger budget cap, no later expiry.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): bind retries to their connection and recheck keys before publishing
- A retry carries on only for the same connection id; another
connection's intent is never resumed, and the app has to ask again.
- Right before the sealed response is published the identity is read
again: no encryption key it carries may be off, and the auth keys that
were already there may hold no more than the plan approved now.
- DashPay profile keys no intent names are offered, on confirm, with the
disconnect of any app: no record proves which app was given one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): publish a response only while its keys are current and usable
- Every encryption key a sealed response carries must be the key Platform
names current for the app and purpose; a key the intent still has to
register needs no current key yet, or that very key. This is checked on
a retry before an update that still has to be sent, and before
publishing on an identity read that shows the update, with reads a few
seconds apart for a node that is behind.
- A retry, and the publication, are refused while any auth key of the
intent is off or expired.
- A DashPay profile key no intent names stands as a connection of its own,
so it can be turned off when no app row is left.
- A disconnect reports the identity as out of date while any key it turned
off still shows on.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): read the app's current encryption key one way
Another key current, or the response's own key off, refuses at once,
whatever a later read says, since that read may come from a node that is
behind. No key current yet for one the identity already shows is read
again; a key one read showed current stays so, and one that never shows
current is out of date rather than changed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(dashconnect): answer a request at most once; show undelivered connections
A request is answered at most once, by any identity of the wallet. Once an
approval's intent is recorded, any failure of its update, of the checks
before publishing, or of the publish spends the request: the sheet shows
why, offers no Approve, the app is told the request failed, and it asks
again with a new code. A sealed response is never published by a later
attempt, since the wallet cannot prove that what it was sealed for still
holds. The retry machinery goes with it (the recorded approved slots, the
plan comparison, resumption).
A connection whose keys are live but whose response was never published
shows as "Not delivered", with Disconnect. A response that landed without
confirming is looked up on Platform when the same request is approved
again and when Connections refreshes, so a working connection is not shown
as undelivered. Superseded grants of the connection are settled whether the
approval succeeded or not.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): check the read that showed the update before publishing
When the identity update does not confirm and a re-read shows it landed,
that read is the one the checks before publishing run on (limits, keys
off, current encryption keys). A later read may come from a node that is
behind and show less, so what the landing read saw stands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): keep a scan button and access seen on other identities
- The Connections list has a Scan QR button in the navigation bar when it
is not empty, so a new code can be scanned after a request is spent.
- A row records the identities whose last read showed the app keys no
approval names. A read of another identity leaves that knowledge alone,
so the row stays, shown as active, until that identity is read again. A
disconnect finishes on the active identity and says that keys are left on
another one, which has to be made active to turn them off.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): tell an answered request by its whole body
A parsed App Connect request carries a SHA-256 of its bytes, and the intent
records it. Approving a request again counts as already answered only when
that digest matches: a request that reuses the key but differs in anything
else (connection, bindings, budgets, expiries) is refused as spent.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): refuse every repeat approval of a request
A request is answered at most once, so a request this wallet already took,
on any identity, is shown as spent on the sheet, before any PIN, and is
refused if approved anyway. The shortcut that reported an answered request
as approved again goes, and with it the request digest it needed. Before a
response is published the wallet waits for a read that shows the whole
update, the earlier keys it turns off included.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): derive an App Connect encryption key at DIP-13 rotation 0
develop's platform pin (1721ca7a8b, with platform#5649) adds the rotation
level to application encryption keys and requires it. A v2 login derives
the first pair; later rotations and the keys from before the level are
#1258's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): refuse an App Connect request v2 for mainnet in the parser
The DIP defines `dash-key:` v2 for testnet and devnets only. The parser
now refuses `n=m` itself, so the refusal does not rest on DashConnect
being off on mainnet. Raised in review of #1204.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs: record ADR-0009 for answering App Connect request v2
The decision this PR makes: a v2 request is answered with keys the
wallet derives, under limits the wallet enforces, in one identity update
the wallet signs. ADR-0009 (Proposed) with its index row, and the
app-connect feature summary extended with request v2.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): key the sheet's permission rows by position
Two rows can read the same (two encryption keys for one app), and
`ForEach(id: \.self)` needs unique ids. Also drops the stale claim that
nothing in the login flow reads `AppConnectRequest`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): bound the dash-key query before it is split or decoded
The v2 router, the v2 parser and the v1/st envelope now refuse a query
longer than 4 KiB before splitting it into parameters or form-decoding
them. The body and callback ceilings applied only after that work, and
a link routed to v1 was not bounded at all.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): tell the app when its request is refused at Approve
A refusal at Approve marks the login refused, and closing the sheet
then skipped the callback the sheet had already shown, leaving a
link-delivered app waiting. The callback now opens with the stored
status (stale, invalid, unsupported, failed) as well.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): leave the encryption slot out behind a disabled current key
Under the `latest` rule, a disabled current key of another wallet's
made the slot count as empty, so a login registered a new encryption
key and replaced the contract's current key. That is a rotation, which
is the user's explicit action and never part of a login: the slot is
now left out, waiting on a later read when a live key may be newer.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): warn, not refuse, when a known app's request returns elsewhere
The wallet's brand map refused a request for a known app whose callback
was not on the app's website. The map only names an app and must not
change which requests are accepted (dips#181, App Identity): such a
request is now accepted, and the sheet warns that it would return to a
host that is not the app's website, as it already warns for an unknown
app or a known app's request without a callback.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): refuse, not retry, a request that names an absent contract
A v2 request asking for a key on a contract the network proves absent
let the not-found error escape the owner lookup, so the sheet offered
"Try again" for a request that can never pass. The lookup now reads such
a contract as having no owner, and the request gets the existing refusal
for a contract the app does not own, as an absent contract group already
did. Any other failure to read still leaves the request unresolved.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): refuse a v2 request for an absent app contract or document type
A v2 request whose app contract the network proves absent let the
not-found error escape preflight, so the sheet offered "Try again" for a
request that can never pass; it is now refused. A document-type binding
was checked only for the contract's owner, so a type the contract does
not define reached an approvable sheet and failed only when Platform
rejected the identity update; preflight now keeps the contracts it read,
the app's own included, and refuses a type the contract does not define.
A contract whose document types this build cannot read asks for an
update instead. Other read failures still leave the request unresolved.
The preflight now takes its contract and group reads as closures, so the
tests drive the whole path.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): refuse a v2 app owned like a system contract
The system contract list missed DecisionProposals and TokenMarket, both
registered from protocol 15 at the platform pin. A request naming one as
its app, with a binding on it, passed the owner checks the way the DPNS
test describes.
Both ids are listed now, and an app whose contract has the all-zero
owner every system contract has is refused as well, so a system contract
added later is caught without updating the list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(dashconnect): drop the session-key terms from the refusal-at-Approve test
The test came with #1210's merge; this branch removed the terms argument
of the consent helper along with the session-key terms.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(dashpay): redesign the Connections page and add a connection sheet
The redesign of #1277, built on #1301's model instead of #1272's grant
records:
- Each connected app is one row with a Disconnect button; the row opens
the connection's sheet, Disconnect opens it asking at once. The status
badge goes: the sheet shows Active, Confirming or Not delivered.
- The connection sheet shows the app, its App ID, the identity and
username, when it was connected, the funding limit and when its keys
expire, what is left of each key's budget (read from Platform), and
what the app can and cannot do. All of it comes from the active
identity's intents for the app (`ConnectionDetails`, `ConnectionAccess`,
`KeyFunding`); an intent now also notes which of its groups had
administrators (`administeredGroupIds`, optional so older intents read).
- Disconnect asks one question: every row's keys are turned off. Keys no
approval of this wallet names are still asked about separately after
it, on the page once the sheet has gone.
- The approval sheet and the connection sheet share the permission lines
(`DashConnectPermissionText`); "What are identity funding limits?"
explains the funding limit.
- The page follows every save of its rows, by any data source over the
same store (`UserDefaultsDashConnectStore.didSaveNotification`).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(dashpay): list disconnected apps on the Connections page
The disconnected-apps history of #1289, on #1301's model:
- The page has two tabs, Active and Disconnected. A disconnected app is
listed while it has no row; its sheet shows what it was given and when
it was disconnected, and Reconnect opens the scanner for the app's new
code.
- The data source publishes the rows and the disconnected apps in one
value (`DashConnectListing`). A disconnect whose app has no row left
records the app, with its details read before its intents closed; one
that could not be recorded is said. An approval whose update landed
forgets the app.
- Deleting a wallet clears its disconnected apps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(dashpay): list expired connections on the Connections page
The expiry check of #1293, through #1301's projection instead of a
checker of its own:
- Until the app reads Platform's block time (dashpay/platform#5715), the
identity snapshot takes a time Platform is known to be past: the Core
tip SPV synced, less 2 h 70 min, how far a header can be ahead of real
time (`AppConnect.platformTimeLowerBound`). The projection's `expired`
status then holds once every live key is past its expiry by it.
- A row whose keys are all expired so is `ConnectionStatus.expired`, and
is listed under a new Expired tab. Its sheet says Expired, lists what
the app was able to do, and offers Reconnect and Disconnect: the keys
stay on Platform until a disconnect turns them off.
- The status is judged on each read of the identity, which the page makes
when it appears.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(dashpay): DashConnect connection states from Platform and a disconnect that leaves nothing behind
Connections show Active, Confirming, Not delivered, Refused, Expired and
Disconnected, worked out from what Platform shows now plus the wallet's
record, through one state-to-actions table. A request's age and a
connection's expiry are judged by the proved block time. A request any
device already answered is refused before the PIN. dash-key codes are
refused on mainnet.
A disconnect turns off every key recorded for the app, every live key
bound to its contracts that no record names, and DashPay profile keys no
connection accounts for, without a further question, and fences a
sign-in that may still land. Every Platform write goes through one
executor that re-reads Platform after an error or a timeout; a run that
stops part-way keeps the row and says what is still live. A wallet wipe
clears the DashConnect stores.
UI here is only what the model needs: the status badge and the row read
the table (Remove on a Refused row), and the unrecorded-keys question is
gone. The approve sheet, pickers and the Connections redesign come with
the redesign stack on top.
SDD-Published-From: 407822fd0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): resolve the catalog conflict the Disconnected merge left in
The merge left conflict markers in the 43 Localizable.strings. They keep "Disconnected (connection status)" and drop the two texts of the removed history store.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(dashpay): leave the approve sheet's terms to the redesigned sheet
The funding limit and expiry model of the earlier approve sheet (the
ranges, presets, custom checks and the key shares of `applying`), the
sheet's facts read and the data source's protocol version read had no
caller here once that sheet moved out: the redesigned approve sheet on
top of this stack (#1278) has its own terms model. Their tests go with
them. The grant plan keeps the request's limits, as before this change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* ci: stub DashConnectStores in the Core drain recovery harness
The wallet deletion it compiles now clears the wallet's DashConnect stores (AC-19); the harness stubs that edge as it does the other per-wallet stores.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs: record ADR-0015 to 0022 for DashConnect connection states and disconnect
The decisions #1334 makes, Proposed until a reviewer who is not their author approves: fence a pending sign-in, unrecorded keys off without asking, a request answered at most once, one write executor, one state table, Platform block time, Refused on the intent, disconnected apps from intents. Index and the app-connect summary updated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs(dashconnect): give the wallet's own gate as the reason a mainnet v2 request is refused
The parser refuses request v2 for mainnet on both carriers, as ADR-0009
records. The comment, the error text and a test comment gave the DIP as
the reason, but the DIP allows dashpay://connect on mainnet and forbids
only dash-key: there. They now say it is not enabled on mainnet yet
(ADR-0009). The doc comment of MainTabbarController.openDashConnect also
names the dashpay://connect link it handles.
Behaviour is unchanged. Follow-up to review on #1257.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): DashConnect unrecorded-only connections by Platform time, a DashPay row when nothing else can be disconnected
A connection made only of keys no intent names is Active while one of
them is live at Platform's proved time, else Expired; its keys stay in
the disconnect plan. DashPay profile keys no connection accounts for
stand as a DashPay row of their own on an identity with no connection
to disconnect, so they can always be turned off. The doc of
keysTurnedOff now says fenced key ids count.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): DashConnect connection sheet ignores a stale dismissal timeout and rereads its details on every rows update
The real dismissal and every new sheet move the dismissal number on,
so an earlier close's one-second fallback no longer marks a later
sheet gone. An open sheet reads its details again whenever the rows
are published, since another approval of the same app leaves the row
unchanged; a failed re-read keeps what the sheet shows.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(dashpay): read the sheet tests' row from the Active tab
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs(adr): record #1301's App Connect decisions (0027–0030)
The intent projection, v2 only, a new approval while another is
confirming, and the Not delivered row, as Proposed ADRs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): disable the app's keys after the profile keys, and record the policy as ADR-0031
- A disconnect disables the unattributed DashPay profile keys before the
app's own keys (`AppConnect.disableOrder`). A failure part way through
the batches now leaves an app key live while a profile key is, so the
retry of a disconnect with no grant record still reaches the profile
keys left instead of removing the row with one still on.
- The disconnect's comment no longer claims that a live key with an
unreadable bound leaves the profile keys unchecked: that key stops the
whole disconnect earlier (`sessionKeyIdsWithUnknownBinding`).
- ADR-0031 (Proposed) records the policy of turning off unattributed
profile keys with any disconnect, and the removal of Keep.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* docs(dashpay): describe the encryption key rules in ADR-0009 and the rule-2 test
ADR-0009's Keys bullet now states the rotation search, the earlier path
derived on testnet and devnet only, and DIP rules 1-3; the forward
reference to this change is removed. The rule-2 test's doc comment says
what it checks: the behaviour came in with #1210.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): disable the app's keys after the other keys on disconnect
Carries #1263's ADR-0031 order into the projection's disconnect: the
DashPay profile keys no intent names and any fence left on are disabled
before the app's own keys (`AppConnect.disableOrder`). An update that fails
part way then leaves an app key live while another key is, so the app's
row stays and its retry reaches the keys left. The merge of #1263 dropped
the base's version, which sorted the grant-record plan.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* test(dashconnect): a disconnect plan lists the profile keys before the app's keys
The merge of #1301 brings ADR-0031's order (`AppConnect.disableOrder`) into
the plan that turns off profile keys without asking.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): retry a failed response delete on the next signed operation
A disconnect whose response delete fails closes the intent with
`responseRemoved` false, and its row goes, so no disconnect of the app
reaches that response again. The next disconnect or approval on the
identity, with the PIN given, now deletes the responses of every closed
intent still marked (`AppConnect.responsesLeft`).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): an update is not landed while a key's bound is unknown
A key whose contract bound the store does not hold yet may be bound to
another contract, so `hasLanded` no longer takes it as this update's and
the response with its secret is not published until the bound is read.
The row still counts the key as live.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): retry left response deletes on every signed disconnect
The retry of responses an earlier disconnect could not delete ran only
when the app being disconnected had a response of its own. It now runs
on any disconnect that signs something.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): keep the row while a disconnect leaves keys of unknown bound
A disconnect that finds keys whose bound the key store does not hold yet
cannot tell whether they are the app's. The app's newest intent now stays
open, so its row keeps Disconnect, until a read places every key; a
refresh with none left closes it and the row goes. The message says the
connection stays listed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): keep every row while a key's bound is unknown
The previous fix kept a row only through the app's newest intent left open
as Disconnected, which missed an intent that read Never landed after its
fence and a row with no intent at all. Now the rows themselves carry it:
while the read has a key whose bound the key store does not hold, no row
goes, so each keeps its Disconnect until a read places every key. A
disconnect closes its intents as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashconnect): a disconnect also turns off the app's keys on its owner's other contracts
A disconnect of an App Connect app reads the owners of the contracts and
contract groups its unrecorded keys are bound to, and turns off the keys on
the app owner's other bindings (#1346). Connections shows them under the app.
A key whose owner cannot be read, or that another connected app of the same
owner may hold, stays on its own row and the result says so; the disconnect
never reports no access left in that case (ADR-0032, ADR-0033).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SDD-Published-From: d87d3085b57c9f27c4b18c91f428ba098e933250
* docs(adr): drop the private feature-record links from ADR-0032 and ADR-0033
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SDD-Published-From: 7e2731702728501fed49de40bcc3eb2866d15c47
* docs(adr): ADR-0033 is superseded by ADR-0016 on this branch
A disconnect here asks no question about unrecorded keys (ADR-0016), so
there is no listed set to keep it to.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): bind offered keys to their identity and report what stays on from the read after the update
A key id is unique only within an identity: the keys a disconnect offers now
travel with the identity they were read on, and a disconnect with listed keys
is refused while another identity is active, before the PIN and after it.
What stays on is told from the read after the update, the one the rows are
refreshed from, so a key that landed during the update is reported (AC-08).
ADR-0032 and ADR-0033 link the PR and issue instead of private records.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SDD-Published-From: b99b438876fd3b3beab6997c16ba9035e7e3804f
* fix(dashconnect): a disconnect also turns off the app's keys on its owner's other contracts
A disconnect of an App Connect app reads the owners of the contracts and
contract groups its unrecorded keys are bound to, and turns off the keys on
the app owner's other bindings (#1346). Connections shows them under the app.
A key whose owner cannot be read, or that another connected app of the same
owner may hold, stays on its own row and the result says so; the disconnect
never reports no access left in that case (ADR-0032, ADR-0033).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SDD-Published-From: d87d3085b57c9f27c4b18c91f428ba098e933250
* docs(adr): drop the private feature-record links from ADR-0032 and ADR-0033
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SDD-Published-From: 7e2731702728501fed49de40bcc3eb2866d15c47
* fix(dashpay): bind offered keys to their identity and report what stays on from the read after the update
A key id is unique only within an identity: the keys a disconnect offers now
travel with the identity they were read on, and a disconnect with listed keys
is refused while another identity is active, before the PIN and after it.
What stays on is told from the read after the update, the one the rows are
refreshed from, so a key that landed during the update is reported (AC-08).
ADR-0032 and ADR-0033 link the PR and issue instead of private records.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SDD-Published-From: b99b438876fd3b3beab6997c16ba9035e7e3804f
* fix(dashpay): date granted App Connect keys by Platform time and refuse a keys read with lower limits
- The default and the longest expiry of a granted key are now counted from
the proved block time, like the request's age, never from the phone's
clock; `grantPlan` no longer takes a clock. The sum is checked and caps at
the largest time.
- A proved keys read that shows a lower budget or an earlier expiry than the
wallet's copy is behind it: Platform only raises a key's limits, without a
new identity revision, so the revision check cannot tell.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): settle a disconnect's rows and result on one owner read
After a disconnect the Connections rows and what the result says stays on
were worked out from two owner reads. A failed read is tried again, so the
rows could give a sibling-contract key its own row while the result told
the user to disconnect the app again, with no row left to do it from; and
an unchanged identity reused the plan from before the PIN. Both now come
from one read of the owners on the read after the update
(settledDisconnect), on every path.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): keep an App Connect row while another identity still has access
A disconnect on one identity closes that identity's intent, and the row
then showed Disconnected even when another identity of the wallet still
held the app (its open intents, or live keys its last read saw), so the
row lost its Disconnect. The row now keeps its status and that access
until the other identity's own read; with no access elsewhere it shows
Disconnected as before. Fixes #1373.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): report every key a confirmed disconnect leaves on, under the row that shows it
After the user answered the question, the result left out a listed key
that stayed on because its owner could not be read when the update was
planned. Every offered key still on after settlement is now reported as
left on. When the disconnected row is gone after settlement and another
app's row shows those keys, the message names that row instead of asking
for a second disconnect of the app.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): keep a key's raised limits across reads and DashConnect records through a failed wipe
A read of the same identity revision with a key's limits from before a
raise replaced the read that showed the raise: Platform raises a key's
budget or expiry without a new revision, and the proved keys fetch never
updates the wallet's copy that reads are held against. A read now replaces
the newest one seen only when no key of it is missing, on again, or below
its budget or expiry.
The full wipe goes on after another devnet scope's deletion fails, and
its deletion of the configured scope removed the wallet's DashConnect
records, which serve every scope. It now leaves them to the wipe's commit
point, which removes them only once every deletion succeeded.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): send the user to the row whose disconnect offers every key left on
A disconnect's result named the first row showing any key left on. Those
keys can show under several rows (a DashPay profile key under DashPay's),
so the result could send the user to a row whose disconnect leaves the
app's keys on. The row named now shows every key left on but the profile
ones, which every disconnect offers.
Closes the review thread on the retry destination (r4543058630); the
settlement refactor the review suggested is tracked in #1379.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SDD-Published-From: d18dd27c453eca937b611e97abdd94c32ee9ad84
* fix(dashpay): remember contract owners per devnet name and endpoint
The process-wide owner memory was keyed by the bare network name, which is
"devnet" for every devnet. After a switch between devnets in one run, an
owner read on the old one could attribute a key on the new one, and turn it
off after the question. Owners are now remembered per persistence scope
(which names the devnet) and endpoint, as the connection stores are.
Closes the review thread on the owner-cache scope (r4544440023).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SDD-Published-From: 7447832b2c4c4887ff32204877b2783346cdb4f4
* fix(dashpay): admit an identity read atomically, keep the later block time, and hold for a key of unknown bound that lands
Two reads at once could both pass against the same newest read, since the
check and the store took the lock apart: they are now one step. A read
whose proof is older than one already seen kept its own block time, so a
key already seen expired could show live again; an admitted read now keeps
the later block time, and only a raised expiry makes such a key live.
A disconnect decided whether to keep the app's intent open, and whether
it finished, from the keys of unknown bound in the read before the update.
A key of unknown bound that landed during the update closed the intent and
left the row Disconnected with no Disconnect. Both now use the read after
the update, and the plan's read only when that read failed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): keep a renewed app's row while a key's bound is unknown, and count a key under a fenced id once
An app whose intents here were all closed and that was renewed through
keys no intent names showed Disconnected, with no Disconnect, after a
disconnect whose read had a key of unknown bound: no open intent was there
to hold. Such a row now stays Confirming, with its Disconnect, until a read
places every key.
A sign-in that beat its fence was counted twice as a key still on: once
under the fenced id and again as a key the read after the update found.
The keys found after the update now leave out the ids the plan fenced.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): the connection sheet shows what the keys on Platform give
The connection sheet built an app's access from every key of an intent that
still had a live key, with the terms the wallet submitted. It now reads the
keys on the identity: a disabled key, or one whose id another key holds,
gives nothing (no "Edit your DashPay profile" for a disabled profile key, no
funding line for it); a key that landed shows the budget and expiry Platform
holds now, which an authorized limits update may have raised; a key not
there yet shows its submitted terms while its intent may still land.
"Maximum of" is the sum of the keys' budgets: Platform counts each key's
budget apart, so that is the most the app can spend. A details read that
fails is unknown, so the sheet says so instead of showing the app's id
alone. The approve sheet says an app may receive messages: whether it gets
a key for them is known only once the approval reads the identity's
current key.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): say what a disconnect turned off beyond the app's record, and tell a failed username read from no username
- A disconnect that turned off keys no approval in this wallet names says how many, and a disconnect that left keys on is shown under a neutral "Disconnected" title instead of "Success".
- A token purchase whose DPNS username read failed, with no stored name, says the name could not be checked instead of asking to create one.
- Code comments cite the ADRs this change records (0018, 0019, 0021); the app-connect README describes disconnect as it now runs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): read key budgets off the main actor and count the app's unrecorded keys on its sheet
The connection sheet read what is left of the keys' budgets through the
SDK's main-actor query, whose FFI call blocks on the network: the UI waited
for the DAPI round trip each time a sheet opened or refreshed. It now runs
on a queue of its own (DashConnectPlatformQueries.keysRemainingBudgets),
as the epoch and contract-key reads already do.
The sheet built the app's access from its intents alone, while its row and
its disconnect also hold the keys the projection gives the app that no
intent names (another device's, or attributed by owner). Those keys now
count too, with Platform's limits: a key with no budget makes the app
unlimited, and one with no expiry leaves the connection with no end date
("with no end date" in its line). A row of such keys only gets a sheet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): a sheet's disconnect runs only while its row still offers one
The connection sheet keeps its disconnect confirmation across row updates,
but the question and the confirmation checked only that a row was still
shown. A row that turned Refused or Disconnected while the sheet asked
still ran a disconnect the state table no longer offers. Both now check the
row's current actions (StateActions) and say why nothing ran otherwise.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* refactor(dashpay): the connection sheet no longer claims what an app can spend or do
The connection sheet showed the app's funding limit, what is left of each
key's budget, when the connection ends, and what the app may do, all built
from the wallet's records and an identity read that may be missing or
behind. Those claims move to their own pull request, where they get the
per-key Platform-backed state they need. This sheet keeps the status, the
app and identity, when the connection was made, what an app is never given,
and its actions.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat(dashpay): the connection sheet shows what an app can spend and do
Brings back to the connection sheet what #1277 left out: the app's funding
limit (the sum of its keys' budgets), what is left of each key's budget,
when the connection ends, and what the app may do. They are built per key
from the identity read: a disabled or taken key gives nothing, a key that
landed shows Platform's current limits, a key not there yet shows its
submitted terms while its intent may still land, and keys the projection
gives the app that no intent names count too. What is left of the budgets
is read off the main actor.
This reverts commit 9d6f34980.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): a connection sheet with no identity read claims no access
Without a read of the identity, the sheet built the app's access from every
open intent, refused ones included, and showed the limits they submitted as
if they had landed. ConnectionAccess now needs a read: with none, the sheet
shows no access, funding or expiry.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): a sheet shows the identity of a row of unrecorded keys, and says when a refresh failed
A row the projection makes from keys no intent names (a restore, another
device's grant, the profile keys) has no intent on the identity, so its
sheet took it for another identity's and showed no identity or username.
It now asks the projection, with the owners known, whether those keys are
on the active identity; the date the connection was made stays unknown.
A refresh of a sheet's details that failed kept the details shown and said
nothing. It still keeps them, and now says they could not be read again
and may be out of date.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): the sheet's message access, funding lines and group warnings follow the keys on Platform
- Message access needs the intent's encryption keys still usable on the
identity read (encryptionKeysUsable): a disabled or no longer live key no
longer reads as "receive messages".
- Funding lines are chosen key by key from the held intents: a live key
keeps its line when another key of its intent never landed.
- An unrecorded key on a contract group gives the administrators' warning
when the group may have them: its owner read as administered, or not
read (unknown is not said to be absent).
- A key with no expiry cannot reach the sheet (the projection lists only
keys with one), so its "no end date" wording is gone.
- The off-main budget query's TODO names dashpay/platform#5867.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): the sheet's Disconnect uses DashUIKit's tinted red, and the stale-read test races for real
The Disconnect button rebuilt a tinted red look around the plain red style,
under a comment that DashUIKit had none; the pinned DashUIKit has
.tintedRed, which now draws it. The test of a details read from an earlier
opening waited for nothing before closing the sheet, so both reads took the
second answer; it now waits until the first read has its slow answer.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): a connection sheet claims message access only from encryption keys that landed or may
The sheet asked encryptionKeysUsable, the response path's check, whose
added-key rule only rejects a disabled key: an encryption key whose id
another key holds, or one the landed update left out, still read as
"receive messages". encryptionKeysGiveAccess, in the projection, takes a
re-sent key when live and an added key when live, or not there yet while
the intent may still land.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): the sheet does not show what is left of a budget above the total it read
The key totals come from the cached identity read and what is left from a
later read, so a limits update between them could show "0.02 DASH left of
0.01 DASH" under "Maximum of 0.01 DASH". When something left is above its
key's total (KeyFunding.agree), the funding lines are not shown and the
sheet says they could not be read; the next identity read brings them
together.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): the sheet claims no access through a key of unknown bound, and shows details before the budgets
- A key that matches an intent but whose bound the store does not hold yet
may be bound elsewhere (hasLanded already refuses it): it no longer gives
the intent's permission or a funding line. One predicate in the
projection, AppConnect.accessKey, decides it for both.
- The sheet's details no longer wait on the remaining-budgets query: the
data source reads them apart (connectionFunding, ConnectionFundingRead),
and the view model adds the funding lines when they come, the latest read
only; a refresh keeps the lines shown until its own read ends.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): keep apps disconnected on another identity, and date only what the intents record
- A read of one identity keeps a Disconnected row whose disconnect closed
another identity's intents; it no longer removes the app from the wallet's
Disconnected tab.
- While the store holds intents of the identity it cannot read, a refresh
keeps the Disconnected rows: one of them may be their disconnect.
- A disconnected app with no marked intent to read has no disconnect time,
access or connection time, instead of the row's own time.
- A disconnected app is connected at its latest approval, as the sheet of the
live connection shows it.
- Tests for the listing the data source publishes: tabs and scope, a
disconnect saved by another data source, a switch to a wallet with only a
disconnected app, and a disconnected app's sheet on a wallet switch.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): a funding refresh with nothing to read clears the sheet's funding lines
A refresh keeps the funding lines shown while its funding read runs, but a
read that ended with nothing to read (no key gives the app access any
more, or no identity read) left those lines and any earlier failure in
place. It now clears both.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): tell the connection sheet's access and funding from one identity read
The sheet built its access from one read of the identity and its funding
lines from another, taken later, so they could disagree: a funding line for
a key the access list did not show, or a newer total beside an older
maximum. Both now come from one ConnectionBasis (the read, the intents that
hold the app on it, and the keys no intent names). Funding is read for that
basis: only what is left of the budgets comes from the network, and the
sheet sets it only beside details told from the same basis. A refresh from
another read drops the earlier funding lines.
Every claim the sheet makes from a key on Platform (access, messages,
funding) now rests on AppConnect.placedKey: the store holds the key's bound.
An encryption key whose bound is unknown, added or sent again, no longer
gives message access.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): an Expired row tells its own connection's expiry, and expired keys elsewhere hold no row
- The sheet of an Expired row shows the expiry, limit and permissions of the
connection the row follows (`ConnectionBasis.followedAccess`), not those of
an older install still held.
- `seenOn` records an identity only while one of its unrecorded keys is live
at Platform's time; keys past their expiry on another identity no longer
keep or bring back an Active row.
- The expired-date comment tells Platform's proved block time; the tab helper
cites ADR-0019.
- Builds on the base after #1399: ended connections keep their recorded
access (`ConnectionDetails(recorded:)`), the sheet previews and a funding
test use the base's API.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): build the disconnected app's sheet preview from the preview details
The preview's standalone access value is gone; the disconnected entry and its
granted lines now take the access the preview details carry, as the Loaded
preview does.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): open the active row through rows(for:) in the funding refresh test
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): an Expired sheet reads the funding of the connection it follows
The sheet of an Expired row is told from `ConnectionBasis.shown(as:)`: the
intents the row follows, or its unrecorded keys when none is held. Its
access, expiry and funding lines come from that basis, so the funding read
no longer lists the keys of an older install still held. Other rows read
the whole basis as before; funding is still attached to the details of the
read it was made for.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): give a disconnected app's sheet the access its intents recorded
ConnectionDetails is told from a basis since the sheet's access and funding
come from one identity read; a connection that ended has none. It gets its
own initializer that carries the recorded access with no basis and no
funding, and the view model builds a disconnected app's details with it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix(dashpay): title a disconnected app's access as what the user allowed
A disconnect also marks an intent whose update was still in flight, so the
access recorded for a disconnected app may never have landed. Its sheet now
says "See what you allowed %@ to do" instead of "was able to do", which holds
whether the keys landed or not. The new key ships in English in every locale
until the Transifex pull.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Issue being fixed or feature implemented
Stacked on #1202 (base
feat/dashconnect-v2). First part of the App Connect request v2 proposed in the comments there (Yapprdocs/APP_CONNECT_PROFILE.md): adash-key:request that names several keys — a contract group, a document type, a single contract, an encryption key — each with a budget and an expiry.This PR holds only the parts that are fully specified and have published vectors. Nothing in the login flow reads them yet: a v2 QR is still refused, and the one-QR login of #1202 is unchanged.
What was done?
AppConnectRequest(new): decodes the v2 body — header, label, and the TLVsIDENTITY_HINT,AUTH_BINDING(1–4),CONNECTION_ID,ENC_BINDING(0–2),MODE,CREATED_AT— and checks the request age (older than 10 minutes is stale, more than 2 minutes ahead is future). Unknown even TLVs, binding kinds and versions areunsupported; everything else that breaks the format isinvalid, in the same precedence as the reference codec.DashConnectUri.parseAppConnectRequest: thev=2URI (n,v,cbat most once each, form-decoded) and thecbreturn URL. The callback check takes only a URL that is valid as written:https, no credentials, a host written without percent-encoding, a port in range.KeyExchangeCrypto: the v2 response — HKDF-SHA256 with the legacy salt and infoapp-connect:v2, AES-256-GCM authenticated against"dash:app-connect:v2" ‖ hash160(appEphPub) ‖ $ownerId, a payload of 1–17 keys. The v1 nonce generation moved into a shared helper, unchanged.How Has This Been Tested?
463f58adc(22 new here, the rest from feat(dashpay): sign in to an app with one DashConnect QR from protocol 14 #1202). feat(dashpay): sign in to an app with one DashConnect QR from protocol 14 #1202 is merged in again at0f3afaadd(no conflicts); this PR's own files did not change, and theDashWalletTests on simulatorcheck runs the suites on that head.vendor/platform-auth/src/app-connect/vectors.json,staging@ddfb001) are reproduced byte for byte: the request body, the URI with its callback, the renew request, the HKDF output, the associated data and the encrypted payload.unsupported/invalideach one gives.Known gaps
bindingIndex'level that rust-dashcore#1049 / platform#4844 do not have — asked on feat(dashpay): sign in to an app with one DashConnect QR from protocol 14 #1202), the owner-consistency checks, the single identity update with supersession byCONNECTION_ID, the encryption key, the approval sheet, opening the callback.invalid(the largest request the format defines is 734 bytes). The profile sets no maximum, so a longer request padded with unknown optional fields is legal there and refused here, and a longer request of a newer version is reported asinvalidrather thanunsupported.|,[]in the path or query) are refused. In one case it is looser: anxn--label that is not valid punycode passes. Whether the host belongs to the app is not decided here.Breaking Changes
None.
Checklist:
no significant decision(the decoder and the sealing are not called by the app yet; the decision to answer App Connect request v2 takes effect in feat(dashpay): sign in with App Connect request v2 #1210 and gets its ADR there)For repository code-owners and collaborators only
🤖 Generated with Claude Code