Repository navigation
feat(dashpay): sign in to an app with one DashConnect QR from protocol 14 #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
93120ee
feat(dashpay): sign in to an app with one DashConnect QR from protoco…
jeanpierreroma 9552f6a
feat(dashpay): disable the app's key when a one-QR connection is turn…
jeanpierreroma 18d0a04
fix(dashpay): keep every one-QR session key revocable
jeanpierreroma c80f5a0
fix(dashpay): match grant records by key and fail closed on a stale i…
jeanpierreroma cc1a970
fix(dashpay): decide one-QR key and response state from Platform
jeanpierreroma 09a28c5
fix(dashpay): disconnect also disables one-QR keys the wallet has no …
jeanpierreroma 7ec86f2
fix(dashpay): keep a stored App Connect value that is not a row list
jeanpierreroma d24e54a
fix(dashpay): show what a one-QR sign-in gives the app and bind the a…
jeanpierreroma 430b3c0
fix(dashpay): model an unresolved sign-in as its own state and keep t…
jeanpierreroma fdc5d4c
fix(dashpay): turning off a one-QR connection also disables the app's…
jeanpierreroma d61a1df
fix(dashpay): a one-QR disconnect reaches the two-QR keys with no ses…
jeanpierreroma aa8488d
fix(dashpay): a one-QR disconnect looks for the app's keys on the wal…
jeanpierreroma 957ea94
fix(dashpay): say when an app's key on another identity keeps the con…
jeanpierreroma c5fdbd3
fix(dashpay): keep DashConnect rows and grant records with the wallet…
jeanpierreroma 1633ae0
fix(dashpay): a DashConnect disconnect acts only on the wallet its ro…
jeanpierreroma 8bfc35b
fix(dashpay): one DashConnect approval, key registration or disconnec…
jeanpierreroma 57b3346
fix(dashpay): bind DashConnect operations to the network scope too, a…
jeanpierreroma c1d6001
fix(dashpay): approve a DashConnect sign-in only for the wallet and n…
jeanpierreroma c89def3
fix(dashpay): a devnet pointed at other nodes is another scope for a …
jeanpierreroma 41187c9
fix(dashpay): record a one-QR session key before its registration is …
jeanpierreroma 5868ac1
fix(dashpay): confirm a recovered one-QR key only with its bound and …
jeanpierreroma b41bc1c
fix(dashpay): free a native result string through a typed C pointer
jeanpierreroma 4a05418
Merge branch 'develop' into feat/dashconnect-v2
jeanpierreroma 06e0d2c
fix(dashpay): activate an app's existing row when its one-QR key is c…
jeanpierreroma 5c2f19d
fix(dashpay): give a confirmed one-QR key its row back if the row was…
jeanpierreroma d126261
Merge remote-tracking branch 'origin/develop' into feat/dashconnect-v2
jeanpierreroma 3b75374
build: pin the platform SDK to v5.1-dev with platform#4844
jeanpierreroma b9e5089
fix(dashpay): settle a pending one-QR registration before a disconnec…
jeanpierreroma 96bee7c
fix(dashpay): choose the disconnect from a fresh view, and settle a o…
jeanpierreroma bf4e32c
fix(dashpay): settle a registration that lands during a disconnect, a…
jeanpierreroma 0f37b44
Merge remote-tracking branch 'origin/develop' into feat/dashconnect-v2
romchornyi 79996be
docs(dashpay): note the revision race a one-QR registration record st…
romchornyi ff13301
docs(dashpay): describe the registration revision gap as it stands
romchornyi 55b0490
fix(dashpay): read the App Connect response through the SDK's off-mai…
romchornyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
798 changes: 798 additions & 0 deletions
798
DashWallet/Sources/Models/DashConnect/AppConnectLogin.swift
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.