Skip to content

fix(l10n): ship Localizable.stringsdict for every locale the app bundles - #1079

Merged
QuantumExplorer merged 1 commit into
developfrom
fix/ship-all-stringsdict-locales
Aug 27, 2026
Merged

QuantumExplorer merged 1 commit into
developfrom
fix/ship-all-stringsdict-locales

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Aug 27, 2026 •

Copy link
Copy Markdown
Member

The bug

The Localizable.stringsdict PBXVariantGroup (2ADC722723B5547000D9DD37) had exactly four children — en, sk, cs, uk — so only those four plural catalogs were copied into the app:

$ find <builtapp> -name '*.stringsdict' | wc -l
4

All 43 DashWallet/*.lproj/Localizable.stringsdict files exist on disk and are actively maintained (#945 added 15 plural entries to all of them, #1076 added %d words), but the rest were never referenced by the project. Every pluralised string silently fell back to English in those locales.

%d words is the cleanest demonstration: it lives only in stringsdict and in no .strings catalog, so it can only come from a bundled stringsdict.

The fix

Add the 18 remaining locales the app actually ships — bg de el es fr id it ja ko nl pl pt ru th tr vi zh-Hans zh-Hant-TW — as children of that variant group, each with its own PBXFileReference (lastKnownFileType = text.plist.stringsdict).

Both targets already reference the single shared variant group through build files 2ADC722923B5547000D9DD37 (dashwallet Resources) and C9D2C91C2A320AA000D15901 (dashpay Resources), so no build-phase change was needed — adding children to the group fixes both targets at once.

Bundled stringsdict count: 4 → 22, one for every shipping locale.

Before / after

Same screen, same simulator, same fresh install — the Дополнительно disclosure on "Сохранить фразу восстановления", Russian device language.

Before — 12 words / 24 words After — 12 слов / 24 слова

Note the body copy around the picker is already Russian in both shots — it comes from .strings, which was shipping fine. Only the stringsdict-backed segment labels were falling back.

Slavic plural categories resolve correctly

Russian and Polish both select two different CLDR categories on this one screen — 12 → many, 24 → few — and both render correctly:

Russian Polish
12 слов (many) / 24 слова (few) 12 słów (many) / 24 słowa (few)

Verification

  1. xcodebuild -workspace DashWallet.xcworkspace -scheme dashpay -sdk iphonesimulator -destination 'generic/platform=iOS Simulator' ARCHS=arm64 build → BUILD SUCCEEDED
  2. find <builtapp> -name '*.stringsdict' | wc -l → 22 (was 4); every .lproj in the bundle except Base now has one
  3. Russian simulator, fresh keychain + onboarding → picker shows 12 слов / 24 слова
  4. Polish simulator, same flow → 12 słów / 24 słowa

Out of scope (found while verifying)

Two further localisation gaps, deliberately not touched here:

  1. 21 locales ship nothing at all. ar ca da eo et fa fi fil hr hu mk ms nb ro sl sl_SI sq sr sv zh zh_TW each have a complete, fully-translated 2081-key Localizable.strings on disk, but are absent from knownRegions and from the Localizable.strings variant group — they are tx pull -a output that was never wired into Xcode. Adding only their stringsdict would have produced a .lproj with plurals and no strings, making the app advertise those languages (RTL included, for ar/fa) with an otherwise-English UI — a regression, so they are excluded. Wiring them up properly is a product decision that also needs the sl/sl_SI, zh/zh-Hans and zh_TW/zh-Hant-TW duplicates resolved.
  2. Hardcoded English copy. The two bullets on the backup screen ("Dash Core Group does NOT store this recovery phrase", "You will NOT be able to restore the wallet without a recovery phrase") are string literals in BackupInfoViewController.swift:32 and BackupInfoItemView.xib, never passed through NSLocalizedString — they are in no catalog, not even en. Visible as English in every screenshot above.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added localized content for French, Japanese, Korean, Dutch, German, Chinese, Spanish, Italian, Turkish, Polish, Russian, Greek, Portuguese, Bulgarian, Vietnamese, Thai, Taiwanese Chinese, and Indonesian.
    • Improved support for pluralized and localized text across the app.

The Localizable.stringsdict PBXVariantGroup had only four children — en, sk,
cs, uk — so `find <builtapp> -name '*.stringsdict'` returned 4 even though all
43 catalogs exist on disk and are actively maintained (#945 added 15 plurals,
#1076 added `%d words`). Every pluralised string therefore fell back to English
in the other locales.

`%d words` is the clearest case: it lives only in stringsdict and in no
`.strings` catalog, so the 12/24 recovery-phrase-length picker rendered
"12 words / 24 words" in English on a Russian device.

Add the 18 remaining locales the app actually ships (bg de el es fr id it ja ko
nl pl pt ru th tr vi zh-Hans zh-Hant-TW) as children of the variant group. Both
the dashwallet and dashpay targets already reference that one group via build
files 2ADC722923B5547000D9DD37 and C9D2C91C2A320AA000D15901, so no build-phase
change is needed.

Bundled stringsdict count: 4 -> 22, one for each shipping locale.

Note: 21 further locales (ar ca da eo et fa fi fil hr hu mk ms nb ro sl sl_SI
sq sr sv zh zh_TW) have complete translations on disk but are absent from
knownRegions and from the Localizable.strings group, so they ship nothing at
all today. Wiring those up adds 21 new advertised languages (including RTL) and
needs a product decision on the sl/sl_SI, zh/zh-Hans and zh_TW/zh-Hant-TW
duplicates — tracked separately, deliberately out of scope here.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c870c30-fe81-4979-b3c2-47aa85dc9952

📥 Commits

Reviewing files that changed from the base of the PR and between f11748e and 4dd5eff.

📒 Files selected for processing (1)
  • DashWallet.xcodeproj/project.pbxproj

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Xcode project registers Localizable.stringsdict files for 18 languages. It adds file references and corresponding entries to the localization group.

Changes

Localization registration

Layer / File(s) Summary
Register localized strings dictionaries
DashWallet.xcodeproj/project.pbxproj
The project adds file references and group entries for 18 localized Localizable.stringsdict files.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4dd5e

This change expands bundled pluralized localization coverage across the app’s supported locales without altering runtime logic or build-phase structure; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: llbartekll

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: packaging Localizable.stringsdict files for all bundled locales.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ship-all-stringsdict-locales

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@QuantumExplorer
QuantumExplorer merged commit 20bd680 into develop Aug 27, 2026
1 of 3 checks passed
@PastaPastaPasta
PastaPastaPasta deleted the fix/ship-all-stringsdict-locales branch August 27, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant