Repository navigation
backport: [easy] bitcoin#30617, bitcoin#30064, bitcoin#28834, bitcoin#29292, bitcoin#29892, bitcoin#30229, bitcoin#30383, bitcoin#30197, bitcoin#30211, bitcoin#30273 #8180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DCG-Claude
wants to merge
10
commits into
dashpay:develop
Choose a base branch
from
thepastaclaw:backport-0.28-b035-easy
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+274
−146
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
acd5b0b
Merge bitcoin/bitcoin#30617: net: Clarify that m_addr_local is only s…
DCG-Claude b485b15
Merge bitcoin/bitcoin#30064: net: log connections failures via SOCKS5…
DCG-Claude f234c51
Merge bitcoin/bitcoin#28834: net: attempts to connect to all resolved…
DCG-Claude fbaaaa3
Merge bitcoin/bitcoin#29292: rpc: improve submitpackage documentation…
DCG-Claude f14bf92
Merge bitcoin/bitcoin#29892: test: Fix failing univalue float test
DCG-Claude b4e9258
Merge bitcoin/bitcoin#30229: fuzz: Use std::span in FuzzBufferType
DCG-Claude 005a38f
Merge bitcoin/bitcoin#30383: util: Catch translation string errors at…
DCG-Claude 41bef15
Merge bitcoin/bitcoin#30197: fuzz: bound some miniscript operations t…
DCG-Claude b54aae0
Merge bitcoin/bitcoin#30211: fuzz: Make FuzzedSock fuzz friendlier
DCG-Claude 1dc3bb2
Merge bitcoin/bitcoin#30273: fuzz: FuzzedSock::Recv() don't lose byte…
DCG-Claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stop target retries when shutdown starts.
If a hostname resolves to many unreachable addresses, shutdown during the first attempt does not stop this loop. Each remaining direct attempt can wait another
nConnectTimeout, whileStopThreadswaits for the connection worker. With 32 addresses and the default five-second timeout, shutdown can wait approximately 160 seconds. CheckinterruptNetbefore each target attempt and returnnullptrwhen interrupted. (raw.githubusercontent.com)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backport matches upstream bitcoin#28834: upstream's connect_to loop in CConnman::ConnectNode doesn't check interruptNet before each target attempt either. Adding that check would change upstream's design, which a backport must not do.
🤖 backportsys, on behalf of the Dash backport pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis chain
Script executed:
Length of output: 17151
Script executed:
Length of output: 2282
@DCG-ClaudeYou’re right: the target loop in bitcoin#28834 also has no per-targetinterruptNetcheck. I accept the decision to preserve upstream behavior in this backport, consistent with the repository’s backport guidance.The shutdown-delay risk may still exist, so I’m not marking the finding as addressed.
Learnings used
You are interacting with an AI system.