Repository navigation
test: wait for a ChainLock only on a block the healed quorum signs - #8171
PastaPastaPasta wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. WalkthroughThe functional test adds a helper to derive ChainLock signing request IDs. After recovery, it mines and validation-syncs blocks until the selected signing quorum matches the recovered quorum, then checks the ChainLock on that block. Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk:
|
feature_llmq_data_recovery.py heals one quorum and then expects the next block to be chainlocked. Two llmq_test quorums are active, and the ChainLock for a height can fall to either. The other quorum lost its key shares to the same reindex, and the test never waits for it to recover. When it is picked, its members either have no key share yet or the recovery member chosen for the session has no verification vector and drops every share, and nothing re-signs the tip, so the wait times out. Mine until selectquorum names the healed quorum for the tip, then wait for its ChainLock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
b136890 to
3a4a591
Compare
|
✅ Final review complete — no blockers (commit 3a4a591) · triage: low |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
The change is a focused functional-test fix that selects the healed quorum for the newly mined block before asserting its ChainLock. The request-ID helper preserves the existing serialization, and the quorum-selection check matches the production ChainLock signing path. Reviewed CI checks are successful where completed, with remaining jobs queued or in progress and no reported failures caused by this change.
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — This is a small, well-contained functional-test change that adds deterministic quorum selection before an existing ChainLock assertion without changing production behavior. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 99% left, weekly 50% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer,gpt-6.1-sol— dash-core-commit-history (completed, effort medium); agentphase2-reviewer
Issue being fixed or feature implemented
feature_llmq_data_recovery.pyfails intermittently: the finalwait_for_chainlocked_block_all_nodesafter the recovery scenario times out. It reproduced 5 times in 144 parallel runs on current develop, and once in 96 runs on the version before #8156, so it predates that PR.The test heals one quorum (
quorum_hash_recover) and then expects the next block to be chainlocked. But twollmq_testquorums are active, and the ChainLock for a height can fall to either one. The other quorum's members lost their DKG data to the same reindex, and the test never waits for them to recover. When that quorum is picked for the block, the ChainLock either never forms or forms only by luck. The failing runs showed both ways it breaks:CreateSigShare -- we don't have our skShare for quorum ...), orPreVerifySigShareQuorum -- we don't have the quorum vvec ... no verification possible).In both cases nothing re-signs the tip, because mocktime is frozen and no new block arrives, so the wait times out.
What was done?
Before waiting for the ChainLock, mine blocks until
quorum selectquorumnames the healed quorum for the tip'sclsigrequest id. That call resolves the quorum the same way the signers do at that tip. The ChainLock check then covers what the test claims: the healed quorum can sign again. Theclsigrequest-id calculation already intest_no_chainlockbecomes a small helper so both places share it.How Has This Been Tested?
The same release
dashdranfeature_llmq_data_recovery.py16 at a time:test_runner.pyon an--enable-debugbuild. With instrumentation, 2 of 16 runs had to mine extra blocks to reach the healed quorum, so both paths run.Breaking Changes
None. The change only touches a functional test.
Checklist:
🤖 Generated with Claude Code