Repository navigation
backport: bitcoin#29421, bitcoin#29752, bitcoin#29419, bitcoin#29798 #8168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DCG-Claude
wants to merge
4
commits into
dashpay:develop
Choose a base branch
from
thepastaclaw:backport-0.28-b011-src
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+272
−459
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
afb9ad1
Merge bitcoin/bitcoin#29421: net: make the list of known message type…
DCG-Claude d3b4e21
Merge bitcoin/bitcoin#29752: refactor: Use typesafe Wtxid in compact …
DCG-Claude 9914d56
Merge bitcoin/bitcoin#29419: log: deduplicate category names and impr…
DCG-Claude a301cb8
Merge bitcoin/bitcoin#29798: Logging cleanup
DCG-Claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 Nitpick: Stale extra-transaction API comment remains
InitDatanow acceptsstd::vector<CTransactionRef>, and the implementation computes the instance hash from each transaction. The comment still describes the argument as being in<hash, reference>form, which is no longer accurate and can mislead callers about the required input. Update it to describe a list of transaction references.source:
muse-spark-1.3-contributor(phase1-reviewer: general);gpt-6.1-sol(phase2-reviewer: general, backport-reviewer, dash-core-commit-history)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backport matches upstream: bitcoin#29752 changed only the InitData signature and left this comment as it was (upstream's merge 7cc9a08 still says "in <witness hash, reference> form"). Rewording it would be a cleanup upstream never made, so it belongs in a separate upstream or Dash change, not this backport.
🤖 backportsys, on behalf of the Dash backport pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the parent diff and agree that this is an unchanged upstream comment carried through the faithful backport, rather than a Dash-specific adaptation error. The wording is stale relative to the upstream API change, but updating it here would be a separate documentation cleanup, so I withdraw this nitpick for this backport.
Withdrawing this finding.