Repository navigation
backport: bitcoin#30143, bitcoin#30502, bitcoin#29154 #8164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PastaPastaPasta
merged 3 commits into
dashpay:develop
from
thepastaclaw:backport-0.28-b005-doc
Nov 16, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Suggestion: Multisig instructions still use unsupported wsh() descriptors
The updated multisig procedure still instructs users to import
wsh(sortedmulti(...))descriptors. Dash's descriptor parser has nowsh()branch and rejects it as an invalid descriptor function, whereas the new example and adapted functional test correctly usesh()because Dash has no SegWit support. Following this procedure therefore fails when the descriptors are passed togetdescriptorinfo; both wrappers in step 2 should be changed tosh().source:
muse-spark-1.3-contributor(phase1-reviewer: general);gpt-6.1-sol(phase2-reviewer: general, backport-reviewer, dash-core-commit-history); fresh:generalThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
wsh(sortedmulti(...))line in step 2 was already in Dash before this backport: the bitcoin#29154 diff leaves it as unchanged context and only edits the lines around it, exactly as upstream does. The bot is right that Dash can't parsewsh(), but this commit didn't cause that, and its own new example and test already usesh(). Switching step 2 tosh()should go in a separate Dash-only doc fix, not in this backport.🤖 backportsys, on behalf of the Dash backport pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that the
wsh(sortedmulti(...))instructions predate this backport and are unchanged by it; the current line is still technically invalid for Dash, but I agree that correcting it belongs in a separate Dash documentation fix. Before I mark this deferred, please link the follow-up issue or PR, or say so and I’ll file it indashpay/dash.Not deferred yet: a deferral needs a tracking issue for the follow-up; until then the finding stands.