Repository navigation
test: drop Dash unit checks that do not guard a contract - #8160
PastaPastaPasta merged 1 commit into
Conversation
|
No actionable comments were generated in the recent review. WalkthroughThe LLMQ tests remove several ChainLockSig and commitment test cases. A new commitment test checks debug output when an undersized bitset is rejected. Hash sensitivity assertions compare each tested input with a base hash. Snapshot tests check selected JSON values and require deserialization to reject every nonempty proper prefix of serialized data. Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk:
|
|
✅ Final review complete — no blockers (commit 6fbc706) · triage: low |
1705dad to
6553a62
Compare
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
The review range is a test-only cleanup that removes tautological, duplicated, or non-actionable assertions while retaining contract-level coverage for serialization, validation, hashing, edge cases, and live handlers. The available CI snapshot shows successful builds, lint, formatting, cppcheck, and nowallet tests; the remaining source test jobs were still in progress and no code check had failed.
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — This is a contained test-only cleanup that removes redundant or non-contractual assertions without changing production behavior, and its correctness is straightforward to verify. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 99% left, weekly 51% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer,gpt-6.1-sol— dash-core-commit-history (completed, effort medium); agentphase2-reviewer
6553a62 to
0b813a4
Compare
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Final validation — Phase 1 + Phase 2
The PR removes non-contractual LLMQ unit checks and replaces the snapshot truncation test with a meaningful one-byte-prefix rejection test. The remaining issues are limited to an orphaned include introduced by the cleanup and a history suggestion to squash the corrective snapshot-test commit; no blocking correctness issues were found. Build, lint, and platform checks passed, while the Linux test and sanitizer jobs were still in progress in the supplied CI snapshot.
🟡 1 suggestion(s)
Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.
1 finding(s) not shown inline (the lines are not part of this PR's diff)
🟡 Suggestion: Squash the replacement snapshot test into the cleanup commit
<commit:0b813a40ace>:1
The second commit restores a stricter version of the snapshot truncation test that the first commit removed, so both commits together form one logical test-cleanup change. Squashing 0b813a4 into d818fb0 would avoid leaving permanent history that shows the test being deleted and then immediately reintroduced.
source: gpt-6.1-sol (phase2-reviewer: dash-core-commit-history)
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — This is a small, contained test-only deletion with no production behavior changes, and the retained assertions are straightforward to verify. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 99% left, weekly 51% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Code unchanged since the last final review (
6553a62c): 1 new nitpick(s) dropped - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer,gpt-6.1-sol— dash-core-commit-history (completed, effort medium); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.
In `<commit:0b813a40ace>`:
- [SUGGESTION] <commit:0b813a40ace>:1: Squash the replacement snapshot test into the cleanup commit
The second commit restores a stricter version of the snapshot truncation test that the first commit removed, so both commits together form one logical test-cleanup change. Squashing 0b813a40ace into d818fb0303a would avoid leaving permanent history that shows the test being deleted and then immediately reintroduced.
Repeated LLMQ cases only echoed getters, compared a value with itself, or ignored truncation errors. Keep each distinct input in one keeper, and reject every proper prefix of a quorum snapshot. Co-authored-by: Cursor <cursoragent@cursor.com>
0b813a4 to
6fbc706
Compare
|
Squashed the snapshot-prefix test into the cleanup commit, and dropped the now-unused 🤖 Posted autonomously by Cursor on behalf of pasta. |
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Final validation — Phase 1 + Phase 2
The test-only cleanup is correct: retained LLMQ tests still cover serialization, field sensitivity, edge cases, and handler behavior, while the replacement snapshot test rejects every proper wire prefix. No in-scope defects were found; completed CI checks passed, and the remaining source build/test checks were still in progress at the supplied snapshot.
🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — This is a small, self-contained test-only deletion and strengthening change with no production behavior or critical-surface changes. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 99% left, weekly 51% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer,gpt-6.1-sol— dash-core-commit-history (completed, effort medium); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.
No unresolved findings remain from the prior review on this head.
#8160 is stacked on #8157. Both were removing
validate_promotion_entry_valid. That consolidation now lives only in #8157 (d787bd3091a). This branch's own commit does not touchcoinjoin_inouts_tests.cpp.Issue being fixed or feature implemented
Dash-only unit tests had checks that cannot fail for the reason their names claim: getter echoes, a value compared with itself, and truncation loops that swallow every error. #8157 already removed the CoinJoin copies of that pattern. This PR keeps the LLMQ copies #8157 did not already remove.
What was done?
Parent is #8157. The commit on top of it (
6553a62cdcd) changes four LLMQ test files, net −207 lines:ToString, and the truncation loop that accepted either an exception or a success are gone.IsNull, serialization (including height 0 andINT_MAX), and the handler tests stay.ToJsonchecks member bits, skip mode, and skip-list values. Truncated prefixes are tested again inquorum_snapshot_truncated_wire_is_rejected: one-byte steps, and each prefix must throwstd::ios_base::failure.llmq_hash_tests.How Has This Been Tested?
Built
test_dashafter the rebase and ranllmq_chainlock_tests,llmq_commitment_tests,llmq_hash_tests, andllmq_snapshot_tests. All passed.Before the rebase, widening
ShouldPromoteDenomsfrom "below half the goal" to "below the goal" made the CoinJoin count keeper fail on (60 smaller, 0 larger) and (50, 0). That keeper is now the one in #8157. The production check was restored.Breaking Changes
None. Test-only.
Checklist: