Repository navigation
build: add dashbls runbench target - #8152
Closed
thepastaclaw wants to merge 5 commits into
Closed
thepastaclaw wants to merge 5 commits into
thepastaclaw wants to merge 5 commits into
Conversation
git-subtree-dir: src/blst git-subtree-split: 54e6e55674722fc2797ebb4bbb71b26d881eb4b8
Merge commit 'eebe528c66888bda26bb033e70d6d37f9a26b9e8' as 'src/blst'.
Carries depends/patches/blst/no_asm_limbs.patch into the subtree. Upstream vect.h picks 64-bit limbs on x86_64 and aarch64 even when __BLST_NO_ASM__ asks for the C implementation, and no_asm.h only defines the double-width llimb_t for 32-bit limbs, so the MSan build (which needs the C code because MSan cannot see through blst's assembly) does not compile. This is the only local change to src/blst. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
blst was pinned twice: depends/packages/blst.mk for depends builds and a copy of the same version, checksum and flags in the CI image for builds against system libraries (linux64_asan), since no distribution packages it. Build it from the src/blst subtree instead, as a libtool convenience library next to dashbls and mimalloc, so the source tree is its only pin. The build mirrors blst's build.sh: server.c (which #includes the rest of the C sources) plus build/assembly.S, -fno-builtin, and __BLST_PORTABLE__ for runtime ADX dispatch. configure selects blst's C implementation and leaves out the assembly on targets other than x86_64 and aarch64, where blst has none, and with --with-asm=no, which the MSan job already passes for secp256k1 and now also covers blst. Drop the depends package, its patch (now carried in src/blst), the CI image build, and the configure checks for an external libblst. Exclude src/blst from lints and coverage like the other subtrees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Build the dashbls benchmark as its own autotools target when benchmarks are enabled, excluding fuzz builds. Link it through the vendored dashbls and blst convenience libraries. Co-Authored-By: Claude Code <noreply@anthropic.com>
thepastaclaw
requested review from
PastaPastaPasta,
UdjinM6 and
knst
as code owners
November 14, 2026 20:56
3 tasks done
Collaborator
Author
|
Additional validation: ran |
knst
marked this pull request as draft
November 14, 2026 21:00
Collaborator
Author
|
🕓 Review not started yet because this PR is a draft.
Commit f36df56. Normal review starts when eligible; priority review starts as soon as a slot is available. |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This applies the requested build-system follow-up from PR #8146. The dashbls benchmark source exists, but the autotools build did not declare
dashbls/runbenchas a target, so benchmark-enabled builds could not build it through the generated makefiles.What was done?
Added the
dashbls/runbenchnoinst program tosrc/Makefile.dashbls.include, guarded byENABLE_BENCHand!ENABLE_FUZZ. The target lists the benchmark source and utility header, uses the dashbls internal include flags, and links throughLIBDASHBLS, which resolves to the vendoredblst/libblst.laconvenience library in PR #8146 rather than an unrelated system blst.Requested by knst via PastaClaw.
How Has This Been Tested?
./autogen.sh.--disable-wallet --without-gui --disable-zmq --disable-tests --disable-fuzz-binary --enable-bench.src/Makefiledeclaresdashbls/runbench, its source/object rules, and the link recipe containingblst/libblst.la.make -C src dashbls/runbenchsuccessfully.libSystem/libc++and that the vendoredsrc/blst/.libs/libblst.acontains the blst symbols.Breaking Changes
None. This only adds the benchmark target when benchmarks are enabled and fuzzing is disabled.
🤖 Generated with Claude Code