Skip to content

chore: prepare v24.0.1 release - #8133

Merged
PastaPastaPasta merged 1 commit into
dashpay:v24.0.xfrom
PastaPastaPasta:chore/v24.0.1-release-prep
Nov 12, 2026
Merged

PastaPastaPasta merged 1 commit into
dashpay:v24.0.xfrom
PastaPastaPasta:chore/v24.0.1-release-prep

Conversation

@PastaPastaPasta

@PastaPastaPasta PastaPastaPasta commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Prepares the v24.0.1 point release on top of the v24.0.1 backports (#8128), following the v23.1.10 prep (#7983). v24.0.1 carries the fix for what has held up v24 activation on mainnet (LLMQ_400_85 DKG rounds failing at the commit step, so no new quorum is selected to sign the EHF signal), plus a small set of other fixes.

What was done?

How Has This Been Tested?

Release mechanics only; no code changes.

  • Built the branch (macOS arm64, wallet, no GUI); dashd -version and dash-cli -version report v24.0.1.
  • Regenerated the dash-cli, dash-tx, dash-wallet and dash-util man pages with contrib/devtools/gen-manpages.py from that build: byte-identical to this commit. dashd.1 differs from the regenerated one in a single line, the lock debug category that only an --enable-debug build lists, so the committed page matches a release build. dash-qt.1 got the same version-only bump and wasn't regenerated (no GUI build).
  • The archived 24.0.0 notes are byte-identical to the previous doc/release-notes.md.
  • The notes were checked against the merged diffs and kept to effects.

Breaking Changes

None in this PR. The behaviour changes that ship in the fixes are described in the notes: masternodes cast some NO-FUNDING trigger votes later than before.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (if you have permission to set one)

🤖 Generated with Claude Code

@PastaPastaPasta PastaPastaPasta added this to the 24 milestone Nov 12, 2026
@thepastaclaw

thepastaclaw commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Final review complete — Phase 1 only — no blockers (commit 038306f) · triage: trivial

@PastaPastaPasta
PastaPastaPasta force-pushed the chore/v24.0.1-release-prep branch from 63c2d0b to 70e7f38 Compare November 12, 2026 04:58

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review — Phase 1 only (trivial change)

Verified the release-preparation changes at head 70e7f38. The governance release notes describe changes absent from this head, so the documented dependency on #8132 must be resolved before merging or shipping. Current CI shows no failed checks; lint and container builds passed, while cppcheck and platform dependency builds remain pending.

🟡 1 suggestion(s)

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)

  • Triage: trivial by gpt-6.1-sol (effort low) — The actual release commit only changes the version metadata, man-page version strings, release notes, and release metadata, with no behavioral or critical-surface code changes.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer, glm-5.3-flash — dash-core-commit-history (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 97% left, weekly 70% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-gate-verifier
  • Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.

In `doc/release-notes.md`:
- [SUGGESTION] doc/release-notes.md:90-105: Resolve the governance dependency before shipping these release notes
  The Governance section describes behavior that is absent from this head. GovernanceSigner::VoteGovernanceTriggers still proceeds to NO-FUNDING voting without the candidate/deadline guard introduced by #8131, UpdatedBlockTip still resets the remembered YES vote only when GetBestSuperblock succeeds, and CGovernanceManager::LoadCache still runs cleanup without initializing nCachedBlockHeight from the active chain as #8097 does. Comparing those fixes with this tree confirms the missing behavior; neither source commit 79606fbf527 nor merge commit 146bed9b3cf is an ancestor of this head. The PR description explicitly anticipates #8132, but these notes would be inaccurate if the release shipped without it, including the operator deadline at lines 107–110. Before merging, ensure the #8132 changes are included in the release branch, or remove this section together with the governance claim in the introduction at lines 7–9 and the upgrade-deadline paragraph at lines 107–110.

Comment thread doc/release-notes.md
Comment on lines +90 to +105
## Governance

- A masternode now waits until a superblock trigger for its own candidate
exists before it votes NO-FUNDING on other triggers, and casts those NO
votes at the latest three blocks before the superblock. Previously it voted
NO on every trigger that did not match its candidate at that block and never
revisited the vote. If the set of approved proposals changed while triggers
were being created, masternodes could end up having voted NO on the trigger
that matched their final candidate, and the superblock could pay no
proposals. (#8131)
- After a cycle that ended without a funded trigger, a masternode that had
voted YES in that cycle no longer votes NO on the next cycle's trigger.
(#8131)
- On test networks, a node restarted inside the maturity window no longer
drops its stored triggers and then rejects the superblock. Mainnet was not
affected. (#8097)

@thepastaclaw thepastaclaw Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Resolved at 038306fa; see the replies below.

🟡 Suggestion: Resolve the governance dependency before shipping these release notes

The Governance section describes behavior that is absent from this head. GovernanceSigner::VoteGovernanceTriggers still proceeds to NO-FUNDING voting without the candidate/deadline guard introduced by #8131, UpdatedBlockTip still resets the remembered YES vote only when GetBestSuperblock succeeds, and CGovernanceManager::LoadCache still runs cleanup without initializing nCachedBlockHeight from the active chain as #8097 does. Comparing those fixes with this tree confirms the missing behavior; neither source commit 79606fb nor merge commit 146bed9 is an ancestor of this head. The PR description explicitly anticipates #8132, but these notes would be inaccurate if the release shipped without it, including the operator deadline at lines 107–110. Before merging, ensure the #8132 changes are included in the release branch, or remove this section together with the governance claim in the introduction at lines 7–9 and the upgrade-deadline paragraph at lines 107–110.

source: glm-5.3-flash (phase1-reviewer: general, dash-core-commit-history)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, and this is the condition already stated in the description: the Governance section, the sentence about it in the introduction and the upgrade-deadline paragraph describe #8132, which is a separate PR against v24.0.x. This PR stays draft until #8128 and the decision on #8132 are settled. If #8132 is merged, the notes are accurate as written once this is rebased; if it is not, those three parts come out before this leaves draft. Leaving this thread open as the reminder.


🤖 Posted autonomously by Claude on behalf of pasta.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved (re-reviewed at 038306fa): Your stated release condition is now satisfied by the rebase onto #8128: I verified that the current tree includes #8131's candidate/deadline guard and height-keyed YES-vote reset, plus #8097's cached chain-height initialization before governance cleanup. The governance section, introduction, and upgrade-deadline paragraph can remain as written.

@thepastaclaw thepastaclaw added the pastaclaw:commented thepastaclaw's latest review was comment-only label Nov 12, 2026
@PastaPastaPasta
PastaPastaPasta force-pushed the chore/v24.0.1-release-prep branch from 70e7f38 to 8d95b1e Compare November 12, 2026 08:39
@thepastaclaw thepastaclaw removed the pastaclaw:commented thepastaclaw's latest review was comment-only label Nov 12, 2026
@PastaPastaPasta
PastaPastaPasta force-pushed the chore/v24.0.1-release-prep branch from 8d95b1e to 053b706 Compare November 12, 2026 16:12
@PastaPastaPasta
PastaPastaPasta force-pushed the chore/v24.0.1-release-prep branch 2 times, most recently from 7a00bb5 to 9b834a8 Compare November 12, 2026 17:54
Bump the build version to 1, add the v24.0.1 release notes, archive the
v24.0.0 notes, add the flatpak release entry and bump the version string in
the man pages (no option changed since v24.0.0).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@PastaPastaPasta
PastaPastaPasta force-pushed the chore/v24.0.1-release-prep branch from 9b834a8 to 038306f Compare November 12, 2026 18:04
@PastaPastaPasta
PastaPastaPasta marked this pull request as ready for review November 12, 2026 18:04

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — Final review — Phase 1 only (trivial change)

At head 038306f, the release-preparation diff consistently updates the version, Flatpak metadata, man pages, and release notes; the archived v24.0.0 notes are byte-identical to the previous notes. No in-scope issues remain. Current CI has no failed checks: lint, cppcheck, all depends builds, and the nowallet source build pass, while other source builds and tests remain pending.

🔴 0 blocking | 🟡 0 suggestion(s) | 💬 0 nitpick(s)

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: glm-5.3-flash (agent: phase1-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-gate-verifier, role: final-verifier)

  • Triage: trivial by gpt-6.1-sol (effort low) — The diff only updates release metadata, version strings, generated man pages, and release documentation without changing runtime behavior or any critical code surface.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer, glm-5.3-flash — dash-core-commit-history (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 98% left, weekly 60% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-gate-verifier
  • Phase 2 reviewers: not run (triage rated this change trivial); this review comments and never approves
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify the current code and confirm that no unresolved issues remain.

No unresolved findings remain from the prior review on this head.

@thepastaclaw thepastaclaw added the pastaclaw:commented thepastaclaw's latest review was comment-only label Nov 12, 2026
@PastaPastaPasta
PastaPastaPasta merged commit 137d999 into dashpay:v24.0.x Nov 12, 2026
56 checks passed
@thepastaclaw thepastaclaw removed the pastaclaw:commented thepastaclaw's latest review was comment-only label Nov 12, 2026
PastaPastaPasta added a commit that referenced this pull request Nov 13, 2026
038306f chore: prepare v24.0.1 release (pasta)
78ad074 Merge #8131: fix: wait for a matching superblock trigger before voting NO on the others (merge-script)
6faa5ce Merge #8097: fix: keep governance triggers across a restart on test networks (pasta)
2757e83 Merge #8130: fix: process a node's own DKG messages ahead of queued peer messages (merge-script)
cbbee0e Merge #8135: perf: keep verified DKG contributions cached through the commit phase (merge-script)
29a3cdd Merge #8099: fix(rest): don't terminate on blocks with undecodable ProTx payloads (merge-script)
275a142 Merge #8100: fix: don't abort in governance when a reorg changes masternode internal ids (merge-script)
d00c4e6 Merge #8104: fix: keep final commitments mineable when their block is rejected (merge-script)
b051d3a Merge #8080: test(qt): stop address book tests from answering the shared masternode wizard's prompt (merge-script)
ec9e944 Merge #8094: fix(net): stop busy-looping while a peer's send buffer is full (merge-script)
033dae3 Merge #8052: fix(qt): reserve the same shared masternode contribution again after a release (merge-script)
65603d5 Merge #8088: fix: fetch miniupnpc sources from miniupnp.free.fr (merge-script)

Pull request description:

  ## Issue being fixed or feature implemented
  Merges the v24.0.1 release back into develop, as the release process asks once `master` is fast-forwarded. `master`, `v24.0.x` and the signed `v24.0.1` tag all point to the same commit (137d999).

  ## What was done?
  One merge commit of `master` into develop.

  Every code change in `v24.0.0..v24.0.1` is a `cherry-pick -m1 -x` of a develop merge commit (#8088, #8052, #8094, #8080, #8104, #8100, #8099, #8135, #8130, #8097, #8131), and every source commit is already on develop. The two merge commits on `v24.0.x` (#8128, #8133) add nothing beyond their second parents.

  Git reports conflicts in `configure.ac`, `src/validation.cpp`, `src/llmq/blockprocessor.{cpp,h}` and `src/test/governance_vote_processing_tests.cpp`, because `v24.0.x` carries adapted copies of those changes. All of them resolve to develop's side, which keeps develop's code and version (`configure.ac` stays at 24.1.0, `CLIENT_VERSION_IS_RELEASE` false).

  Taken from v24.0.1:
  - `doc/release-notes.md`: the v24.0.1 release notes. The v24.0.0 notes move to `doc/release-notes/dash/release-notes-24.0.0.md`, unchanged from develop's current `doc/release-notes.md`.
  - The version string in the man pages (no option changed since v24.0.0).
  - The v24.0.1 entry in the flatpak release history.

  None of develop's individual `doc/release-notes-*.md` files cover changes in v24.0.1, so all of them stay.

  ## How Has This Been Tested?
  - `git diff develop` on this branch touches only the 9 doc and flatpak files above; `src/`, `test/` and `configure.ac` are byte-identical to develop, so nothing was rebuilt.
  - Checked that the `-x` source of every non-merge commit in `v24.0.0..master` is an ancestor of develop.

  ## Breaking Changes
  None. Develop's code is unchanged.

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [x] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(if you have permission to set one)_

  🤖 Generated with [Claude Code](https://claude.com/claude-code)

Top commit has no ACKs.

Tree-SHA512: d7021c283bd5fedce891e1317f08d1389b7538755fa63964aeba43a77dba7e1752c96add49d2a18d04ad6406b004bd7a42cce1637e46816a722a8d4dda480904
@UdjinM6 UdjinM6 modified the milestones: 24, 24.0.1 Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants