Repository navigation
fix: correct stale wallet and masternode wording #8092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -569,7 +569,7 @@ void MigrateWalletActivity::migrate(WalletModel* wallet_model) | |
| "If this wallet contains any watchonly scripts, a new wallet will be created which contains those watchonly scripts.\n" | ||
| "If this wallet contains any solvable but not watched scripts, a different and new wallet will be created which contains those scripts.\n\n" | ||
| "The migration process will create a backup of the wallet before migrating. This backup file will be named " | ||
| "<wallet name>-<timestamp>.legacy.bak and can be found in the directory for this wallet. In the event of " | ||
| "<wallet name>_<timestamp>.legacy.bak and can be found in the directory for this wallet. In the event of " | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Describe the backup prefix accurately. For a wallet named Update this warning and the patterns in
|
||
| "an incorrect migration, the backup can be restored with the \"Restore Wallet\" functionality.")); | ||
| box.setStandardButtons(QMessageBox::Yes|QMessageBox::Cancel); | ||
| box.setDefaultButton(QMessageBox::Yes); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Suggestion: Document the actual backup prefix for unnamed and nested wallet names
The underscore correction is accurate, but
<name>_<timestamp>.legacy.bakis not the exact filename for every wallet.MigrateWalletderives the prefix from the final component of the canonicalized wallet path, so a wallet namednested/subdir_walletproducessubdir_wallet_<timestamp>.legacy.bak, notnested/subdir_wallet_<timestamp>.legacy.bak; when the name is empty or canonicalizes to an empty filename, it falls back todefault_wallet. Because this PR's purpose is to make migration guidance accurate, update this sentence and the matching help text insrc/wallet/rpc/wallet.cpp:1137andsrc/qt/walletcontroller.cpp:572consistently.source:
glm-5.3-flash(phase1-reviewer: general, dash-core-commit-history)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 07e23ba. The guide, migration dialog, and RPC help now use _.legacy.bak and explain the canonical path basename and default_wallet prefix for the unnamed wallet. The guide includes a nested wallet example; backup generation is unchanged. Whitespace lint and git diff --check passed.