Repository navigation
backport: bitcoin#28139, bitcoin#27866, bitcoin#28038, bitcoin#28039 #7863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PastaPastaPasta
merged 4 commits into
dashpay:develop
from
thepastaclaw:backport-0.26-b061-misc
Oct 15, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5df4af4
Merge bitcoin/bitcoin#28139: test: create wallet specific for test_loβ¦
DCG-Claude cfc78e3
Merge bitcoin/bitcoin#27866: blockstorage: Return on fatal flush errors
DCG-Claude 9c5b3ff
Merge bitcoin/bitcoin#28038: wallet: address book migration bug fixes
DCG-Claude acb58ed
Merge bitcoin/bitcoin#28039: wallet: don't include bdb files from ourβ¦
DCG-Claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When either the block or undo file flush fails because of an I/O error, this branch only logs and then continues into
WriteBlockIndexDB, pruning, and the chainstate/EvoDB flush. The callee'sAbortNodecall merely schedules shutdown, so these writes still execute and this function can return true, potentially persisting an index or chainstate that refers to block data that never reached disk; return an error fromFlushStateToDiskhere instead.AGENTS.md reference: AGENTS.md:L60-L61
Useful? React with πΒ / π.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backport matches upstream bitcoin#27866. Upstream also only logs a warning when FlushBlockFile() fails inside FlushStateToDisk and leaves a TODO about handling the error, so changing that would go beyond this backport.
π€ backportsys, on behalf of the Dash backport pipeline.