Repository navigation
refactor: bump bls-signatures again to remove relic and cleanup unused files from the repo - #7679
Conversation
|
🔍 Review in progress (commit 688b47a) · live progress |
|
This pull request has conflicts, please rebase. |
cfd06b0 to
1e3423a
Compare
2bf133c docs: cite #8042 for the index fixes in the v24.0.0 release notes (pasta) 8aa11f6 docs: add the v24.0.0-rc.7 picks and index fixes to the v24.0.0 release notes (pasta) ad4e5d6 docs: drop the index caveat from the -reindex-chainstate man page entry (pasta) 19a90bb test: blocks orphaned while the address index is disabled are removed from it (pasta) d2f2a1f fix(index): don't adopt an empty or rebuilt async index as migrated legacy data (pasta) e3bafdb fix(index): reject an uncommitted tip the block index lost (pasta) 9198962 fix(index): check the blocks governance resumes from at startup (pasta) baff347 fix(index): resume from the tip a skipped commit leaves behind (pasta) 2dbf5ca fix(index): write a rewound block's erasures in one batch with its locator (pasta) 252acbe fix(index): move the committed locator below the entries a rewind erases (Konstantin Akimov) e9f9c8a Merge bitcoin#36150: indexes: set prune lock to genesis before first block (Konstantin Akimov) 2edeb98 partial Merge bitcoin#34897: indexes: Don't commit ahead of the flushed chainstate (Konstantin Akimov) 3eba84c Merge bitcoin#32875: index: handle case where pindex_prev equals chain tip in NextSyncBlock() (Konstantin Akimov) 399125c Merge bitcoin#32882: index: remove unnecessary locator cleaning in BaseIndex::Init() (Konstantin Akimov) bb724c6 Merge bitcoin#33212: index: Don't commit state in BaseIndex::Rewind (Konstantin Akimov) d5ff431 Merge bitcoin#32878: index: fix wrong assert of current_tip == m_best_block_index (Konstantin Akimov) 31c7d8f partial Merge bitcoin#32580: wallet, test: best block locator matches scan state follow-ups (Konstantin Akimov) 94f5c58 partial Merge bitcoin#30221: wallet: Ensure best block matches wallet scan state (Konstantin Akimov) 8e0b1e8 partial Merge bitcoin#32069: test: fix intermittent failure in wallet_reorgsrestore.py (Konstantin Akimov) 4d17947 Merge bitcoin#25193: indexes: Read the locator's top block during init, allow interaction with reindex-chainstate (Konstantin Akimov) 0127df8 Merge #8045: test: scale the mempool-loaded wait by timeout_factor so TSAN reindex restarts stop timing out (pasta) 62d0cef Merge #8036: fix(qt): let a shared masternode participant follow a revised invitation that keeps their share (merge-script) 775d31c Merge #8018: fix(consensus): require IPv4 masternode primaries until IPv4 is optional, pin mainnet ports (merge-script) e1b826e Merge #8026: fix(qt): keep shared masternode contribution fields locked while coins are reserved (merge-script) 9fa3df3 Merge #8020: fix(rpc): make protx shared_sign sign only dissolutions that return every principal (merge-script) 246a465 Merge #8024: fix(qt): keep the shared masternode dissolve dialog consistent with what it will send (merge-script) 590ad0a Merge #8021: fix(qt): don't load a newer shared masternode session copy that changes your own share (merge-script) 974aaa3 Merge #8034: fix(qt): check a shared masternode's service and refund addresses before coins are reserved (merge-script) 0026e3e Merge #8027: fix(qt): fund a shared masternode's service update from this wallet by default (merge-script) 6a5d2dc Merge #8035: fix(qt): don't strand coins reserved for a shared masternode session (merge-script) df6083a Merge #8032: fix(qt): don't offer a new operator key when reopening a shared masternode session (merge-script) 2b5bf30 Merge #8029: fix: let dashd -version, -help and first start work without an existing data directory (merge-script) e33d9b1 Merge #8037: docs: list the config file path each Linux init system uses (merge-script) 6030ea0 docs: add the #8014 migratewallet fixes to the v24.0.0 release notes (pasta) 1b1ea95 Merge #8014: backport: bitcoin#28609, bitcoin#34215, bitcoin#34226, bitcoin#34370, partials bitcoin#31423, bitcoin#34156 (migratewallet fixes from 28.x) (merge-script) 608ff63 Merge bitcoin#28542: wallet: Check for uninitialized last processed and conflicting heights in MarkConflicted (DCG-Claude) 3af6f63 Merge bitcoin#28038: wallet: address book migration bug fixes (DCG-Claude) 2fe41fb docs: add ecosystem notes on Asset Unlock txids, coinbase payees and RPC errors (pasta) 0e3f653 docs: correct operator guidance in the v24.0.0 release notes for rc.7 (pasta) 11c8140 Merge #8019: fix(qt): stop reporting refused shared masternode broadcasts as sent (merge-script) Pull request description: ## Issue being fixed or feature implemented Backports and release prep for v24.0.0-rc.7, on top of `v24.0.x` at 8d195f1 (v24.0.0-rc.6, #8013). This PR collects the develop merges labeled `backport-candidate-24.0.x`, the v24.0.x port of #8042 with the index fixes from #8033, and the release notes for them, so rc.7 has a single backport PR to merge. ## What was done? ### Picked Cherry-picked with `git cherry-pick -m1 -x`, in develop merge order, except that bitcoin#28038 goes before bitcoin#28542 as in Bitcoin Core. Each pick changes exactly the same lines as its develop merge, except as noted below for bitcoin#28542, #8014, #8020 and #8018. - #8019 fix(qt): stop reporting refused shared masternode broadcasts as sent - bitcoin#28038 (from #7863): prerequisite of #8014 - bitcoin#28542 (from #7762): prerequisite of #8014. Its `test_conflict_txs` migrates through `self.migrate_wallet`, as on develop since bitcoin#28868. - #8014 backport: bitcoin#28609, bitcoin#34215, bitcoin#34226, bitcoin#34370, partials bitcoin#31423, bitcoin#34156 (migratewallet fixes from 28.x), with the Dash adaptations below - #8037 docs: list the config file path each Linux init system uses - #8029 fix: let dashd -version, -help and first start work without an existing data directory - #8032 fix(qt): don't offer a new operator key when reopening a shared masternode session - #8035 fix(qt): don't strand coins reserved for a shared masternode session - #8027 fix(qt): fund a shared masternode's service update from this wallet by default - #8034 fix(qt): check a shared masternode's service and refund addresses before coins are reserved - #8021 fix(qt): don't load a newer shared masternode session copy that changes your own share - #8024 fix(qt): keep the shared masternode dissolve dialog consistent with what it will send - #8020 fix(rpc): make protx shared_sign sign only dissolutions that return every principal. Its `doc/release-notes-7437.md` sentence goes into the same paragraph of `doc/release-notes.md`, since that file was folded in for v24.0.0. - #8026 fix(qt): keep shared masternode contribution fields locked while coins are reserved (merged on develop as cc73a04; GitHub shows the PR as closed) - #8018 fix(consensus): require IPv4 masternode primaries until IPv4 is optional, pin mainnet ports, with the adaptation below - #8036 fix(qt): let a shared masternode participant follow a revised invitation that keeps their share - #8045 test: scale the mempool-loaded wait by timeout_factor so TSAN reindex restarts stop timing out ### Index fixes: #8042 port and #8033 The index commits are #8042 (merge 9e5e3d5), ported commit by commit to `v24.0.x`, plus the parts of #8033 that #8042 doesn't cover. #8042's v24.0.x port replaces #8033's bitcoin#33212, bitcoin#34897 and rewind-locator commits, and #8033's flushed-block announcement fix (e6a687b) is dropped: bitcoin#30221 removes the wallet's `ChainStateFlushed` locator write, and nothing else on `v24.0.x` consumes that notification. This PR replaces #8033, and #8031 comes in through it (adapted to the `v24.0.x` `CCoinsViewDB` constructor), not as a separate pick. - bitcoin#25193 (from #7883, via #8033): indexes: read the locator's top block during init, allow interaction with `-reindex-chainstate` - From #8042: partial bitcoin#32069 (only `TestNode.kill_process()`, with develop's `wait_until_stopped(**kwargs)` handling it needs), partial bitcoin#30221, partial bitcoin#32580, bitcoin#32878, bitcoin#33212, bitcoin#32882, bitcoin#32875, partial bitcoin#34897, bitcoin#36150, and #8042's own fixes: move the committed locator below the entries a rewind erases; write a rewound block's erasures in one batch with its locator; resume from the tip a skipped commit leaves behind; check the blocks an index resumes from at startup; reject an uncommitted tip the block index lost - From #8033: #8031 fix(index): don't adopt an empty or rebuilt async index as migrated legacy data; test: blocks orphaned while the address index is disabled are removed from it; docs: drop the index caveat from the `-reindex-chainstate` man page entry #### Dash adaptations for #8042 - The governance collateral index doesn't exist on `v24.0.x`, so its hunks are dropped; from the startup resume check only the `base.{h,cpp}` part is kept. - `feature_pruning.py`: node 5 syncs before node 0's pruned restart, and `test_rescan_blockchain` expects the governance-disabled stderr a pruned node prints on `v24.0.x`. - The wallet's `blockConnected` has no birthday skip on `v24.0.x`. - `TestNode.wait_until_stopped()` keeps `v24.0.x`'s `None` default for a clean exit. Apart from these, the `v24.0.x` index, validation and index test sources differ from develop after #8042 only by differences that already existed before it. #### Dash adaptations for #8018 `v24.0.x` predates bitcoin#26177, so it has no `src/kernel/chainparams.cpp` and no `GetBuriedDeployment()`. The four `IPv4OptionalHeight` values (mainnet not scheduled, testnet 0, devnet 0, regtest only through `-testactivationheight=ipv4_optional@<height>`) go into the matching classes in `src/chainparams.cpp`, and `ipv4_optional` is parsed in its `MaybeUpdateHeights()`. The `GetBuriedDeployment()` hunk is dropped; the `DeploymentName()` case is kept. Every other file, including all tests, changes exactly the same lines as the develop merge. The same notes are in the pick's commit message. #### Dash adaptations for #8014 #8014 doesn't cherry-pick cleanly onto `v24.0.x`. The conflicts were resolved against `v24.0.x` APIs. No prerequisite was backported, and no hunk or test was dropped. The same notes are in the pick's commit message. - `src/wallet/bdb.{cpp,h}`, `dump.cpp`, `sqlite.{cpp,h}`, `transaction.{cpp,h}`, `wallet.cpp`: the changed lines are identical to the develop merge. In `wallet.cpp`, the conflict was with develop-only context (`CanGrindR`), which stays out. - `src/wallet/db.h`: #8014 makes `WalletDatabase::Files()` pure virtual. `v24.0.x` still defines `DummyDatabase` in `db.h`, so it gets the `Files()` override there. - `src/wallet/test/wallet_tests.cpp`: the test database mock on `v24.0.x` is `FailDatabase`, so it gets the same `Files()` override. `src/wallet/salvage.cpp` and `src/wallet/test/util.h` keep the `v24.0.x` side, since develop's `DummyDatabase`/`MockableDatabase` placement doesn't exist here. - `test/functional/tool_wallet.py`, `wallet_backup.py`, `wallet_migration.py`: the test framework on `v24.0.x` has no `TestNode.wallets_path`/`datadir_path` (bitcoin#27884), so the new tests build these paths with `os.path.join` and pass RPC paths as strings. `wallet_migration.py` takes only #8014's new tests, not the develop-only tests around them. - `test/functional/wallet_migration.py`: `unsynced_wallet_on_pruned_node_fails` stops its pruned node with `EXPECTED_STDERR_NO_GOV_PRUNE`, because on `v24.0.x` a pruned node still prints the governance-disabled warning. The rc.6 picks handled the same warning the same way. ### Separate v24.0.x PRs, merged separately - #8016 backport: v23.1.10 fixes for v24.0.x - #8022 backport: bind CoinJoin signatures to the approved transaction (#7815) for v24.0.x, which depends on #7815 merging on develop #8016 and #8022 each merge cleanly with this branch in either order, and all three merge to the same tree in any order. ### Not picked - #8025: closed; superseded by #8014 (picked above) - #8031 is not picked separately; it comes through #8033's commits above. - #8039, #8040, #8041, #8043, #8044 (CI and tooling), #7905, follow-ups to #8042, and the PRs in the 24.1 milestone. - Explicitly deferred: #7870, #7679, #7675, #7220, #7217, #7109, #6988, #4974, #8028. ### Release notes `doc/release-notes.md` corrections, checked against the code on this branch: - **Version 2 Asset Unlocks:** version 1 Asset Unlocks stay valid after `v24` activation. Platform withdrawals keep using version 1 until a future Dash Platform release issues version 2, so the stable txid, InstantSend locking and instance-hash relay don't apply to them yet. - **Masternode requirements:** the startup refusals (#7754) and the DKG bad votes for missing transaction relay or compact filters (#7755) apply from the first start of v24.0.0, not from activation. Operators should remove conflicting settings and upgrade before the `v24` start date (November 9, 2026), so their masternodes are running when the activation signal is signed. `-peerblockfilters=0` is the new refusal; `-blockfilterindex=0` already failed on v23. - **How to Upgrade:** a pruned node with `-addressindex` or `-spentindex` now refuses to start; v23 accepted that combination. - **Downgrading:** there is no supported downgrade after `v24` activation: older versions can't follow the network, and they misread the masternode list data v24.0.0 writes. Before activation, downgrading to v23.1.x works with the listed caveats. Dash-Qt's dust-protection setting is migrated to the shared settings, so it reads as disabled after a downgrade. - **Dash Platform:** Platform/dashmate v5.0.0 and later handle the hidden `service` and `softforks` RPC fields. Older Platform versions need both `-deprecatedrpc` options. - **Compatibility:** users on macOS 13 or older must upgrade macOS, or move their node, before activation. - **Legacy wallets:** in v24, `createwallet` with `descriptors=false` also needs `load_on_startup`; before v24 this applied only to `descriptors=true`. The notes now give a working example. - **Wallet migration (#8014):** failure handling in `migratewallet`, `restorewallet` and `dash-wallet createfromdump` is fixed, and the new backup and watch-only/solvables wallet names are listed. - **Ecosystem notes:** the txid of a version 2 Asset Unlock zeroes `requestedHeight`, `quorumHash` and `quorumSig` before hashing (the full-bytes hash is `instanceHash`); pools should emit one coinbase output per `masternode[]` and `superblock[]` template entry, since merged or deduplicated payees are invalid after activation; client libraries that send numbers or booleans as strings fail (#7099); and some wallet RPC error messages changed with upstream backports. - **rc.7 picks:** `doc/release-notes-8018.md` and `doc/release-notes-8029.md` are folded in and removed. #8018's IPv4-primary and mainnet standard-port rules are under Extended addresses, with a pointer from the masternode upgrade notes; #8029's `dash.conf` change is under Updated settings. The other rc.7 picks fix code that is new in v24 and need no release note. - **Index fixes (#8042, #8031):** nodes that ran a release candidate with the address, spent or timestamp index should rebuild them once (with `-reindex`, or by starting once with them disabled, deleting their `indexes/` directories and starting with them enabled). The notes also cover `-reindex-chainstate` with indexes enabled, older versions refusing a migrated index until `-reindex`, the new "the block the index was last synced to is not found. Please rebuild the index." startup error, and the known limitation shared with earlier versions in the remaining cases. - All rc.7 TODO comments are resolved. `configure.ac` is already 24.0.0 with `CLIENT_VERSION_IS_RELEASE` false, so the version string comes from the `v24.0.0-rc.7` tag. The man pages carry #8033's `-reindex-chainstate` change; no other pick changes non-debug help text (#8018's `-testactivationheight` change is debug-only). ## How Has This Been Tested? On this head (2bf133c): - Every develop pick compared with its develop merge (`git patch-id --stable` and the set of changed lines). #8019, #8037, #8032, #8035, #8027, #8034, #8021, #8024, #8026, #8036 and #8045: identical. #8029: the same changed lines; only context differs in `feature_config_args.py`. #8020: the same changed lines, in `doc/release-notes.md` instead of `doc/release-notes-7437.md`. #8018: identical except the adaptation above, checked file by file against 900f085 and reviewed separately for consensus equivalence on mainnet, testnet, devnet and regtest. #8014 and its prerequisites: as in the earlier rounds (adaptations above). - #8042 port: `v24.0.x`'s divergence from develop, before #8042 (058b060) versus after it (9e5e3d5), is unchanged in `src/index/*`, `src/validation.{h,cpp}`, the index unit tests and `feature_coinstatsindex.py`, apart from the adaptations listed above. The #8031, test and man page commits have the same patch-id and message as on #8033. - Built with `--enable-debug --enable-werror` and Qt: no warnings. - Unit suites pass: `baseindex_tests`, `index_migration_tests`, `txindex_tests`, `blockfilter_index_tests`, `coinstatsindex_tests`, `validation_flush_tests`, `wallet_tests`, `interfaces_tests`, `evo_netinfo_tests` and `evo_snapshot_tests`. With the develop picks (7275005), every `evo_*` suite and `test_dash-qt` (15 classes, 152 passed, 0 failed) passed too. - Functional tests pass: `rpc_netinfo.py`, `feature_masternode_shares.py`, `wallet_migration.py`, `feature_coinstatsindex.py` (including the unclean restart after a reorg), `feature_addressindex.py`, `feature_config_args.py` and `feature_index_prune.py`. On the same C++ tree, these pass as well: `feature_spentindex.py`, `feature_timestampindex.py`, `feature_pruning.py`, `feature_txindex.py`, `feature_reindex.py`, `feature_init.py`, `feature_abortnode.py` and `wallet_reorgsrestore.py`. - Regtest upgrade gates, run on a build of this exact head: all pass. They cover v23.1.10 index migration, index contents vs v23 and `-reindex`, a kill mid-migration, 9 wallets, a pre-activation downgrade and round trip, and v22.1.3/v23.0.2 upgrades. The crash-after-reorg probe and the deleted-index probe are both required to be not reproduced: 0/10 stale (rc.6: about 4/10), and the plain-delete rebuild matches. - Man pages: `help2man` output of the built `dashd`, `dash-cli`, `dash-tx`, `dash-wallet` and `dash-util` matched `doc/man` on the develop picks (apart from the debug-build-only `lock` log category). No later commit changes non-debug help text, so nothing is regenerated beyond #8033's `-reindex-chainstate` change. - `git merge-tree` against #8016 (cdb250c) and #8022 (62609bf), heads fetched 05:23 UTC: clean in both orders, and all three merge to the same tree in every order. From the earlier rounds: the wallet suites and functional tests listed for #8014, bitcoin#28038 and bitcoin#28542 passed, and the `createwallet` example was checked against the official v24.0.0-rc.6 binary. ## Breaking Changes - From #8014: migration backups are now named `<name>_<time>.legacy.bak`, the unnamed wallet's watch-only and solvables wallets are named `default_wallet_watchonly` and `default_wallet_solvables`, and `restorewallet` accepts an existing empty directory. - From #8018: on mainnet, a version 3 ProRegTx or ProUpServTx must list an IPv4 address on the standard port as the first entry of each address list; testnet and devnets are unaffected. - From #8029: `dashd` no longer creates an empty `dash.conf`. - From #8031: older versions refuse an index migrated by v24.0.0 until they run `-reindex`; nodes that ran a release candidate should rebuild these indexes once. - From #8042: an index whose last synced block was lost in an unclean shutdown makes startup fail with a rebuild instruction. The release notes describe these. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone 🤖 Generated with [Claude Code](https://claude.com/claude-code) Top commit has no ACKs. Tree-SHA512: 3c405ef570fc1c5b46d1ba8bb2e344213cf65018abe5ef4b94b7cf2b9aa7160ba2675f71a0a365c72bc8249a2f9a5defe774af2a4e33537245aeb420c5f66711
|
This pull request has conflicts, please rebase. |
e6d4d7e build: compile dashbls with Dash's autotools, blst from depends (Konstantin Akimov) b2efb31 Squashed 'src/dashbls/' changes from dbd61e6a4e..77c8da5a53 (Konstantin Akimov) 01f7215 depends: update 'src/dashbls' to dashpay/bls-signatures@77c8da5 (Konstantin Akimov) ef50cc5 depends: add blst 0.3.17 (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented Blst library has much better performance compare to relic for bls signatures. See dashpay/bls-signatures#132 for details. | Benchmark | relic | v0.3.17 | Speedup | |---|---:|---:|---:| | Signing | 0.4738 ms | 0.2427 ms | 1.95x | | Verification | 1.526 ms | 0.6607 ms | 2.31x | | Batch verification preparation | 0.5659 ms | 0.2819 ms | 2.01x | | Public key validation | 0.124 ms | 0.0341 ms | 3.64x | | Signature validation | 0.1398 ms | 0.0487 ms | 2.87x | | Aggregation | 1.4 µs | 1.0 µs | 1.40x | | Batch verification | 0.663 ms | 0.2417 ms | 2.74x | | Serialize PrivateKey | 11.4 ns | 9.9 ns | 1.15x | | Serialize G1Element | 108.2 ns | 47.6 ns | 2.27x | | Serialize G2Element | 156.0 ns | 92.7 ns | 1.68x | | SerializeToArray PrivateKey | 7.6 ns | 5.7 ns | 1.33x | | SerializeToArray G1Element | 105.0 ns | 43.6 ns | 2.41x | | SerializeToArray G2Element | 147.2 ns | 86.0 ns | 1.71x | ## What was done? Migrated dash core repo to use blst library [over chia's framework v2]. Changes kept minimal as possible while everything still works. Beyond blst's migration one more PR is relevant with bls-signatures's version bump: dashpay/bls-signatures#123 Behaviour change: legacy verification (LegacySchemeMPL::Verify/AggregateVerify/VerifySecure) now rejects public keys and signatures that are not on the curve or not in the prime-order subgroup, following dashpay/bls-signatures#123. Identity points were already rejected by CBLSWrapper::SetBytes, so only non-subgroup points are newly rejected; honest signers cannot produce them, and mainnet replay with this branch rejects nothing. There's futher PRs that do: - drop gmp dependency see #7679 - drop relic relevant files, various binding [js, go, python, etc] which are not required for Dash Core. it's preliminary step to clean up all unused files and it is NOT included in this PR due to huge diff [-250k lines] which will make this PR unresponsible on github + more difficult to review for people and for agents, see #7679 for details - final phase: get rid of chia's layer and call blst's methods directly from CBLSSecretKey, CBLSPublicKey, CBLSSignature and CBLSId. Accordingly benchmark it gives extra 15% of performance for aggregate's functionality and simplify implementation significantly. See #7680 for mockup / proof-of-concept. ## How Has This Been Tested? Dash Core chains are re-synced from genesis successfully with `-reindex -assumevalid=0` and ``-reindex -assumevalid=0 -testnet` Performance impact is measured by block-reconsider ~5000blocks measured performance impact for blocks validation: | Step | develop | PR | Speedup | |---|---:|---:|---:| | Sanity checks | 0.19s | 0.20s | 0.95x | | Fork checks | 0.04s | 0.05s | 0.80x | | GetTxPayload | 1.10s | 0.38s | 2.89x | | Loop | 1.94s | 1.15s | 1.69x | | CheckCreditPoolDiffForBlock | 0.06s | 0.03s | 2.00x | | m_qblockman.ProcessBlock | 14.09s | 6.76s | 2.08x | | m_dmnman.ProcessBlock | 2.75s | 3.10s | 0.89x | | CalcCbTxMerkleRootMNList | 0.16s | 0.18s | 0.89x | | GetQcHashes | 3.76s | 2.51s | 1.50x | | Loop (quorums) | 0.04s | 0.04s | 1.00x | | ComputeMerkleRoot | 0.04s | 0.04s | 1.00x | | CalcCbTxMerkleRootQuorums | 3.85s | 2.60s | 1.48x | | CheckCbTxBestChainlock | 10.36s | 4.36s | 2.38x | | m_mnhfman->ProcessBlock | 0.09s | 0.13s | 0.69x | | ProcessSpecialTxsInBlock | 34.47s | 18.78s | 1.84x | | Connect 1 transactions | 35.27s | 19.62s | 1.80x | | Verify 0 txins | 37.90s | 21.03s | 1.80x | | IS filter | 0.00s | 0.27s | slower | | GetBlockSubsidy | 0.00s | 0.00s | – | | IsBlockValueValid | 0.00s | 0.00s | – | | IsBlockPayeeValid | 0.04s | 0.04s | 1.00x | | Dash specific | 0.05s | 0.31s | 0.16x | | Write undo data | 0.00s | 0.00s | – | | Index writing | 0.00s | 0.00s | – | | **Connect total** | **38.39s** | **21.85s** | **1.76x** | | Flush | 0.31s | 0.34s | 0.91x | | Writing chainstate | 0.01s | 0.02s | 0.50x | | Connect postprocess | 0.78s | 0.88s | 0.89x | | **Connect block** | **39.88s** | **23.52s** | **1.70x** | Beside pure faster block validation time, it's expected lower CPU usage for nodes and especially masternodes; it's expected faster performance for instant-send locks, higher throughput for instant-send locks, faster forming of chainlocks. There's extra validity tests that had been done inside bls-signatures and enabled as regression tests of Dash Core. ## Breaking Changes `blst 0.3.17` is a new dependency for Dash Core, no other changes in behaviour beside performance is expected. Please note that build process for bls-signatures is updated. It's no more has own 'config.status' and other autoconf's files, but directly integrated to dash core's build. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: 511e5635ad68f9bd6ea63a925a58a0b6136658d08ca54a23009779e9dae619678e01f867752195a7725ea11da9e60ec6d0f84dd0b98d78b43ce1097beb302f97
5fb621a to
b4e73d0
Compare
85f016781b Merge pull request dashpay#140 from knst/remove-relic 522337bd00 Merge pull request dashpay#141 from knst/fix-js-ci bac75cf716 Merge pull request dashpay#139 from knst/bump-blst-0.3.17 0eb1a10e0f fix(js): include <iterator> for std::back_inserter 0d13f77296 doc: list blst in NOTICE, drop relic and GNU MP d84100f822 chore: remove unused vendored relic ecd706b853 Merge pull request dashpay#128 from kwvg/harden c36e15821f fix: free the hashes `cAllocHashes` copies 786dfe74f4 fix: free the messages `cAllocMsgs` copies dee14efc33 fix: free the message `AugSchemeMPL.SignPrepend` copies 9e5c67551d fix: free the message `PopSchemeMPL.FastAggregateVerify` copies 21695be46e fix: make swapping the secure allocator safe while others allocate deebc2e0f6 fix: clear the copy `ChainCode` prints through 66017cfbde fix: let a moved-from `PrivateKey` be copy-assigned again c79efe01af fix: guard `PrivateKey` assignment against self-assignment 410b519869 fix: clear `ChainCode` when it is destroyed 34abe313cc feat: introduce `util::SecPtr<T>` for holding temporaries 7c48336607 feat: introduce `util::SecVector<T>` for handling sensitive bytes ae4fc67ef1 refactor!: drop `Util::Sec{Alloc,Free}` 1222cd2f7a refactor: route secure allocation through `util::Sec{Malloc,Free}` bdcc5360ce feat: introduce `util::SecureWipe` for clearing secrets 7d50b8b45a refactor(move-only): move the installed headers' definitions into TUs 6862cff556 doc: add MIT license for sources that reference `COPYING.MIT` e1338fa2a4 fix: stop FourBytesToInt shifting into the sign bit 421843607d fix: test for the uppercase prefix intended by `Util::HexToBytes()` 0189e6fd74 build: bump blst to v0.3.17 git-subtree-dir: src/dashbls git-subtree-split: 85f016781b21af74d34da2ae150d58a5a61fabeb
b4e73d0 to
acaa24c
Compare
Everything that only served the standalone library build or the relic backend goes: the relic tree, the CMake and autotools files, the Go/Rust/JS/Python bindings and their helper scripts, differential fuzzer. What stays is what Dash Core builds and tests: the library sources and headers, the Catch2 test with its relic reference vectors (plus the generator that produced them), mimalloc, LICENSE, NOTICE and README.
acaa24c to
7511242
Compare
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
The subtree cleanup and Dash build integration are consistent, and the retained sources are wired into the Autotools build. The Debian copyright stanza added by this PR broadly labels dashbls as Apache-2.0 even though the new sources and several retained Dash-specific files use MIT/MIT-X11, so the packaging metadata needs a more-specific override. The failed slim arm64 container job was unrelated infrastructure failure (apt.llvm.org DNS resolution), while PR-title validation is a policy check rather than a code failure.
🟡 1 suggestion(s)
Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.
1 finding(s) not shown inline (GitHub refused the PR diff as too large)
🟡 Suggestion: Correct mixed dashbls license classification
contrib/debian/copyright:30-34
This PR adds a wildcard src/dashbls/* stanza declaring the entire subtree Apache-2.0, but the new src/dashbls/src/hdkeys.cpp, hkdf.cpp, secure.cpp, secure.h, util.cpp, and test/test_secure.cpp explicitly refer to COPYING.MIT and use the MIT license. The wildcard also covers retained Dash-specific MIT/X11 files such as include/dashbls/legacy.hpp, include/dashbls/threshold.hpp, src/legacy.cpp, src/threshold.cpp, and src/test-vectors.hpp, as well as COPYING.MIT. Add more-specific Debian copyright stanzas for all of these paths, using Debian's Expat identifier for MIT/MIT-X11, so generated package metadata and downstream license scanners report the licenses stated by the source files.
source: muse-spark-1.3-contributor (phase1-reviewer: general); gpt-6.1-sol (phase2-reviewer: general, dash-core-commit-history)
Review provenance
Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); reviewer 4: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 5: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This is a broad dependency subtree and build/test cleanup affecting cryptographic library sources and compilation, but the diff does not change Dash Core’s cryptographic behavior, consensus rules, key handling, or other critical surfaces. - Phase 1 reviewers:
muse-spark-1.3-contributor— general (completed, effort xhigh); agentphase1-reviewer - Phase 1 model:
muse-spark-1.3-contributor— not quota-gated; passed overgemini-3.8-flash-high(antigravity quota lookup failed),glm-5.3-flash(not used above high effort; tier asks max) - Second Phase-2 pass: on this first full review every Phase-2 reviewer also ran a second, independent time, and the verifier weighed both sets
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— dash-core-commit-history (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— dash-core-commit-history (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.
In `contrib/debian/copyright`:
- [SUGGESTION] contrib/debian/copyright:30-34: Correct mixed dashbls license classification
This PR adds a wildcard `src/dashbls/*` stanza declaring the entire subtree Apache-2.0, but the new `src/dashbls/src/hdkeys.cpp`, `hkdf.cpp`, `secure.cpp`, `secure.h`, `util.cpp`, and `test/test_secure.cpp` explicitly refer to `COPYING.MIT` and use the MIT license. The wildcard also covers retained Dash-specific MIT/X11 files such as `include/dashbls/legacy.hpp`, `include/dashbls/threshold.hpp`, `src/legacy.cpp`, `src/threshold.cpp`, and `src/test-vectors.hpp`, as well as `COPYING.MIT`. Add more-specific Debian copyright stanzas for all of these paths, using Debian's `Expat` identifier for MIT/MIT-X11, so generated package metadata and downstream license scanners report the licenses stated by the source files.
thepastaclaw
left a comment
There was a problem hiding this comment.
CI failed after approval — commit 7511242
The standing review approved this commit; this follow-up moves the verdict to COMMENT: checks that failed after the review look related to this change.
Failing checks:
linux64_tsan-build / Build source(failure)
Why they look related: The failing check directly fails dashbls/runtest, a test target added and wired by this pull request, and ThreadSanitizer reports a data race in the newly added test_secure.cpp exercising secure.h/mimalloc allocation. This is a failure in changed code and behavior, not unrelated infrastructure.
Nothing was re-reviewed: the findings of the standing review are unchanged. The next push gets a full review; a re-run that passes does not restore the approval.
Review provenance
Source: CI-check lane gpt-6.1-sol (agent: triage); no reviewer or verifier lanes ran for this follow-up
- Verdict moved because CI failed on this commit after the review; failure logs read: 1 GitHub Actions job(s)
7511242 to
7d5bd92
Compare
thepastaclaw
left a comment
There was a problem hiding this comment.
Re-review — Final validation — Phase 1 + Phase 2
The integrated dashbls cleanup and build wiring are coherent. The new benchmark target produces src/dashbls/runbench, but that generated binary is not covered by the repository ignore rules. Most CI builds and lint checks succeeded; test jobs remain pending, and the snapshot reports a TSAN build failure whose log is unavailable while the workflow is still in progress.
🟡 1 suggestion(s) | 💬 1 nitpick(s)
Approved: nothing here blocks the merge. The non-blocking findings are optional: fix them forward, in this PR or a follow-up, without waiting for another review round.
2 finding(s) not shown inline (GitHub refused the PR diff as too large)
🟡 Suggestion: Correct mixed dashbls license classification
contrib/debian/copyright:30-34
The broad Files: src/dashbls/* stanza assigns Apache-2.0 to the entire vendored subtree, but the current tree contains separately licensed files. The secure-allocation sources and test/test_secure.cpp identify the MIT license in COPYING.MIT; legacy sources and headers identify the MIT/X11 license in COPYING; and the vendored Catch2 header is licensed under the Boost Software License 1.0, as also documented in src/dashbls/NOTICE. The more-specific mimalloc stanza handles only mimalloc, so it does not correct these classifications. Add more-specific Files stanzas for the MIT paths and Catch2, along with the corresponding MIT/Expat and BSL-1.0 license definitions.
source: muse-spark-1.3-contributor (phase1-reviewer: general); gpt-6.1-sol (phase2-reviewer: general, dash-core-commit-history)
💬 Nitpick: Ignore the generated dashbls benchmark binary
src/Makefile.dashbls.include:124-126
This newly added benchmark target creates src/dashbls/runbench in the source tree. The root .gitignore ignores src/dashbls/runtest but not runbench, so a benchmark-enabled build leaves the generated binary as an untracked file. Add src/dashbls/runbench to the root ignore rules.
source: gpt-6.1-sol (phase2-reviewer: general)
Review provenance
Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: dash-core-commit-history); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This is a large cross-cutting dependency, source-layout, build, test, CI, and licensing cleanup, but the diff itself does not change Dash Core consensus, funds handling, cryptographic behavior, or other critical runtime logic. - Phase 1 reviewers:
muse-spark-1.3-contributor— general (completed, effort xhigh); agentphase1-reviewer - Phase 1 model:
muse-spark-1.3-contributor— not quota-gated; passed overgemini-3.8-flash-high(antigravity quota lookup failed),glm-5.3-flash(not used above high effort; tier asks max) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— dash-core-commit-history (completed, effort high); agentphase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review (PastaClaw). How to work through them:
- Verify each finding against the code; fix only what is real, as narrowly as the finding.
- If a finding is wrong, decline it on its thread in one or two sentences; the bot answers once and stops.
- To defer one, link a tracking issue on its thread (or reply asking the bot to file one).
- Suggestions don't block the merge, but most are worth fixing in this PR; judge each on its merits.
- Keep the PR's scope; don't grow it to satisfy hardening suggestions.
- Carried items were raised in an earlier round: read the thread first, and don't re-fix what you already fixed, declined or deferred there. Disputed and deferred items are already handled and are not listed.
In `contrib/debian/copyright`:
- [SUGGESTION] contrib/debian/copyright:30-34: Correct mixed dashbls license classification
The broad `Files: src/dashbls/*` stanza assigns Apache-2.0 to the entire vendored subtree, but the current tree contains separately licensed files. The secure-allocation sources and `test/test_secure.cpp` identify the MIT license in `COPYING.MIT`; legacy sources and headers identify the MIT/X11 license in `COPYING`; and the vendored Catch2 header is licensed under the Boost Software License 1.0, as also documented in `src/dashbls/NOTICE`. The more-specific mimalloc stanza handles only mimalloc, so it does not correct these classifications. Add more-specific Files stanzas for the MIT paths and Catch2, along with the corresponding MIT/Expat and BSL-1.0 license definitions.
In `src/Makefile.dashbls.include`:
- [NITPICK] src/Makefile.dashbls.include:124-126: Ignore the generated dashbls benchmark binary
This newly added benchmark target creates `src/dashbls/runbench` in the source tree. The root `.gitignore` ignores `src/dashbls/runtest` but not `runbench`, so a benchmark-enabled build leaves the generated binary as an untracked file. Add `src/dashbls/runbench` to the root ignore rules.
bls-signatures moved definitions out of its headers into hdkeys.cpp, hkdf.cpp, secure.cpp and util.cpp. Add them, and secure.h, to libdashbls. Build test/test_secure.cpp into runtest as upstream does; it includes secure.h from dashbls/src. Suppress TSan races for test_secure.cpp: mimalloc's C code is built without -fsanitize=thread, so TSan cannot see the atomics that hand a freed block from a finished thread to another, and reports the next writes to that block (same class as dashpay#7558).
GMP was only needed by relic.
dashbls's own autotools build compiled src/test-bench.cpp into src/dashbls/runbench whenever benchmarks were enabled. Its build files went away with the subtree update to bls-signatures@77c8da5, and the integrated build added in dashpay#7678 only brought back runtest. Build it again under ENABLE_BENCH, and keep it out of the CI bundle like the other test and bench binaries.
7d5bd92 to
688b47a
Compare
…itcoin#30664, bitcoin#31013, bitcoin#31395) bc908d1 partial Merge bitcoin#30664: build: Remove Autotools-based build system (pasta) 69db231 doc: describe the CMake build (pasta) e162a2a guix: make the build-id check reliable and report its failures (pasta) 2584f0b guix: build releases with CMake (pasta) 0feb3b3 ci: build and test every job with CMake (pasta) 1ac032c Merge bitcoin#31013: depends: For mingw cross compile use -gcc-posix to prevent library conflict (laanwj) 22ee095 Merge bitcoin#31395: build: Set shared linker flags in toolchain file (TheCharlatan) 313e982 build: adapt the CMake build to Dash (pasta) a4176c8 partial Merge bitcoin#30454: build: Introduce CMake-based build system (merge-script) Pull request description: ## Issue being fixed or feature implemented Bitcoin Core replaced Autotools with CMake (bitcoin#30454 added the CMake build and switched CI, Guix and the documentation; bitcoin#30664 removed Autotools). Since then every upstream backport carries build-system changes that Dash cannot apply, and keeping two build systems in step would double the maintenance for every source, flag or dependency change. This PR switches Dash Core to CMake and removes the Autotools build. ## What was done? The series is nine commits, in this order: 1. **`partial Merge bitcoin#30454`** imports upstream's CMake tree at merge commit `338bc2cd261`: the top-level `CMakeLists.txt`, the `cmake/` modules, the per-directory `CMakeLists.txt` and `depends/toolchain.cmake.in`, with source lists and target names changed to the Dash tree. 2. **`build: adapt the CMake build to Dash`** brings it to parity with the Autotools build it replaces: - Dash feature detection: the miner, the X11 SSSE3/AES-NI/ARM sources, stacktraces and crash hooks, zstd. - Version reporting, executable names, Windows resources and the NSIS installer. - The public `libdashconsensus` with its existing `.so.0` soname. - dashbls compiled from Dash's source list, with blst from depends. - The Dash Platform GUI (`-DENABLE_PLATFORM_GUI`, enabled by depends' `PLATFORM_GUI`). - Dash source lists, WERROR builds, and the `check-symbols`, `check-security`, `check-stdlib-paths` and `osx_debug` maintenance targets. - Linux binaries keep their `-Wl,--build-id=sha1` build-id, which the Guix release script needs to match them to their split debug files. - `ctest` runs what `make check` ran, including the dashbls and minisketch tests. 3. **`Merge bitcoin#31395`** applies depends' linker flags to shared libraries too, so the cross-compiled `libdashconsensus` links with the depends linker. 4. **`Merge bitcoin#31013`** uses the posix variant of the mingw C compiler as well as the C++ one. When both variants are installed and win32 is the default, as in the CI image, CMake otherwise links the win32 libstdc++, and `test_dash.exe` deadlocks. 5. **`ci:`** - `ci/dash/build_src.sh` configures every job with CMake, keeping the `build-ci/dashcore-$BUILD_TARGET` layout the workflows bundle from. Jobs built on depends use its toolchain file. The ASan job builds against system libraries (#8106), so it has no toolchain file to turn on UPnP, NAT-PMP, zstd and USDT and names them in its own options. - `test_unittests.sh` runs `ctest`. - Every `ci/test/00_setup_env_*.sh` maps its configure flags to CMake options, with extra flags passed through `APPEND_CPPFLAGS`, `APPEND_CFLAGS`, `APPEND_CXXFLAGS` and `APPEND_LDFLAGS`. - The fuzz and MSan jobs keep the standard-library debug defines of their `DEBUG=1` depends build. The toolchain file applies those to Debug builds only, so the jobs pass them in `APPEND_CPPFLAGS`. - The tidy job uses CMake's `compile_commands.json` instead of Bear. - Functional tests run from the build directory, as upstream does. 6. **`guix: build releases with CMake`**: `contrib/guix/libexec/build.sh` configures, builds, checks, installs and deploys with CMake, following upstream's e821f0a. macOS releases keep their dSYM debug archives, and Windows releases still disable the miner. The Debian packaging and the GitHub Actions deploy image use CMake too. 7. **`guix: make the build-id check reliable`**: the check reads all of `readelf`'s output, so binaries with USDT probe notes are no longer misreported as lacking a build-id under `pipefail`, and it prints the binaries that fail instead of exiting silently. 8. **`doc:`** The build guides, developer notes, depends, test and fuzzing docs and the agent guide describe the CMake workflow. `doc/release-notes-7481.md` announces the switch. 9. **`partial Merge bitcoin#30664`** removes Autotools: - `autogen.sh`, `configure.ac`, every `Makefile.am`, the `src/Makefile.*.include` fragments and `build-aux/m4`. - `share/genbuild.sh`, depends' `config.site.in`, `src/.bear-tidy-config`, `src/univalue/sources.mk`. - The convenience Makefiles in `src/`, `src/qt` and `src/test`, and the `.gitignore` entries for in-tree build products. - Leftover references in comments, scripts and `.editorconfig`. The vendored subtrees keep their own build files, and depends packages keep their upstream Autotools builds. Not carried over: - From upstream: `vcpkg.json`, `CMakePresets.json` (MSVC presets only) and the MSVC build guide. Dash Core does not build with MSVC, and CMake stops with an error there, so they would describe a build that cannot run. They can come back with MSVC support. - From upstream: test and fuzz registrations whose source files Dash does not have, because the upstream change is not backported yet or belongs to a feature Dash does not adopt. - From Autotools: the experimental shared `libdashkernel` (`--with-experimental-kernel-lib --enable-shared`), which the CMake build does not provide, so the nowallet CI job no longer builds it. - From Autotools: `--enable-suppress-external-warnings` has no CMake equivalent; vendored headers are included as system headers instead. - The win64 CI job builds `install` instead of `deploy`. The CI image has no `makensis`, and Autotools skipped the installer silently, so CI never built it. Guix still does. ## How Has This Been Tested? CI at the PR head covers every job: cross builds, sanitizers, fuzzing, multiprocess, tidy, `ctest` and the full functional suite. Before the final history cleanup, on a tree that differs from this head only by the points listed below: - The Guix build passed on all 7 hosts, which exercises `check-security`, `check-symbols`, `check-stdlib-paths`, the macOS dSYM archives, the NSIS installer and the build-id debug split. - Locally on x86_64 Linux: built depends with `PLATFORM_GUI=1`, configured with `-DWERROR=ON -DBUILD_BENCH=ON -DBUILD_FUZZ_BINARY=ON -DENABLE_EXTERNAL_SIGNER=ON -DWITH_ZMQ=ON` and built everything, including dash-qt with the Platform SDK. `ctest` passed 183/183, and `build/test/functional/test_runner.py` passed wallet_basic, wallet_descriptor, tool_wallet, rpc_blockchain, mining_basic, feature_dip3_deterministicmns and feature_llmq_signing. Changed since then: the MSVC files were dropped, the minisketch test was added to `ctest`, the fuzz and MSan jobs got their debug defines back, and `gen-dash-conf.sh` and `ci/dash/build-docker.sh` default to `build/`. After #8136 merged, its new `span_tests.cpp` was added to the unit-test list, and after #8072 merged, its new `package_eval.cpp` was added to the fuzz target list; those rebases were not built locally. After #7679 merged, the dashbls target picked up its new sources, `dashbls_runtest` gained `test_secure.cpp`, and `dashbls_runbench` was added; on macOS arm64 those three targets build with `-Wall -Wextra -Werror` from `cmake/dashbls.cmake` in a small wrapper project, and `dashbls_runtest` passes. After #8165 merged (`-Wundef`, with the X11 headers fixed for it), the CMake build stopped downgrading `-Wundef` under `WERROR`, and the TSan job passes `-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES`; on macOS arm64 that head builds with `-DWERROR=ON` (no GUI), and `crypto_tests`, `hash_tests`, `netbase_tests`, `bls_tests` and `dashbls_runtest` pass. On macOS arm64 the tree configures with CMake, and the new `libminisketch_test` builds and passes. ## Breaking Changes Building from source now requires CMake 3.22 or later: `cmake -B build && cmake --build build`, with `--toolchain depends/<host>/toolchain.cmake` for depends builds. `./autogen.sh` and `./configure` no longer exist. Functional tests are run as `build/test/functional/test_runner.py`. Release artifacts and executable names are unchanged. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(if you have permission to set one)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Top commit has no ACKs. Tree-SHA512: b719a9ceb5081a1aeec09afb9fe303bbb4f9a180aee5d5cbd8cae4955c8b31451be341f9873c02d4ef36b2fbd991170477ee053994e89b598f864a2182bdad85
Issue being fixed or feature implemented
Since #7678 Dash Core builds
src/dashblswith its own autotools files on top of blst. The subtree still carried relic and everything that serves only the standalone bls-signatures build: CMake files, the Go/Rust/JS/Python bindings, their CI workflows and helper scripts.This is a prerequisite for #7680 - inline calls of blst directory to dash bls primitives: CBLSPrivateKyee, CBLSPublicKey, CBLSSignature, etc.
What was done?
src/dashblssubtree to dashpay/bls-signatures@85f016781b. Upstream removed the unused relic tree there and moved definitions from headers intohdkeys.cpp,hkdf.cpp,secure.cppandutil.cpp.src/Makefile.dashbls.include, and built upstream'stest/test_secure.cppintodashbls/runtest.src/dashbls. What stays is what Dash Core builds and tests: the library sources and headers, the Catch2 tests with the reference vectors and their generator, mimalloc,LICENSE,NOTICEandREADME.md.src/dashbls/NOTICEandREADME.mdno longer describe the removed code.contrib/debian/copyright.libgmp-devfrom the slim CI image; GMP was only needed by relic.No changes to Dash Core's own sources.
How Has This Been Tested?
CI.
Breaking Changes
None.
Checklist: