Repository navigation
Conversation
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
|
This pull request has conflicts, please rebase. |
, bitcoin#31099, bitcoin#31172, bitcoin#31450, bitcoin#31608, bitcoin#31818, bitcoin#29881, bitcoin#32458, bitcoin#32400, bitcoin#32760, bitcoin#33178, bitcoin#33312, bitcoin#33780, bitcoin#33181, bitcoin#34102, partial bitcoin#29023, bitcoin#30454, bitcoin#30509, bitcoin#30510, bitcoin#31105, bitcoin#32922, bitcoin#33489, bitcoin#33445 (build backports: part 5) ad5c299 doc: add release notes (Kittywhiskers Van Gogh) 6350e93 merge bitcoin#34102: capnp 1.3.0 (Kittywhiskers Van Gogh) e6e4ad0 merge bitcoin#33181: build for Linux HOSTS with `-static-libgcc` (Kittywhiskers Van Gogh) e403bba merge bitcoin#33780: disable libsanitizer in Linux GCC build (Kittywhiskers Van Gogh) 88108ac partial bitcoin#33445: Update Clang in "tidy" job (Kittywhiskers Van Gogh) f9686bb partial bitcoin#33489: Drop support for EOL macOS 13 (Kittywhiskers Van Gogh) 4a6de56 merge bitcoin#33312: Disable `UndefinedBinaryOperatorResult` check in `src/ipc` (Kittywhiskers Van Gogh) 00f46c2 merge bitcoin#33178: increase maximum allowed (runtime) GCC to 7 (Kittywhiskers Van Gogh) 49f815d partial bitcoin#32922: use notarized v28.2 binaries and fix macOS detection (Kittywhiskers Van Gogh) 7bf7523 merge bitcoin#32760: capnp 1.2.0 (Kittywhiskers Van Gogh) 369e875 merge bitcoin#32400: Use modern Windows randomness functions (Kittywhiskers Van Gogh) 62cb45b merge bitcoin#32458: move `*-check.py` scripts under `contrib/guix/` (Kittywhiskers Van Gogh) 362013a merge bitcoin#29881: use GCC 13 to build releases (Kittywhiskers Van Gogh) bfcf58a merge bitcoin#31818: remove test-security/symbol-check scripts (Kittywhiskers Van Gogh) 973eca0 merge bitcoin#31608: Clarify min macOS and Xcode version (Kittywhiskers Van Gogh) 7f80572 merge bitcoin#31450: disable gcov in base-linux-gcc (Kittywhiskers Van Gogh) e189624 merge bitcoin#31172: increase minimum supported Windows to 10.0 (Kittywhiskers Van Gogh) 8494bd6 partial bitcoin#31105: Update libmultiprocess library (Kittywhiskers Van Gogh) 29c8bd9 merge bitcoin#31099: drop macOS LLVM install instructions (Kittywhiskers Van Gogh) 84b1e17 fix: bump `darwin_cmake_system_version` to match `OSX_MIN_VERSION` (Kittywhiskers Van Gogh) cdc411d merge bitcoin#31048: Bump minimum supported macOS to 13.0 (Kittywhiskers Van Gogh) 5515a69 partial bitcoin#30510: Add IPC wrapper for Mining interface (Kittywhiskers Van Gogh) ce6504e merge bitcoin#27038: test for `_FORTIFY_SOURCE` usage in release binaries (Kittywhiskers Van Gogh) 140848d partial bitcoin#30509: Add -ipcbind option to bitcoin-node (Kittywhiskers Van Gogh) 9df31ce partial bitcoin#30454: Introduce CMake-based build system (Kittywhiskers Van Gogh) 310a652 merge bitcoin#30423: simplify `test-security-check` (Kittywhiskers Van Gogh) 3bb0e30 partial bitcoin#29023: add historical release notes for 26.0 (Kittywhiskers Van Gogh) c725a30 docs: add omitted "Compatibility" heading to release notes template (Kittywhiskers Van Gogh) Pull request description: ## Motivation While working on adding support for Rust to our build system (see [dash#7109](#7109)), there were sources of conflict between our current setup and the minimums demanded by Rust and our FFI crate, [`cxx`](https://github.com/dtolnay/cxx). Specifically, Dash Core currently targets building for Windows 7 ([source](https://github.com/dashpay/dash/blob/cc50446936f8436d9ac3a2442bb348d93d8ba314/configure.ac#L818), [`0x601`](https://learn.microsoft.com/en-gb/windows/win32/winprog/using-the-windows-headers)) in direct conflict with the decision by Rusts' maintainers to drop support for Windows 7 effective Rust 1.78 ([source](https://blog.rust-lang.org/2024/02/26/Windows-7/)) More recent versions of Rust have issues that require additional workarounds (see [`rust-lang/rust#128218`](rust-lang/rust#128218)) to keep support for Windows 7 around and using older versions of Rust is infeasible since both [`cxx`](https://github.com/dtolnay/cxx) and Rust packages currently under evaluation for integration with Dash Core require Rust 1.82+. Additionally, non-conformant definitions in the macOS SDK cause issues when attempting to build crates with FFI definitions (see [`dtolnay/cxx#1574`](dtolnay/cxx#1574)) which is resolved by an additional SDK bump that is not in the scope of this PR as it is _above_ the SDK version used upstream but does give cause to also consider a macOS target version bump, which _is_ done by upstream. ## Additional Information * Dependent on #6919 * Dependency for #7109 * macOS 11 (Big Sur) had its support period elapse ~2 years ago ([source](https://endoflife.date/macos)). macOS 14 (Sonoma) is the lowest version of macOS still receiving support from Apple and the new minimum version elected by upstream. * Windows 7 had its _extended_ support period elapse ~5 years ago ([source](https://learn.microsoft.com/en-gb/lifecycle/products/windows-7)) with the second lowest version, Windows 8.1, had its _extended_ support period elapse ~2 years ago ([source](https://learn.microsoft.com/en-us/lifecycle/products/windows-81)). ## Breaking Changes Dash Core binaries will now target Windows 10 and macOS 14 (Sonoma), replacing the previous target Windows 7 and macOS 11 (Big Sur). ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK ad5c299 Tree-SHA512: 650cbc12f2f129770623fd4e62bd7eb77ba0677ae33b765cc8359878633562e2a5c302f86d399400bb798d6a0ac5e6c030f3b8c657b63178f468bbe0d1b246a5
|
This pull request has conflicts, please rebase. |
68f1157 to
9da49be
Compare
|
Guix Automation has began to build this PR tagged as v23.0.2-devpr7109.9da49bec. A new comment will be made when the image is pushed. |
Checksums for 9da49bec |
|
Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.2-devpr7109.9da49bec. The image should be on dockerhub soon. |
|
Guix Automation has began to build this PR tagged as v23.0.2-devpr7109.5443107c. A new comment will be made when the image is pushed. |
|
Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.0.2-devpr7109.5443107c. The image should be on dockerhub soon. |
The conflict occurs due a difference in glibc version between the Guix environment and the targets compiled, this is only a problem for Linux targets so the issue doesn't extend to Windows
|
Guix Automation has began to build this PR tagged as v23.1.0-devpr7109.3582e9c1. A new comment will be made when the image is pushed. |
|
Guix Automation has failed with an unknown error for tag v23.1.0-devpr7109.3582e9c1 |
|
🔨 Guix build started for Targets: x86_64-linux-gnu aarch64-linux-gnu riscv64-linux-gnu x86_64-w64-mingw32 x86_64-apple-darwin arm64-apple-darwin A follow-up comment with checksums will be posted when the build completes. |
|
✅ Guix build complete! Release: https://github.com/dashpay/dash-dev-branches/releases/tag/v23.1.0-devpr7109.3582e9c1 Checksums for 3582e9c |
|
This pull request has conflicts, please rebase. |
1 similar comment
|
This pull request has conflicts, please rebase. |
…st track Measured spike results comparing three integration scopes for rebuilding the platform-gui internals on real dashpay/platform crates (grovedb, drive, dpp) via the dashpay#7109 Rust build track. Recommends the crypto-core scope: canonical proof verification and DPP signing in Rust with zero async runtime, keeping PR 49's C++ transport, quorum-sig check, GUI, and wallet seams. Spike workspaces with lockfiles and test harnesses live in ~/workspace/platform-rust-spikes.
…st track Measured spike results comparing three integration scopes for rebuilding the platform-gui internals on real dashpay/platform crates (grovedb, drive, dpp) via the dashpay#7109 Rust build track. Recommends the crypto-core scope: canonical proof verification and DPP signing in Rust with zero async runtime, keeping PR 49's C++ transport, quorum-sig check, GUI, and wallet seams. Spike workspaces with lockfiles and test harnesses live in ~/workspace/platform-rust-spikes. (cherry picked from commit d3a81f2)
…st track Measured spike results comparing three integration scopes for rebuilding the platform-gui internals on real dashpay/platform crates (grovedb, drive, dpp) via the dashpay#7109 Rust build track. Recommends the crypto-core scope: canonical proof verification and DPP signing in Rust with zero async runtime, keeping PR 49's C++ transport, quorum-sig check, GUI, and wallet seams. Spike workspaces with lockfiles and test harnesses live in ~/workspace/platform-rust-spikes. (cherry picked from commit d3a81f2)
|
🕓 Review not started yet because this PR is a draft.
Commit 3582e9c. Normal review starts when eligible; priority review starts as soon as a slot is available. |
2bf133c docs: cite #8042 for the index fixes in the v24.0.0 release notes (pasta) 8aa11f6 docs: add the v24.0.0-rc.7 picks and index fixes to the v24.0.0 release notes (pasta) ad4e5d6 docs: drop the index caveat from the -reindex-chainstate man page entry (pasta) 19a90bb test: blocks orphaned while the address index is disabled are removed from it (pasta) d2f2a1f fix(index): don't adopt an empty or rebuilt async index as migrated legacy data (pasta) e3bafdb fix(index): reject an uncommitted tip the block index lost (pasta) 9198962 fix(index): check the blocks governance resumes from at startup (pasta) baff347 fix(index): resume from the tip a skipped commit leaves behind (pasta) 2dbf5ca fix(index): write a rewound block's erasures in one batch with its locator (pasta) 252acbe fix(index): move the committed locator below the entries a rewind erases (Konstantin Akimov) e9f9c8a Merge bitcoin#36150: indexes: set prune lock to genesis before first block (Konstantin Akimov) 2edeb98 partial Merge bitcoin#34897: indexes: Don't commit ahead of the flushed chainstate (Konstantin Akimov) 3eba84c Merge bitcoin#32875: index: handle case where pindex_prev equals chain tip in NextSyncBlock() (Konstantin Akimov) 399125c Merge bitcoin#32882: index: remove unnecessary locator cleaning in BaseIndex::Init() (Konstantin Akimov) bb724c6 Merge bitcoin#33212: index: Don't commit state in BaseIndex::Rewind (Konstantin Akimov) d5ff431 Merge bitcoin#32878: index: fix wrong assert of current_tip == m_best_block_index (Konstantin Akimov) 31c7d8f partial Merge bitcoin#32580: wallet, test: best block locator matches scan state follow-ups (Konstantin Akimov) 94f5c58 partial Merge bitcoin#30221: wallet: Ensure best block matches wallet scan state (Konstantin Akimov) 8e0b1e8 partial Merge bitcoin#32069: test: fix intermittent failure in wallet_reorgsrestore.py (Konstantin Akimov) 4d17947 Merge bitcoin#25193: indexes: Read the locator's top block during init, allow interaction with reindex-chainstate (Konstantin Akimov) 0127df8 Merge #8045: test: scale the mempool-loaded wait by timeout_factor so TSAN reindex restarts stop timing out (pasta) 62d0cef Merge #8036: fix(qt): let a shared masternode participant follow a revised invitation that keeps their share (merge-script) 775d31c Merge #8018: fix(consensus): require IPv4 masternode primaries until IPv4 is optional, pin mainnet ports (merge-script) e1b826e Merge #8026: fix(qt): keep shared masternode contribution fields locked while coins are reserved (merge-script) 9fa3df3 Merge #8020: fix(rpc): make protx shared_sign sign only dissolutions that return every principal (merge-script) 246a465 Merge #8024: fix(qt): keep the shared masternode dissolve dialog consistent with what it will send (merge-script) 590ad0a Merge #8021: fix(qt): don't load a newer shared masternode session copy that changes your own share (merge-script) 974aaa3 Merge #8034: fix(qt): check a shared masternode's service and refund addresses before coins are reserved (merge-script) 0026e3e Merge #8027: fix(qt): fund a shared masternode's service update from this wallet by default (merge-script) 6a5d2dc Merge #8035: fix(qt): don't strand coins reserved for a shared masternode session (merge-script) df6083a Merge #8032: fix(qt): don't offer a new operator key when reopening a shared masternode session (merge-script) 2b5bf30 Merge #8029: fix: let dashd -version, -help and first start work without an existing data directory (merge-script) e33d9b1 Merge #8037: docs: list the config file path each Linux init system uses (merge-script) 6030ea0 docs: add the #8014 migratewallet fixes to the v24.0.0 release notes (pasta) 1b1ea95 Merge #8014: backport: bitcoin#28609, bitcoin#34215, bitcoin#34226, bitcoin#34370, partials bitcoin#31423, bitcoin#34156 (migratewallet fixes from 28.x) (merge-script) 608ff63 Merge bitcoin#28542: wallet: Check for uninitialized last processed and conflicting heights in MarkConflicted (DCG-Claude) 3af6f63 Merge bitcoin#28038: wallet: address book migration bug fixes (DCG-Claude) 2fe41fb docs: add ecosystem notes on Asset Unlock txids, coinbase payees and RPC errors (pasta) 0e3f653 docs: correct operator guidance in the v24.0.0 release notes for rc.7 (pasta) 11c8140 Merge #8019: fix(qt): stop reporting refused shared masternode broadcasts as sent (merge-script) Pull request description: ## Issue being fixed or feature implemented Backports and release prep for v24.0.0-rc.7, on top of `v24.0.x` at 8d195f1 (v24.0.0-rc.6, #8013). This PR collects the develop merges labeled `backport-candidate-24.0.x`, the v24.0.x port of #8042 with the index fixes from #8033, and the release notes for them, so rc.7 has a single backport PR to merge. ## What was done? ### Picked Cherry-picked with `git cherry-pick -m1 -x`, in develop merge order, except that bitcoin#28038 goes before bitcoin#28542 as in Bitcoin Core. Each pick changes exactly the same lines as its develop merge, except as noted below for bitcoin#28542, #8014, #8020 and #8018. - #8019 fix(qt): stop reporting refused shared masternode broadcasts as sent - bitcoin#28038 (from #7863): prerequisite of #8014 - bitcoin#28542 (from #7762): prerequisite of #8014. Its `test_conflict_txs` migrates through `self.migrate_wallet`, as on develop since bitcoin#28868. - #8014 backport: bitcoin#28609, bitcoin#34215, bitcoin#34226, bitcoin#34370, partials bitcoin#31423, bitcoin#34156 (migratewallet fixes from 28.x), with the Dash adaptations below - #8037 docs: list the config file path each Linux init system uses - #8029 fix: let dashd -version, -help and first start work without an existing data directory - #8032 fix(qt): don't offer a new operator key when reopening a shared masternode session - #8035 fix(qt): don't strand coins reserved for a shared masternode session - #8027 fix(qt): fund a shared masternode's service update from this wallet by default - #8034 fix(qt): check a shared masternode's service and refund addresses before coins are reserved - #8021 fix(qt): don't load a newer shared masternode session copy that changes your own share - #8024 fix(qt): keep the shared masternode dissolve dialog consistent with what it will send - #8020 fix(rpc): make protx shared_sign sign only dissolutions that return every principal. Its `doc/release-notes-7437.md` sentence goes into the same paragraph of `doc/release-notes.md`, since that file was folded in for v24.0.0. - #8026 fix(qt): keep shared masternode contribution fields locked while coins are reserved (merged on develop as cc73a04; GitHub shows the PR as closed) - #8018 fix(consensus): require IPv4 masternode primaries until IPv4 is optional, pin mainnet ports, with the adaptation below - #8036 fix(qt): let a shared masternode participant follow a revised invitation that keeps their share - #8045 test: scale the mempool-loaded wait by timeout_factor so TSAN reindex restarts stop timing out ### Index fixes: #8042 port and #8033 The index commits are #8042 (merge 9e5e3d5), ported commit by commit to `v24.0.x`, plus the parts of #8033 that #8042 doesn't cover. #8042's v24.0.x port replaces #8033's bitcoin#33212, bitcoin#34897 and rewind-locator commits, and #8033's flushed-block announcement fix (e6a687b) is dropped: bitcoin#30221 removes the wallet's `ChainStateFlushed` locator write, and nothing else on `v24.0.x` consumes that notification. This PR replaces #8033, and #8031 comes in through it (adapted to the `v24.0.x` `CCoinsViewDB` constructor), not as a separate pick. - bitcoin#25193 (from #7883, via #8033): indexes: read the locator's top block during init, allow interaction with `-reindex-chainstate` - From #8042: partial bitcoin#32069 (only `TestNode.kill_process()`, with develop's `wait_until_stopped(**kwargs)` handling it needs), partial bitcoin#30221, partial bitcoin#32580, bitcoin#32878, bitcoin#33212, bitcoin#32882, bitcoin#32875, partial bitcoin#34897, bitcoin#36150, and #8042's own fixes: move the committed locator below the entries a rewind erases; write a rewound block's erasures in one batch with its locator; resume from the tip a skipped commit leaves behind; check the blocks an index resumes from at startup; reject an uncommitted tip the block index lost - From #8033: #8031 fix(index): don't adopt an empty or rebuilt async index as migrated legacy data; test: blocks orphaned while the address index is disabled are removed from it; docs: drop the index caveat from the `-reindex-chainstate` man page entry #### Dash adaptations for #8042 - The governance collateral index doesn't exist on `v24.0.x`, so its hunks are dropped; from the startup resume check only the `base.{h,cpp}` part is kept. - `feature_pruning.py`: node 5 syncs before node 0's pruned restart, and `test_rescan_blockchain` expects the governance-disabled stderr a pruned node prints on `v24.0.x`. - The wallet's `blockConnected` has no birthday skip on `v24.0.x`. - `TestNode.wait_until_stopped()` keeps `v24.0.x`'s `None` default for a clean exit. Apart from these, the `v24.0.x` index, validation and index test sources differ from develop after #8042 only by differences that already existed before it. #### Dash adaptations for #8018 `v24.0.x` predates bitcoin#26177, so it has no `src/kernel/chainparams.cpp` and no `GetBuriedDeployment()`. The four `IPv4OptionalHeight` values (mainnet not scheduled, testnet 0, devnet 0, regtest only through `-testactivationheight=ipv4_optional@<height>`) go into the matching classes in `src/chainparams.cpp`, and `ipv4_optional` is parsed in its `MaybeUpdateHeights()`. The `GetBuriedDeployment()` hunk is dropped; the `DeploymentName()` case is kept. Every other file, including all tests, changes exactly the same lines as the develop merge. The same notes are in the pick's commit message. #### Dash adaptations for #8014 #8014 doesn't cherry-pick cleanly onto `v24.0.x`. The conflicts were resolved against `v24.0.x` APIs. No prerequisite was backported, and no hunk or test was dropped. The same notes are in the pick's commit message. - `src/wallet/bdb.{cpp,h}`, `dump.cpp`, `sqlite.{cpp,h}`, `transaction.{cpp,h}`, `wallet.cpp`: the changed lines are identical to the develop merge. In `wallet.cpp`, the conflict was with develop-only context (`CanGrindR`), which stays out. - `src/wallet/db.h`: #8014 makes `WalletDatabase::Files()` pure virtual. `v24.0.x` still defines `DummyDatabase` in `db.h`, so it gets the `Files()` override there. - `src/wallet/test/wallet_tests.cpp`: the test database mock on `v24.0.x` is `FailDatabase`, so it gets the same `Files()` override. `src/wallet/salvage.cpp` and `src/wallet/test/util.h` keep the `v24.0.x` side, since develop's `DummyDatabase`/`MockableDatabase` placement doesn't exist here. - `test/functional/tool_wallet.py`, `wallet_backup.py`, `wallet_migration.py`: the test framework on `v24.0.x` has no `TestNode.wallets_path`/`datadir_path` (bitcoin#27884), so the new tests build these paths with `os.path.join` and pass RPC paths as strings. `wallet_migration.py` takes only #8014's new tests, not the develop-only tests around them. - `test/functional/wallet_migration.py`: `unsynced_wallet_on_pruned_node_fails` stops its pruned node with `EXPECTED_STDERR_NO_GOV_PRUNE`, because on `v24.0.x` a pruned node still prints the governance-disabled warning. The rc.6 picks handled the same warning the same way. ### Separate v24.0.x PRs, merged separately - #8016 backport: v23.1.10 fixes for v24.0.x - #8022 backport: bind CoinJoin signatures to the approved transaction (#7815) for v24.0.x, which depends on #7815 merging on develop #8016 and #8022 each merge cleanly with this branch in either order, and all three merge to the same tree in any order. ### Not picked - #8025: closed; superseded by #8014 (picked above) - #8031 is not picked separately; it comes through #8033's commits above. - #8039, #8040, #8041, #8043, #8044 (CI and tooling), #7905, follow-ups to #8042, and the PRs in the 24.1 milestone. - Explicitly deferred: #7870, #7679, #7675, #7220, #7217, #7109, #6988, #4974, #8028. ### Release notes `doc/release-notes.md` corrections, checked against the code on this branch: - **Version 2 Asset Unlocks:** version 1 Asset Unlocks stay valid after `v24` activation. Platform withdrawals keep using version 1 until a future Dash Platform release issues version 2, so the stable txid, InstantSend locking and instance-hash relay don't apply to them yet. - **Masternode requirements:** the startup refusals (#7754) and the DKG bad votes for missing transaction relay or compact filters (#7755) apply from the first start of v24.0.0, not from activation. Operators should remove conflicting settings and upgrade before the `v24` start date (November 9, 2026), so their masternodes are running when the activation signal is signed. `-peerblockfilters=0` is the new refusal; `-blockfilterindex=0` already failed on v23. - **How to Upgrade:** a pruned node with `-addressindex` or `-spentindex` now refuses to start; v23 accepted that combination. - **Downgrading:** there is no supported downgrade after `v24` activation: older versions can't follow the network, and they misread the masternode list data v24.0.0 writes. Before activation, downgrading to v23.1.x works with the listed caveats. Dash-Qt's dust-protection setting is migrated to the shared settings, so it reads as disabled after a downgrade. - **Dash Platform:** Platform/dashmate v5.0.0 and later handle the hidden `service` and `softforks` RPC fields. Older Platform versions need both `-deprecatedrpc` options. - **Compatibility:** users on macOS 13 or older must upgrade macOS, or move their node, before activation. - **Legacy wallets:** in v24, `createwallet` with `descriptors=false` also needs `load_on_startup`; before v24 this applied only to `descriptors=true`. The notes now give a working example. - **Wallet migration (#8014):** failure handling in `migratewallet`, `restorewallet` and `dash-wallet createfromdump` is fixed, and the new backup and watch-only/solvables wallet names are listed. - **Ecosystem notes:** the txid of a version 2 Asset Unlock zeroes `requestedHeight`, `quorumHash` and `quorumSig` before hashing (the full-bytes hash is `instanceHash`); pools should emit one coinbase output per `masternode[]` and `superblock[]` template entry, since merged or deduplicated payees are invalid after activation; client libraries that send numbers or booleans as strings fail (#7099); and some wallet RPC error messages changed with upstream backports. - **rc.7 picks:** `doc/release-notes-8018.md` and `doc/release-notes-8029.md` are folded in and removed. #8018's IPv4-primary and mainnet standard-port rules are under Extended addresses, with a pointer from the masternode upgrade notes; #8029's `dash.conf` change is under Updated settings. The other rc.7 picks fix code that is new in v24 and need no release note. - **Index fixes (#8042, #8031):** nodes that ran a release candidate with the address, spent or timestamp index should rebuild them once (with `-reindex`, or by starting once with them disabled, deleting their `indexes/` directories and starting with them enabled). The notes also cover `-reindex-chainstate` with indexes enabled, older versions refusing a migrated index until `-reindex`, the new "the block the index was last synced to is not found. Please rebuild the index." startup error, and the known limitation shared with earlier versions in the remaining cases. - All rc.7 TODO comments are resolved. `configure.ac` is already 24.0.0 with `CLIENT_VERSION_IS_RELEASE` false, so the version string comes from the `v24.0.0-rc.7` tag. The man pages carry #8033's `-reindex-chainstate` change; no other pick changes non-debug help text (#8018's `-testactivationheight` change is debug-only). ## How Has This Been Tested? On this head (2bf133c): - Every develop pick compared with its develop merge (`git patch-id --stable` and the set of changed lines). #8019, #8037, #8032, #8035, #8027, #8034, #8021, #8024, #8026, #8036 and #8045: identical. #8029: the same changed lines; only context differs in `feature_config_args.py`. #8020: the same changed lines, in `doc/release-notes.md` instead of `doc/release-notes-7437.md`. #8018: identical except the adaptation above, checked file by file against 900f085 and reviewed separately for consensus equivalence on mainnet, testnet, devnet and regtest. #8014 and its prerequisites: as in the earlier rounds (adaptations above). - #8042 port: `v24.0.x`'s divergence from develop, before #8042 (058b060) versus after it (9e5e3d5), is unchanged in `src/index/*`, `src/validation.{h,cpp}`, the index unit tests and `feature_coinstatsindex.py`, apart from the adaptations listed above. The #8031, test and man page commits have the same patch-id and message as on #8033. - Built with `--enable-debug --enable-werror` and Qt: no warnings. - Unit suites pass: `baseindex_tests`, `index_migration_tests`, `txindex_tests`, `blockfilter_index_tests`, `coinstatsindex_tests`, `validation_flush_tests`, `wallet_tests`, `interfaces_tests`, `evo_netinfo_tests` and `evo_snapshot_tests`. With the develop picks (7275005), every `evo_*` suite and `test_dash-qt` (15 classes, 152 passed, 0 failed) passed too. - Functional tests pass: `rpc_netinfo.py`, `feature_masternode_shares.py`, `wallet_migration.py`, `feature_coinstatsindex.py` (including the unclean restart after a reorg), `feature_addressindex.py`, `feature_config_args.py` and `feature_index_prune.py`. On the same C++ tree, these pass as well: `feature_spentindex.py`, `feature_timestampindex.py`, `feature_pruning.py`, `feature_txindex.py`, `feature_reindex.py`, `feature_init.py`, `feature_abortnode.py` and `wallet_reorgsrestore.py`. - Regtest upgrade gates, run on a build of this exact head: all pass. They cover v23.1.10 index migration, index contents vs v23 and `-reindex`, a kill mid-migration, 9 wallets, a pre-activation downgrade and round trip, and v22.1.3/v23.0.2 upgrades. The crash-after-reorg probe and the deleted-index probe are both required to be not reproduced: 0/10 stale (rc.6: about 4/10), and the plain-delete rebuild matches. - Man pages: `help2man` output of the built `dashd`, `dash-cli`, `dash-tx`, `dash-wallet` and `dash-util` matched `doc/man` on the develop picks (apart from the debug-build-only `lock` log category). No later commit changes non-debug help text, so nothing is regenerated beyond #8033's `-reindex-chainstate` change. - `git merge-tree` against #8016 (cdb250c) and #8022 (62609bf), heads fetched 05:23 UTC: clean in both orders, and all three merge to the same tree in every order. From the earlier rounds: the wallet suites and functional tests listed for #8014, bitcoin#28038 and bitcoin#28542 passed, and the `createwallet` example was checked against the official v24.0.0-rc.6 binary. ## Breaking Changes - From #8014: migration backups are now named `<name>_<time>.legacy.bak`, the unnamed wallet's watch-only and solvables wallets are named `default_wallet_watchonly` and `default_wallet_solvables`, and `restorewallet` accepts an existing empty directory. - From #8018: on mainnet, a version 3 ProRegTx or ProUpServTx must list an IPv4 address on the standard port as the first entry of each address list; testnet and devnets are unaffected. - From #8029: `dashd` no longer creates an empty `dash.conf`. - From #8031: older versions refuse an index migrated by v24.0.0 until they run `-reindex`; nodes that ran a release candidate should rebuild these indexes once. - From #8042: an index whose last synced block was lost in an unclean shutdown makes startup fail with a rebuild instruction. The release notes describe these. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone 🤖 Generated with [Claude Code](https://claude.com/claude-code) Top commit has no ACKs. Tree-SHA512: 3c405ef570fc1c5b46d1ba8bb2e344213cf65018abe5ef4b94b7cf2b9aa7160ba2675f71a0a365c72bc8249a2f9a5defe774af2a4e33537245aeb420c5f66711
…ehind PLATFORM_GUI=1 bfe078a ci: build linux64 against depends with PLATFORM_GUI=1 (pasta) 2525537 build: add --enable-platform-gui (pasta) 3a4de8a build(depends): build dash-sdk-cxx behind a PLATFORM_GUI knob (pasta) 30f071c build(depends): add a prebuilt Rust toolchain and per-host standard library (pasta) Pull request description: ## Issue being fixed or feature implemented The Dash Platform GUI (DPNS usernames, DashPay profiles, contacts and contact payments) links a Rust library: `dash-sdk-cxx`, from `packages/rs-sdk-cxx` in dashpay/platform (dashpay/platform#4633). It is a thin cxx binding of `dash-sdk`, which handles transport, proof verification and state-transition assembly. Core keeps the keys, the trust inputs and the UI. This PR is only the build foundation: depends can build the binding behind `PLATFORM_GUI=1`, and `configure --enable-platform-gui` can link it. Nothing in `src/` uses it yet. #7512 has the full map of the stack. ## Decision requested Before reviewing the code, maintainers need to answer one question: **should depends carry a prebuilt, sha256-pinned Rust toolchain and a prebuilt protoc, built only when `PLATFORM_GUI=1` is set?** If the answer is no, this PR closes, and the stacked client and GUI PRs (#7670, #7671, #7765, #7766, #7767) need a different design. The wallet seams in #7763 are useful either way. **What depends would carry (only with `PLATFORM_GUI=1`)** | Package | What | Pinned by | |---|---|---| | `native_rust` | prebuilt `rustc` and `cargo` 1.98.1 (the toolchain dashpay/platform pins), from the component `.tar.xz` archives, for the four build hosts depends supports | sha256 of each static.rust-lang.org archive | | `rust_stdlib` | prebuilt Rust standard library for the host, and for the build machine when it differs; every Linux host uses the glibc (`-unknown-linux-gnu`) one | sha256 per host | | `native_protobuf` | prebuilt `protoc` 32.0, which build scripts in the crate closure (such as tenderdash-proto's) use to generate protobuf code | sha256 per build host | | `platform_cxx` | `dash-sdk-cxx` (`libdash_sdk_cxx.a`, headers `dash/sdk/*.h`), built `--frozen --offline` from a Platform source tarball and a crate bundle, both at one Platform commit | commit plus two sha256s | **Costs** - Download: the Rust toolchain's rustc and cargo components are 57 MB to 91 MB per build architecture (91 MB for x86_64 Linux), plus 26 MB to 30 MB of standard library per host (and for the build machine when it is a different target). The Platform tarball is 158 MB and the crate bundle 63 MB. - Mirror: every pin bump adds those two Platform archives to the depends sources mirror. The bundle has no upstream URL, and GitHub does not promise stable bytes for its archive endpoint. - CI: one more depends job (`x86_64-pc-linux-gnu_platform_gui`). The `linux64` job builds against it instead of the shared `x86_64-pc-linux-gnu` depends, which `linux64_asan` and `linux64_fuzz` keep, so there is no extra build or test job. - Maintenance: whoever bumps the pin runs `contrib/devtools/platform-bundle.sh <commit>`, which prints the new pins and reproduces the bundle hash, and uploads both archives. `contrib/devtools/update-rust-hashes.py` refreshes the toolchain pins. **Precedents** - Zcash carries a prebuilt Rust toolchain in its depends. `native_rust.mk`, `rust_stdlib.mk` and `update-rust-hashes.py` are derived from Zcash's. - libmultiprocess is an external library that depends pins by commit. - `PLATFORM_GUI` copies the `MULTIPROCESS` knob, which is the approach requested on #7109. **Default builds are unchanged.** Without `PLATFORM_GUI=1`, depends builds the same package set as develop for every host, and config.site leaves `--enable-platform-gui` off. With it, config.site sets the option to `auto`, which configure keeps on only when the GUI and the wallet are built, so `--enable-fuzz`, `--without-gui` and `--disable-wallet` still configure against those depends. With the option, only `dash-qt`, `test_dash` and `test_dash-qt` link `dash-sdk-cxx`, so `dashd`, `dash-cli`, `dash-tx`, `dash-util`, `dash-wallet`, `bench_dash` and the fuzz binary never link Rust on any OS. CI enforces this: `linux64` builds with the option, and `contrib/devtools/check-no-rust.py` then fails that job if any of those seven binaries contains Rust or cxx-bridge symbols, or has no symbols to check. **It is an opt-in developer build, not a release one.** With `PLATFORM_GUI=1` inside a Guix environment, depends stops with an error, so release binaries are built without it. The remaining Guix work: Guix's own Rust versus the prebuilt one, the mingw-w64 `dlltool`, a two-builder hash match, ring and blst on armhf, ppc64 and riscv64, and a per-binary Windows DLL allowlist for `dash-qt`. `depends/README.md` and `doc/dependencies.md` say this, and that CI builds and tests it on x86_64 Linux only. ## Merge gates 1. **Policy (maintainers).** The decision above. A maintainer approved this PR on 2026-10-21, at the previous pin. The head has changed since (the docs, the two host fixes below, and the rebase onto develop with the CI job move), so it needs a fresh review. 2. **Platform merge. Done.** dashpay/platform#5473 (makes the workspace lockfile vendorable) merged on 2026-10-29, and dashpay/platform#4633 merged on 2026-11-02 into the protected `v5.1-dev` branch. This PR pins that merge commit, `fb463c282ea09adf93dd5d256fc9471969f7a46f`. 3. **Mirror upload. Done (2026-11-02).** Both archives are on the depends sources mirror, and each returns 200 with the pinned sha256: - `platform-fb463c282ea09adf93dd5d256fc9471969f7a46f.tar.gz`, sha256 `8ccb913069ce8d96a32443e98e44e85c331694727cc37c321364711ddaa04039` - `dash-sdk-cxx-crates-fb463c282ea09adf93dd5d256fc9471969f7a46f.tar.gz`, sha256 `da47a0ca89ed023f357a70e19d097f42bd4fe76221ee7bfd1c4eca0102b5f70e` 4. **CI. Done on the fork.** This PR's dashpay CI runs develop's workflows (`pull_request_target`), which have no Platform GUI job, so a green PR run says nothing about the CI commit. The branch's own workflows ran in a fork `push` run against the real mirror (see below). ## What was done? **depends** - `native_rust`, `rust_stdlib`, `native_protobuf` and `platform_cxx`, all added only by `PLATFORM_GUI=1`. Combining it with `NO_QT` or `NO_WALLET` is an error. - The package is named `platform_cxx`, and the configure variables are named `PLATFORM_CXX_*`, after the `PLATFORM_GUI` feature's C++ binding rather than after the crate. The stacked PRs consume those variables, and the crate name appears only where it is the artifact: `-p dash-sdk-cxx`, `libdash_sdk_cxx.a`, `dash_sdk_cxx.pc` and `dash-sdk-cxx-crates-<commit>.tar.gz`. - `platform_cxx` builds only from the two sha256-pinned archives. Cargo runs with `--frozen --offline` and never touches the network. tenderdash-proto's sources come from a Tenderdash archive inside the bundle, next to the `TENDERDASH_COMMITISH` that names it. - Isolation: only the bundle's Cargo configuration is used. Cargo runs from `/` with `--config`, and its home is private. Variables that would change the build (wrappers, `CARGO_BUILD_*`, `CARGO_PROFILE_*`, `CARGO_TARGET_*`, every variable named after the host's or the build machine's Rust triple in either spelling, such as `CC_x86_64-unknown-linux-gnu` or `CFLAGS_x86_64_unknown_linux_gnu`, the generic `CC`/`CFLAGS`/`AR`/`RANLIB` and `HOST_*`/`TARGET_*` fallbacks cc-rs reads, `TENDERDASH_*`) are unset. The depends compilers and flags are then set in Cargo's own environment, after those removals. The release profile is pinned to Platform's (`panic = "unwind"`). - The depends host compiler links the crate and compiles its C and C++. The depends build compiler links build scripts and proc macros. The build directory is remapped out of the objects. - The build fails if the dependency graph (`cargo tree -e normal,build`, matched by exact crate name) reaches the trusted context provider, a general-purpose HTTP client (reqwest, isahc, attohttpc, surf, curl) or a system TLS library (openssl, native-tls, hyper-tls). ureq is allowed: it is only `tenderdash-proto-compiler`'s archive downloader, which never runs, because the bundle carries the archive and Cargo is offline. - **System libraries.** `platform_cxx.mk` holds a vetted per-OS list of the system libraries the archive needs. rustc prints its own list (`--print=native-static-libs`), and the build fails if that list has a library that is neither vetted nor in an explicit, commented ignore set. For example, glibc's `-lutil` and `-lrt` are ignored, because `symbol-check.py` does not allow them and the standard library imports nothing from them. The vetted list goes to configure through an installed `dash_sdk_cxx.pc`. The Linux and macOS lists are within `symbol-check.py`'s allowed libraries; the mingw-w64 one is not (`ntdll.dll`, and the DLLs raw-dylib imports add, which rustc never reports), and the comment says so. Guix refuses `PLATFORM_GUI`, so `symbol-check.py` never sees these builds. - **mingw-w64:** rustc also reports `-lwindows.0.52.0`, the import library windows-targets 0.52 bundles (socket2 0.5, through hyper-util). It is in the ignore set: every function it names is in the vetted mingw-w64 import libraries, and the `dash-qt` link fails loudly if a later pin needs one that is not. - **powerpc64-linux-gnu:** `PLATFORM_GUI` is refused before anything is fetched. Rust links linux-gnu targets with its bundled rust-lld, which rejects big-endian POWER's ELFv1 objects, and the options to use the depends linker instead are unstable there. `depends/README.md` names it, and the hosts `rust_stdlib.mk` has no entry for (such as `powerpc64le-linux-gnu`), as unavailable. - **Docs:** `depends/README.md` and `doc/dependencies.md` describe it as an opt-in developer build: Guix refuses it, release binaries are built without it, CI builds and tests it on x86_64 Linux only, and Rust and protoc are pinned prebuilt binaries verified by SHA256. - `contrib/devtools/platform-bundle.sh <commit>` produces the crate bundle reproducibly and prints the pins. - `contrib/devtools/update-rust-hashes.py` refreshes the toolchain pins, checking each download against the `.sha256` file published next to it. **configure:** `--enable-platform-gui` (default no) requires the GUI and the wallet. The `auto` that PLATFORM_GUI depends set becomes `no` without them, with a notice. It takes `PLATFORM_CXX_CFLAGS` and `PLATFORM_CXX_LIBS` from `dash_sdk_cxx.pc` through `PKG_CHECK_MODULES`, and both can be overridden as usual. It then link-tests creating and shutting down a `dash_sdk::PlatformClient` (`#include <dash/sdk/ffi.h>`). `PLATFORM_CXX_LIBS` is added to the link of `dash-qt`, `test_dash` and `test_dash-qt` only. **CI** - A `linux64_platform_gui` depends job builds with `PLATFORM_GUI=1`, and `linux64` builds against it instead of the shared `x86_64-pc-linux-gnu` depends, as `linux64_tsan` builds against `linux64_multiprocess`'s. #8058 removed `linux64_sqlite`, which this PR used before; `linux64` is the only x86_64 job left with the wallet and GUI and no sanitizers. `linux64_asan` and `linux64_fuzz` keep the plain depends. The new depends job is in the fast tier, with the `linux64` build it feeds. - `linux64` then runs `check-no-rust.py` on the seven binaries. Its other checks are unchanged and now cover the option: `test_dash` (which links `dash-sdk-cxx`), `check-stdlib-paths` and the previous-releases functional tests. It does not run `test_dash-qt`; this PR adds no Qt tests. - The new depends job's cache check runs on x86_64, like its build. Pull request CI runs develop's workflows with the pull request's own `ci/` scripts, so a pull request based before this one has no matrix entry for `linux64_platform_gui` and guesses its host from the machine. On the ARM runner the other depends jobs check on, that host would not match the build runner's and the pull request would lose `linux64` until rebased; on x86_64 it builds the plain depends, as before. - "Cache depends sources" also downloads the x86_64 Linux Platform GUI sources: the toolchain, protoc, standard library and Platform archives. It names the build machine, because its runner may be ARM. Its cache key is unchanged; it hashes `depends/packages/*`, which the new packages change. Pinned: dashpay/platform `fb463c282ea09adf93dd5d256fc9471969f7a46f` (`packages/rs-sdk-cxx`, crate `dash-sdk-cxx`), with the tarball and crate bundle listed under merge gate 3. ## How Has This Been Tested? Environment-scrub revision (head `bfe078a835a7`, same base and pin; only `build(depends): build dash-sdk-cxx…` changes, the other three commits are identical): - Per-target variables were injected in both spellings for both triples (for example `CFLAGS_x86_64_unknown_linux_gnu=-Werror=bogus`, `ARFLAGS_aarch64_unknown_linux_gnu=--bogus`, `CXXSTDLIB_x86_64_unknown_linux_gnu=c++`). The environment Cargo receives no longer contains any of them, natively and for `HOST=aarch64-linux-gnu`; at parse time this also holds for mingw-w64 and x86_64 macOS. Without the injected variables, the environment Cargo receives is the same as at `406cf256e5fa`. - With those variables injected, `make -C depends PLATFORM_GUI=1` builds `platform_cxx` natively and for `HOST=aarch64-linux-gnu`. Both report the same `native-static-libs` as a clean build (`-lstdc++ -lgcc_s -lutil -lrt -lpthread -lm -ldl -lc`), and ring's build script sees no injected build-machine `CFLAGS`. At `406cf256e5fa` the same aarch64 build fails: blake3 on the injected `ARFLAGS`, then ring on the injected build-machine `CFLAGS`. - Fork `push` run [42869942430](https://github.com/PastaPastaPasta/dash/actions/runs/42869942430) at `bfe078a835a7`: every job passed. All 48 PR checks passed too. Three of them (the x86_64 and aarch64 depends jobs and `mac-build`) first failed when their self-hosted runners lost contact with GitHub mid-build; they passed when rerun. Review-fix revision (head `406cf256e5fa`, same base and pin), x86_64 Linux: - `make -C depends PLATFORM_GUI=1` builds every package with the new toolchain recipes, including `platform_cxx` (system-library and forbidden-crate checks pass). `update-rust-hashes.py --check` passes for all 16 pins. - A reviewer built `rust_stdlib` for `HOST=x86_64-w64-mingw32`, which fetches and stages both standard libraries (the host's and the build machine's). - configure against that prefix: the default gives `platform gui = yes` and the link test passes. `--enable-fuzz`, `--without-gui` and `--disable-wallet` each configure with `platform gui = no`. `--without-gui --enable-platform-gui` still stops with "requires the GUI". - The forbidden-crate pattern matches nothing in the real `cargo tree` for x86_64 Linux, mingw-w64 or aarch64 macOS, with `CARGO_TERM_UNICODE` true or false. A positive control (`ureq|hyper`) matches. - `platform-bundle.sh fb463c28…` (now dropping Platform's `.cargo` before pruning) reproduces the pinned bundle hash `da47a0ca…`. - Fork `push` run [42857408117](https://github.com/PastaPastaPasta/dash/actions/runs/42857408117) at `406cf256e5fa`: every job passed, including the `PLATFORM_GUI` depends job and the `linux64` build and tests, except `linux64_multiprocess-lint`. Its runner received a shutdown signal during clang-tidy. Earlier revisions: Rebased onto develop `4c5c0153500f`, at this pin (`fb463c28`), in an `ubuntu:noble` container on x86_64 Linux, commit by commit in one tree: - `build(depends): add a prebuilt Rust toolchain…`: default depends, configure and build pass. - `build(depends): build dash-sdk-cxx…`: `make -C depends PLATFORM_GUI=1` builds every package, including `platform_cxx` from the two archives, and stages `libdash_sdk_cxx.a`, `dash/sdk/ffi.h` and `dash_sdk_cxx.pc`. Configure and build pass. - `build: add --enable-platform-gui`: from a clean tree, configure with the `linux64` job's flags (`--enable-zmq --with-libs=no --enable-reduce-exports`, `-DDEBUG_LOCKORDER -DDEBUG_LOCKCONTENTION -DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE`, `LDFLAGS=-static-libstdc++`, gcc-14, plus `--enable-external-signer --enable-werror`) and `--enable-platform-gui` reports `platform gui = yes`, and the build passes. - `ci: build linux64…`, on that build: - `check-no-rust.py` passes for `dashd`, `dash-cli`, `dash-tx`, `dash-util`, `dash-wallet`, `bench_dash` and the fuzz binary. - A positive control linked against `libdash_sdk_cxx.a` (create and shut down a `PlatformClient`, as configure's link test does) fails `check-no-rust.py`, which lists its Rust symbols. `dash-qt`, `test_dash` and `test_dash-qt` pass it here: they link the archive, but nothing in this PR calls the binding, so no archive member is pulled in. - `make -C src check-stdlib-paths` passes. - `make check` passes (156 `test_dash` test files, `test_dash-qt`, univalue, minisketch, secp256k1, bench sanity). - Disabled, at the head: default depends (no `dash_sdk_cxx.pc` in the prefix) and default configure (`platform gui = no`) build. `check-no-rust.py` passes for all ten binaries, `dash-qt`, `test_dash` and `test_dash-qt` included, and `make check` passes. - Lints: lint-whitespace, lint-files, lint-shell, lint-shell-locale, lint-python-utf8-encoding and lint-tests pass. actionlint reports nothing in `build.yml` beyond develop's own four findings. - Fork `push` run [42354400055](https://github.com/PastaPastaPasta/dash/actions/runs/42354400055) at 86902f7 passed every job. The `x86_64-pc-linux-gnu_platform_gui` cache check ran on x86_64; its depends job built `platform_cxx` from the pinned archives. `linux64-build` staged that depends (`DEP_OPTS: PLATFORM_GUI=1`), configured with `platform gui = yes`, and ran `check-stdlib-paths` and `check-no-rust.py`. `linux64-test` passed. The sources cache had an exact hit, so its download step did not run in this run; run 41517453011 below exercised it. Not exercised: a pull request based before this one running develop's workflows after this merges. Its cache check now runs on x86_64, which is reasoned from `00_setup_env.sh` and `build-depends.yml`, not observed. Before that rebase, at this pin (`fb463c28`), on develop `92f2bfbc9ddb`: - Linux x86_64, in an `ubuntu:noble` container with gcc-11 and the `linux64_sqlite` configure flags plus `--enable-werror`, with the stacked PRs #7763, #7670, #7671 and #7765–#7767 applied on top: - `make -C depends PLATFORM_GUI=1` builds every package, including `platform_cxx` from the two archives. - `dash-qt`, `test_dash` and `test_dash-qt` build. - `check-no-rust.py` passes for `dashd`, `dash-cli`, `dash-tx`, `dash-util`, `dash-wallet`, `bench_dash` and the fuzz binary. - `make check` passes, and so does `test_dash-qt` with `QT_QPA_PLATFORM=minimal`. - macOS: two runs of `contrib/devtools/platform-bundle.sh` into separate `SOURCES_PATH`s produced byte-identical bundles and tarballs, with the hashes above. - Fork `push` run [41517453011](https://github.com/PastaPastaPasta/dash/actions/runs/41517453011) at 42c8e10 passed, with the `linux64_sqlite` CI design this PR had then. At the previous pin (`dc4dc8e8`), on macOS 27 (aarch64-apple-darwin, Xcode 27 SDK), unless stated: - `make -C depends PLATFORM_GUI=1` builds every package, including `platform_cxx` from the two archives. rustc reports `-lc++ -framework Security -framework CoreFoundation -liconv -lSystem -lc -lm`, and the system-library check and the forbidden-crate check pass. - `pkg-config --static --cflags --libs dash_sdk_cxx` from the depends prefix gives `-I<prefix>/lib/pkgconfig/../../include -L<prefix>/lib/pkgconfig/../../lib -ldash_sdk_cxx -framework Security -framework CoreFoundation`. - `configure --enable-platform-gui` finds `dash-sdk-cxx` through pkg-config, and its link test passes. Without the `.pc` file configure stops and says to build depends with `PLATFORM_GUI=1`. With `PLATFORM_CXX_LIBS=-ldash_sdk_cxx`, which drops the vetted frameworks, the link test fails on the missing framework symbols. - Without `PLATFORM_GUI=1`, `make -C depends print-packages print-native_packages print-all_packages` gives the same result as develop for the native host and for x86_64 Linux, armhf, aarch64 Linux, riscv64, ppc64, mingw-w64, x86_64 macOS and arm64 macOS. With `GUIX_ENVIRONMENT` set, `PLATFORM_GUI=1` stops with the Guix error, and a default build does not. - Two runs of `contrib/devtools/platform-bundle.sh` into separate `SOURCES_PATH`s produced byte-identical bundles and tarballs. depends fetched the tarball from GitHub again during the build, and it matched the pin. - Lints: lint-shell, lint-shell-locale, lint-whitespace, lint-files and lint-python-utf8-encoding pass. actionlint reports nothing new in the touched workflows compared with develop. Not run at this pin: the macOS and mingw-w64 `platform_cxx` builds. Not run at all: Guix, or a build on armhf, ppc64 or riscv64. ## Breaking Changes None. Without `PLATFORM_GUI=1` and `--enable-platform-gui`, depends and configure behave as before. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Top commit has no ACKs. Tree-SHA512: 17ddacb35004f89257eb8eb27d993d1dd79be2131d0ee4d01f10668974a17f10223b59edfdf9d51be985e1ecfbc0638568f254085435c962d3d00b25b3bb7d1a
Additional Information
Depends on backport: merge bitcoin#30423, #27038, #31048, #31099, #31172, #31450, #31608, #31818, #29881, #32458, #32400, #32760, #33178, #33312, #33780, #33181, #34102, partial bitcoin#29023, #30454, #30509, #30510, #31105, #32922, #33489, #33445 (build backports: part 5) #6927
Depends on build: target aarch64 over armv7, update to macOS 15.0 SDK (Xcode 16.0), add verification step to
setup-sdk#7184On top of
ntdll.dll, Rust's standard library has a hard dependency onapi-ms-win-core-synch-l1-2-0.dll(sync primitives) after rust-lang/rust#124019, which has been added to the allowlist even though this dependency isn't specified inRUST_LIBS.The build system passes information about the host compiler, target macOS version and other parameters as Rust crates themselves may be FFI bindings to C/C++ codebases, this is specifically relevant for cross-compilation where host and target do not match.
dependsexposes whatever is needed but if attempting to build withoutdepends, the following environment variables need to be defined.OSX_MIN_VERSION(target version of macOS)OSX_SDK(path to the macOS SDK)NATIVE_AR(host archiver)NATIVE_CC(host C compiler)NATIVE_CXX(host C++ compiler)RUST_NATIVE(host Rust target, if cannot be deduced by build system)For integrating the crates into our C++ codebase, we use the
cxxcrate with the version defined innative_cxxbridge.mkThe version of Rust defined in
native_rust.mkandrust-toolchain.tomlmust match as the former is what we use independs(and is the same version used in the Guix environment, we don't rely on Guix to supply us a Rust build environment) and the latter is used to ensure that builds outsidedependsuse a matching Rust version.The version should also be synced with
rust_stdlib.mk, which defines the standard libraries used. All hosts (native_rust) will have a target (rust_stdlib) but not all targets will have a host. Version management is done usingcontrib/devtools/update-rust-hashes.pyandcontrib/devtools/update-native-cxxbridge.py.To avoid glibc-related issues in Guix builds due to conflicting versions, incompatible symbols or the mixing of code generated with different glibc targets, we have opted to use the
muslvariant of the standard library for Linux builds. Non-dependsbuilds will need to configure their Rust environment accordingly.To allow PowerPC target builds, we had to move from Rust 1.82 (the minimum version demanded by
cxx) to 1.85.1This also means that the CI Docker image does not have a Rust compiler as it is supplied by
depends. This is done due to the fact that we already need a depends-supplied compiler to have greater control over version and variant but also to avoid increasing the size of our already-large master image.Future work on the CI system could provide Rust compilers to aid in debugging and development (as development images are derived from CI images) but that is out of scope for this PR.
The depends system introduces the following verbs
download-rust-src(downloads packages necessary for vendoring)download-rust-std(downloads the standard library for all targets listed inrust_stdlib.mk, needed as Guix environments do not have access to the internet)vendor-dep-crates(vendors dependencies by Rust packages in thedependssystem)vendor-all-crates(vendors dependencies by Rust packages used in the codebase)During development and when building without the depends system, you will need to use
--enable-online-rust, failing which, you will need to defineRUST_VENDORED_SOURCES(a value that is otherwise defined by thedependssystem).Vendoring support was added as Guix environments have no access to the internet and to allow for caching crates for CI.
As the Guix environment does not use normal paths, we have to do the inverse of the patch that is usually done to binaries generated in Guix environments (replacing the loader with standard paths instead of store-specific paths) to ensure our native binaries will run and additionally locate the GCC runtime (
libgcc_s.so.1) and move it to a location reachable to the native binaries and patch that patch too.This is done using
contrib/guix/libexec/fix-elf-interpreter.shand is meant only for the Guix environment as it assumes that it will always run on a Linux host.How Has This Been Tested?
Running
dashdordash-qtshould have this entry in their debug log (see below) demonstrating a call to the stub crate during init.Breaking Changes
None expected.
Checklist