Repository navigation
refactor: migrate ProcessMessage definitions to MessageProcessingResult, drop PeerMsgRet - #6820
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
Dependency for refactor: reduce
PeerManagerusage in InstantSend worker functions #6821To avoid having to redeclare
NodeIdrepeatedly to avoid circular dependencies from includingnet.h(source), a redeclaration is made in the relatively lightweightnet_types.hthat as ofdevelop(fb87a5a), doesn't have includes outside the standard library (source).Redeclarations were flagged during review (see comment, comment).
As
tl::expectedwas introduced alongsidePeerMsgRetin dash#5782 and has not been used elsewhere, we can safely remove it as we've finished migrating all usage toMessageProcessingResult.Breaking Changes
None expected.
Checklist