Skip to content

refactor: migrate ProcessMessage definitions to MessageProcessingResult, drop PeerMsgRet - #6820

Merged
PastaPastaPasta merged 16 commits into
dashpay:developfrom
kwvg:pmr_rem
Aug 18, 2025
Merged

PastaPastaPasta merged 16 commits into
dashpay:developfrom
kwvg:pmr_rem

Conversation

@kwvg

@kwvg kwvg commented Aug 15, 2025 •

Copy link
Copy Markdown
Collaborator

Additional Information

  • Dependency for refactor: reduce PeerManager usage in InstantSend worker functions #6821

  • To avoid having to redeclare NodeId repeatedly to avoid circular dependencies from including net.h (source), a redeclaration is made in the relatively lightweight net_types.h that as of develop (fb87a5a), doesn't have includes outside the standard library (source).

    Redeclarations were flagged during review (see comment, comment).

  • As tl::expected was introduced alongside PeerMsgRet in dash#5782 and has not been used elsewhere, we can safely remove it as we've finished migrating all usage to MessageProcessingResult.

Breaking Changes

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants