Skip to content

Gate identity-based exclusion for rotating quorum members #8134

Open

Description

@coderabbitai

Summary

A rotating quorum can contain the same masternode identity more than once, even after short-quarter snapshot reconstruction is corrected. In src/llmq/utils.cpp, a historical property conflict can make AddMN reject a retained member from an exclusion list. If that identity later has a different address, the current candidate may pass HasMN and be selected again. An assembled quorum can then contain duplicate member positions, such as [A, B, A].

Follow-up

Design and implement identity-based exclusion for rotating quorum selection independently of the historical property-based CDeterministicMNList::AddMN bookkeeping. This changes consensus selection even when all quarters fill, so activate the new behavior through an appropriate consensus deployment and preserve historical behavior before activation. Define how the transition handles the three retained quarters, snapshots, member caches, and any resulting shortage of eligible members.

Acceptance criteria

  • Add a regression test for a retained identity omitted from the exclusion list because of a historical property conflict, followed by selection of the same proTxHash with a different address. Check the assembled quorum for duplicate identities.
  • Verify the activated rules prevent the duplicate selection and produce deterministic quarter reconstruction, including at the activation boundary.
  • Verify pre-activation selection and historical snapshot replay remain unchanged. Include a full-quarter case as well as a shortage case.
  • Document the activation and compatibility implications for nodes and clients that rebuild rotating quorums.

Requested by @UdjinM6.

PR: #8074
Review discussion: #8074 (comment)
Original finding: #8074 (comment)
Related partial-quarter reconstruction issue: #7688

Activity

  1. UdjinM6 commented on Nov 12, 2026

    @UdjinM6

    Related: #8012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions