You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: p2p_blocksonly.py intermittently times out under TSAN #7436
p2p_blocksonly.py intermittently times out under the linux64_tsan-test CI configuration while waiting for a transaction to reach the second relay-permission peer.
Expected behavior
After the first peer sends the transaction, the node relays it to the second peer and second_peer.wait_for_tx(txid) completes.
Actual behavior
In #7434's TSAN job, all three functional-test attempts timed out at p2p_blocksonly.py:77 after 240 seconds:
second_peer.wait_for_tx(txid)
AssertionError: Predicate ... not true after 240.0 seconds
The node log shows that it accepted the transaction into the mempool and queued the inventory for peer 1:
The triggering PR changes only LLMQ signature-share preverification and its unit tests; it does not touch transaction relay, the P2P test framework, or p2p_blocksonly.py. Other test configurations passed on the same head, so this failure appears unrelated and timing-sensitive.
To reproduce
Run the functional test repeatedly with the TSAN build/configuration, especially under CI load:
test/functional/p2p_blocksonly.py
The observed failure reproduced on all three automatic attempts within one CI job, but has not yet been reproduced locally.
Potential investigation areas are whether mocktime advancement leaves the normal inventory trickle/send scheduling stalled under TSAN, and whether the test should explicitly synchronize the send path before waiting for the second peer.
All three p2p_blocksonly.py attempts timed out at line 77 in second_peer.wait_for_tx(txid) after 240 seconds.
The txid and failure mode match the earlier occurrence documented here: the node accepted transaction 1a379b51934c0da5408fd43b1ed408f99dd2ae29be34c8963d54c88f16da8b85 and queued its inventory for peer 1, but the test peer did not observe the transaction before timeout.
There was no ThreadSanitizer report.
Scope check: the PR changes one line in TestNode.add_p2p_connection, replacing peer["addrbind"] with peer.get("addrbind"). That is semantically identical for peers with addrbind and does not touch transaction relay, p2p_blocksonly.py, or wait_for_tx. A local run of p2p_blocksonly.py on current upstream/develop (2bbf4a4) passed in 10 seconds.
This is another occurrence of the existing TSAN timing/scheduling flake, not a regression from the PR.
p2p_blocksonly.py timed out at line 77 in second_peer.wait_for_tx(txid) after 240 seconds.
The signature matches the prior occurrences: node 0 accepted transaction 1a379b51934c0da5408fd43b1ed408f99dd2ae29be34c8963d54c88f16da8b85 and logged PushInv -- adding new inv ... peer=1, but the test peer never observed it before timeout.
There was no ThreadSanitizer report.
Scope check: #7441 changes four quorum/governance functional tests and adds two LLMQ-only helper methods to DashTestFramework; it does not change p2p_blocksonly.py, the P2P peer framework, transaction relay, or inventory scheduling. All 318 other TSAN functional tests and every other CI test matrix job passed. This is another occurrence of the existing TSAN timing/scheduling flake, not a regression from #7441.
Activity
thepastaclaw commentedon Jul 10, 2026
New occurrence on vijaydasmp#28 at head ffe9358:
Scope check: the PR changes one line in TestNode.add_p2p_connection, replacing peer["addrbind"] with peer.get("addrbind"). That is semantically identical for peers with addrbind and does not touch transaction relay, p2p_blocksonly.py, or wait_for_tx. A local run of p2p_blocksonly.py on current upstream/develop (2bbf4a4) passed in 10 seconds.
This is another occurrence of the existing TSAN timing/scheduling flake, not a regression from the PR.
thepastaclaw commentedon Jul 12, 2026
New occurrence on #7441 at head
944e487c43165dc0950e299c42784a4db26290cd:p2p_blocksonly.pytimed out at line 77 insecond_peer.wait_for_tx(txid)after 240 seconds.1a379b51934c0da5408fd43b1ed408f99dd2ae29be34c8963d54c88f16da8b85and loggedPushInv -- adding new inv ... peer=1, but the test peer never observed it before timeout.Scope check: #7441 changes four quorum/governance functional tests and adds two LLMQ-only helper methods to
DashTestFramework; it does not changep2p_blocksonly.py, the P2P peer framework, transaction relay, or inventory scheduling. All 318 other TSAN functional tests and every other CI test matrix job passed. This is another occurrence of the existing TSAN timing/scheduling flake, not a regression from #7441.