Repository navigation
docs: plan DashConnect's move from kotlin-platform to the Kotlin SDK - #1707
Draft
HashEngineering wants to merge 2 commits into
Draft
HashEngineering wants to merge 2 commits into
HashEngineering wants to merge 2 commits into
Conversation
Maps every kotlin-platform call DashConnect makes to its Kotlin SDK 5.1.0-int36 replacement, or to the dashpay/platform PR it needs. The dash-st: decoder has shipped (StateTransitionParser). Contract-group reads and Platform time are still missing. Also covers key registration through addMissingKeys (kotlin-platform#43), the signer, and when the identity-key backfill from #1693 can go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StateTransitionParser is in the int36 AAR, but nothing has run it, and its token transition has no typed field for the agreed price. PR-1 now closes only when phase 0 shows a typed price and correct parsing of the test vectors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
|
🕓 Review not started yet because this PR is a draft.
Commit 959241d. Normal review starts when eligible; priority review starts as soon as a slot is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
DashConnect sends every Platform read and write through the old kotlin-platform SDK (
org.dashj.platform.*) and signs through dashj. This adds a plan for moving it onto the Kotlin SDK (org.dashfoundation.dashsdk). It is a docs-only change.What was done?
docs/dashconnect-kotlin-sdk-migration.md:dash-sdk-android5.1.0-int36. The API was read from the AAR's class signatures and has not been run.dash-st:decoder: available in int36 asStateTransitionParserbut unverified. It closes only once the parser exposes the agreed price as a typed field and parses the test vectors correctly.ConnectPlatforminterface with legacy and SDK implementations, chosen by cutover state; add aConnectSignerfor the per-app keys; then move reads before writes and remove the legacy path.IdentityUpdates.addKey, with the wallet's own missing-key check. That removes the race tracked in BlockchainIdentity.addMissingKeys can register a duplicate key that the refreshed identity already has but the wallet hasn't issued kotlin-platform#43.How Has This Been Tested?
It's a docs-only change. Every file and line reference was checked against this branch's code.
Breaking Changes
None.
Open questions
🤖 Generated with Claude Code