Skip to content

docs: plan DashConnect's move from kotlin-platform to the Kotlin SDK - #1707

Draft
HashEngineering wants to merge 2 commits into
feat/kotlin-sdk-phase-1from
docs/dashconnect-sdk-migration
Draft

HashEngineering wants to merge 2 commits into
feat/kotlin-sdk-phase-1from
docs/dashconnect-sdk-migration

Conversation

@HashEngineering

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

DashConnect sends every Platform read and write through the old kotlin-platform SDK (org.dashj.platform.*) and signs through dashj. This adds a plan for moving it onto the Kotlin SDK (org.dashfoundation.dashsdk). It is a docs-only change.

What was done?

docs/dashconnect-kotlin-sdk-migration.md:

  • Call map: every kotlin-platform call DashConnect makes, with its file and line on this branch, mapped to its replacement in dash-sdk-android 5.1.0-int36. The API was read from the AAR's class signatures and has not been run.
  • Missing pieces in dashpay/platform:
    • PR-1, the dash-st: decoder: available in int36 as StateTransitionParser but unverified. It closes only once the parser exposes the agreed price as a typed field and parses the test vectors correctly.
    • PR-2, contract-group owner and members: blocking.
    • PR-3, Platform block time: blocking.
    • PR-4 and PR-5: needed only if the phase-0 checks call for them.
  • Five phases: confirm the gaps on testnet; land the Platform PRs and bump the SDK; add a ConnectPlatform interface with legacy and SDK implementations, chosen by cutover state; add a ConnectSigner for the per-app keys; then move reads before writes and remove the legacy path.
  • Key registration: on the SDK path it becomes IdentityUpdates.addKey, with the wallet's own missing-key check. That removes the race tracked in BlockchainIdentity.addMissingKeys can register a duplicate key that the refreshed identity already has but the wallet hasn't issued kotlin-platform#43.
  • Identity-key backfill from fix(identity): issue an SDK identity's keys on the identity chain before checking or signing #1693: what the SDK signer means for it, and when it can be removed.

How Has This Been Tested?

It's a docs-only change. Every file and line reference was checked against this branch's code.

Breaking Changes

None.

Open questions

  • Who owns PR-2 and PR-3 in dashpay/platform?
  • Should DashConnect keep running before the cutover? If not, the legacy implementation isn't needed.

🤖 Generated with Claude Code

HashEngineering and others added 2 commits November 12, 2026 12:57
Maps every kotlin-platform call DashConnect makes to its Kotlin SDK
5.1.0-int36 replacement, or to the dashpay/platform PR it needs.
The dash-st: decoder has shipped (StateTransitionParser). Contract-group
reads and Platform time are still missing. Also covers key registration
through addMissingKeys (kotlin-platform#43), the signer, and when the
identity-key backfill from #1693 can go.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StateTransitionParser is in the int36 AAR, but nothing has run it, and
its token transition has no typed field for the agreed price. PR-1
now closes only when phase 0 shows a typed price and correct parsing of
the test vectors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@thepastaclaw

Copy link
Copy Markdown
Contributor

🕓 Review not started yet because this PR is a draft.

  • Request normal review — click when the PR is ready for review.
  • Request priority review — click to move this review to the front of the queue.

Commit 959241d. Normal review starts when eligible; priority review starts as soon as a slot is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants