Repository navigation
chore(i18n): add missing de, fr, it, pl, ru, pt and es translations for 12.0.2 - #1705
HashEngineering wants to merge 3 commits into
Conversation
…or 12.0.2 Adds the 223 strings that were missing in each of the seven locales: wallet strings-dashpay.xml (172), wallet strings.xml (44), wallet strings-extra.xml (3) and common strings.xml (4). Entries are placed in English-file order next to their nearest existing neighbour; English values/ files are unchanged. Placeholders, escapes and \n match the English source for every entry. These files are managed by Transifex (dash-mobile-wallets); the same translations need to be uploaded there so the next pull keeps them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ource The row also covers Platform identity-credit and evonode reward withdrawals, so the label reads "unshielded withdrawal" like the English and other locales. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
fr uses blindé/blinder and ru uses экранированный/экранировать, as the iOS app's translations on the same Transifex project do. The Unshielded row labels in pl, pt and es follow iOS too (Nieosłonięte, Não blindado, Sin blindar). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
✅ Final review complete — no blockers (commit b916b8a) · triage: low |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
The reviewed range contains only the intended 1,561 localized Android resource additions across 28 XML files. The resources parse successfully, match English keys and format placeholders, preserve safety-critical payment and recovery messaging, and the supplied build and check CI results passed. No in-scope defects or actionable CodeRabbit findings were identified.
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — This is a large but straightforward localization-only change that adds translated resource entries without modifying application behavior, critical surfaces, or build logic. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 97% left, weekly 54% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer
Summary
Adds every missing translation for de, fr, it, pl, ru, pt and es for the 12.0.2 Google Play release.
A string counted as missing when an English
values/strings*.xmlentry (<string>,<plurals>or<string-array>, skippingtranslatable="false") had no entry of the same name in the locale's same-named file. All six resource roots were checked:wallet/res,common/src/main/res,features/exploredash/src/main/res, andintegrations/{coinbase,maya,uphold}/src/main/res. Strings that were already translated were left as they were.Counts (identical for every locale)
strings-dashpay.xmlstrings.xmlstrings-extra.xmlstrings.xmlstrings_app_connect.xmlThat's 1,561 entries in total across 28 files. None of the missing entries are
<plurals>or<string-array>. The two%dcount strings are worded to read correctly for any number, which matters for pl and ru.How the translations were made
The English
values/files are unchanged.Each new entry sits in English-file order, right after its nearest preceding sibling in the locale file. The existing order and formatting are kept.
Each locale's terminology and form of address were matched to its existing files (wallet, balance, sync, username, contested, top-up, mixing, Report an Issue and so on). Brand names stay in English: Dash, DashPay, CoinJoin, Platform, Firebase, dashj, ChainLock.
"Dash Wallet" follows each locale's existing
dash_wallet_name: it stays in English for de, fr, ru and es, and is localized for it ("Portafoglio Dash"), pl ("Portfel Dash") and pt ("Carteira Dash")."Shielded" terms follow the iOS wallet's translations (dashpay/dashwallet-ios, same
dash-mobile-walletsTransifex project). No Android locale had an existing term.iOS leaves a few standalone labels ("Shielded balance", "Shielded") in English. Android translates them with the same adjective throughout.
Symbol-only entries (
%1$d%%,%1$s / %2$s,—,C,%s DASH,%s Dash) are copied unchanged. They aren't markedtranslatable="false"in English, so they counted as missing..tx/configshows these files are managed by Transifex. They were hand-edited this time at the owner's request. These translations should also be uploaded to Transifex (thedash-mobile-walletsproject). Otherwise the nexttx pullmay overwrite or drop them.Verification
prereview.sh, baseorigin/feat/kotlin-sdk-phase-1): round 1 flagged the rutransaction_row_unshielded_withdrawallabel, whose wording ("withdrawal from the shielded balance") wrongly claimed a shielded source for identity-credit and evonode reward withdrawals. It is fixed in a separate commit. Round 2, and a round after the iOS term alignment, are clean (0 blocking, 0 suggestions, 0 nitpicks).\ncount, HTML tags and XML entities match the English source. The script also confirmed there are no unescaped'or"and that every locale file still parses as XML. Result: 0 problems. After the merge, rerunning the missing-string scan shows 0 missing for all seven locales../gradlew :wallet:compile_testNet3DebugKotlin :wallet:process_testNet3DebugResources(JDK 17) passes. aapt2 accepts all resources../gradlew :wallet:lint_testNet3Debugpasses, but only when run with-x :features:exploredash:lintAnalyzeDebug -x :integrations:coinbase:lintAnalyzeDebug.DashSpendViewModel.kt,CoinbaseConversionPreviewViewModel.kt). The cause is a toolchain issue: "Metadata version 2.1.0, while maximum supported version is 2.0.0" inComposableStateFlowValueDetector.🤖 Generated with Claude Code
Summary by CodeRabbit