Skip to content

chore(i18n): add missing de, fr, it, pl, ru, pt and es translations for 12.0.2 - #1705

Open
HashEngineering wants to merge 3 commits into
feat/kotlin-sdk-phase-1from
chore/translations-12.0.2
Open

HashEngineering wants to merge 3 commits into
feat/kotlin-sdk-phase-1from
chore/translations-12.0.2

Conversation

@HashEngineering

@HashEngineering HashEngineering commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds every missing translation for de, fr, it, pl, ru, pt and es for the 12.0.2 Google Play release.

A string counted as missing when an English values/strings*.xml entry (<string>, <plurals> or <string-array>, skipping translatable="false") had no entry of the same name in the locale's same-named file. All six resource roots were checked: wallet/res, common/src/main/res, features/exploredash/src/main/res, and integrations/{coinbase,maya,uphold}/src/main/res. Strings that were already translated were left as they were.

Counts (identical for every locale)

Module / file de fr it pl ru pt es
wallet strings-dashpay.xml 172 172 172 172 172 172 172
wallet strings.xml 44 44 44 44 44 44 44
wallet strings-extra.xml 3 3 3 3 3 3 3
common strings.xml 4 4 4 4 4 4 4
exploredash, coinbase, maya, uphold, wallet strings_app_connect.xml 0 0 0 0 0 0 0
Total 223 223 223 223 223 223 223

That's 1,561 entries in total across 28 files. None of the missing entries are <plurals> or <string-array>. The two %d count strings are worded to read correctly for any number, which matters for pl and ru.

How the translations were made

  • The English values/ files are unchanged.

  • Each new entry sits in English-file order, right after its nearest preceding sibling in the locale file. The existing order and formatting are kept.

  • Each locale's terminology and form of address were matched to its existing files (wallet, balance, sync, username, contested, top-up, mixing, Report an Issue and so on). Brand names stay in English: Dash, DashPay, CoinJoin, Platform, Firebase, dashj, ChainLock.

  • "Dash Wallet" follows each locale's existing dash_wallet_name: it stays in English for de, fr, ru and es, and is localized for it ("Portafoglio Dash"), pl ("Portfel Dash") and pt ("Carteira Dash").

  • "Shielded" terms follow the iOS wallet's translations (dashpay/dashwallet-ios, same dash-mobile-wallets Transifex project). No Android locale had an existing term.

    Locale shielded / to shield Unshielded / Unshielded Withdrawal
    de abgeschirmt / abschirmen Nicht abgeschirmt / Nicht abgeschirmte Auszahlung
    fr blindé / blinder Non blindé / Retrait non blindé
    it schermato / schermare Non schermato / Prelievo non schermato
    pl osłonięty / osłonić Nieosłonięte / Nieosłonięta wypłata
    ru экранированный / экранировать Не экранировано / Неэкранированный вывод
    pt blindado / blindar Não blindado / Saque não blindado
    es blindado / blindar Sin blindar / Retiro sin blindar

    iOS leaves a few standalone labels ("Shielded balance", "Shielded") in English. Android translates them with the same adjective throughout.

  • Symbol-only entries (%1$d%%, %1$s / %2$s, —, C, %s DASH, %s Dash) are copied unchanged. They aren't marked translatable="false" in English, so they counted as missing.

⚠️ Transifex

.tx/config shows these files are managed by Transifex. They were hand-edited this time at the owner's request. These translations should also be uploaded to Transifex (the dash-mobile-wallets project). Otherwise the next tx pull may overwrite or drop them.

Verification

  • pre-review (prereview.sh, base origin/feat/kotlin-sdk-phase-1): round 1 flagged the ru transaction_row_unshielded_withdrawal label, whose wording ("withdrawal from the shielded balance") wrongly claimed a shielded source for identity-credit and evonode reward withdrawals. It is fixed in a separate commit. Round 2, and a round after the iOS term alignment, are clean (0 blocking, 0 suggestions, 0 nitpicks).
  • Placeholder script: for all 1,561 new entries, the format placeholders, \n count, HTML tags and XML entities match the English source. The script also confirmed there are no unescaped ' or " and that every locale file still parses as XML. Result: 0 problems. After the merge, rerunning the missing-string scan shows 0 missing for all seven locales.
  • Compile and resources: ./gradlew :wallet:compile_testNet3DebugKotlin :wallet:process_testNet3DebugResources (JDK 17) passes. aapt2 accepts all resources.
  • Lint: ./gradlew :wallet:lint_testNet3Debug passes, but only when run with -x :features:exploredash:lintAnalyzeDebug -x :integrations:coinbase:lintAnalyzeDebug.
    • Those two analysis tasks crash on files this PR doesn't touch (DashSpendViewModel.kt, CoinbaseConversionPreviewViewModel.kt). The cause is a toolchain issue: "Metadata version 2.1.0, while maximum supported version is 2.0.0" in ComposableStateFlowValueDetector.
    • None of the lint issues in the locale string files is on a string this PR adds. All of them predate this branch.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added localized guidance for invitations, username payments, shielded balances and transfers, fund migration, and wallet synchronization across supported languages.
    • Added contact-request notification labels and descriptions, transaction filter labels, and messages for pending or unsaved transactions.
    • Added status and error messages for payment processing, network delays, and uncertain transaction outcomes.

HashEngineering and others added 2 commits November 13, 2026 12:24
…or 12.0.2

Adds the 223 strings that were missing in each of the seven locales:
wallet strings-dashpay.xml (172), wallet strings.xml (44), wallet
strings-extra.xml (3) and common strings.xml (4). Entries are placed in
English-file order next to their nearest existing neighbour; English
values/ files are unchanged. Placeholders, escapes and \n match the
English source for every entry.

These files are managed by Transifex (dash-mobile-wallets); the same
translations need to be uploaded there so the next pull keeps them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ource

The row also covers Platform identity-credit and evonode reward withdrawals,
so the label reads "unshielded withdrawal" like the English and other locales.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request adds localized DashPay and wallet interface strings in German, Spanish, French, Italian, Polish, Portuguese, and Russian. The resources cover identity and contact requests, invitations, shielded balances and transfers, fund migration, synchronization, and wallet SDK setup.

Changes: Localized DashPay and wallet resources

Layer / File(s) Summary
Identity, invitation, and contact messages
wallet/res/values-*/strings-dashpay.xml, wallet/res/values-*/strings-extra.xml
Adds localized contact-request notifications and errors, username and invitation messages, credit top-up statuses, transaction counts, and filter labels.
Shielded wallet and synchronization messages
wallet/res/values-*/strings-dashpay.xml
Adds localized text for shielded-balance screens and transfers, payment choices, CoinJoin-fund migration, wallet synchronization, and SDK binding states.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

Merge Risk: Minimal · up to b916b

This PR adds missing German, French, Italian, Polish, Russian, Portuguese and Spanish strings for DashPay and wallet screens. It does not change application logic. The reported build and lint checks pass, and no concrete defect was found, so it is ready to merge. Uploading the translations to Transifex remains a follow-up so a later pull does not overwrite them.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change accurately. The PR adds missing German, French, Italian, Polish, Russian, Portuguese, and Spanish translation entries for the 12.0.2 release, which matches the raw summary a…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change accurately. The PR adds missing German, French, Italian, Polish, Russian, Portuguese, and Spanish translation entries for the 12.0.2 release, which matches the raw summary and the PR objectives. The title is specific, follows a conventional commit style, and conveys the primary change. It is 78 characters, slightly longer than ideal, but still clear.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 72f4fdd and b916b8a.

Files ignored due to path filters: 5

  • wallet/res/values-es/strings.xml is excluded by !**/res/values-*/strings.xml
  • wallet/res/values-fr/strings.xml is excluded by !**/res/values-*/strings.xml
  • wallet/res/values-pl/strings.xml is excluded by !**/res/values-*/strings.xml
  • wallet/res/values-pt/strings.xml is excluded by !**/res/values-*/strings.xml
  • wallet/res/values-ru/strings.xml is excluded by !**/res/values-*/strings.xml
Files selected for processing: 2

  • wallet/res/values-fr/strings-dashpay.xml
  • wallet/res/values-ru/strings-dashpay.xml
Files skipped from review as they are similar to previous changes: 2

  • wallet/res/values-fr/strings-dashpay.xml
  • wallet/res/values-ru/strings-dashpay.xml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

fr uses blindé/blinder and ru uses экранированный/экранировать, as the
iOS app's translations on the same Transifex project do. The Unshielded
row labels in pl, pt and es follow iOS too (Nieosłonięte, Não blindado,
Sin blindar).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@thepastaclaw

thepastaclaw commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

✅ Final review complete — no blockers (commit b916b8a) · triage: low

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

The reviewed range contains only the intended 1,561 localized Android resource additions across 28 XML files. The resources parse successfully, match English keys and format placeholders, preserve safety-critical payment and recovery messaging, and the supplied build and check CI results passed. No in-scope defects or actionable CodeRabbit findings were identified.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — This is a large but straightforward localization-only change that adds translated resource entries without modifying application behavior, critical surfaces, or build logic.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 97% left, weekly 54% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants