Skip to content

chore(sdk): pin Kotlin SDK 5.0.0-int32 (5.0.0-int32-20261026.223239-1) - #1644

Merged
HashEngineering merged 1 commit into
feat/kotlin-sdk-phase-1from
chore/sdk-int32
Oct 27, 2026
Merged

HashEngineering merged 1 commit into
feat/kotlin-sdk-phase-1from
chore/sdk-int32

Conversation

@HashEngineering

@HashEngineering HashEngineering commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

What

Pins dashSdkVersion to the int32 Kotlin SDK, 5.0.0-int32-20261026.223239-1. It's the only int32 build on Sonatype, pinned by its exact timestamped name rather than -SNAPSHOT, so a later upload can't change what this branch builds. It replaces int31, which #1630 pinned.

What int32 is

int31 with the latest v5.0-dev merged in; everything else is the same as int31.

Test plan

  • Gradle resolves org.dashj:dash-sdk-android:5.0.0-int32-SNAPSHOT:20261026.223239-1. The published AAR, pom and module were downloaded back byte-identical (AAR sha256 44822db1…).
  • SDK host tests on the int32 tip, all passing: platform-wallet 1,634, ffi 451 (1 ignored), JNI 56, encryption 26, kotlin-sdk 592.
  • Native libraries: 275 JNI exports on both ABIs, 0 misaligned LOAD segments. On the device, build_info.txt reports 0495544fd5, not dirty.
  • Wallet A fresh restore, testnet, Pixel 9 emulator (API 35): PASS. Compared with the int30 baseline from 2026-10-12, the store is identical: 7,464 transactions (AssetLock 20, CoinJoin 5,070, Standard 2,374), none missed or extra and none with a different net; 1,083 unspent coins; 169.08001479 tDASH; 26,053 watched addresses. The sync reached SYNCED with headers = filters = wallet, the TXO reconcile reported mirror consistent (engineRows=1083 storeRows=1083 inserted=0 healedSpent=0 flipped=0), there was no DashPay rewind, and DashPay sync settled.
  • Wallet B restore, including the known CoinJoin net 4a1e255c… (expected unchanged, since folding is still out).
  • int31 → int32 in-place upgrade on an existing wallet.
  • Shielded flows and DashPay contact payments on this build.

Recipe and evidence: HashEngineering/dash-wallet-qa recipes/platform/5.0.0-int32.yaml.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the platform integration to a newer build and refreshed the associated revision information. This update does not report any changes to user-facing features or behavior. No other user-visible changes are included in this release.

int32 is int31 with v5.0-dev 78d494f525 (5.0.0-rc.8) merged in. The engine
moves to rust-dashcore v0.45.0, which already backports four of int31's six
engine PRs, plus the other two (#1016, #1063): HashEngineering/rust-dashcore
integration/5.0.0-int32-engine @ 0398ec0a. The carries are as in int31
(#4312/#4313, #5259, #5256, the dashj-legacy ECDH fallback, the asset-lock
re-poll); transaction-record folding is still out.

Built from HashEngineering/platform integration/5.0.0-int32 @ 0495544fd5 and
pinned by its exact timestamped name. The published AAR is byte-identical to
the build (sha256 44822db119e529e1), and that AAR passed a fresh Wallet A
restore on testnet. Room schema 15 and the 275 JNI exports are unchanged from
int31.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 26cd120 and e4fa3bc.

Files selected for processing: 1
  • build.gradle

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Walkthrough

The build configuration updates the pinned Dash Platform Kotlin SDK from the timestamped int31 build to the timestamped int32 build. It also replaces the accompanying revision details, included changes, and recipe reference.

Changes: SDK version update

Layer / File(s) Summary
Update SDK pin and release details
build.gradle
The SDK pin changes to the int32 build. The accompanying comments identify the int32 platform and engine revisions, included changes, and recipe.

Priority: Not assessed

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Suggested reviewers: abaranouski

Merge Risk: Minimal · up to e4fa3

The pinned SDK update is mergeable with no identified blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: pinning the Kotlin SDK to the specific 5.0.0-int32 version.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

✅ Final review complete — no blockers (commit e4fa3bc) · triage: low

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

The PR is a focused one-file SDK pin update from int31 to the exact timestamped int32 artifact, with the provenance comment updated consistently. The dependency wiring remains unchanged, supplied CI checks passed at the exact head SHA, and no in-scope correctness, compatibility, security, or architecture issues were identified.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — The diff only pins a timestamped Kotlin SDK dependency in build.gradle, with no direct source or behavior changes and straightforward correctness verification through dependency resolution.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 97% left, weekly 98% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer

@HashEngineering
HashEngineering merged commit 5b0f8c3 into feat/kotlin-sdk-phase-1 Oct 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants