Repository navigation
chore(sdk): pin Kotlin SDK 5.0.0-int32 (5.0.0-int32-20261026.223239-1) - #1644
Conversation
int32 is int31 with v5.0-dev 78d494f525 (5.0.0-rc.8) merged in. The engine moves to rust-dashcore v0.45.0, which already backports four of int31's six engine PRs, plus the other two (#1016, #1063): HashEngineering/rust-dashcore integration/5.0.0-int32-engine @ 0398ec0a. The carries are as in int31 (#4312/#4313, #5259, #5256, the dashj-legacy ECDH fallback, the asset-lock re-poll); transaction-record folding is still out. Built from HashEngineering/platform integration/5.0.0-int32 @ 0495544fd5 and pinned by its exact timestamped name. The published AAR is byte-identical to the build (sha256 44822db119e529e1), and that AAR passed a fresh Wallet A restore on testnet. Room schema 15 and the 275 JNI exports are unchanged from int31. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update SDK pin and release details build.gradle |
The SDK pin changes to the int32 build. The accompanying comments identify the int32 platform and engine revisions, included changes, and recipe. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related PRs
- dashpay/dash-wallet#1630: This PR pins the Kotlin SDK to int31, the version replaced by this update.
Suggested reviewers: abaranouski
Merge Risk: 
Minimal · up to e4fa3
-
The pinned SDK update is mergeable with no identified blocking risk.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
✅ Final review complete — no blockers (commit e4fa3bc) · triage: low |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 1 + Phase 2
The PR is a focused one-file SDK pin update from int31 to the exact timestamped int32 artifact, with the provenance comment updated consistently. The dependency wiring remains unchanged, supplied CI checks passed at the exact head SHA, and no in-scope correctness, compatibility, security, or architecture issues were identified.
Review provenance
Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — The diff only pins a timestamped Kotlin SDK dependency in build.gradle, with no direct source or behavior changes and straightforward correctness verification through dependency resolution. - Phase 1 reviewers:
glm-5.3-flash— general (completed, effort high); agentphase1-reviewer - Phase 1 model:
glm-5.3-flash— zai quota: 5h 97% left, weekly 98% left; passed overgemini-3.8-flash-high(antigravity quota lookup failed) - Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer
What
Pins
dashSdkVersionto the int32 Kotlin SDK,5.0.0-int32-20261026.223239-1. It's the only int32 build on Sonatype, pinned by its exact timestamped name rather than-SNAPSHOT, so a later upload can't change what this branch builds. It replaces int31, which #1630 pinned.What int32 is
int31 with the latest
v5.0-devmerged in; everything else is the same as int31.integration/5.0.0-int32@0495544fd5= int31 (0c5fcfec1c) +v5.0-dev@78d494f525(5.0.0-rc.8, 19 commits past int31's base). New from the base:integration/5.0.0-int32-engine@0398ec0a= v0.45.0 plus chore: add coinbase strings to transifex config #1016 and Dash-wallet (kick-kick) #1063. v0.45.0 already backports the other four engine fixes int31 carried ([NMA-1278 && NMA-1276] Import Private Key on the Send/Receive screen + redesign #1035, Coinbase integration #1015, Bugfix release 8.0.1 #1037, fZ3ODxKkSaOygChfVhxNIQ #1059). It also adds Nma 1337 #1009, [NMA-1356] Return to StakingActivity from VerifySeedActivity #1014 (prune observed spends during the initial sync), fix(uphold): wrong balance #1140, fix: send coins crash #1143 (sweep a conflict loser's keys-only records), feat: send flow redesign #1147, Android notification fails to calculate total value in FIAT #1148, fix: stuck currency code & cleanup obsolete currencies #1187 and chore: update to dashj 20.0.0-SNAPSHOT to support Core v20 #1204.unrecorded_spend_heightsdelegation, becausev5.0-devimplements it itself now.Test plan
org.dashj:dash-sdk-android:5.0.0-int32-SNAPSHOT:20261026.223239-1. The published AAR, pom and module were downloaded back byte-identical (AAR sha25644822db1…).build_info.txtreports0495544fd5, not dirty.mirror consistent (engineRows=1083 storeRows=1083 inserted=0 healedSpent=0 flipped=0), there was no DashPay rewind, and DashPay sync settled.7d8539e49) with the int32 pin, so it predates fix(cutover): migrate CoinJoin funds through bounded consolidation #1607 and docs: code knowledge for the v12 line (review lessons, checklist, project map) #1637, which are in this PR's base.4a1e255c…(expected unchanged, since folding is still out).Recipe and evidence: HashEngineering/dash-wallet-qa
recipes/platform/5.0.0-int32.yaml.🤖 Generated with Claude Code
Summary by CodeRabbit