Repository navigation
docs: code knowledge for the v12 line (review lessons, checklist, project map) - #1637
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
On v12 PRs, thepastaclaw and coderabbitai find the same few kinds of defect again and again:
Each one gets rediscovered PR by PR, often over 20+ review rounds (#1570, #1576, #1616, #1621). This PR writes them
down once, together with a map of the v12 code, so that people and agents start from it.
Related PR's and Dependencies
/pre-reviewskill, merged to master as cdaf542 and cherry-picked here.What was done?
docs/code-knowledge/is new and contains:checklist.md: the questions the bots ask most often, one line each. Walk a diff through it before pushing.00-project-map.md: a map of the v12 code. It covers:SdkWriteResult;01–09: rules by area. Each rule names the PRs it came from, so the reasoning can be checked:Sources.
feat/kotlin-sdk-phase-1from feat(dashspend): piggycards provider picker #1414 to fix: base-branch follow-ups — funding gate height rule, replay wake lock, bind-heal lifetime, flaky tests #1632, readtogether with the author replies and how each thread was resolved. That is 722 threads. PRs into
masterwereskipped.
Caveat. Some source PRs are still open (#1607, #1616, …). Names taken from them may not exist on the base yet; the
docs say so where it matters.
CLAUDE.mdnow links the folder. It also fixes three stale facts:.claude/skills/pre-review/is out of scope here. It is a cherry-pick of #1634 (merged to master as cdaf542,reviewed and approved there), included only because
feat/kotlin-sdk-phase-1does not have #1634 yet. It is bytefor byte identical to
origin/master. Findings on it belong to a separate hardening PR into master. Some of themwere fixed and then reverted here, so that this PR does not fork the tool.
How Has This Been Tested?
Documentation only. I checked that the classes and functions the rules reference exist on the base with
git grep;the docs mark the ones from still-open PRs.
/pre-reviewran againstfeat/kotlin-sdk-phase-1, and its documentation findings are fixed. The tool's own testsuite passes (
test_prereview.sh).The project map also notes two possible issues. Both are inferred from the code and not verified:
SecurityFunctions.authenticatemay never resume;FakeDashSpendServiceuses a testnet-only address on devnet.They are left for separate follow-ups.
Checklist:
🤖 Generated with Claude Code