Repository navigation
fix(wallet): show keys awaiting their old password right after a storage update - #1171
Draft
Claudius-Maginificent wants to merge 1 commit into
Draft
Claudius-Maginificent wants to merge 1 commit into
Claudius-Maginificent wants to merge 1 commit into
Conversation
…etried storage update Retrying a failed storage update with Wallets open did not show the "imported key needs your old password" banner until a manual Refresh or restart: the page scanned for such keys while the storage was still unreadable and nothing told it to scan again. The finished update reports a change of every cached domain, which the page did not handle. Wallets now re-scans on that report for its own network, without resetting anything else on the page. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Collaborator
|
🕓 Review not started yet because this PR is a draft.
Commit 5a525cc. Normal review starts when eligible; priority review starts as soon as a slot is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
After a failed wallet-storage update is retried successfully, the Wallets screen now shows the "this imported key needs your old password" notice right away, instead of only after Refresh or a restart.
User story
As a wallet user upgrading from an older version, I want the app to tell me straight away which imported keys need their old password after the storage update finishes, so that I can restore them without hunting for a Refresh button.
Scenario
Steps to reproduce
Actual behavior
The restore notice for imported keys that still need their old password does not appear until the user presses Refresh or restarts the app. The same happens after wiping a devnet.
Expected behavior
The notice appears as soon as the update finishes.
Detailed discussion
FinishUnwire(migration retry) and the devnet wipe reportCacheUpdated { domain: All }. That reaches screens only throughcached_data_changed, whichWalletsBalancesScreendid not implement.list_pending_protected_restoresreturns Err. The screen setspending_restores_scanned = truewith an empty list and never scans again.WalletsBalancesScreen::cached_data_changednow resetspending_restores_scannedforCacheDomain::Allon its own network, and the banner re-scans on its next paint. No inputs or pending operations are touched.refresh()is updated.All.All.Testing
ui::wallets::wallets_screen::tests::a_finished_storage_update_offers_keys_awaiting_their_old_password:Allfor another network leaves the list empty andAllfor its own network surfaces 1 entry;left: 0, right: 1).--lib wallets_screen: 40 passed. Clippy is clean.🤖 Co-authored by Claudius the Magnificent AI Agent
🤖 Generated with Claude Code