Skip to content

chore(deps): update Platform to v5.1-dev 575d961f - #1132

Merged
lklimek merged 5 commits into
v1.0-devfrom
chore/bump-platform-575d961f
Oct 26, 2026
Merged

lklimek merged 5 commits into
v1.0-devfrom
chore/bump-platform-575d961f

Conversation

@Claudius-Maginificent

@Claudius-Maginificent Claudius-Maginificent commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

TL;DR

DET now runs on Platform v5.1-dev 575d961f. When the network is on a newer protocol version than this build understands, the Platform Info epoch report says so and tells you to update DET. DET also stops keeping its own copy of "which protocol version has the network proven" and reads it from the SDK. Pasted proofs in the proof visualizer are decoded as untrusted input. Existing data needs no migration.

What changed

  • Pin bump. dash-sdk, rs-sdk-trusted-context-provider, platform-wallet and platform-wallet-storage move from 063589bf to 575d961f (v5.1-dev tip). This includes feat(sdk): expose cached verified protocol version to Swift platform#5511 and fix(sdk): query compacted address balances when the recent proof has no boundary platform#5572, which makes address sync query compacted address balances when the recent proof has no boundary; DET needed no code change for it. The lockfile moves only the Platform packages, and rust-dashcore stays at aca02026.
  • Wallet storage unchanged. The platform-wallet-storage migrations are identical between the two revisions: still 19 files with the same fingerprint. The pin guard passes (ancestry on v5.1-dev, fingerprint match); only the recorded revision changed.
  • Protocol version comes from upstream. AppContext::proven_protocol_version() and proven_platform_version() duplicated #5511's Sdk::protocol_version_info() (verified_version, newer_protocol_available). Both are replaced by a passthrough, AppContext::protocol_version_info(). Protocol capabilities (shielded) still fail closed in two cases: before the network proves a version, and when it proves a version this build does not define.
  • Update advisory. Tools → Platform Info → current epoch ends with "The network runs protocol version N, which is newer than this version of Dash Evo Tool supports (up to M). Some features stay unavailable until you update Dash Evo Tool." This appears when the network has proven a newer protocol. It shows on both the normal report and the "epoch unavailable" report.
  • Proof visualizer. Pasted proofs are decoded with decode_from_slice_untrusted and the shared PLATFORM_BINCODE_CONFIG (#5586), as upstream's prettify_proof does. A bogus length prefix is refused instead of allocated.

Upstream features adopted

Upstream Adoption in DET
dashpay/platform#5511 Sdk::protocol_version_info() / ProtocolVersionInfo Replaces DET's proven-version accessors and backs the update advisory
dashpay/platform#5586 PLATFORM_BINCODE_CONFIG Used by the proof visualizer
dashpay/platform#5572 address sync compacted-balance fallback Automatic, no DET code: platform address balances sync through the fixed SDK
dashpay/platform#5533 / #5538 native document and schema validation at protocol 15 Automatic, no DET code: contract registration and update use the SDK's protocol version. On a protocol 15 network, index property names are limited to 255 bytes, and schemas the native validator cannot represent are refused. No live network runs protocol 15 yet.

The #5511 branch history includes write admission, prefixed DAPI processing refusals, typed unconfirmed-submission and broadcast-ambiguity errors, and a DPNS v3 target. Its final commit removed all of them before merge; they now live in draft dashpay/platform#5556. None of them is in 575d961f, so this PR adds no new TaskError variants.

Follow-ups

  1. When fix(sdk): preserve uncertain submission outcomes through shared broadcast platform#5556 lands, map its typed unconfirmed-submission and broadcast-ambiguity errors to dedicated TaskError variants.
  2. Show the "newer protocol available, update DET" advisory more prominently, for example as a global banner or in the connection status indicator, not only in Platform Info.
  3. Adopt the DPNS v3 development target once it is actually merged upstream.

Testing

  • New: a_newer_proven_protocol_appends_the_update_advisory, no_update_advisory_without_a_newer_proven_protocol, a_failed_epoch_fetch_still_advises_updating_for_a_newer_network, an_unknown_proven_version_is_flagged_as_newer, a_platform_encoded_proof_is_shown, an_oversized_length_prefix_is_refused. The advisory tests were run red before the implementation.
  • Existing platform_info, feature_gate, mcp::resolve and context tests pass, including an_unknown_future_protocol_version_closes_every_protocol_capability.
  • cargo clippy --all-features --all-targets -- -D warnings and cargo fmt --all -- --check are clean.
  • scripts/migration-fixtures/check-pin-ancestry.sh passes.

🤖 Co-authored by Claudius the Magnificent AI Agent

🤖 Generated with Claude Code

https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q

PR Hygiene · e686291

  • Bots — coderabbitai skipped after its own rate limit · thepastaclaw ✓
  • Self-review — not asked of a bot author
  • Build green
  • Approvals
    • files with no dedicated owner (Cargo.lock, Cargo.toml, scripts/migration-fixtures/expected-migration-fingerprint.txt and 7 more) — approved by lklimek

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

lklimek and others added 4 commits October 26, 2026 16:26
Pin dash-sdk, rs-sdk-trusted-context-provider, platform-wallet and
platform-wallet-storage to dashpay/platform v5.1-dev 3d0db533, which
includes dashpay/platform#5511. The lockfile moves only the Platform
packages; rust-dashcore stays at aca02026.

The platform-wallet-storage migrations are unchanged (19 files, same
fingerprint), so the pin guard records only the new revision.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
…otocol

Read the network's proven protocol version from upstream's
Sdk::protocol_version_info() (dashpay/platform#5511) instead of DET's own
copy. AppContext::proven_protocol_version() and proven_platform_version()
re-implemented its verified_version and newer_protocol_available, so
they are replaced by a passthrough, AppContext::protocol_version_info().
Protocol capabilities still fail closed before anything is proven and
on a version this build does not define.

Platform Info's current-epoch report now ends with an update advisory
when the network has proven a protocol version newer than this build
supports, on both the read and the unavailable-epoch paths.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
The proof visualizer decoded user-pasted bytes with the trusted bincode
decoder and a hand-built copy of Platform's configuration. Decode them
as upstream's prettify_proof does: decode_from_slice_untrusted with the
shared PLATFORM_BINCODE_CONFIG (dashpay/platform#5586), so a bogus length
prefix is refused instead of allocated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
Move the four Platform pins from 3d0db533 to 575d961f, the v5.1-dev tip
that adds dashpay/platform#5572: address sync queries compacted address
balances when the recent proof has no boundary. No API change. The
platform-wallet-storage migrations are unchanged (19 files, same
fingerprint).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between c26a626 and e686291.

Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 9
  • Cargo.toml
  • scripts/migration-fixtures/expected-migration-fingerprint.txt
  • src/backend_task/platform_info.rs
  • src/context/feature_gate.rs
  • src/context/mod.rs
  • src/mcp/resolve.rs
  • src/ui/tools/proof_visualizer_screen.rs
  • src/wallet_backend/platform_compatibility/fixtures/README.md
  • tests/backend-e2e/platform_info.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit e686291) · triage: normal · Phase 2 only (no Phase 1 for this repository)

@lklimek
lklimek marked this pull request as ready for review October 26, 2026 16:49
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Oct 26, 2026
@lklimek
lklimek enabled auto-merge (squash) October 26, 2026 16:52

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 2 only (no Phase 1 for this repository)

The Platform dependency bump, protocol-version metadata migration, update advisory, and untrusted proof decoding changes are consistent with the pinned upstream APIs and the PR’s stated goals. The relevant CI checks passed, including tests, Clippy, formatting, and the Platform pin guard; no correctness, security, compatibility, or maintainability issues were found.

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — This is a cross-cutting dependency and behavior update affecting protocol-version feature gating, platform information UI, proof decoding, and MCP resolution, but it does not directly change consensus, funds movement, cryptography, key handling, or storage migrations.
  • Phase 1 reviewers: not run (disabled for this repository)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort high); agent phase2-reviewer

@github-actions

Copy link
Copy Markdown
Contributor

Policy satisfied — this can merge.
Full checklist in the description.

@github-actions github-actions Bot added bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Oct 26, 2026
@lklimek
lklimek merged commit aca9bb4 into v1.0-dev Oct 26, 2026
20 checks passed
@lklimek
lklimek deleted the chore/bump-platform-575d961f branch October 26, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-skipped A required review bot did not report; it was skipped by the window or by a person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants