Repository navigation
chore(deps): update Platform to v5.1-dev 575d961f - #1132
Conversation
Pin dash-sdk, rs-sdk-trusted-context-provider, platform-wallet and platform-wallet-storage to dashpay/platform v5.1-dev 3d0db533, which includes dashpay/platform#5511. The lockfile moves only the Platform packages; rust-dashcore stays at aca02026. The platform-wallet-storage migrations are unchanged (19 files, same fingerprint), so the pin guard records only the new revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
…otocol Read the network's proven protocol version from upstream's Sdk::protocol_version_info() (dashpay/platform#5511) instead of DET's own copy. AppContext::proven_protocol_version() and proven_platform_version() re-implemented its verified_version and newer_protocol_available, so they are replaced by a passthrough, AppContext::protocol_version_info(). Protocol capabilities still fail closed before anything is proven and on a version this build does not define. Platform Info's current-epoch report now ends with an update advisory when the network has proven a protocol version newer than this build supports, on both the read and the unavailable-epoch paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
The proof visualizer decoded user-pasted bytes with the trusted bincode decoder and a hand-built copy of Platform's configuration. Decode them as upstream's prettify_proof does: decode_from_slice_untrusted with the shared PLATFORM_BINCODE_CONFIG (dashpay/platform#5586), so a bogus length prefix is refused instead of allocated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
Move the four Platform pins from 3d0db533 to 575d961f, the v5.1-dev tip that adds dashpay/platform#5572: address sync queries compacted address balances when the recent proof has no boundary. No API change. The platform-wallet-storage migrations are unchanged (19 files, same fingerprint). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Final review complete — no blockers (commit e686291) · triage: normal · Phase 2 only (no Phase 1 for this repository) |
|
Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 2 only (no Phase 1 for this repository)
The Platform dependency bump, protocol-version metadata migration, update advisory, and untrusted proof decoding changes are consistent with the pinned upstream APIs and the PR’s stated goals. The relevant CI checks passed, including tests, Clippy, formatting, and the Platform pin guard; no correctness, security, compatibility, or maintainability issues were found.
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
normalbygpt-6.1-sol(effort low) — This is a cross-cutting dependency and behavior update affecting protocol-version feature gating, platform information UI, proof decoding, and MCP resolution, but it does not directly change consensus, funds movement, cryptography, key handling, or storage migrations. - Phase 1 reviewers: not run (disabled for this repository)
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort high); agentphase2-reviewer,gpt-6.1-sol— rust-quality (completed, effort high); agentphase2-reviewer
|
Policy satisfied — this can merge. |
TL;DR
DET now runs on Platform v5.1-dev
575d961f. When the network is on a newer protocol version than this build understands, the Platform Info epoch report says so and tells you to update DET. DET also stops keeping its own copy of "which protocol version has the network proven" and reads it from the SDK. Pasted proofs in the proof visualizer are decoded as untrusted input. Existing data needs no migration.What changed
dash-sdk,rs-sdk-trusted-context-provider,platform-walletandplatform-wallet-storagemove from063589bfto575d961f(v5.1-dev tip). This includes feat(sdk): expose cached verified protocol version to Swift platform#5511 and fix(sdk): query compacted address balances when the recent proof has no boundary platform#5572, which makes address sync query compacted address balances when the recent proof has no boundary; DET needed no code change for it. The lockfile moves only the Platform packages, and rust-dashcore stays ataca02026.platform-wallet-storagemigrations are identical between the two revisions: still 19 files with the same fingerprint. The pin guard passes (ancestry on v5.1-dev, fingerprint match); only the recorded revision changed.AppContext::proven_protocol_version()andproven_platform_version()duplicated #5511'sSdk::protocol_version_info()(verified_version,newer_protocol_available). Both are replaced by a passthrough,AppContext::protocol_version_info(). Protocol capabilities (shielded) still fail closed in two cases: before the network proves a version, and when it proves a version this build does not define.decode_from_slice_untrustedand the sharedPLATFORM_BINCODE_CONFIG(#5586), as upstream'sprettify_proofdoes. A bogus length prefix is refused instead of allocated.Upstream features adopted
Sdk::protocol_version_info()/ProtocolVersionInfoPLATFORM_BINCODE_CONFIGThe #5511 branch history includes write admission, prefixed DAPI processing refusals, typed unconfirmed-submission and broadcast-ambiguity errors, and a DPNS v3 target. Its final commit removed all of them before merge; they now live in draft dashpay/platform#5556. None of them is in
575d961f, so this PR adds no newTaskErrorvariants.Follow-ups
TaskErrorvariants.Testing
a_newer_proven_protocol_appends_the_update_advisory,no_update_advisory_without_a_newer_proven_protocol,a_failed_epoch_fetch_still_advises_updating_for_a_newer_network,an_unknown_proven_version_is_flagged_as_newer,a_platform_encoded_proof_is_shown,an_oversized_length_prefix_is_refused. The advisory tests were run red before the implementation.an_unknown_future_protocol_version_closes_every_protocol_capability.cargo clippy --all-features --all-targets -- -D warningsandcargo fmt --all -- --checkare clean.scripts/migration-fixtures/check-pin-ancestry.shpasses.🤖 Co-authored by Claudius the Magnificent AI Agent
🤖 Generated with Claude Code
https://claude.ai/code/session_012ujJpB9DBhvtbjhYB3aG9Q
PR Hygiene ·
e686291Cargo.lock,Cargo.toml,scripts/migration-fixtures/expected-migration-fingerprint.txtand 7 more) — approved by lklimekWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.