Repository navigation
fix(dashpay): save contact details through platform-wallet (DIP-15) #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Claudius-Maginificent
wants to merge
98
commits into
v1.0-dev
Choose a base branch
from
fix/dashpay-contact-info-keys
base: v1.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,620
−3,835
Open
Changes from all commits
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
942de7d
perf(identity): clone the Profile tab's identity snapshot once per frame
lklimek 1451e89
fix(identity): keep identity hub tabs to one content width
lklimek fb50583
fix(identity): lay out the Profile tab like its wireframe
lklimek 6f90d46
fix(identity): tidy the Contacts tab's sections and rows
lklimek 4132340
fix(identity): keep the identity header in the hub's content column
lklimek f1a43f2
fix(identity): shorten long usernames and contact names to fit their row
lklimek 5320dd5
perf(identity): render the Profile tab from the borrowed identity
lklimek 1b559f4
fix(identity): keep the identity hub inside narrow windows
lklimek 4b980d8
fix(identity): keep long contact names clear of the row's buttons
lklimek ba82835
feat(identity): show contact details and a private note in the hub's …
lklimek 861c047
fix(identity): keep the contact pane's spacing and align usernames in…
lklimek c699370
fix(identity): settle contact details writes the hub cannot see
lklimek ed3d486
fix(dashpay): read and write contact details the way platform-wallet …
lklimek 67d3fc3
fix(identity): expand the hub to the available window width
lklimek 2cc7add
Merge branch 'v1.0-dev' into fix/identity-hub-layout
lklimek a3f83db
chore(identity): merge the updated hub layout base
lklimek b977e31
fix(dashpay): preserve typed contact encoding errors
lklimek 3b0e080
fix(identity): open Home contacts in the hub detail pane
lklimek 38ed5df
chore(identity): merge v1.0-dev into contact details
lklimek a72db92
fix(identity): address contact note review findings
lklimek 863d1ef
fix(identity): preserve contact write lifecycle and visibility
lklimek 4377702
Merge branch 'v1.0-dev' into feat/identity-hub-contact-detail
lklimek 69f1a51
fix(identity): release hidden hub contact details writes on bare errors
lklimek c02b866
fix(dashpay): save contact details through platform-wallet (DIP-15)
lklimek 52fcddf
fix(dashpay): keep withdrawals and cleared contact details in force
lklimek 8442489
fix(dashpay): read published contact details back after a restart
lklimek ef7ebb9
fix(identity): settle hub contact details writes only for their dispatch
lklimek 76c0963
Merge #1096 dispatch-bound contact details writes into fix/dashpay-co…
lklimek a68370c
fix(identity): keep a running contact details write correlated across…
lklimek 69f5be7
Merge #1096 write correlation across identity switches into fix/dashp…
lklimek a31aef0
fix(dashpay): finish the withdraw lifecycle and fail unsafe contact d…
lklimek 15ec292
fix(identity): drop contact lists from loads older than the latest one
lklimek 1bf4ca5
Merge #1096 stale contact load fix into fix/dashpay-contact-info-keys
lklimek a2bd488
test(identity): pass the publish outcome in the merged stale-load test
lklimek 2839d06
fix(dashpay): fail a contact details save when the legacy keys cannot…
lklimek 964072b
fix(identity): give the hub's confirmed notes an explicit lifecycle
lklimek 95f2187
Merge #1096 confirmed-note lifecycle into fix/dashpay-contact-info-keys
lklimek 00f5639
fix(dashpay): let published notes win over saves kept on this device
lklimek a247264
fix(dashpay): keep saves and withdrawals from racing other writers
lklimek 567c4c8
revert(dashpay): drop the stale-baseline guard on contact details saves
lklimek 8aceb46
fix(identity): keep a confirmed note through a lagging read after an …
lklimek 251566a
Merge v1.0-dev (4c38d4cc9) into feat/identity-hub-contact-detail
lklimek 03f1860
Merge #1096 (v1.0-dev 4c38d4cc9 and the identity-switch note fix) int…
lklimek 27a440f
fix(dashpay): fail a contact details read when the wallet is not loaded
lklimek 46d868e
fix(dashpay): save only the edited fields from the contact details sc…
lklimek 71341fb
fix(dashpay): hide withdrawn requests from the offline contacts list
lklimek 22cc687
fix(dashpay): report a sent contact request this device could not finish
lklimek 0180288
docs(dashpay): tag the contactInfo reader TODO with its upstream request
lklimek 2810f4e
docs(dashpay): drop review thread IDs from test comments
lklimek 7aadc72
fix(dashpay): show platform-wallet's contact details in the offline list
lklimek 548d6c8
fix(dashpay): open the contact details editor from the published details
lklimek 8fae6cd
Merge remote-tracking branch 'origin/v1.0-dev' into pr1096-work
lklimek 34af582
Merge feat/identity-hub-contact-detail (8fae6cd44) into fix/dashpay-c…
lklimek ee5c16d
fix(dashpay): keep contact details editing closed until its own read …
lklimek 1b354ff
fix(dashpay): stop claiming a device-only contact save reached the ne…
lklimek 964d30b
fix(dashpay): read contact details from documents as Platform returns…
lklimek 0c358ab
Merge feat/identity-hub-contact-detail (964d30b66) into fix/dashpay-c…
lklimek 82deefb
Merge origin/v1.0-dev (aca9bb40e) into feat/identity-hub-contact-detail
lklimek b2e27b0
Merge feat/identity-hub-contact-detail (82deefb6e) into fix/dashpay-c…
lklimek 42e830f
fix(dashpay): keep contacts with unreadable details hidden and say so
lklimek 4a85c4d
Merge origin/v1.0-dev (01434ece3) into feat/identity-hub-contact-detail
lklimek c4dfec9
Merge feat/identity-hub-contact-detail (4a85c4d1c) into fix/dashpay-c…
lklimek aee88cb
fix(deps): take platform-encryption from the shared Platform pin
lklimek a78aef1
fix(dashpay): keep a contact hidden when its newest published details…
lklimek bdbd01d
fix(dashpay): stop claiming the network for a failed local decline or…
lklimek d16e72c
fix(dashpay): let the contacts list's details sync wait for a save
lklimek aeb1d58
fix(dashpay): do not fail a recorded decline or withdrawal on leftove…
lklimek 03b0e0b
fix(dashpay): skip contact details syncs while a save runs instead of…
lklimek 41000cb
fix(dashpay): save to and show the newest contactInfo document of a c…
lklimek 419b409
Merge feat/identity-hub-contact-detail (41000cbe0) into fix/dashpay-c…
lklimek d8ac50a
docs(dashpay): say the newest contactInfo document wins, next to its …
lklimek 3b45d3b
Merge feat/identity-hub-contact-detail (d8ac50ab5) into fix/dashpay-c…
lklimek 60c92c5
Merge v1.0-dev (34dbaab49, squash of #1096) into fix/dashpay-contact-…
lklimek 04793b8
fix(dashpay): serialize request actions per person and keep declined …
lklimek 96e5a92
fix(dashpay): never save over unreadable contact details by accident,…
lklimek ee6b5ca
test(dashpay): generate the contact info provider tests' seed at run …
lklimek b8fcb59
fix(dashpay): record nothing on a failed publish, and let the backend…
lklimek c0a81af
test(dashpay): pin that every send retires a decline, and share the n…
lklimek d00edb0
refactor(dashpay): name the unhide-only update instead of comparing t…
lklimek ed394ac
Merge v1.0-dev (6d90573d3, #1119) into fix/dashpay-contact-info-keys
lklimek 0490a1f
Merge v1.0-dev into fix/dashpay-contact-info-keys
lklimek 4887235
refactor(dashpay): build and use contact QR codes through platform-wa…
lklimek 39b610b
fix(dashpay): harden contact QR parsing and the auto-accept key export
lklimek 03260fa
fix(dashpay): hide declined people from the offline contacts list
lklimek 771d850
fix(dashpay): never leave a contact ignored after a failed decline or…
lklimek 9133a4f
Merge v1.0-dev into fix/dashpay-contact-info-keys
lklimek 70f2bf3
docs(dashpay): link the upstream issue for a failed contact-details p…
lklimek 12f88f3
test(dashpay): generate the offline tests' wallet seeds at runtime
lklimek 7337d33
Merge v1.0-dev into fix/dashpay-contact-info-keys
lklimek bcd5710
fix(dashpay): keep a send from re-engaging halfway through a cancel
lklimek 566581b
docs(dashpay): say cancel is local only and link the upstream issues
lklimek 09a38b8
docs(dashpay): link the upstream issue for erased accepted accounts
lklimek 33fe2b6
refactor(dashpay): mint a held peer lock only from the lock helper
lklimek e25ea74
test(dashpay): pin that accept's handed-down lock never deadlocks its…
lklimek 9b072e9
fix(dashpay): restore a withdrawn request under the person's lock
lklimek ab454c7
Merge remote-tracking branch 'origin/v1.0-dev' into fix/dashpay-conta…
lklimek c76261c
fix(dashpay): adapt merged base code to the reshaped DashPay tasks
lklimek 171e479
fix(dashpay): show the note fee only when the save publishes
lklimek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document the signing-key limitation.
The PR reports that identities with default
ECDSA_HASH160authentication keys cannot publish contact details until upstream support lands. For those identities, having two contacts does not make the save publish. Add this limitation to the story. This finding is based on the PR’s reported upstream blocker.