Skip to content

fix(identity): size and align inline username actions - #1097

Merged
lklimek merged 1 commit into
v1.0-devfrom
fix/identity-username-actions
Oct 19, 2026
Merged

lklimek merged 1 commit into
v1.0-devfrom
fix/identity-username-actions

Conversation

@lklimek

@lklimek lklimek commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR: The identity header's “…” and “+” buttons are smaller, equally sized, and vertically aligned with the usernames.

User story

As an everyday user, I want username actions to sit neatly beside my names so the identity header is easy to read.

Scenario

Open an identity with more than three usernames.

Actual behavior

The two actions inherit oversized button padding and sit lower than the names.

Expected behavior

Both actions appear as matching compact buttons centered beside the names. “…” opens the usernames section and “+” starts username registration.

Detailed discussion

Use local compact padding, matching secondary-button styling, and a 24-point initial row height. Keep wrapping and the existing action routing.

The issue exists on v1.0-dev; this PR is independent of #1094, where it was reported.

Testing

  • The themed geometry regression failed before the fix (overflow button approximately 45 × 31 points).
  • cargo test --locked --all-features --test kittest identity_home::: 25 passed, including size/alignment in light and dark themes and both action routes.
  • cargo clippy --locked --all-features --lib --test kittest -- -D warnings: passed.
  • cargo fmt --all and git diff --check: passed.
  • Real compiled application on the X11 desktop: visually checked light/dark themes at 800 × 760 and 1200 × 760. Accessibility geometry confirms both header buttons are 24 × 24 and share the username row's vertical center. Clicking “…” opens Profile's usernames section.
  • GUI checks used an isolated synthetic testnet identity with four usernames and no private keys. No transactions were submitted.

🤖 Co-authored by Claudius the Magnificent AI Agent

PR Hygiene · c3fe320

  • Bots — coderabbitai ✓ · thepastaclaw skipped by lklimek
  • Self-review — posted; again after any push
  • Build green
  • Approvals — you own every area touched; none needed

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

  • Style
    • Updated the identity header layout so username information and actions wrap within the available space.
    • Restyled the overflow and add-username buttons to match the active theme while keeping them aligned with the username list.

Use matching compact buttons and reserve the username row height before
laying out its label. Verify geometry with the application theme and keep
coverage for both username actions.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: dashpay/dash-evo-tool/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a7b57780-fce3-4c79-b38e-84fd9588ba23
📥 Commits

Reviewing files that changed from the base of the PR and between 1d9eab8 and c3fe320.

📒 Files selected for processing: 2
  • src/ui/identity/home.rs
  • tests/kittest/identity_home.rs
📝 Walkthrough

The identity username row now uses an allocated wrapping layout. The overflow and add-username controls use 24×24 secondary buttons. Tests check their size, alignment, and order in light and dark themes.

Changes: Identity username row

Layer / File(s) Summary
Username row layout and controls
src/ui/identity/home.rs, tests/kittest/identity_home.rs
The username row uses an allocated wrapping layout. The overflow and add-username controls use 24×24 secondary buttons. Existing name displays and navigation behavior remain. Tests check button size, alignment, and order in both themes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: claudius-maginificent

Merge Risk: ⚪ Minimal · up to c3fe3

The username actions are compacted and the row layout adjusted. No actionable regression is established, so the change appears ready to merge subject to normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: fixing the size and alignment of inline username actions in the identity header.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.

  • Request normal review — click when the PR is ready for review.
  • Request priority review — click to move this review to the front of the queue.

Commit c3fe320. Normal review starts when eligible; priority review starts as soon as a slot is available.

@lklimek
lklimek marked this pull request as ready for review October 19, 2026 13:16
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai ✓ · thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Oct 19, 2026

@lklimek lklimek left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/self-reviewed

@lklimek

lklimek commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

/skip-bots

@lklimek
lklimek enabled auto-merge (squash) October 19, 2026 13:34
@github-actions

Copy link
Copy Markdown
Contributor

Policy satisfied — this can merge.
Full checklist in the description.

@github-actions github-actions Bot added bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Oct 19, 2026
@lklimek
lklimek merged commit 804ee4c into v1.0-dev Oct 19, 2026
15 checks passed
@lklimek
lklimek deleted the fix/identity-username-actions branch October 19, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-skipped A required review bot did not report; it was skipped by the window or by a person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants