Repository navigation
fix(identity): size and align inline username actions - #1097
Conversation
Use matching compact buttons and reserve the username row height before laying out its label. Verify geometry with the application theme and keep coverage for both username actions. <sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub> Co-Authored-By: Codex GPT-6 <noreply@openai.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
🕓 Review not started yet because the new head is waiting for the 30-minute push debounce.
Commit c3fe320. Normal review starts when eligible; priority review starts as soon as a slot is available. |
|
Waiting for bot review — coderabbitai ✓ · thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
|
/skip-bots |
|
Policy satisfied — this can merge. |
TL;DR: The identity header's “…” and “+” buttons are smaller, equally sized, and vertically aligned with the usernames.
User story
As an everyday user, I want username actions to sit neatly beside my names so the identity header is easy to read.
Scenario
Open an identity with more than three usernames.
Actual behavior
The two actions inherit oversized button padding and sit lower than the names.
Expected behavior
Both actions appear as matching compact buttons centered beside the names. “…” opens the usernames section and “+” starts username registration.
Detailed discussion
Use local compact padding, matching secondary-button styling, and a 24-point initial row height. Keep wrapping and the existing action routing.
The issue exists on
v1.0-dev; this PR is independent of #1094, where it was reported.Testing
cargo test --locked --all-features --test kittest identity_home::: 25 passed, including size/alignment in light and dark themes and both action routes.cargo clippy --locked --all-features --lib --test kittest -- -D warnings: passed.cargo fmt --allandgit diff --check: passed.🤖 Co-authored by Claudius the Magnificent AI Agent
PR Hygiene ·
c3fe320When every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.Summary by CodeRabbit