Skip to content

fix(masternodes): make long node lists scroll everywhere - #1086

Merged
lklimek merged 2 commits into
v1.0-devfrom
fix/masternodes-list-scroll
Oct 14, 2026
Merged

lklimek merged 2 commits into
v1.0-devfrom
fix/masternodes-list-scroll

Conversation

@Claudius-Maginificent

@Claudius-Maginificent Claudius-Maginificent commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

TL;DR

With many masternodes loaded, the "Vote with" list in Masternodes → Votes ran off the window and could not be scrolled, so some nodes and the "Save as my default" button were unreachable. That list now scrolls, and the node list in Masternodes → Nodes scrolls from anywhere in its panel, with the scroll bar at the panel's edge.

User story

As a masternode owner with many nodes, I want every list of my nodes to scroll, so that I can reach each node and every button no matter how many nodes I have loaded or how small the window is.

Scenario

Actual behavior

  • Masternodes → Votes, click "Vote with: …" with about 20 or more nodes loaded in a small window: the list is taller than the window and does not scroll. The lower part of the list and the "Save as my default" button cannot be reached.
  • Masternodes → Nodes in a window wider than the cards: the list scrolls only while the pointer is over a card. With the pointer in the empty space beside the cards the mouse wheel does nothing and no scroll bar shows; when it does show, it sits at the edge of the last card instead of the edge of the panel.

Expected behavior

  • The "Vote with" list scrolls, and "Save as my default" stays visible below it.
  • The node list scrolls wherever the pointer is in the panel, and its scroll bar is at the panel's edge.

Detailed discussion

  • src/ui/dpns/node_set_picker.rs: the node rows of the "Vote with" popover are wrapped in ScrollArea::vertical().max_height(..). The height comes from the room above or below the chip (the larger of the two) minus the fixed height of the rest of the popover, clamped to 80–400 px. It is deliberately not derived from the popover's own position: egui places a popup from its size in the previous frame, so the two must not depend on each other. The button stays outside the scroll area.
  • src/ui/masternodes/list_screen.rs: the card grid's scroll area gets .auto_shrink([false, false]), as the identity card grid in src/ui/identity/picker.rs already has, so it takes the whole panel.
  • Neither defect is a recent regression: the popover never scrolled since it was added in feat(dpns): operator-first masternode voting and usernames in identities #901, and the grid has had the default auto_shrink since feat: rewrite Dash Evo Tool onto the new platform-wallet #860.

Testing

tests/kittest/masternode_tab.rs:

  • vote_with_list_scrolls_when_it_outgrows_the_window: 40 nodes, 800x600. The button below the list is inside the window; the last node starts out of view and is visible above the button after scrolling.
  • node_list_scrolls_and_shows_its_bar_from_the_space_beside_the_cards: 12 nodes, 1280x800. With the pointer beside the cards the list scrolls and the bar is at the panel's edge.
  • every_node_is_reached_by_scrolling_in_the_default_window: 12 nodes, 800x600. Passed before the change too; it records the criterion.

The first two fail without the change (button at y=1200–1231 in a 600 px window; no scroll bar found) and fail again when the two production edits are reverted.

Local runs on the final tree: cargo test --all-features --test kittest (446 passed), cargo test --all-features --lib -- ui::dpns ui::masternodes (184 passed), clippy for the lib and kittest targets clean, cargo fmt --all -- --check clean.

Checked on a real display (testnet, 24 view-only masternodes loaded through the app's own form, same data in a build without and with this change):

Check Without the change With the change
Nodes, 1280x800, wheel with the pointer beside the cards nothing happens; scrolls only over a card scrolls to the last node
Nodes, position of the scroll bar at the edge of the last card at the panel's edge
Nodes, 800x600 every node reachable every node reachable
"Vote with" list, 800x600 does not scroll, runs off the window; last nodes and "Save as my default" unreachable scrolls to the last node; the button stays in the window; the list does not move while scrolling
"Vote with" list, 1280x800 "Save as my default" below the window scrolls; the button is visible

Known limitations

  • Scroll bars in the whole app use egui's floating style: invisible until the pointer is over the list, then thin until hovered. This PR does not change that shared style, so a list at rest still shows no scroll bar (confirmed on the real display).
  • At 800x600 a row of two cards overhangs the panel content by 14 px (the column rule counts 260 px per card, a framed card takes 294). Cards are not clipped. Fixing it would change the layout from two columns to one, so it is left alone here.
  • POPOVER_CHROME_HEIGHT (220 px) matches the popover's current content (measured 195 px); it needs raising if rows are added above the list.

🤖 Generated with Claude Code

https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw

🤖 Co-authored by Claudius the Magnificent AI Agent

PR Hygiene · beafeda

  • Bots — coderabbitai skipped after its own rate limit · thepastaclaw ✓
  • Self-review — not asked of a bot author
  • Build green
  • Approvals
    • files with no dedicated owner (CHANGELOG.md, src/ui/dpns/node_set_picker.rs, src/ui/masternodes/list_screen.rs and 1 more) — lklimek

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Summary by CodeRabbit

  • Bug Fixes
    • Long node lists in the “Vote with” picker can now scroll while the “Save as my default” button remains visible.
    • The masternode list now scrolls across the full panel, including when scrolling over empty space beside the cards. Its scrollbar appears at the panel edge.
    • The node picker adjusts its list height to the available space, making more entries accessible without hiding the controls.

The "Vote with" list in Masternodes → Votes names every loaded node and had
no scroll area. With more nodes than fit in the window it ran off the
screen: the rest of the list and "Save as my default" could not be reached.
The node rows now scroll. The list is sized from the room beside the chip
that opens it, so the button below it stays in the window.

The card list in Masternodes → Nodes scrolled, but its scroll area was only
as wide as its cards. In a window wider than the cards the scroll bar sat
at the edge of the last card instead of the panel, and with the pointer in
the space beside the cards the list neither scrolled nor showed the bar.
The scroll area now takes the whole panel, as the identity picker's does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Oct 13, 2026
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: dashpay/dash-evo-tool/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 974423ce-0eb4-41d2-b7c4-33b76c6e70ce
📥 Commits

Reviewing files that changed from the base of the PR and between 0e08dec and 7445b81.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • src/ui/dpns/node_set_picker.rs
  • src/ui/masternodes/list_screen.rs
  • tests/kittest/masternode_tab.rs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Votes selector now scrolls long node lists within a calculated height, while keeping its save-default button visible. The Nodes card grid now scrolls across its panel. UI tests cover both scrolling behaviors.

Changes: Masternode and vote-list scrolling

Layer / File(s) Summary
Bounded Votes selector list
src/ui/dpns/node_set_picker.rs, tests/kittest/masternode_tab.rs
The selector calculates a list height from the space around the chip, clamps it to 80–400 points, and scrolls node rows within that height. A UI test checks that the last node can be reached while the save-default button remains in view.
Full-panel Nodes scrolling
src/ui/masternodes/list_screen.rs, tests/kittest/masternode_tab.rs, CHANGELOG.md
The card grid’s vertical scroll area occupies the panel and responds to wheel input beside the cards. UI tests check scrolling at two window sizes. The changelog describes both scrolling updates.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: lklimek

Merge Risk: ⚪ Minimal · up to 7445b

The scrolling changes appear ready to merge after normal checks. Real-display testing remains to be done, but no specific failure is established.

Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 3 files. (1 skipped: 1 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: enabling long masternode lists to scroll across the relevant panels.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Final review complete — no blockers (commit beafeda) · triage: low · Phase 2 only (no Phase 1 for this repository)

Resolves the CHANGELOG.md conflict by keeping both entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Waiting for bot review — coderabbitai not yet · thepastaclaw ✓. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 2 only (no Phase 1 for this repository)

The changes bound the “Vote with” node list while keeping the save button outside the scrolling region, and expand the masternode grid’s scroll area to fill the panel without changing node-selection behavior. Static inspection of the complete diff, surrounding callers, and test harness supports the supplied reviewers’ clean assessments; the three new regression tests cover the reported scrolling interactions. No builds or tests were run in this verification lane; the supplied CI snapshot shows Clippy and the platform pin guard passing, with the Test Suite still in progress.

Review provenance

Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — The diff makes two contained UI scrolling adjustments with focused regression tests and does not change voting logic or any critical surface.
  • Phase 1 reviewers: not run (disabled for this repository)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — rust-quality (completed, effort medium); agent phase2-reviewer

@github-actions

Copy link
Copy Markdown
Contributor

Ready for review — files with no dedicated owner: lklimek.
Full checklist in the description.

@github-actions github-actions Bot added ready-for-human Bots have reported, the author has self-reviewed, and the build is green: this needs a human. bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Oct 13, 2026
@github-actions
github-actions Bot requested a review from lklimek October 13, 2026 18:09
@lklimek
lklimek enabled auto-merge (squash) October 14, 2026 11:09
@lklimek
lklimek disabled auto-merge October 14, 2026 11:42
@lklimek
lklimek merged commit 04a2cab into v1.0-dev Oct 14, 2026
11 of 12 checks passed
@lklimek
lklimek deleted the fix/masternodes-list-scroll branch October 14, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. ready-for-human Bots have reported, the author has self-reviewed, and the build is green: this needs a human.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants