Repository navigation
fix(masternodes): make long node lists scroll everywhere - #1086
Conversation
The "Vote with" list in Masternodes → Votes names every loaded node and had no scroll area. With more nodes than fit in the window it ran off the screen: the rest of the list and "Save as my default" could not be reached. The node rows now scroll. The list is sized from the room beside the chip that opens it, so the button below it stays in the window. The card list in Masternodes → Nodes scrolled, but its scroll area was only as wide as its cards. In a window wider than the cards the scroll bar sat at the edge of the last card instead of the panel, and with the pointer in the space beside the cards the list neither scrolled nor showed the bar. The scroll area now takes the whole panel, as the identity picker's does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Waiting for bot review — coderabbitai not yet · thepastaclaw not yet. Wait for the missing reviews, or a writer can post |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
✅ Final review complete — no blockers (commit beafeda) · triage: low · Phase 2 only (no Phase 1 for this repository) |
Resolves the CHANGELOG.md conflict by keeping both entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
|
Waiting for bot review — coderabbitai not yet · thepastaclaw ✓. Wait for the missing reviews, or a writer can post |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 2 only (no Phase 1 for this repository)
The changes bound the “Vote with” node list while keeping the save button outside the scrolling region, and expand the masternode grid’s scroll area to fill the panel without changing node-selection behavior. Static inspection of the complete diff, surrounding callers, and test harness supports the supplied reviewers’ clean assessments; the three new regression tests cover the reported scrolling interactions. No builds or tests were run in this verification lane; the supplied CI snapshot shows Clippy and the platform pin guard passing, with the Test Suite still in progress.
Review provenance
Source: reviewer 1: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: rust-quality); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)
- Triage:
lowbygpt-6.1-sol(effort low) — The diff makes two contained UI scrolling adjustments with focused regression tests and does not change voting logic or any critical surface. - Phase 1 reviewers: not run (disabled for this repository)
- Fresh verifier:
gpt-6.1-sol— final-verifier; agentsol-verifier - Phase 2 reviewers:
gpt-6.1-sol— general (completed, effort medium); agentphase2-reviewer,gpt-6.1-sol— rust-quality (completed, effort medium); agentphase2-reviewer
|
Ready for review — files with no dedicated owner: lklimek. |
TL;DR
With many masternodes loaded, the "Vote with" list in Masternodes → Votes ran off the window and could not be scrolled, so some nodes and the "Save as my default" button were unreachable. That list now scrolls, and the node list in Masternodes → Nodes scrolls from anywhere in its panel, with the scroll bar at the panel's edge.
User story
As a masternode owner with many nodes, I want every list of my nodes to scroll, so that I can reach each node and every button no matter how many nodes I have loaded or how small the window is.
Scenario
Actual behavior
Expected behavior
Detailed discussion
src/ui/dpns/node_set_picker.rs: the node rows of the "Vote with" popover are wrapped inScrollArea::vertical().max_height(..). The height comes from the room above or below the chip (the larger of the two) minus the fixed height of the rest of the popover, clamped to 80–400 px. It is deliberately not derived from the popover's own position: egui places a popup from its size in the previous frame, so the two must not depend on each other. The button stays outside the scroll area.src/ui/masternodes/list_screen.rs: the card grid's scroll area gets.auto_shrink([false, false]), as the identity card grid insrc/ui/identity/picker.rsalready has, so it takes the whole panel.auto_shrinksince feat: rewrite Dash Evo Tool onto the new platform-wallet #860.Testing
tests/kittest/masternode_tab.rs:vote_with_list_scrolls_when_it_outgrows_the_window: 40 nodes, 800x600. The button below the list is inside the window; the last node starts out of view and is visible above the button after scrolling.node_list_scrolls_and_shows_its_bar_from_the_space_beside_the_cards: 12 nodes, 1280x800. With the pointer beside the cards the list scrolls and the bar is at the panel's edge.every_node_is_reached_by_scrolling_in_the_default_window: 12 nodes, 800x600. Passed before the change too; it records the criterion.The first two fail without the change (button at y=1200–1231 in a 600 px window; no scroll bar found) and fail again when the two production edits are reverted.
Local runs on the final tree:
cargo test --all-features --test kittest(446 passed),cargo test --all-features --lib -- ui::dpns ui::masternodes(184 passed), clippy for the lib and kittest targets clean,cargo fmt --all -- --checkclean.Checked on a real display (testnet, 24 view-only masternodes loaded through the app's own form, same data in a build without and with this change):
Known limitations
POPOVER_CHROME_HEIGHT(220 px) matches the popover's current content (measured 195 px); it needs raising if rows are added above the list.🤖 Generated with Claude Code
https://claude.ai/code/session_012YneRVSNLhVnGiedWDr3fw
🤖 Co-authored by Claudius the Magnificent AI Agent
PR Hygiene ·
beafedaCHANGELOG.md,src/ui/dpns/node_set_picker.rs,src/ui/masternodes/list_screen.rsand 1 more) — lklimekWhen every merge requirement is met, the
PR Hygienecheck passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.Summary by CodeRabbit