feat: add dash0 slos command group (SLO IaC support)#207
Draft
nicolastakashi wants to merge 2 commits into
Draft
feat: add dash0 slos command group (SLO IaC support)#207nicolastakashi wants to merge 2 commits into
dash0 slos command group (SLO IaC support)#207nicolastakashi wants to merge 2 commits into
Conversation
Add create/get/list/update/delete subcommands for service level objectives (SLOs), backed by the /api/slos endpoint using OpenSLO v1 documents (apiVersion: openslo/v1, kind: SLO). Dataset-scoped; ID at metadata.labels."dash0.com/id"; deep-link URL support. Also wires SLO into `apply`, adds integration tests against the mock server, a roundtrip test, docs, and a changelog entry. Part of cross-facility SLO IaC support (API client, CLI, Terraform provider, Kubernetes operator). Note: builds against the local dash0-api-client-go worktree via a go.mod replace directive while the API client change is unpublished. The replace must be removed and the require version upgraded once the API client is released. Closes #206 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Dash0 SLO API document version changed from openslo/v1 to openslo.com/v1. Update the CLI's SLO fixtures, tests, help text, docs, and changelog entry to use the new apiVersion token. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SLO (service level objective) support to the Dash0 CLI: a new
dash0 sloscommand group withcreate/get/list/update/delete, backed by the/api/slosendpoint using OpenSLO v1 documents (apiVersion: openslo/v1,kind: SLO).--dataset; ID atmetadata.labels."dash0.com/id"; deep-link URL support (/goto/alerting/slos/details).SLOintoapply.run_all.sh.docs/commands.md,docs/cli-naming-conventions.md) and a.chloggen/entry.Part of cross-facility SLO IaC support (API client, CLI, Terraform provider, Kubernetes operator).
This branch builds against a local
dash0-api-client-goworktree via ago.modreplacedirective, because the required API client change (SLO client methods, helpers,DeeplinkAssetTypeSLO) is not published yet. CI will fail until:dash0-api-client-gois released with SLO support.replacedirective is removed andgo get github.com/dash0hq/dash0-api-client-go@latest+go mod tidyare run (Phase 4 of the rollout).Keeping this as a draft for early review of the command surface, output strings, and tests in the meantime.
Closes #206
🤖 Generated with Claude Code