Introduce rules to say that missing formal parameter type means dynamic - #2163
Open
eernstg wants to merge 2 commits into
Open
Introduce rules to say that missing formal parameter type means dynamic#2163eernstg wants to merge 2 commits into
eernstg wants to merge 2 commits into
Conversation
…namic, or inferred
|
Visit the preview URL for this PR (updated for commit 83b48d4): https://dart-specification--pr2163-specify-dynamic-para-axp7en66.web.app (expires Wed, 30 Mar 2022 12:57:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6941ecd630c4f067ff3d02708a45ae0f0a42b88a |
munificent
reviewed
Mar 23, 2022
| %% TODO(eernst): Change to \ref{} when inference spec is added. | ||
| Briefly, override inference yields a type computed from the declared types of | ||
| the corresponding parameter of member signatures in superinterfaces, | ||
| or it causes a compile-time error if said types can not be reconciled.% |
Member
There was a problem hiding this comment.
Do you also want to mention inference from initializing formals here too since you include constructors under this umbrella now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language specification definition of function declarations in section 'Function Declarations' has not been updated for a long time. Unfortunately, the definition is inconsistent with the usage of that phrase elsewhere in the spec. With this PR, we're consistently considering a function declaration as a broad concept (e.g., it includes constructors, operators, getters, and external functions).
With a consistently broad definition of function declarations in place, this PR then introduces the rule (in section 'Formal Parameters') that an omitted type annotation on a formal parameter yields the declared type
dynamic, and also mentions that the declared type isn't omitted if it is provided by override inference.