Skip to content

test(workflow): fix the RetiredStreamCannotOverwriteCurrentStreamCache race #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nelson-parente wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test(workflow): fix the RetiredStreamCannotOverwriteCurrentStreamCache race #1924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/Dapr.Workflow.Test/Worker/Grpc/GrpcProtocolHandlerStatefulHistoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,12 +366,15 @@ public async Task RetiredStreamCannotOverwriteCurrentStreamCache()
var releaseRetiredHandler = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
var retiredCompletionSent = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

// The failing delta tears down the first stream, which cancels that stream's token. A work item
// whose task has not started by then never runs, so deliver the failing delta only once the
// retired turn's handler is running. Otherwise the current turn waits for it forever.
grpcClientMock
.SetupSequence(x => x.GetWorkItems(It.IsAny<GetWorkItemsRequest>(), It.IsAny<CallOptions>()))
.Returns(CreateServerStreamingCallFromReader(new GatedStreamReader(
[
(retiredTurn, null),
(new WorkItem { WorkflowRequest = failingDelta }, null),
(new WorkItem { WorkflowRequest = failingDelta }, retiredHandlerStarted.Task),
(new WorkItem(), neverCompletes.Task)
])))
.Returns(CreateServerStreamingCallFromReader(new GatedStreamReader(
Expand Down
Loading