ci: rebuild tag-selector dist so 1.17 is selected again - #1923
Closed
nelson-parente wants to merge 1 commit into
Closed
nelson-parente wants to merge 1 commit into
nelson-parente wants to merge 1 commit into
Conversation
dapr#1856 removed the temporary 1.17 filter from src/index.ts but did not rebuild dist/index.js. The action runs dist/index.js (action.yml main), so a workflow that uses the action at a commit SHA still skips every 1.17 release. sdk_build.yml in this repo rebuilds dist before it runs the selector, so the .NET CI matrix is not affected. This commit is the output of npm ci, npm test (17 tests pass) and npm run build. The only change in dist/index.js is the removed filter. Signed-off-by: Nelson Parente <nelson_parente@live.com.pt> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5
Contributor
|
@nelson-parente Are you sure this is necessary? I'm looking at the outstanding "detached workflows" PR at #1919 and just re-ran the workflow from scratch. The
As 1.16, 1.17, 1.18 and the RC for 1.19 are in there, I'm not sure what your issue is referring to. Perhaps you're got a dated version of the repository on your system? You indicated that 1.15.14 is showing up in your list and that's fallen out of supported service (not N-2). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1856 removed the temporary 1.17 filter from
.github/tools/tag-selector/src/index.ts, butdist/index.jswas not rebuilt.action.ymlrunsdist/index.js, so a workflow that uses this action at a commit SHA still skips every 1.17 release.sdk_build.ymlin this repo runsnpm run buildbefore it runs the selector, so the .NET CI matrix already includes 1.17. It is not affected.dd2d9debin.github/workflows/build.yml. Its E2E matrix on 2026-10-02 (run 37039524516) was 1.19.0-rc.1, 1.18.4, 1.16.20 and 1.15.14. It has no 1.17, which is still a supported runtime.This PR is the output of
npm ci,npm test(17 tests pass) andnpm run buildin.github/tools/tag-selector. The only change indist/index.jsis the removed filter.With the current dapr/dapr releases, the selector (
stable_count3,rc_count1) returns:js-sdk gets the change only after its pin moves to a commit that includes it.
Issue reference
None. Found while checking which runtime versions the SDK CI tests for 1.19.
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_017JhKUDV9dbs5JDz2uwZqz5