Improve gRPC method discovery and failover - #1920
Merged
Merged
Conversation
…lookup stalls, but also improve on the source generator to better identify if methods are supported, unsupported or unknown based on protos at build time. At runtime then, it prefers to use reflection to see what's there, fails back to the source generator registry with failovers based on that information that'll try through each method until one works. Added in-memory cache so if a failover is required for a given method (and the response succeeds), it's persistently used until the app restarts. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1920 +/- ##
==========================================
+ Coverage 64.23% 64.94% +0.70%
==========================================
Files 358 358
Lines 10506 10573 +67
Branches 1256 1244 -12
==========================================
+ Hits 6749 6867 +118
+ Misses 3422 3370 -52
- Partials 335 336 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Iterates on the #1816 implementation to both fix the possible reflection lookup stalls, but also improve on the source generator to better identify if methods are supported, unsupported or unknown based on protos at build time. At runtime then, it prefers to use reflection to see what's there, fails back to the source generator registry with failovers based on that information that'll try through each method until one works. Added in-memory cache so if a failover is required for a given method (and the response succeeds), it's persistently used until the app restarts.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1918
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: