Skip to content

Refactor skill mutation command setup - #179

Merged
danielsitek merged 3 commits into
mainfrom
feature/dsi-skill-mutation-dedup
Oct 31, 2026
Merged

danielsitek merged 3 commits into
mainfrom
feature/dsi-skill-mutation-dedup

Conversation

@danielsitek

Copy link
Copy Markdown
Owner

Summary

  • Share write-command capabilities, exit configuration, and single skill mutation rendering across install, update, and uninstall.
  • Share installed-target resolution for update and uninstall while keeping their file operations explicit.
  • Preserve human and JSON output, error messages, scope handling, and the separate update all flow.

Verification

  • bun test src/cli/index.test.ts src/skill/index.test.ts (239 passed)
  • bun run check (772 passed; compiled smoke passed)
  • Production-only jscpd scan from Remove repeated skill mutation command scaffolding #163: neither cited skill command nor domain clone remains; 14 unrelated clones remain.
  • Compiled CLI: local install, update, and uninstall returned the expected JSON payloads.
  • Compiled capabilities: all three commands retain write, never authentication/configuration, and exit codes 0,2,6.

Closes #163

@codacy-production

codacy-production Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · -6 duplication

Metric Results
Complexity 0
Duplication -6

View in Codacy

🟢 Coverage 93.94% diff coverage · +0.33% coverage variation

Metric Results
Coverage variation ✅ +0.33% coverage variation (-1.00%)
Diff coverage ✅ 93.94% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2535e7e) 7780 7624 97.99%
Head commit (9441171) 7780 (+0) 7650 (+26) 98.33% (+0.33%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#179) 66 62 93.94%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@danielsitek
danielsitek merged commit a2976f8 into main Oct 31, 2026
11 checks passed
@danielsitek
danielsitek deleted the feature/dsi-skill-mutation-dedup branch October 31, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove repeated skill mutation command scaffolding

1 participant