Skip to content

refactor: isolate task URL parsing patterns - #172

Merged
danielsitek merged 1 commit into
mainfrom
feature/dsi-task-id-parser-clarity
Oct 24, 2026
Merged

danielsitek merged 1 commit into
mainfrom
feature/dsi-task-id-parser-clarity

Conversation

@danielsitek

@danielsitek danielsitek commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Closes #157

Summary

  • move GID and legacy/current Asana URL patterns to named module constants
  • isolate URL extraction in dedicated helpers and keep parseTaskId as a short dispatch
  • cover current URL query/fragment/path suffixes and legacy URL rejection boundaries

Verification

  • bun test src/tasks/index.test.ts: 173 passed
  • bun run check: 765 passed; compiled smoke passed
  • git diff --check: passed
  • all 11 PR checks passed
  • Codacy PR refactor: isolate task URL parsing patterns #172 Issues view lists both original parseTaskId findings at src/tasks/index.ts:715 under Potentially fixed -2 (cyclomatic complexity 12 and reported 144 lines). No false-positive marking was needed.

Codacy Cloud CLI issue/detail endpoints returned HTTP 500 during verification; the PR web analysis supplied the finding-level evidence.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -5 complexity · 0 duplication

Metric Results
Complexity -5
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@danielsitek
danielsitek merged commit 9b16513 into main Oct 24, 2026
11 checks passed
@danielsitek
danielsitek deleted the feature/dsi-task-id-parser-clarity branch October 24, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make task identifier parsing analyzable without changing its contract

1 participant