Repository navigation
fix: Cache.load() leaving partial state after WAL replay failure - #342
Merged
Merged
Conversation
Loads the snapshot and replay WAL entries into temporary state before updating the cache attributes. This prevent WAL replay failures from leaving the cache partially initialized. Adds a regression test verifying that failed loads leave the cache uninitialized and that commited WAL entries survive retry and subsequent compaction.
Cache.load() leaving partial state after WAL replay failureCache.load() leaving partial state after WAL replay failure
Contributor
Author
mattsva
approved these changes
Oct 12, 2026
Collaborator
|
Merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
Cache.load()failure-atomic by loading the database snapshot and replaying WAL entries into temporary state before updating the cache instance.Previously, if WAL replay raised an
OSError, the cache could retain partially initialized attributes, potentially causing subsequent operations to behave incorrectly.Type of Change
Key Changes
Validation
I used the pre-commit CI already existing the repository, also using the updated tests.
Checklist
uv run ruff check .anduv run ruff format --check ., or this PR does not change Python.