Skip to content

[storage engine]: refactoring the Node class in storage_format.py. #339

Closed

Description

@mohammedFawzy0111

What problem would this address?

our current implementaion only have one calss Node for both B+ tree node types with a bolean deciding the type which is rather inconvenient for futrue implementaion of the tree.

What outcome would help?

Abstracting Node to two seprate classes for each of the node types. will facilitate future use and reduce the need of extra checks.

Additional context

B+ tree implementation pr #338

Activity

  1. mattsva commented on Oct 12, 2026

    @mattsva
    Collaborator

    @mohammedFawzy0111 would you like to get assigned here? Or maybe @sowashieristjaschoninteressant

    (Please keep the PR in draft, till the B+tree implementation is more like finished.)

  2. mohammedFawzy0111 commented on Oct 12, 2026

    @mohammedFawzy0111
    ContributorAuthor

    4. @mohammedFawzy0111 would you like to get assigned here? Or maybe @sowashieristjaschoninteressant
    (Please keep the PR in draft, till the B+tree implementation is more like finished.)

    Yes please.
    I already opened a pr for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions