Skip to content

Allow selecting a Gemfile in Danger Run workflow - #13

Merged
numbata merged 1 commit into
danger:mainfrom
dblock:add-gemfile-input
Nov 7, 2026
Merged

numbata merged 1 commit into
danger:mainfrom
dblock:add-gemfile-input

Conversation

@dblock

@dblock dblock commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add an optional gemfile input to the reusable Danger Run workflow, defaulting to Gemfile.
  • Set BUNDLE_GEMFILE so Ruby setup, Bundler caching, and Danger use the selected bundle.
  • Document the input and set the gem version to 0.2.0 for this new feature.
  • Temporarily constrain git below 6 for Danger 9.6.1; the upstream Git 6 support fix is in danger/danger#1561.

This change comes from ruby-grape/grape#3057, where Grape moved Danger into a separate Gemfile.danger. The reusable workflow currently assumes the root Gemfile; this input lets callers select that separate file instead of duplicating the workflow steps.

Validation

  • bundle exec rake spec (47 examples, 0 failures)
  • bundle exec rubocop lib/danger-pr-comment/version.rb Gemfile

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Danger Report

No issues found.

View run

Set the gem version to 0.2.0 for this new feature. Temporarily constrain git below 6 until Danger's upstream compatibility fix lands.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@numbata numbata left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@numbata
numbata merged commit 1437e0e into danger:main Nov 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants