Fix/dark mode sponsor logo - #807
Open
AnkitTsj wants to merge 2 commits into
Open
Conversation
|
@AnkitTsj is attempting to deploy a commit to the DAIR-AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Sponsored by" SerpAPI logo (an image sourced from an external CDN) wasn't visible in dark mode - due to the png image having a transparent/light background that blended into the dark theme, making the sponsor name effectively invisible to dark-mode users.
Fix
-based logo with a styled text link instead:
Replaced the
jsx
<a href="https://serpapi.com/" target="_blank" rel="noopener noreferrer" style={{ textDecoration: 'none', fontSize: '1.5rem', fontWeight: '700' }}>
SerpAPI
This removes the dependency on the external image asset entirely and uses the theme's existing text color that matches with the brand text format, so it's guaranteed to be visible and legible in both light and dark modes without needing a separate dark-mode-specific asset.
Before / After
Before: logo invisible in dark mode (blends into background) -
After: "SerpAPI" renders as bold, clearly visible text in dark mode -
Notes for reviewers
This is a UI/component-level fix (in the site's theme/layout config), not a content change like most PRs in this repo - happy to adjust styling (font size/weight) if you'd prefer something closer to the original branding.
Also tested in light mode to confirm no regression there.