Repository navigation
fix(settings): tolerate blocked localStorage - #26
Merged
Merged
Conversation
The settings initializer called localStorage.getItem outside its try and the settings effect called setItem with no guard. When storage is blocked (privacy settings, sandboxed frame) getItem throws and the app never renders; a full quota made setItem throw inside the effect, skipping the theme class. Both calls are now inside try/catch.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
useStateinitializer:localStorage.getItemmoved inside the existingtry, falls back toDEFAULT_SETTINGSlocalStorage.setItemwrapped intry/catchwith aconsole.warn; the theme class is applied either wayWhy
CSV-M1: these were the only two unguarded storage calls (
NEEDS_BOOT_RESTOREand the dataset helpers already catch). When storage is blocked,getItemthrowsSecurityErrorduring the first render and the app shows a blank page. With a full quota,setItemthrows inside the effect, so dark or light mode is not applied. Split from the parser fix to keep one concern per PRChecks
bun run buildtsc --noEmit --strict --skipLibCheck --jsx react-jsxonsrc/main.tsx(no errors)SecurityError, new returns defaults; old effect throws, new appliesdarksetItem: old effect throwsQuotaExceededError, new appliesdarkgit diff --check