Repository navigation
feat: add transform-driven column updates - #83
Merged
Merged
Conversation
FANNG1
force-pushed
the
feat/update-columns-transform
branch
2 times, most recently
from
October 10, 2026 07:28
9b931ae to
60ca79b
Compare
FANNG1
marked this pull request as ready for review
October 10, 2026 07:55
Contributor
Author
|
@rchowell @universalmind303 could you take a look when you get a chance? This is the transform-driven half of the column-update work (#84), built on the same |
FANNG1
force-pushed
the
feat/update-columns-transform
branch
from
October 12, 2026 22:48
60ca79b to
d88c189
Compare
rchowell
approved these changes
Oct 14, 2026
Comment on lines
+246
to
+249
| max_concurrency: int | None, | ||
| ) -> list[str]: | ||
| if max_concurrency is not None and max_concurrency <= 0: | ||
| raise ValueError("max_concurrency must be a positive integer.") |
Contributor
There was a problem hiding this comment.
nit: it's a bit odd to have concurrency checks in this method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84.
Summary
update_columnsAPI that does not require a prepared DataFrameBatchUDF, and row-preserving Arrow callableswherepredicate evaluated before the transformRewriteColumnstransaction pathCorrectness
fragment.update_columns(..., with_offsets=True)and propagate them throughupdated_fragment_offsets, including for stable-row-ID datasetsfragment_idwhile preserving the grouping-key restriction inupdate_columns_dfversion,asof, ordefault_scan_optionsTests
uv run pytest tests/io/lance/test_update_columns.py -q(40 passed)uv run pytest tests/ -q(492 passed, 10 skipped, 2 xfailed, 2 xpassed)